[PATCH] D28226: threading_support: introduce __libcpp_recursive_mutex_t

EricWF added inline comments. Comment at: include/__threading_support:79 + + template (__value); + } Wouldn't a `static_cast` be valid here? Comment at: include/__threading_support:110 +int __libcpp_mutex_lock(__libcpp_mutex_reference&& __m);

[PATCH] D28207: Add second fast path for DiagnosticsEngine::GetDiagStatePointForLoc

djasper added inline comments. Comment at: lib/Basic/Diagnostic.cpp:179 + + // 2nd most frequent case: L is before the first diag state change. + FullSourceLoc FirstStateChangePos = DiagStatePoints[1].Loc; rsmith wrote: > It's surprising to me that this would b

[PATCH] D28220: provide Win32 native threading

EricWF added inline comments. Comment at: include/__threading_support:44 +#define WIN32_LEAN_AND_MEAN +#define VC_EXTRA_LEAN +#include compnerd wrote: > EricWF wrote: > > Do these definitions have any affect when `` has already been > > included? > > Also are t

[PATCH] D28222: [libcxx] Re-implement LWG 2770 again: Fix tuple_size to work with structured bindings

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, but a minor simplification seems possible. Comment at: include/__tuple:32 template -class _LIBCPP_TYPE_VIS_ONLY tuple_size -: public __tuple_size_base_type<_Tp>::

[PATCH] D28222: [libcxx] Re-implement LWG 2770 again: Fix tuple_size to work with structured bindings

EricWF added inline comments. Comment at: include/__tuple:32 template -class _LIBCPP_TYPE_VIS_ONLY tuple_size -: public __tuple_size_base_type<_Tp>::type {}; +class _LIBCPP_TYPE_VIS_ONLY tuple_size<__enable_if_tuple_size_imp::type>::value)>> +: public integral_constant:

[clang-tools-extra] r290873 - [clang-move] Only move used helper declarations.

Author: hokein Date: Tue Jan 3 03:00:51 2017 New Revision: 290873 URL: http://llvm.org/viewvc/llvm-project?rev=290873&view=rev Log: [clang-move] Only move used helper declarations. Summary: Instead of moving all the helper declarations blindly, this patch implements an AST-based call graph solut

[PATCH] D27673: [clang-move] Only move used helper declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rL290873: [clang-move] Only move used helper declarations. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D27673?vs=82804&id=82847#toc Repository: rL LLVM https://reviews.llvm

[PATCH] D28081: Make GetStyle return Expected instead of FormatStyle

ioeric added a comment. The patch LGTM now. I'll accept both this and the one for clang-tool-extra when it is ready. Regarding builbots, we have bots that continually run builds/tests (http://lab.llvm.org:8011/). Many buildbots test llvm and clang as well as clang-tools-extra (e.g. with `ninja

[PATCH] D28223: clean up use of _WIN32

kimgr added a comment. I don't think wchar_t is UCS-2 anymore, I read somewhere that they switched to UTF-16 as of Windows 2000. Is it the actual encoding you're interested in, or the element size? Judging from the diff, it looks like both, but the code appears to assume UCS-2, so it could alr

[PATCH] D28148: [Sema] Suppress warnings for C's zero initializer

sgilles updated this revision to Diff 82849. sgilles marked 2 inline comments as done. sgilles added a comment. Address danielmarjamaki's and rsmith's comments (creating `InitListExpr::isSyntactic()` since it didn't already exist), as well as correct syntax of test so that it actually runs. ht

[PATCH] D28220: provide Win32 native threading

kimgr added a comment. Re Eric's windows.h concern. Comment at: include/__threading_support:44 +#define WIN32_LEAN_AND_MEAN +#define VC_EXTRA_LEAN +#include EricWF wrote: > compnerd wrote: > > EricWF wrote: > > > Do these definitions have any affect when `` ha

[PATCH] D28148: [Sema] Suppress warnings for C's zero initializer

sgilles marked an inline comment as done. sgilles added a comment. Thanks to danielmarjamaki and rsmith for comments, which I think this diff addresses. I have not done an extensive search of the codebase for places where `isSyntacticForm()` would be useful, but there don't seem to be any call

[PATCH] D28222: [libcxx] Re-implement LWG 2770 again: Fix tuple_size to work with structured bindings

EricWF planned changes to this revision. EricWF added a comment. I thought this formulation worked for GCC and Clang but it appears it does not. I'll update with another attempt. https://reviews.llvm.org/D28222 ___ cfe-commits mailing list cfe-comm

[PATCH] D28222: [libcxx] Re-implement LWG 2770 again: Fix tuple_size to work with structured bindings

EricWF updated this revision to Diff 82850. EricWF added a comment. This revision is now accepted and ready to land. @rsmith Could you re-review this please? It's a mostly different implementation. https://reviews.llvm.org/D28222 Files: include/__tuple test/libcxx/test/config.py test/std/

[PATCH] D28222: [libcxx] Re-implement LWG 2770 again: Fix tuple_size to work with structured bindings

EricWF updated this revision to Diff 82851. EricWF added a comment. - Remove redundant SFINAE. https://reviews.llvm.org/D28222 Files: include/__tuple test/libcxx/test/config.py test/std/utilities/tuple/tuple.tuple/tuple.helper/tuple_size.pass.cpp test/std/utilities/tuple/tuple.tuple/tu

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

firolino marked 5 inline comments as done. firolino added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:34 + // a tag declaration (e.g. struct, class etc.): + // class A { } Object1, Object2; <-- won't be matched + Finder->addMatcher(

[PATCH] D28223: clean up use of _WIN32

EricWF added inline comments. Comment at: include/__config:158 +#if defined(_WIN32) +# define _LIBCPP_WIN32 1 # define _LIBCPP_LITTLE_ENDIAN 1 smeenai wrote: > Perhaps `_LIBCPP_WIN32API` instead, to be clear that this is specific to the > usage of Win

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

firolino updated the summary for this revision. firolino updated this revision to Diff 82855. firolino marked an inline comment as done. firolino added a comment. - applied suggestions from Aaron - added support and test cases for TagDecl e.g. struct S {} S1, S2; https://reviews.llvm.org/D276

[PATCH] D26830: [libcxx] Add string_view literals

EricWF added inline comments. Comment at: test/std/strings/string.view/string.view.literals/literal3.pass.cpp:16 + +int main() +{ You can move this test into `literal.pass.cpp` but putting it at another function scope. https://reviews.llvm.org/D26830 _

[PATCH] D28228: [clang-move] Support moving enum declarations.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D28228 Files: clang-move/ClangMove.cpp test/clang-move/Inputs/enum.h test/clang-move/move-enum-decl.cpp unittests/clang-move/ClangMoveTests.cpp Index: unittests

[PATCH] D26830: [libcxx] Add string_view literals

EricWF added a comment. This LGTM. I'll approve once I see the inline comments addressed. Comment at: test/std/strings/string.view/string.view.literals/literal.pass.cpp:10 +//===--===// + +// UNSUPPORTED: c++9

[libcxx] r290875 - Simplify CMake target for the __generated_config header

Author: ericwf Date: Tue Jan 3 05:18:17 2017 New Revision: 290875 URL: http://llvm.org/viewvc/llvm-project?rev=290875&view=rev Log: Simplify CMake target for the __generated_config header Modified: libcxx/trunk/include/CMakeLists.txt Modified: libcxx/trunk/include/CMakeLists.txt URL: http:

[libcxx] r290876 - Update year to 2017

Author: ericwf Date: Tue Jan 3 05:20:43 2017 New Revision: 290876 URL: http://llvm.org/viewvc/llvm-project?rev=290876&view=rev Log: Update year to 2017 Modified: libcxx/trunk/LICENSE.TXT libcxx/trunk/docs/conf.py libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/LICENSE.TXT

[PATCH] D28228: [clang-move] Support moving enum declarations.

ioeric added a comment. Do we consider enum helpers? Comment at: clang-move/ClangMove.cpp:171 +assert(ED); +MoveTool->getMovedDecls().push_back(ED); +MoveTool->getUnremovedDeclsInOldHeader().erase(ED); These 3 lines seen to be repeated. Maybe pull t

[PATCH] D28229: [libcxx] Fix testing of the externally-threaded library build after r290850

rmaprath created this revision. rmaprath added reviewers: compnerd, EricWF. rmaprath added a subscriber: cfe-commits. Before r290850, building libcxx with `-DLIBCXX_HAS_EXTERNAL_THREAD_API=ON` had two uses: - Allow platform vendors to plug-in an `__external_threading` header which should take c

[libcxxabi] r290877 - Update LICENSE.TXT to 2017

Author: ericwf Date: Tue Jan 3 05:21:43 2017 New Revision: 290877 URL: http://llvm.org/viewvc/llvm-project?rev=290877&view=rev Log: Update LICENSE.TXT to 2017 Modified: libcxxabi/trunk/LICENSE.TXT Modified: libcxxabi/trunk/LICENSE.TXT URL: http://llvm.org/viewvc/llvm-project/libcxxabi/trun

[PATCH] D28229: [libcxx] Fix testing of the externally-threaded library build after r290850

rmaprath added a comment. I will commit this now to get the testing working again. Thought of putting up the patch for review in case if there is a better way to do this. @compnerd: I wondered, for windows threading support, why not do something similar to `__external_threading` (and how it is

[PATCH] D26137: [clang-tidy] Add check name to YAML export

Alpha updated this revision to Diff 82860. Alpha added a comment. Rebase on top of HEAD. Ping. Repository: rL LLVM https://reviews.llvm.org/D26137 Files: include/clang/Tooling/Core/Diagnostic.h include/clang/Tooling/Core/Replacement.h include/clang/Tooling/DiagnosticsYaml.h include/c

[libcxx] r290878 - [libcxx] Fix testing of the externally-threaded library build

Author: asiri Date: Tue Jan 3 05:32:31 2017 New Revision: 290878 URL: http://llvm.org/viewvc/llvm-project?rev=290878&view=rev Log: [libcxx] Fix testing of the externally-threaded library build after r290850 Before r290850, building libcxx with -DLIBCXX_HAS_EXTERNAL_THREAD_API=ON had two uses:

Re: [PATCH] Add missing Decl::Kind for -print-decl-contexts

Thanks for working on this patch! I'm sorry to say but I had an earlier patch in review that fixes this issue (https://reviews.llvm.org/D26964). I think my patch covers all of the decl kinds that are fixed by this patch. I plan on committing my patch today. Alex On 29 December 2016 at 23:35, Fang

[PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

varjujan updated this revision to Diff 82859. varjujan added a comment. Herald added subscribers: JDevlieghere, mgorny. I have implemented some more heuristics to achieve better results. https://reviews.llvm.org/D20689 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

r290879 - [CodeCompletion] Autocomplete NS_DESIGNATED_INITIALIZER in initializers

Author: arphaman Date: Tue Jan 3 05:56:40 2017 New Revision: 290879 URL: http://llvm.org/viewvc/llvm-project?rev=290879&view=rev Log: [CodeCompletion] Autocomplete NS_DESIGNATED_INITIALIZER in initializers with arguments rdar://21014571 Differential Revision: https://reviews.llvm.org/D27039 Ad

[PATCH] D27039: [CodeCompletion] Autocomplete NS_DESIGNATED_INITIALIZER in initializers with arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL290879: [CodeCompletion] Autocomplete NS_DESIGNATED_INITIALIZER in initializers (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D27039?vs=79049&id=82863#toc Repository: rL L

[PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

varjujan added a comment. I ran the check on multiple projects and tried to categorize the warnings: real errors, false positives, naming errors and coincidences. The results are attached. I got no warnings on LLVM. F2902037: postgres F2902036: linuxKernel <

r290880 - Handle FriendDecl in DeclContextPrinter

Author: arphaman Date: Tue Jan 3 06:07:20 2017 New Revision: 290880 URL: http://llvm.org/viewvc/llvm-project?rev=290880&view=rev Log: Handle FriendDecl in DeclContextPrinter This commit fixes a crash that occurs when -print-decl-contexts AST consumer tries to print an unhandled declaration. rda

[PATCH] D26964: Handle more declarations in DeclContextPrinter to fix -print-decl-contexts crashes

This revision was automatically updated to reflect the committed changes. Closed by commit rL290880: Handle FriendDecl in DeclContextPrinter (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D26964?vs=78848&id=82864#toc Repository: rL LLVM https://reviews.llvm.org/D2

r290881 - Handle UsingDecl and UsingShadowDecl in DeclContextPrinter

Author: arphaman Date: Tue Jan 3 06:08:40 2017 New Revision: 290881 URL: http://llvm.org/viewvc/llvm-project?rev=290881&view=rev Log: Handle UsingDecl and UsingShadowDecl in DeclContextPrinter This commit fixes a crash that occurs when -print-decl-contexts AST consumer tries to print an unhandle

r290882 - Handle EmptyDecl in DeclContextPrinter

Author: arphaman Date: Tue Jan 3 06:09:39 2017 New Revision: 290882 URL: http://llvm.org/viewvc/llvm-project?rev=290882&view=rev Log: Handle EmptyDecl in DeclContextPrinter This commit fixes a crash that occurs when -print-decl-contexts AST consumer tries to print an unhandled declaration. rdar

[PATCH] D25406: Fix doubled whitespace in modernize-use-auto fixit

malcolm.parsons abandoned this revision. malcolm.parsons added a comment. I'd prefer a -format option to clang-tidy. https://reviews.llvm.org/D25406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

r290884 - Handle ClassTemplateSpecializationDecl in DeclContextPrinter

Author: arphaman Date: Tue Jan 3 06:11:17 2017 New Revision: 290884 URL: http://llvm.org/viewvc/llvm-project?rev=290884&view=rev Log: Handle ClassTemplateSpecializationDecl in DeclContextPrinter This commit fixes a crash that occurs when -print-decl-contexts AST consumer tries to print an unhand

[clang-tools-extra] r290883 - [clang-tidy] Handle constructors in performance-unnecessary-value-param

Author: malcolm.parsons Date: Tue Jan 3 06:10:44 2017 New Revision: 290883 URL: http://llvm.org/viewvc/llvm-project?rev=290883&view=rev Log: [clang-tidy] Handle constructors in performance-unnecessary-value-param Summary: modernize-pass-by-value doesn't warn about value parameters that cannot be

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

This revision was automatically updated to reflect the committed changes. Closed by commit rL290883: [clang-tidy] Handle constructors in performance-unnecessary-value-param (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D28022?vs=82443&id=82865#toc Repository:

r290885 - Handle AccessSpecDecl in DeclContextPrinter

Author: arphaman Date: Tue Jan 3 06:12:36 2017 New Revision: 290885 URL: http://llvm.org/viewvc/llvm-project?rev=290885&view=rev Log: Handle AccessSpecDecl in DeclContextPrinter This commit fixes a crash that occurs when -print-decl-contexts AST consumer tries to print an unhandled declaration.

r290886 - Handle VarTemplateDecl in DeclContextPrinter

Author: arphaman Date: Tue Jan 3 06:14:59 2017 New Revision: 290886 URL: http://llvm.org/viewvc/llvm-project?rev=290886&view=rev Log: Handle VarTemplateDecl in DeclContextPrinter This commit fixes a crash that occurs when -print-decl-contexts AST consumer tries to print an unhandled declaration.

r290887 - Handle StaticAssertDecl in DeclContextPrinter

Author: arphaman Date: Tue Jan 3 06:16:02 2017 New Revision: 290887 URL: http://llvm.org/viewvc/llvm-project?rev=290887&view=rev Log: Handle StaticAssertDecl in DeclContextPrinter This commit fixes a crash that occurs when -print-decl-contexts AST consumer tries to print an unhandled declaration

[PATCH] D26034: [CodeCompletion] Block property setters: Use dynamic priority heuristic

arphaman added a reviewer: manmanren. arphaman updated this revision to Diff 82866. arphaman added a comment. I've rebased the patch Repository: rL LLVM https://reviews.llvm.org/D26034 Files: lib/Sema/SemaCodeComplete.cpp test/Index/complete-block-property-assignment.m Index: test/Inde

[PATCH] D28222: [libcxx] Re-implement LWG 2770 again: Fix tuple_size to work with structured bindings

EricWF updated the summary for this revision. EricWF updated this revision to Diff 82867. EricWF added a comment. - SFINAE the specializations on `sizeof(tuple_size)` instead of `decltype(tuple_size::value)`. https://reviews.llvm.org/D28222 Files: include/__tuple test/libcxx/test/config.py

[libcxxabi] r290888 - [libcxxabi] Introduce an externally threaded libc++abi variant.

Author: asiri Date: Tue Jan 3 06:58:34 2017 New Revision: 290888 URL: http://llvm.org/viewvc/llvm-project?rev=290888&view=rev Log: [libcxxabi] Introduce an externally threaded libc++abi variant. r281179 Introduced an externally threaded variant of the libc++ library. This patch adds support for

[PATCH] D27575: [libcxxabi] Introduce an externally threaded libc++abi variant (take-2)

This revision was automatically updated to reflect the committed changes. Closed by commit rL290888: [libcxxabi] Introduce an externally threaded libc++abi variant. (authored by asiri). Changed prior to commit: https://reviews.llvm.org/D27575?vs=81062&id=82868#toc Repository: rL LLVM https:

[libcxx] r290889 - [libcxx] Add build/test support for the externally threaded libc++abi variant

Author: asiri Date: Tue Jan 3 06:59:50 2017 New Revision: 290889 URL: http://llvm.org/viewvc/llvm-project?rev=290889&view=rev Log: [libcxx] Add build/test support for the externally threaded libc++abi variant Differential revision: https://reviews.llvm.org/D27576 Reviewers: EricWF Modified:

[PATCH] D27576: [libcxx] libc++ changes necessary for the externally threaded libcxxabi variant

This revision was automatically updated to reflect the committed changes. Closed by commit rL290889: [libcxx] Add build/test support for the externally threaded libc++abi variant (authored by asiri). Changed prior to commit: https://reviews.llvm.org/D27576?vs=81059&id=82869#toc Repository: r

[PATCH] D28228: [clang-move] Support moving enum declarations.

hokein updated this revision to Diff 82872. hokein marked an inline comment as done. hokein added a comment. Address review comment. https://reviews.llvm.org/D28228 Files: clang-move/ClangMove.cpp clang-move/ClangMove.h test/clang-move/Inputs/enum.h test/clang-move/move-enum-decl.cpp

[PATCH] D28228: [clang-move] Support moving enum declarations.

hokein added a comment. In https://reviews.llvm.org/D28228#633863, @ioeric wrote: > Do we consider enum helpers? This patch excludes enum helpers, only considers the enum declarations which are defined in old.h. Ideally, we should support enum helpers which are defined in old.cc, but that's

[PATCH] D28222: [libcxx] Re-implement LWG 2770 again: Fix tuple_size to work with structured bindings

EricWF added inline comments. Comment at: include/__tuple:34 +const _Tp, +typename enable_if::value>::type, +decltype(tuple_size<_Tp>::value)>> Without this extra `enable_if`, GCC will diagnose each of these three specializations as ambiguous. htt

[PATCH] D28228: [clang-move] Support moving enum declarations.

ioeric added a comment. In https://reviews.llvm.org/D28228#633925, @hokein wrote: > In https://reviews.llvm.org/D28228#633863, @ioeric wrote: > > > Do we consider enum helpers? > > > This patch excludes enum helpers, only considers the enum declarations which > are defined in old.h. > Ideally,

[PATCH] D26137: [clang-tidy] Add check name to YAML export

alexfh added a comment. Err, looks like I forgot to post comments I entered a few days ago. Just a few nits. Comment at: include/clang/Tooling/Core/Diagnostic.h:62 + Diagnostic(llvm::StringRef DiagnosticName, DiagnosticMessage &Message, + llvm::StringMap &Fix, +

[PATCH] D28228: [clang-move] Support moving enum declarations.

hokein updated this revision to Diff 82874. hokein marked an inline comment as done. hokein added a comment. Refine function name and add a comment for enum helpers. https://reviews.llvm.org/D28228 Files: clang-move/ClangMove.cpp clang-move/ClangMove.h test/clang-move/Inputs/enum.h test

[PATCH] D28228: [clang-move] Support moving enum declarations.

hokein added a comment. In https://reviews.llvm.org/D28228#633930, @ioeric wrote: > I mean, if a enum helper used in say only old cc, will it be moved? The > question is related to https://reviews.llvm.org/D27673. You don't need to > support enum helper now, but it would be nice to drop a comme

[PATCH] D28228: [clang-move] Support moving enum declarations.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lg Comment at: clang-move/ClangMove.cpp:456 +void ClangMoveTool::addMovedAndDeletedDecl(const NamedDecl *D) { + MovedDecls.push_back(D); Remove this? ht

[PATCH] D28231: -Wunreachable-code: Avoid multiple diagnostics that are triggered by the same source range and fix the unary operator fixit source range

arphaman created this revision. arphaman added reviewers: rsmith, bruno, ahatanak. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch fixes an issue with -Wunreachable-code diagnostic that happens with the following code sample: struc

[PATCH] D28228: [clang-move] Support moving enum declarations.

hokein updated this revision to Diff 82875. hokein added a comment. Remove forgot-deleted code. https://reviews.llvm.org/D28228 Files: clang-move/ClangMove.cpp clang-move/ClangMove.h test/clang-move/Inputs/enum.h test/clang-move/move-enum-decl.cpp unittests/clang-move/ClangMoveTests.c

[PATCH] D28228: [clang-move] Support moving enum declarations.

hokein updated this revision to Diff 82876. hokein marked an inline comment as done. hokein added a comment. Not change in ClangMove.h https://reviews.llvm.org/D28228 Files: clang-move/ClangMove.cpp test/clang-move/Inputs/enum.h test/clang-move/move-enum-decl.cpp unittests/clang-move/Cl

[clang-tools-extra] r290891 - [clang-move] Support moving enum declarations.

Author: hokein Date: Tue Jan 3 08:22:25 2017 New Revision: 290891 URL: http://llvm.org/viewvc/llvm-project?rev=290891&view=rev Log: [clang-move] Support moving enum declarations. Reviewers: ioeric Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D28228 Added: clang

[PATCH] D28228: [clang-move] Support moving enum declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rL290891: [clang-move] Support moving enum declarations. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D28228?vs=82876&id=82879#toc Repository: rL LLVM https://reviews.llvm.o

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

aaron.ballman added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:34 + // a tag declaration (e.g. struct, class etc.): + // class A { } Object1, Object2; <-- won't be matched + Finder->addMatcher( firolino wrote: > aaron.b

[PATCH] D26137: [clang-tidy] Add check name to YAML export

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Fixed the issues myself and running tests before committing this. Thank you for working on this! Comment at: tools/extra/clang-tidy/ClangTidy.cpp:106 void re

r290892 - [clang-tidy] Add check name to YAML export

Author: alexfh Date: Tue Jan 3 08:35:47 2017 New Revision: 290892 URL: http://llvm.org/viewvc/llvm-project?rev=290892&view=rev Log: [clang-tidy] Add check name to YAML export Add a field indicating the associated check for every replacement to the YAML report generated with the '-export-fixes' o

[PATCH] D26137: [clang-tidy] Add check name to YAML export

This revision was automatically updated to reflect the committed changes. Closed by commit rL290892: [clang-tidy] Add check name to YAML export (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D26137?vs=82860&id=82881#toc Repository: rL LLVM https://reviews.llvm.org/D

[clang-tools-extra] r290893 - [clang-tidy] Add check name to YAML export (clang-tools-extra part)

Author: alexfh Date: Tue Jan 3 08:36:13 2017 New Revision: 290893 URL: http://llvm.org/viewvc/llvm-project?rev=290893&view=rev Log: [clang-tidy] Add check name to YAML export (clang-tools-extra part) Add a field indicating the associated check for every replacement to the YAML report generated w

[PATCH] D25406: Fix doubled whitespace in modernize-use-auto fixit

alexfh added a comment. In https://reviews.llvm.org/D25406#633892, @malcolm.parsons wrote: > I'd prefer a -format option to clang-tidy. Exactly. https://reviews.llvm.org/D25406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D28217: [libc++] Overallocation of am_pm array in locale.cpp

mclow.lists added a comment. This looks fine to me. All the other places that use this (or related functionality) have a rank of 2. Interestingly enough, this has been there since "the beginning of time" (the initial import of libc++ into the LLVM subversion repo) https://reviews.llvm.org/D2

[PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. In https://reviews.llvm.org/D20689#633889, @varjujan wrote: > I ran the check on multiple projects and tried to categorize the warnings: > real errors, false positives, naming errors

[PATCH] D27529: Correct Vectorcall Register passing and HVA Behavior

erichkeane updated this revision to Diff 82887. erichkeane added a comment. Sorry about that, I have no idea how I messed up the process, I must have thought this was a different window. I've updated it with the latest version of this diff that I have which seems to be the one I intended initia

[PATCH] D27680: [CodeGen] Move lifetime.start of a variable when goto jumps back past its declaration

ahatanak added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:917 + if (!InsertPt) +Builder.SetInsertPoint(BB, BB->begin()); + // If InsertPt is a terminator, insert it before InsertPt. rjmccall wrote: > BB->begin() is not necessarily a leg

[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr

cameron314 added a comment. >> Thanks, I'll check these out! Btw, I noticed that the clang-format tests are >> non-Windows due to path assumptions. Is this a lost cause, or just something >> no one's bothered to look into yet? > > No one's bothered looking into it yet. Which tests? We run the

[PATCH] D28166: Properly merge K&R functions that have attributes

aaron.ballman added a comment. In https://reviews.llvm.org/D28166#633643, @rsmith wrote: > In https://reviews.llvm.org/D28166#633621, @aaron.ballman wrote: > > > Do you think this patch should be gated on (or perhaps combined with) a fix > > for the lowering bug, or do you think this patch is re

[PATCH] D28235: [clang-format cleanup] merge continuous deleted lines into one deletion.

ioeric created this revision. ioeric added a reviewer: djasper. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. This cleans up "\n" among continuous lines when they are deleted. https://reviews.llvm.org/D28235 Files: lib/Format/Format.cpp unittests/Format/CleanupT

[PATCH] D27680: [CodeGen] Move lifetime.start of a variable when goto jumps back past its declaration

ahatanak added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:917 + if (!InsertPt) +Builder.SetInsertPoint(BB, BB->begin()); + // If InsertPt is a terminator, insert it before InsertPt. ahatanak wrote: > rjmccall wrote: > > BB->begin() is n

[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr

amaiorano added a comment. In https://reviews.llvm.org/D27440#634043, @cameron314 wrote: > >> Thanks, I'll check these out! Btw, I noticed that the clang-format tests > >> are non-Windows due to path assumptions. Is this a lost cause, or just > >> something no one's bothered to look into yet? >

[PATCH] D28235: [clang-format cleanup] merge continuous deleted lines into one deletion.

ioeric updated this revision to Diff 82889. ioeric added a comment. - Fixed a nit. https://reviews.llvm.org/D28235 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp === --- u

[PATCH] D26137: [clang-tidy] Add check name to YAML export

Alpha added a comment. Thanks for the review! Comment at: tools/extra/clang-tidy/ClangTidy.cpp:106 void reportDiagnostic(const ClangTidyError &Error) { -const ClangTidyMessage &Message = Error.Message; +const ClangTidyMessage Message = Error.Message; SourceLocat

[PATCH] D27680: [CodeGen] Move lifetime.start of a variable when goto jumps back past its declaration

rjmccall added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:917 + if (!InsertPt) +Builder.SetInsertPoint(BB, BB->begin()); + // If InsertPt is a terminator, insert it before InsertPt. ahatanak wrote: > ahatanak wrote: > > rjmccall wrote:

[PATCH] D28081: Make GetStyle return Expected instead of FormatStyle

amaiorano updated this revision to Diff 82896. amaiorano added a comment. Minor comment change, turned the ObjC test into a non-fixture test, and renamed FormatStyleOrError to FormatStyle in format function. https://reviews.llvm.org/D28081 Files: include/clang/Format/Format.h lib/Format/Fo

[PATCH] D28238: [Driver] Add openSuse AArch64 Triple

cryptoad created this revision. cryptoad added reviewers: chandlerc, bruno, bkramer. cryptoad added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. openSuse has AArch64 support, with images running on the Raspberry Pi 3. The libraries and headers live under the aarch64-sus

[PATCH] D28226: threading_support: introduce __libcpp_recursive_mutex_t

majnemer added a comment. Is `__libcpp_mutex_reference` all that useful? There is no real dynamism for these mutexes. I'd just add functions for the recursive locks just like we have a separate function for `__libcpp_recursive_mutex_init` Repository: rL LLVM https://reviews.llvm.org/D28226

[PATCH] D28165: Change clang-format's Chromium JavaScript defaults

thakis added inline comments. Comment at: lib/Format/Format.cpp:643 +ChromiumStyle.AllowShortIfStatementsOnASingleLine = false; +ChromiumStyle.AllowShortLoopsOnASingleLine = false; + } Thanks for the patch! Do we want these as false in Chromium's JS? I w

[PATCH] D27486: Correct class-template deprecation behavior

erichkeane updated this revision to Diff 82909. erichkeane added a comment. Updated based on Richard Smith's suggestion, all tests pass with no alteration, and the initial incorrect behavior was corrected in an existing test. https://reviews.llvm.org/D27486 Files: include/clang/Basic/Attr.td

[PATCH] D28223: clean up use of _WIN32

compnerd added inline comments. Comment at: include/__config:158 +#if defined(_WIN32) +# define _LIBCPP_WIN32 1 # define _LIBCPP_LITTLE_ENDIAN 1 EricWF wrote: > smeenai wrote: > > Perhaps `_LIBCPP_WIN32API` instead, to be clear that this is specific to

[PATCH] D28166: Properly merge K&R functions that have attributes

aaron.ballman added a reviewer: majnemer. aaron.ballman added a comment. > I *think* the problem is that we gin up the function type for a > non-prototyped function based on the function call expression argument types, > and the literal `0` is getting the type `signed long long`. I think this i

[PATCH] D28223: clean up use of _WIN32

compnerd added a comment. I figured that using the explicit encoding is nicer since it means that its more documenting. I dont have a problem with `_LIBCPP_SHORT_WCHAR` as that maps quite well to `-fshort-wchar`. Repository: rL LLVM https://reviews.llvm.org/D28223 __

[PATCH] D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.

tra added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:511-516 +// Activate workers. +syncCTAThreads(CGF); + +// Barrier at end of parallel region. +syncCTAThreads(CGF); + Are two back-to-back syncCTAThreads() intentional or d

[PATCH] D28223: clean up use of _WIN32

compnerd updated this revision to Diff 82912. compnerd added a comment. Update for `_LIBCPP_WIN32API` and addition of `_LIBCPP_OBJECT_FORMAT_COFF`, `_LIBCPP_OBJECT_FORMAT_ELF`, `_LIBCPP_OBJECT_FORMAT_MACHO` Repository: rL LLVM https://reviews.llvm.org/D28223 Files: include/__config incl

r290898 - [OPENMP] Private, firstprivate, and lastprivate clauses for distribute, host code generation

Author: cbertol Date: Tue Jan 3 12:24:42 2017 New Revision: 290898 URL: http://llvm.org/viewvc/llvm-project?rev=290898&view=rev Log: [OPENMP] Private, firstprivate, and lastprivate clauses for distribute, host code generation https://reviews.llvm.org/D17840 This patch enables private, firstpri

[PATCH] D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.

arpith-jacob added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:511-516 +// Activate workers. +syncCTAThreads(CGF); + +// Barrier at end of parallel region. +syncCTAThreads(CGF); + tra wrote: > Are two back-to-back syncCTAThre

[PATCH] D28243: [OpenMP] Add missing regression test for pragma distribute, clause firstprivate

carlo.bertolli created this revision. carlo.bertolli added reviewers: ABataev, sfantao, kkwli0. carlo.bertolli added subscribers: arpith-jacob, gtbercea, caomhin, cfe-commits. The regression test was missing from the previous already accepted patch. https://reviews.llvm.org/D28243 Files: test

[PATCH] D17840: [OPENMP] Private, firstprivate, and lastprivate clauses for distribute, host code generation

carlo.bertolli closed this revision. carlo.bertolli added a comment. Commited r290898. Repository: rL LLVM https://reviews.llvm.org/D17840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D28223: clean up use of _WIN32

smeenai added a comment. In https://reviews.llvm.org/D28223#634199, @compnerd wrote: > I figured that using the explicit encoding is nicer since it means that its > more documenting. I think @kimgr's point was that if you're using an explicit encoding, it should be UTF-16 rather than UCS-2 :)

[PATCH] D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.

tra added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:511-516 +// Activate workers. +syncCTAThreads(CGF); + +// Barrier at end of parallel region. +syncCTAThreads(CGF); + arpith-jacob wrote: > tra wrote: > > Are two back-to-b

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

firolino added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:34 + // a tag declaration (e.g. struct, class etc.): + // class A { } Object1, Object2; <-- won't be matched + Finder->addMatcher( aaron.ballman wrote: > firolin

[PATCH] D20791: Support SOURCE_DATE_EPOCH environment variable

emaste abandoned this revision. emaste added a comment. Abandon in favour of https://reviews.llvm.org/D23934 https://reviews.llvm.org/D20791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

  1   2   >