ioeric added a comment. In https://reviews.llvm.org/D28228#633925, @hokein wrote:
> In https://reviews.llvm.org/D28228#633863, @ioeric wrote: > > > Do we consider enum helpers? > > > This patch excludes enum helpers, only considers the enum declarations which > are defined in old.h. > Ideally, we should support enum helpers which are defined in old.cc, but > that's another topic. I mean, if a enum helper used in say only old cc, will it be moved? The question is related to https://reviews.llvm.org/D27673. You don't need to support enum helper now, but it would be nice to drop a comment somewhere. ================ Comment at: clang-move/ClangMove.h:140 + /// old.h/cc. + void addMovedAndDeletedDecl(const NamedDecl *Decl); + ---------------- Maybe just `addMovedDecl`? `move` indicates move and delete IMO. But you might need to explain what's really going on in the comment. https://reviews.llvm.org/D28228 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
