[PATCH] D27410: Always issue vtables when generating coverage instrumentation

ahatanak added inline comments. Comment at: llvm/tools/clang/test/CodeGenCXX/vtable-coverage-gen.cpp:3 +// RUN: FileCheck %s < %t +// CHECK: @_ZTV8Category = linkonce_odr unnamed_addr constant {{.*}}, comdat, + I'm not sure I understood the purpose of this test,

Re: r290084 - clang-format: Allow "single column" list layout even if that violates the

Hi Daniel, this commit introduce an unnecessary string split, which does not seem to be an intended result of the formatting style change this commit introduced: BEFORE: #define SCOP_STAT(NAME, DESC) llvm::Statistic RejectStatistics[] = { SCOP_STAT(CFG, ""), SCOP_STAT(InvalidTerminator,

Re: r290084 - clang-format: Allow "single column" list layout even if that violates the

Yeah, I just saw that when fixing polly format. I'll take a look. On Mon, Dec 19, 2016 at 9:05 AM, Tobias Grosser wrote: > Hi Daniel, > > this commit introduce an unnecessary string split, which does not seem > to be an intended result of the formatting style change this commit > introduced: > >

Re: r290084 - clang-format: Allow "single column" list layout even if that violates the

On Mon, Dec 19, 2016, at 09:07 AM, Daniel Jasper wrote: > Yeah, I just saw that when fixing polly format. I'll take a look. You then probably also saw the second issue: -Type *Params[] = {PointerType::getUnqual(FunctionType::get( - Builder.getVoidTy(), Builder.getInt8

r290090 - clang-format: Fix regression introduced in r290084.

Author: djasper Date: Mon Dec 19 02:40:56 2016 New Revision: 290090 URL: http://llvm.org/viewvc/llvm-project?rev=290090&view=rev Log: clang-format: Fix regression introduced in r290084. We still want to try in linewrap within single elements of a 1-column list. After: Type *Params[] = {Pointer

[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr

klimek added a reviewer: ioeric. klimek added a comment. +eric, who has some experience llvm::Error'ing our interfaces :) llvm::ErrorOr seems like the right approach here? https://reviews.llvm.org/D27440 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D27575: [libcxxabi] Introduce an externally threaded libc++abi variant (take-2)

rmaprath added a comment. Ping. https://reviews.llvm.org/D27575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27576: [libcxx] libc++ changes necessary for the externally threaded libcxxabi variant

rmaprath added a comment. Ping. https://reviews.llvm.org/D27576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr

ioeric added a comment. `llvm::ErrorOr` carries `std::error_code`. If you want richer information (e.g. error_code + error message), `llvm::Expcted` and `llvm::Error` are your friends. FYI, if you only need error_code + error_message in the returned error, there is also `llvm::StringError`. An

r290092 - Revert "[c++1z] P0195R2: Support pack-expansion of using-declarations."

Author: djasper Date: Mon Dec 19 04:09:25 2016 New Revision: 290092 URL: http://llvm.org/viewvc/llvm-project?rev=290092&view=rev Log: Revert "[c++1z] P0195R2: Support pack-expansion of using-declarations." This reverts commit r290080 as it leads to many Clang crashes, e.g.: http://lab.llvm.org:80

[PATCH] D27827: [ObjC] CodeGen support for @available on macOS

arphaman added a comment. In https://reviews.llvm.org/D27827#625438, @erik.pilkington wrote: > I seem to remember that mapping from kernel versions to marketing versions > was tossed around as a potential alternative to Gestalt. I think that the > problem was Apple sometimes introduces (or rese

[PATCH] D27673: [clang-move] Only move used helper declarations.

ioeric added inline comments. Comment at: test/clang-move/move-used-helper-decls.cpp:1 +// RUN: mkdir -p %T/used-helper-decls +// RUN: cp %S/Inputs/helper_decls_test* %T/used-helper-decls/ Can you also add test cases where class members are treated as the same n

r290093 - [clang-format] revert an unintended change in r288493 and add a test case.

Author: ioeric Date: Mon Dec 19 04:41:05 2016 New Revision: 290093 URL: http://llvm.org/viewvc/llvm-project?rev=290093&view=rev Log: [clang-format] revert an unintended change in r288493 and add a test case. Modified: cfe/trunk/lib/Format/Format.cpp cfe/trunk/unittests/Format/CleanupTest.

Re: r288493 - [ClangFormat] Only insert #include into the #include block in the beginning of the file.

Hi Mehdi, This is an unintended change. I've reverted this line and added a test case for this in r290093. Thanks, Eric On Fri, Dec 16, 2016 at 7:02 PM Mehdi Amini wrote: Hi Eric, > On Dec 2, 2016, at 3:01 AM, Eric Liu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: ioeric >

Re: [PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

Firstly, please respond in phabricator if it is possible. When you send email it doesn't appear in phabricator, it's probably a bug. 2016-12-19 8:00 GMT+01:00 Mads Ravn : > Hi Piotr, > > Thank you for your detailed comments :) > > I would love some help with the other fixit. I have some notes on

[PATCH] D27815: [clang-tidy] Add obvious module for obvious bugs

Prazek added a comment. The example of this kind of check is here: https://reviews.llvm.org/D27806 I am not sure if it make sense to put it as clang warning. After a little bit of thinking I guess name "typos" would be better, because I want to look for checks that are mostly typos (which are o

[PATCH] D25206: [Parser] Correct typo after lambda capture initializer is parsed

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. This looks good to me. It would be nice if we could get rid of the 2nd `expected expression` error in `auto s0 = S1{[name=]() {}};`, but it can be done later. https://reviews.llvm.org/D2

r290094 - clang-format: Slightly tweak the behavior of <<-wrapping.

Author: djasper Date: Mon Dec 19 05:14:23 2016 New Revision: 290094 URL: http://llvm.org/viewvc/llvm-project?rev=290094&view=rev Log: clang-format: Slightly tweak the behavior of <<-wrapping. Before: SomeLongLoggingStatementOrMacro() << "Some long text " << s

Re: r290080 - [c++1z] P0195R2: Support pack-expansion of using-declarations.

On 19 December 2016 at 11:28, Daniel Jasper via cfe-commits wrote: > I have reverted this in r290092 as it was leading to Clang crashes on the > bots and elsewhere, e.g.: > http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/1814 Hi Daniel, Richard, This is will red on our LNT bot

Re: r290080 - [c++1z] P0195R2: Support pack-expansion of using-declarations.

I don't understand. This *is* a revert of the whole patch. On Mon, Dec 19, 2016 at 1:26 PM, Renato Golin wrote: > On 19 December 2016 at 11:28, Daniel Jasper via cfe-commits > wrote: > > I have reverted this in r290092 as it was leading to Clang crashes on the > > bots and elsewhere, e.g.: > >

Re: r290080 - [c++1z] P0195R2: Support pack-expansion of using-declarations.

On 19 December 2016 at 12:27, Daniel Jasper wrote: > I don't understand. This *is* a revert of the whole patch. My bad, your revert hadn't gone through: http://lab.llvm.org:8011/builders/clang-native-arm-lnt/builds/1361 Now it's green. Sorry, we're dealing with 4 different cluster-plucks today

Re: r290080 - [c++1z] P0195R2: Support pack-expansion of using-declarations.

Oh, I completely understand, I am doing the same here :) On Mon, Dec 19, 2016 at 1:38 PM, Renato Golin wrote: > On 19 December 2016 at 12:27, Daniel Jasper wrote: > > I don't understand. This *is* a revert of the whole patch. > > My bad, your revert hadn't gone through: > > http://lab.llvm.org:

Re: r290080 - [c++1z] P0195R2: Support pack-expansion of using-declarations.

On 19 December 2016 at 12:39, Daniel Jasper wrote: > Oh, I completely understand, I am doing the same here :) Btw, this also happened: http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-selfhost/builds/582 It seems Clang lost the ability to find the libstdc++: CMake Error at cmake/modules

[PATCH] D27917: [OpenCL] Improve diagnostics for double type

echuraev created this revision. echuraev added a reviewer: Anastasia. echuraev added subscribers: bader, cfe-commits, yaxunl. https://reviews.llvm.org/D27917 Files: include/clang/AST/Type.h lib/AST/Type.cpp lib/Sema/SemaType.cpp test/SemaOpenCL/unknown_type.cl Index: test/SemaOpenCL/unk

[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr

amaiorano added a comment. In https://reviews.llvm.org/D27440#626415, @ioeric wrote: > `llvm::ErrorOr` carries `std::error_code`. If you want richer information > (e.g. error_code + error message), `llvm::Expcted` and `llvm::Error` are > your friends. > > FYI, if you only need error_code + erro

[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr

klimek added a comment. In https://reviews.llvm.org/D27440#626477, @amaiorano wrote: > In https://reviews.llvm.org/D27440#626415, @ioeric wrote: > > > `llvm::ErrorOr` carries `std::error_code`. If you want richer information > > (e.g. error_code + error message), `llvm::Expcted` and `llvm::Error

[PATCH] D22507: Clang-tidy - Enum misuse check

alexfh added a comment. A few more notes, all fine for a follow up. Comment at: clang-tidy/misc/SuspiciousEnumUsageCheck.cpp:202 + + const auto *LhsExpr = Result.Nodes.getNodeAs("lhsExpr"); + const auto *RhsExpr = Result.Nodes.getNodeAs("rhsExpr"); Looks like

[PATCH] D22507: Clang-tidy - Enum misuse check

aaron.ballman added inline comments. Comment at: clang-tidy/misc/SuspiciousEnumUsageCheck.cpp:31 +"enum type seems like a bitmask (contains mostly " +"power-of-2 literals) but some literal(s) are not a power-of-2"; + Please drop the `(s)` from the diagnos

[PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

aaron.ballman added a comment. In https://reviews.llvm.org/D22910#601083, @Abpostelnicu wrote: > Can someone please show me an example on how to write a test for this patch? You could test this with anything that diagnoses side effects in an unevaluated context (look for `warn_side_effects_une

[PATCH] D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value

arphaman updated this revision to Diff 81950. arphaman marked an inline comment as done. arphaman added a comment. The updated patch renames the attribute to `loads_format_specifier_value_using_key` and addresses Aaron's comments Repository: rL LLVM https://reviews.llvm.org/D27165 Files:

[PATCH] D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value

arphaman added inline comments. Comment at: include/clang/Basic/Attr.td:862 +def FormatDynamicKeyArg : InheritableAttr { + let Spellings = [GCC<"format_dynamic_key_arg">]; + let Args = [IntArgument<"FormatIdx">]; aaron.ballman wrote: > Does GCC support this att

[PATCH] D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value

arphaman updated this revision to Diff 81952. arphaman added a comment. Update to fix a test failure. Repository: rL LLVM https://reviews.llvm.org/D27165 Files: include/clang/Analysis/Analyses/FormatString.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/Analysis/Pri

[PATCH] D27917: [OpenCL] Improve diagnostics for double type

yaxunl added inline comments. Comment at: lib/Sema/SemaType.cpp:1505 + S.getLangOpts().OpenCLVersion < 120 && + !S.getOpenCLOptions().cl_khr_fp64) { +S.Diag(DS.getTypeSpecTypeLoc(), diag::err_type_requires_extension) Plea

r290110 - [ARM] Add missing -backend-option for -arm-execute-only

Author: prakhar Date: Mon Dec 19 09:43:33 2016 New Revision: 290110 URL: http://llvm.org/viewvc/llvm-project?rev=290110&view=rev Log: [ARM] Add missing -backend-option for -arm-execute-only Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/arm-execute-only.c Modified: cfe/tr

[PATCH] D27641: DebugInfo: Added support for Checksum debug info feature (Clang part)

aaboud updated this revision to Diff 81953. aaboud marked 3 inline comments as done. aaboud added a comment. Addressed comments by Reid and David. https://reviews.llvm.org/D27641 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGen/Inputs/debug-info-file-checksum.c

[PATCH] D26454: Implement no_sanitize_address for global vars

aaron.ballman added a comment. In https://reviews.llvm.org/D26454#609578, @dougk wrote: > Suppression of sanitizing is necessary if the variable is magically a > memory-mapped device I/O address. > The linker can arrange for this to be the case using fancy scripts, or even > just as simple as

[PATCH] D27920: [find-all-symbols] Index partial template specializations.

hokein created this revision. hokein added a reviewer: ioeric. hokein added subscribers: bkramer, cfe-commits. Fix no std::function index. https://reviews.llvm.org/D27920 Files: include-fixer/find-all-symbols/FindAllSymbols.cpp unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cp

[PATCH] D23325: [WIP] Binding of references to packed fields

rogfer01 updated this revision to Diff 81955. rogfer01 added a comment. Rebase to current trunk https://reviews.llvm.org/D23325 Files: include/clang/AST/Decl.h include/clang/AST/Expr.h include/clang/AST/Stmt.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/Specifiers.h

Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

On Thu, Dec 15, 2016 at 2:18 PM Sean Callanan via Phabricator via cfe-commits wrote: > spyffe updated this revision to Diff 81661. > spyffe marked 2 inline comments as done. > spyffe added a comment. > Herald added a subscriber: jgosnell. > > Applied Vassil and Vedant's comments. I will commit t

Re: [PATCH] D27763: Debug Info: Modified DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. (Clang part)

Was this change approved by anyone? Generally once it's sent for review, you should wait until it's approved before committing (the assumption being, if you sent it for review it's because it needed review) On Wed, Dec 14, 2016 at 12:49 PM Amjad Aboud via Phabricator via cfe-commits wrote: > Thi

r290113 - [libclang] Revert part of r290025, "Remove the 'extern "C"' blocks from the implementation files."

Author: chapuni Date: Mon Dec 19 10:50:43 2016 New Revision: 290113 URL: http://llvm.org/viewvc/llvm-project?rev=290113&view=rev Log: [libclang] Revert part of r290025, "Remove the 'extern "C"' blocks from the implementation files." mingw32-ld complains missing symbols in exports, Cannot expo

Re: [PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

Test coverage? On Tue, Dec 13, 2016 at 2:39 PM Sean Callanan via Phabricator via cfe-commits wrote: > spyffe retitled this revision from "Fix the linkage for > __crashtracer_info__" to "Prepare PrettyStackTrace for LLDB adoption". > spyffe updated the summary for this revision. > spyffe updated

RE: [PATCH] D27763: Debug Info: Modified DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. (Clang part)

It was approved by Reid. This patch had two parts, he did not stamp the change in Clang, but he did stamp the change for LLVM. https://reviews.llvm.org/D27762 I assumed that this means a green light to commit. Did I misinterpret the rules? Thanks, Amjad From: David Blaikie [mailto:dblai...@gmai

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

firolino updated this revision to Diff 81964. firolino added a comment. Added support for new test cases: int S::*mdpa1[2] = {&S::a, &S::a}, var1 = 0; // CHECK-MESSAGES: :[[@LINE-1]]:9: warning: declaration statement can be split // CHECK-FIXES: {{^}}int S::*mdpa1[2] = {&S::a, &S::a

Re: [PATCH] D27763: Debug Info: Modified DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. (Clang part)

Ah, sure - no worries. Good to mention/link to the other change, etc, in the future. (if the changes on the clang side are trivial enough to not need review, may not need to send them out for review either - or could include them as an addendum to the llvm change ("oh, and here's what it looks like

[PATCH] D26750: [clang-tidy] Add modernize-use-default-member-init check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:33-34 + case Type::STK_Floating: + case Type::STK_IntegralComplex: + case Type::STK_FloatingComplex: +return "0.0"; Do these require a literal suffix to avo

Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

On 19/12/16 17:55, David Blaikie wrote: On Thu, Dec 15, 2016 at 2:18 PM Sean Callanan via Phabricator via cfe-commits > wrote: spyffe updated this revision to Diff 81661. spyffe marked 2 inline comments as done. spyffe added a comment. Heral

[PATCH] D21298: [Clang-tidy] delete null check

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, with one nit. You should wait for @alexfh to sign off before committing though, since he requested changes. Comment at: clang-tidy/readability/DeleteNullPointerCheck.cpp:53 + "'if' statement is unn

Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

On Fri, Dec 16, 2016 at 7:00 AM, Attila Török via Phabricator wrote: > torokati44 added a comment. > > I see this has been reverted in r281612, but I can no longer access the build > log serving as a reason linked in the message: > https://www.mail-archive.com/cfe-commits@lists.llvm.org/msg35386

[PATCH] D26454: Implement no_sanitize_address for global vars

dougk added a comment. I think it probably works to have the attribute appertain to any sanitizer. I did not know that it did, so I conservatively assumed that it didn't. I'll go ahead and make things consistent, and confirm that it dtrt. https://reviews.llvm.org/D26454 __

Re: [PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

That would require making LLDB crash and collecting the relevant crash log data out of the user's own logs. This isn't impossible – but additionally the generation of that log is asynchronous and you don't quite know when it'll land. Would you be all right with a more restricted macOS-only unit

Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

David, thanks for keeping an eye on this and sorry for the breach of process. Would having Vassil approve the changelist (https://reviews.llvm.org/D27180 ) be appropriate? Let's say if he has any concerns or can't get to it by tomorrow, we revert my patches since

[PATCH] D27806: [clang-tidy] Add obvious-invalid-range

aaron.ballman added inline comments. Comment at: clang-tidy/obvious/InvalidRangeCheck.cpp:20-36 +"std::for_each; std::find; std::find_if; std::find_end; " +"std::find_first_of; std::adjacent_find; std::count; std::count_if;" +"std::mismatch; std::equal; std::search; s

r290120 - Make a few OpenMP tests "C++11 clean."

Author: probinson Date: Mon Dec 19 11:58:09 2016 New Revision: 290120 URL: http://llvm.org/viewvc/llvm-project?rev=290120&view=rev Log: Make a few OpenMP tests "C++11 clean." Reviewed by abataev (in D27794) Modified: cfe/trunk/test/CodeGenCXX/arm-swiftcall.cpp cfe/trunk/test/CodeGenCXX/

[PATCH] D27815: [clang-tidy] Add obvious module for obvious bugs

aaron.ballman added a comment. In https://reviews.llvm.org/D27815#626440, @Prazek wrote: > The example of this kind of check is here: > https://reviews.llvm.org/D27806 > > I am not sure if it make sense to put it as clang warning. > > After a little bit of thinking I guess name "typos" would be

r290121 - Undo accidental comit

Author: probinson Date: Mon Dec 19 12:00:45 2016 New Revision: 290121 URL: http://llvm.org/viewvc/llvm-project?rev=290121&view=rev Log: Undo accidental comit Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp cfe/trunk/test/CodeGenCXX/arm-swiftcall.cpp cfe/trunk/test/CodeGenCXX/d

[PATCH] D26964: Handle more declarations in DeclContextPrinter to fix -print-decl-contexts crashes

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. Testing is in line with the existing testing. It is not great, but at the same time is a development/debugging tool right? Repository: rL LLVM https://reviews.llvm.org/D26964 _

r290125 - Revert another accidental bit

Author: probinson Date: Mon Dec 19 12:20:19 2016 New Revision: 290125 URL: http://llvm.org/viewvc/llvm-project?rev=290125&view=rev Log: Revert another accidental bit Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp URL: http://l

[PATCH] D27569: [OpenCL] Enabling the usage of CLK_NULL_QUEUE as compare operand.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D27569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

r290128 - Make a few OpenMP tests "C++11 clean."

Author: probinson Date: Mon Dec 19 12:43:26 2016 New Revision: 290128 URL: http://llvm.org/viewvc/llvm-project?rev=290128&view=rev Log: Make a few OpenMP tests "C++11 clean." This time trying to commit just the relevant 3 tests! Reviewed by abataev (in D27794) Modified: cfe/trunk/test/OpenM

[PATCH] D26544: [PPC] support for arithmetic builtins in the FE

amehsan closed this revision. amehsan added a comment. https://reviews.llvm.org/rL287872 https://reviews.llvm.org/D26544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27180: Testbed and skeleton of a new expression parser

a.sidorin added a comment. Sorry for being late :( Comment at: cfe/trunk/tools/clang-import-test/clang-import-test.cpp:99 +llvm::errs() << LineString << '\n'; +std::string Space(LocColumn, ' '); +llvm::errs() << Space.c_str() << '\n'; I still think

[PATCH] D27410: Always issue vtables when generating coverage instrumentation

vsk added inline comments. Comment at: llvm/tools/clang/test/CodeGenCXX/vtable-coverage-gen.cpp:3 +// RUN: FileCheck %s < %t +// CHECK: @_ZTV8Category = linkonce_odr unnamed_addr constant {{.*}}, comdat, + ahatanak wrote: > I'm not sure I understood the purpose

[PATCH] D27794: Make some diagnostic tests C++11 clean

probinson added a reviewer: rnk. probinson updated this revision to Diff 81977. probinson added a comment. Remove the OpenMP tests from this review (committed in r290128). +rnk who added test/Parser/backtrack-off-by-one.cpp originally. https://reviews.llvm.org/D27794 Files: test/FixIt/fixit.

r290130 - Reverting r290004, r290006, r290010 pending review.

Author: spyffe Date: Mon Dec 19 13:15:43 2016 New Revision: 290130 URL: http://llvm.org/viewvc/llvm-project?rev=290130&view=rev Log: Reverting r290004, r290006, r290010 pending review. Removed: cfe/trunk/test/Import/ cfe/trunk/tools/clang-import-test/ Modified: cfe/trunk/test/CMakeLis

Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

Reverted by 290130. I have new comments from Aleksei in https://reviews.llvm.org/D27180 . I'll apply those and update the patch. Sean > On Dec 19, 2016, at 9:48 AM, Sean Callanan wrote: > > David, > > thanks for keeping an eye on this and sorry for the bre

[PATCH] D27410: Always issue vtables when generating coverage instrumentation

vsk added inline comments. Comment at: llvm/tools/clang/test/CodeGenCXX/vtable-coverage-gen.cpp:3 +// RUN: FileCheck %s < %t +// CHECK: @_ZTV8Category = linkonce_odr unnamed_addr constant {{.*}}, comdat, + vsk wrote: > ahatanak wrote: > > I'm not sure I understo

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

timshen updated this revision to Diff 81980. timshen added a comment. Remove 'else' after return. Remove 'return' on void type. https://reviews.llvm.org/D27872 Files: clang/test/CodeGen/ppc64-complex-parms.c llvm/include/llvm/ADT/APFloat.h llvm/lib/Support/APFloat.cpp llvm/test/CodeGen/

[PATCH] D23325: [WIP] Binding of references to packed fields

aaron.ballman added inline comments. Comment at: include/clang/AST/Decl.h:2388 + /// its alignment is smaller than the alignment of its field type. + bool isPackedField(const ASTContext& context) const; + Should be `&Context` instead of `& context`. =

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

timshen updated this revision to Diff 81981. timshen added a comment. Remove more 'else' after return. https://reviews.llvm.org/D27872 Files: clang/test/CodeGen/ppc64-complex-parms.c llvm/include/llvm/ADT/APFloat.h llvm/lib/Support/APFloat.cpp llvm/test/CodeGen/PowerPC/fp128-bitcast-aft

[PATCH] D27832: Add -plugin-opt=sample-profile for thinLTO build.

bruno added inline comments. Comment at: lib/Driver/Tools.cpp:2211 + if (Arg *A = Args.getLastArg(options::OPT_fprofile_sample_use_EQ)) { +StringRef fname = A->getValue(); +if (!llvm::sys::fs::exists(fname)) "fname" -> "FName", "FileName", etc, or any na

[PATCH] D26750: [clang-tidy] Add modernize-use-default-member-init check

malcolm.parsons marked 9 inline comments as done. malcolm.parsons added inline comments. Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:77-78 +static bool sameValue(const Expr *E1, const Expr *E2) { + E1 = ignoreUnaryPlus(getInitializer(E1->IgnoreImpCasts())); +

[PATCH] D26750: [clang-tidy] Add modernize-use-default-member-init check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:77-78 +static bool sameValue(const Expr *E1, const Expr *E2) { + E1 = ignoreUnaryPlus(getInitializer(E1->IgnoreImpCasts())); + E2 = ignoreUnaryPlus(getInitializer(E2->IgnoreImpCa

[PATCH] D26750: [clang-tidy] Add modernize-use-default-member-init check

malcolm.parsons added inline comments. Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:77-78 +static bool sameValue(const Expr *E1, const Expr *E2) { + E1 = ignoreUnaryPlus(getInitializer(E1->IgnoreImpCasts())); + E2 = ignoreUnaryPlus(getInitializer(E2->IgnoreImp

[PATCH] D26750: [clang-tidy] Add modernize-use-default-member-init check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:77-78 +static bool sameValue(const Expr *E1, const Expr *E2) { + E1 = ignoreUnaryPlus(getInitializer(E1->IgnoreImpCasts())); + E2 = ignoreUnaryPlus(getInitializer(E2->IgnoreImpCa

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

aaron.ballman added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:22 + +const internal::VariadicDynCastAllOfMatcher tagDecl; + We may want to consider adding this to ASTMatchers.h at some point (can be done in a future patch)

[PATCH] D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:862 +def FormatDynamicKeyArg : InheritableAttr { + let Spellings = [GCC<"format_dynamic_key_arg">]; + let Args = [IntArgument<"FormatIdx">]; arphaman wrote: > aaron.ballman wrote: > >

[PATCH] D27936: C++11 test cleanup: nonthrowing destructors

probinson created this revision. probinson added a reviewer: rsmith. probinson added a subscriber: cfe-commits. If a dtor has no interesting members, then it ends up being nothrow, which affects the generated IR. Modify some tests to tolerate this difference between C++03 and C++11. In C++11, a

r290132 - Add fix-it notes to the nullability consistency warning.

Author: jrose Date: Mon Dec 19 14:58:20 2016 New Revision: 290132 URL: http://llvm.org/viewvc/llvm-project?rev=290132&view=rev Log: Add fix-it notes to the nullability consistency warning. This is especially important for arrays, since no one knows the proper syntax for putting qualifiers in arra

[PATCH] D27837: Add fix-it notes to the nullability consistency warning

jordan_rose accepted this revision. jordan_rose added a reviewer: jordan_rose. jordan_rose added a comment. This revision is now accepted and ready to land. Doug was okay with the idea and I trust Alex and Akira would have caught any major problems. Committed in r290132. Repository: rL LLVM

Re: [libcxx] r289963 - [CMake] Put headers relative to clang

Sorry I didn't reply to this email over the weekend. I did push a fix in r290052. My weekend was just a bit nuts, so I didn't take the time to reply here. The bot went green after that fix. If there are other issues please let me know. -Chris > On Dec 16, 2016, at 5:58 PM, Evgenii Stepanov >

r290134 - [ASTReader] Sort RawComments before merging

Author: bruno Date: Mon Dec 19 15:06:06 2016 New Revision: 290134 URL: http://llvm.org/viewvc/llvm-project?rev=290134&view=rev Log: [ASTReader] Sort RawComments before merging `RawComments` are sorted by comparing underlying `SourceLocation`'s. This is done by comparing `FileID` and `Offset`; whe

[PATCH] D24812: Lit C++11 Compatibility Patch #11

tigerleapgorge updated the summary for this revision. tigerleapgorge updated this revision to Diff 81987. tigerleapgorge added a comment. Update Lit patch #11 to match latest Clang behavior 2 minor changes in this update 1. Back out test/CodeGenCXX/mangle-unnamed.cpp because it has already been

r290135 - [Format] Remove dead code.

Author: d0k Date: Mon Dec 19 15:10:50 2016 New Revision: 290135 URL: http://llvm.org/viewvc/llvm-project?rev=290135&view=rev Log: [Format] Remove dead code. No functionality change. Modified: cfe/trunk/lib/Format/Encoding.h cfe/trunk/lib/Format/TokenAnalyzer.h cfe/trunk/lib/Format/Wh

Re: r289754 - [c++1z] Permit constant evaluation of a call through a function pointer whose

Richard, Clang crashes for me on this code while doing "check-all". This change seems to introduce the assert. Can you take a look? BTW I'm not sure why bots are green. Do we build libcxx with bootstrap compiler? FAIL: libc++ :: std/experimental/string.view/string.view.find/find_last_of_pointer

[PATCH] D27180: Testbed and skeleton of a new expression parser

spyffe updated this revision to Diff 81991. spyffe marked 3 inline comments as done. spyffe added a comment. Applied Aleksei's comments, and integrated all the CMakeFiles fixes required to make the bots happy. Repository: rL LLVM https://reviews.llvm.org/D27180 Files: test/CMakeLists.txt

[PATCH] D27955: Make CodeGenCXX/arm-swiftcall.cpp tolerate C++11

probinson created this revision. probinson added a reviewer: rjmccall. probinson added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. The test conjures up and returns a temp which has a struct type, and the struct has some empty/padding bytes in the middle. In C++03 the

r290140 - [analyzer] Add sink after construction of temporary with no-return destructor.

Author: dcoughlin Date: Mon Dec 19 16:23:22 2016 New Revision: 290140 URL: http://llvm.org/viewvc/llvm-project?rev=290140&view=rev Log: [analyzer] Add sink after construction of temporary with no-return destructor. The analyzer's CFG currently doesn't have nodes for calls to temporary destructors

[PATCH] D27955: Make CodeGenCXX/arm-swiftcall.cpp tolerate C++11

rjmccall added a comment. Yes, I think being more specific about the dialect would be better. https://reviews.llvm.org/D27955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27956: Make CodeGenCXX/stack-reuse-miscompile.cpp tolerate C++11

probinson created this revision. probinson added a reviewer: lenykholodov. probinson added a subscriber: cfe-commits. In this test, the allocas for the temps come out in a different order depending on whether the dialect is C++03 or C++11. To avoid depending on the default dialect, I forced it

r290141 - Don't try to emit nullability fix-its within/around macros.

Author: jrose Date: Mon Dec 19 16:35:24 2016 New Revision: 290141 URL: http://llvm.org/viewvc/llvm-project?rev=290141&view=rev Log: Don't try to emit nullability fix-its within/around macros. The newly-added notes from r290132 are too noisy even when the fix-it is valid. For the existing warning

[PATCH] D27955: Make CodeGenCXX/arm-swiftcall.cpp tolerate C++11

probinson updated this revision to Diff 82021. probinson added a comment. Force C++03 on this test, to make it insensitive to future changes in the default dialect. https://reviews.llvm.org/D27955 Files: test/CodeGenCXX/arm-swiftcall.cpp Index: test/CodeGenCXX/arm-swiftcall.cpp ===

[PATCH] D27769: Update MSVC compat docs about debug info.

thakis closed this revision. thakis added a comment. r289712 https://reviews.llvm.org/D27769 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r290143 - [analyzer] Add checker modeling gtest APIs.

Author: dcoughlin Date: Mon Dec 19 16:50:31 2016 New Revision: 290143 URL: http://llvm.org/viewvc/llvm-project?rev=290143&view=rev Log: [analyzer] Add checker modeling gtest APIs. gtest is a widely-used unit-testing API. It provides macros for unit test assertions: ASSERT_TRUE(p != nullptr);

[PATCH] D24969: [Sema] Use the instantiated name of destructors in FindInstantiatedDecl and RebuildMemberExpr

ahatanak added a comment. ping https://reviews.llvm.org/D24969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27478: Make ASTContext::getDeclAlign return the correct alignment for FunctionDecls

ahatanak added a comment. ping https://reviews.llvm.org/D27478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27955: Make CodeGenCXX/arm-swiftcall.cpp tolerate C++11

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D27955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D27955: Make CodeGenCXX/arm-swiftcall.cpp tolerate C++11

This revision was automatically updated to reflect the committed changes. Closed by commit rL290145: Make another test insensitive to the default C++ dialect. (authored by probinson). Changed prior to commit: https://reviews.llvm.org/D27955?vs=82021&id=82028#toc Repository: rL LLVM https://

r290145 - Make another test insensitive to the default C++ dialect.

Author: probinson Date: Mon Dec 19 17:32:10 2016 New Revision: 290145 URL: http://llvm.org/viewvc/llvm-project?rev=290145&view=rev Log: Make another test insensitive to the default C++ dialect. Differential Revision: http://reviews.llvm.org/D27955 Modified: cfe/trunk/test/CodeGenCXX/arm-swif

[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

sfertile updated this revision to Diff 82031. sfertile marked 6 inline comments as done. sfertile added a comment. Updated to swap the arguments when generating the intrinsic. Updated a number of the comments, and added some tests with the index out of range. Repository: rL LLVM https://revi

  1   2   >