Ah, sure - no worries. Good to mention/link to the other change, etc, in
the future. (if the changes on the clang side are trivial enough to not
need review, may not need to send them out for review either - or could
include them as an addendum to the llvm change ("oh, and here's what it
looks like in terms of client (clang) changes" sort of thing) - either in
comments, as a link to a review that doesn't have other subscribers (so it
doesn't go to cfe-commits), or as an attached patch to the llvm review, etc)On Mon, Dec 19, 2016 at 9:05 AM Aboud, Amjad <amjad.ab...@intel.com> wrote: > It was approved by Reid. > > This patch had two parts, he did not stamp the change in Clang, but he did > stamp the change for LLVM. > > https://reviews.llvm.org/D27762 > > > > I assumed that this means a green light to commit. > > Did I misinterpret the rules? > > > > Thanks, > > Amjad > > > > *From:* David Blaikie [mailto:dblai...@gmail.com] > *Sent:* Monday, December 19, 2016 19:00 > *To:* reviews+d27763+public+4530ee00cad28...@reviews.llvm.org; Amjad > Aboud via Phabricator <revi...@reviews.llvm.org>; Aboud, Amjad < > amjad.ab...@intel.com>; r...@google.com > *Cc:* cfe-commits@lists.llvm.org > *Subject:* Re: [PATCH] D27763: Debug Info: Modified > DIBuilder::createCompileUnit() to take DIFile instead of FileName and > Directory. (Clang part) > > > > Was this change approved by anyone? Generally once it's sent for review, > you should wait until it's approved before committing (the assumption > being, if you sent it for review it's because it needed review) > > > > On Wed, Dec 14, 2016 at 12:49 PM Amjad Aboud via Phabricator via > cfe-commits <cfe-commits@lists.llvm.org> wrote: > > This revision was automatically updated to reflect the committed changes. > Closed by commit rL289701: [DebugInfo] Changed > DIBuilder::createCompileUnit() to take DIFile instead of… (authored by > aaboud). > > Changed prior to commit: > https://reviews.llvm.org/D27763?vs=81397&id=81438#toc > > Repository: > rL LLVM > > https://reviews.llvm.org/D27763 > > Files: > cfe/trunk/lib/CodeGen/CGDebugInfo.cpp > > > Index: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp > =================================================================== > --- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp > +++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp > @@ -466,7 +466,8 @@ > // Create new compile unit. > // FIXME - Eliminate TheCU. > TheCU = DBuilder.createCompileUnit( > - LangTag, remapDIPath(MainFileName), > remapDIPath(getCurrentDirname()), > + LangTag, DBuilder.createFile(remapDIPath(MainFileName), > + remapDIPath(getCurrentDirname())), > Producer, LO.Optimize, CGM.getCodeGenOpts().DwarfDebugFlags, > RuntimeVers, > CGM.getCodeGenOpts().SplitDwarfFile, EmissionKind, 0 /* DWOid */, > CGM.getCodeGenOpts().SplitDwarfInlining); > @@ -1977,10 +1978,11 @@ > // but LLVM detects skeleton CUs by looking for a non-zero DWO id. > uint64_t Signature = Mod.getSignature() ? Mod.getSignature() : ~1ULL; > llvm::DIBuilder DIB(CGM.getModule()); > - DIB.createCompileUnit(TheCU->getSourceLanguage(), Mod.getModuleName(), > - Mod.getPath(), TheCU->getProducer(), true, > - StringRef(), 0, Mod.getASTFile(), > - llvm::DICompileUnit::FullDebug, Signature); > + DIB.createCompileUnit(TheCU->getSourceLanguage(), > + DIB.createFile(Mod.getModuleName(), > Mod.getPath()), > + TheCU->getProducer(), true, StringRef(), 0, > + Mod.getASTFile(), > llvm::DICompileUnit::FullDebug, > + Signature); > DIB.finalize(); > } > llvm::DIModule *Parent = > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > > --------------------------------------------------------------------- > Intel Israel (74) Limited > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
