[PATCH] D26606: Protect tests for std::uninitialized_{copy, fill} under libcpp-no-exceptions

rogfer01 added a comment. Ping? :) https://reviews.llvm.org/D26606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26606: Protect tests for std::uninitialized_{copy, fill} under libcpp-no-exceptions

jmolloy added a comment. Hi, This looks fairly obviously correct to me, but perhaps someone more familiar with libcxx should look too: Asiri? James https://reviews.llvm.org/D26606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D26858: [AArch64] Don't constrain the assembler when using -mgeneral-regs-only

jmolloy accepted this revision. jmolloy added a comment. This revision is now accepted and ready to land. It's a bit awkward that you need to copy the LastOpt loop from below, but I can't see a simpler way to do this. LGTM. https://reviews.llvm.org/D26858 ___

Re: [libcxx] r287435 - Fix stdint/cstdint modules

Hello Eric, I think that this commit (r287435) might have broken the green dragon stage 2 ASAN + UBSAN buildbot: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/2643/ I'm not sure why exactly the tests fail, since ASAN/UBSAN isn't triggering anything, and it's just a module err

r287529 - [Frontend] Add a predefined macro that describes the Objective-C bool type

Author: arphaman Date: Mon Nov 21 05:05:15 2016 New Revision: 287529 URL: http://llvm.org/viewvc/llvm-project?rev=287529&view=rev Log: [Frontend] Add a predefined macro that describes the Objective-C bool type This commit adds a new predefined macro named __OBJC_BOOL_IS_BOOL that describes the Ob

[PATCH] D26234: [Frontend] Add a predefined macro that describes the Objective-C bool type

This revision was automatically updated to reflect the committed changes. Closed by commit rL287529: [Frontend] Add a predefined macro that describes the Objective-C bool type (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D26234?vs=76680&id=78698#toc Repository: r

r287530 - [ObjC] Prevent infinite loops when iterating over redeclaration

Author: arphaman Date: Mon Nov 21 05:16:30 2016 New Revision: 287530 URL: http://llvm.org/viewvc/llvm-project?rev=287530&view=rev Log: [ObjC] Prevent infinite loops when iterating over redeclaration of a method that was declared in an invalid interface This commit fixes an infinite loop that occu

[PATCH] D26664: [ObjC] Prevent infinite loops when iterating over redeclaration of a method that was declared in an invalid interface

This revision was automatically updated to reflect the committed changes. arphaman marked 6 inline comments as done. Closed by commit rL287530: [ObjC] Prevent infinite loops when iterating over redeclaration (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D26664?vs=779

[PATCH] D26664: [ObjC] Prevent infinite loops when iterating over redeclaration of a method that was declared in an invalid interface

arphaman added a comment. I managed to get rid of the extra function and simplify the check thanks to suggestions from Erik. Repository: rL LLVM https://reviews.llvm.org/D26664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[libcxx] r287531 - Revert r287435 because of OS X test failures

Author: ericwf Date: Mon Nov 21 05:26:10 2016 New Revision: 287531 URL: http://llvm.org/viewvc/llvm-project?rev=287531&view=rev Log: Revert r287435 because of OS X test failures Removed: libcxx/trunk/test/libcxx/modules/cinttypes_exports.sh.cpp libcxx/trunk/test/libcxx/modules/cstdint_exp

Re: [libcxx] r287435 - Fix stdint/cstdint modules

Hi Alex, Sorry about the breakage. It's reverted in r287531. /Eric On Mon, Nov 21, 2016 at 3:59 AM, Alex L wrote: > Hello Eric, > > I think that this commit (r287435) might have broken the green dragon > stage 2 ASAN + UBSAN buildbot: > > http://lab.llvm.org:8080/green/job/clang-stage2-cmake-R

[PATCH] D25660: [Analyzer] Checker for iterators dereferenced beyond their range.

baloghadamsoftware added inline comments. Comment at: test/Analysis/Inputs/system-header-simulator-for-iterators.h:62 + ForwardIterator2 first2, ForwardIterator2 last2); +} Maybe we should merge this file with the system-header-simulator-

[PATCH] D26909: [ClangFormat] Do not insert #include into code after #include block in the beginning of the file.

ioeric created this revision. ioeric added a reviewer: djasper. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. This avoid inserting/deleting #include into/from: - raw string literals containing #include. - #if block. - Special #include among declarations (e.g. function

[PATCH] D26909: [ClangFormat] Do not insert #include into code after #include block in the beginning of the file.

ioeric added a comment. @djasper This is not very urgent. Feel free to leave it until you are back from vacation :) https://reviews.llvm.org/D26909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

Abpostelnicu added a comment. Can someone please show me an example on how to write a test for this patch? https://reviews.llvm.org/D22910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D26636: patch for llvm/clang bug 25965, suppress warning diagnostic on float-to-bool conversion when in condition context

mibintc added a comment. Does anyone have time to do a code review for this patch? https://reviews.llvm.org/D26636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26911: readability-redundant-declarations: Fix crash

hokein accepted this revision. hokein added a reviewer: hokein. hokein added a comment. This revision is now accepted and ready to land. LGTM with a nit. Comment at: clang-tidy/readability/RedundantDeclarationCheck.cpp:33 return; + if (!Prev->getLocation().isValid()) +

[clang-tools-extra] r287540 - readability-redundant-declaration: Fix crash

Author: danielmarjamaki Date: Mon Nov 21 08:29:53 2016 New Revision: 287540 URL: http://llvm.org/viewvc/llvm-project?rev=287540&view=rev Log: readability-redundant-declaration: Fix crash Differential Revision: https://reviews.llvm.org/D26911 Modified: clang-tools-extra/trunk/clang-tidy/read

[PATCH] D26911: readability-redundant-declarations: Fix crash

This revision was automatically updated to reflect the committed changes. Closed by commit rL287540: readability-redundant-declaration: Fix crash (authored by danielmarjamaki). Changed prior to commit: https://reviews.llvm.org/D26911?vs=78706&id=78715#toc Repository: rL LLVM https://reviews

Re: r287343 - [OpenCL] Introduce ReadPipeType and WritePipeType.

Hi Joey, In order for ReadPipeType and WritePipeType to work with LLVM type system (isa, dyn_cast), you need to modify the existing TypeClass::Pipe kind into TypeClass::ReadPipe and TypeClass::WritePipe, have Pipe::classof recognize both kinds and have ReadPipe::classof and WritePipe::classof rec

Re: [clang-tools-extra] r287540 - readability-redundant-declaration: Fix crash

On 21 November 2016 at 14:29, Daniel Marjamaki via cfe-commits wrote: > Author: danielmarjamaki > Date: Mon Nov 21 08:29:53 2016 > New Revision: 287540 > > URL: http://llvm.org/viewvc/llvm-project?rev=287540&view=rev > Log: > readability-redundant-declaration: Fix crash Introduced another... :)

Re: [PATCH] Warning for main returning a bool.

I modified the patch to warn only when a bool literal is returned from main. See attached. -Josh On Tue, Nov 15, 2016 at 7:50 PM Richard Smith wrote: > On Tue, Nov 15, 2016 at 2:55 PM, Aaron Ballman via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > On Tue, Nov 15, 2016 at 5:44 PM, Hal F

[clang-tools-extra] r287544 - [include-fixer plugin] Make the plugin emit proper fixits in case multiple errors are found.

Author: d0k Date: Mon Nov 21 09:28:50 2016 New Revision: 287544 URL: http://llvm.org/viewvc/llvm-project?rev=287544&view=rev Log: [include-fixer plugin] Make the plugin emit proper fixits in case multiple errors are found. The standalone tool only fixes the first one and we managed to bake that

[clang-tools-extra] r287546 - clang-tidy: Attempt to fix build bot failure with mismatching size_t platform type.

Author: danielmarjamaki Date: Mon Nov 21 09:46:40 2016 New Revision: 287546 URL: http://llvm.org/viewvc/llvm-project?rev=287546&view=rev Log: clang-tidy: Attempt to fix build bot failure with mismatching size_t platform type. Modified: clang-tools-extra/trunk/test/clang-tidy/readability-red

Re: [clang-tools-extra] r287540 - readability-redundant-declaration: Fix crash

On Mon, Nov 21, 2016 at 9:29 AM, Daniel Marjamaki via cfe-commits wrote: > Author: danielmarjamaki > Date: Mon Nov 21 08:29:53 2016 > New Revision: 287540 > > URL: http://llvm.org/viewvc/llvm-project?rev=287540&view=rev > Log: > readability-redundant-declaration: Fix crash > > Differential Revisio

[clang-tools-extra] r287550 - clang-tidy: improve my test for readability-redundant-declaration

Author: danielmarjamaki Date: Mon Nov 21 10:08:17 2016 New Revision: 287550 URL: http://llvm.org/viewvc/llvm-project?rev=287550&view=rev Log: clang-tidy: improve my test for readability-redundant-declaration Modified: clang-tools-extra/trunk/test/clang-tidy/readability-redundant-declaration

[PATCH] D26916: [ObjC] Avoid a @try/@finally/@autoreleasepool fixit when parsing an expression

arphaman created this revision. arphaman added reviewers: manmanren, bruno. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch ensures that the typo fixit for the `@try/@finally/@autoreleasepool { }` directive is shown only when we're pa

[PATCH] D26853: Make llvm::Error generated from replacement interfaces more specific.

bkramer added inline comments. Comment at: include/clang/Tooling/Core/Replacement.h:157 + /// \brief Constructs an error related to an existing replacement. + ReplacementError(replacement_error Err, const Replacement &Existing) + : Err(Err), ExistingReplacement(Existing) {

[PATCH] D26853: Make llvm::Error generated from replacement interfaces more specific.

ioeric updated this revision to Diff 78733. ioeric marked 5 inline comments as done. ioeric added a comment. - Addressed review comments. https://reviews.llvm.org/D26853 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replacement.cpp unittests/Tooling/RefactoringTest.cpp

[PATCH] D26853: Make llvm::Error generated from replacement interfaces more specific.

ioeric added a comment. Thanks for the review! https://reviews.llvm.org/D26853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] Warning for main returning a bool.

On Tue, Nov 15, 2016 at 4:50 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Nov 15, 2016 at 2:55 PM, Aaron Ballman via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > On Tue, Nov 15, 2016 at 5:44 PM, Hal Finkel wrote: > > - Original Message - > >> F

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lib/Lex/Lexer.cpp:1717 + const StringRef CompleteSuffix(Buffer, Chars); + const LangOptions &LangOpts = getLangOpts(); +

[PATCH] D26442: [analyzer] Fix crash on getSVal: handle case of CompoundVal

alexshap added a comment. @NoQ , @ilya-palachev - what are the plans for this ? Repository: rL LLVM https://reviews.llvm.org/D26442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

AntonBikineev updated this revision to Diff 78739. https://reviews.llvm.org/D26829 Files: include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp lib/Sema/SemaDeclCXX.cpp test/SemaCXX/cxx1z-user-defined-literals.cpp Index: test/SemaCXX/cxx1z-user-defined-litera

[PATCH] D26922: [ObjC++] Don't enter a C++ declarator context when the current context is an Objective-C declaration

arphaman created this revision. arphaman added reviewers: manmanren, ahatanak. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch ensures that Sema won't enter a C++ declarator context when the current context is an Objective-C declarati

Re: [PATCH] Warning for main returning a bool.

This looks good to me. (While we could generalize this further, this patch is a strict improvement, and we'll probably want to treat the 'main' case specially regardless of whether we add a more general conversion warning.) On 21 November 2016 at 07:18, Joshua Hurwitz wrote: > I modified the pat

[PATCH] D26560: Add a test for vcall on a null ptr.

krasin added a comment. Ping. https://reviews.llvm.org/D26560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

sfertile updated this revision to Diff 78760. sfertile added a comment. Moved the endian related massaging from altivec.h into Clang codegen and clamped the input index into the valid range [0, 12]. Repository: rL LLVM https://reviews.llvm.org/D26546 Files: include/clang/Basic/BuiltinsPPC

[PATCH] D26903: [libcxx] Add tests (but not implementation)

CaseyCarter added inline comments. Comment at: test/std/utilities/variant/variant.relops/relops.pass.cpp:60 +inline bool operator>(MakeEmptyT const&, MakeEmptyT const&) { assert(false); } +inline bool operator>=(MakeEmptyT const&, MakeEmptyT const&) { assert(false); } +

[PATCH] D26560: Add a test for vcall on a null ptr.

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D26560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26896: [libcxx] Make constexpr char_traits and char_traits

mclow.lists added a comment. Tests look good; I'm still staring at the stuff in `<__string>`. Comment at: include/__string:138 template -inline -const _CharT* +_LIBCPP_CONSTEXPR_AFTER_CXX14 inline const _CharT* char_traits<_CharT>::find(const char_type* __s, size_t __n, cons

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

rnk added a comment. This added a bunch of warnings to the Chromium build, which doesn't use LTO today, so we had to revert our clang roll: https://codereview.chromium.org/2520453002/ We currently don't use LTO on Mac, so we don't build or package the LTO plugin, and in the near term aren't pla

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

(In addition to rnk's question: We build with -Werror, but Wliblto seems unaffected by this. Because of that, our bots didn't catch the new warning and we only noticed this when a human did a local build after we updated compilers and saw a wall of warnings. It'd be good if Wliblto was affected by

[PATCH] D26896: [libcxx] Make constexpr char_traits and char_traits

AntonBikineev updated this revision to Diff 78773. https://reviews.llvm.org/D26896 Files: include/__config include/__string test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char/assign2.pass.cpp test/std/strings/char.traits/char.traits.specializations

[PATCH] D26934: [libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS

smeenai created this revision. smeenai added reviewers: mclow.lists, EricWF. smeenai added a subscriber: cfe-commits. It's useful to be able to disable visibility annotations entirely; for example, if we're building libc++ static to include in another library, and we don't want any libc++ function

[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

syzaara added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:8185 + +// Need to cast the second argument from a vector of cahr to a vector +// of long long. tiny comment, char is misspelled as cahr Repository: rL LLVM https://reviews.llvm.org

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

mehdi_amini added a comment. We ship `clang + libLTO + ld64` bundled in the toolchain, so even if you don't package libLTO yourself, it is already accessible from the linker: it will use the one in the toolchain when needed. I don't have an immediate idea to prevent this and have the linker iss

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

rnk added a comment. In https://reviews.llvm.org/D25932#601820, @mehdi_amini wrote: > We ship `clang + libLTO + ld64` bundled in the toolchain, so even if you > don't package libLTO yourself, it is already accessible from the linker: it > will use the one in the toolchain when needed. > > I don

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

mehdi_amini added a comment. In https://reviews.llvm.org/D25932#601842, @rnk wrote: > In https://reviews.llvm.org/D25932#601820, @mehdi_amini wrote: > > > We ship `clang + libLTO + ld64` bundled in the toolchain, so even if you > > don't package libLTO yourself, it is already accessible from the

[PATCH] D26934: [libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS

smeenai updated this revision to Diff 78785. smeenai added a comment. Adding documentation per @EricWF's comment https://reviews.llvm.org/D26934 Files: docs/UsingLibcxx.rst include/__config Index: include/__config === --- incl

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

On Mon, Nov 21, 2016 at 5:19 PM, Mehdi AMINI via cfe-commits < cfe-commits@lists.llvm.org> wrote: > mehdi_amini added a comment. > > In https://reviews.llvm.org/D25932#601842, @rnk wrote: > > > In https://reviews.llvm.org/D25932#601820, @mehdi_amini wrote: > > > > > We ship `clang + libLTO + ld64`

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

rnk added a comment. Maybe we should `touch ../lib/libLTO.dylib` relative to clang in our package and just let the loader fail if a bitcode file comes along. Repository: rL LLVM https://reviews.llvm.org/D25932 ___ cfe-commits mailing list cfe-co

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

> On Nov 21, 2016, at 2:27 PM, Nico Weber wrote: > > On Mon, Nov 21, 2016 at 5:19 PM, Mehdi AMINI via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > mehdi_amini added a comment. > > In https://reviews.llvm.org/D25932#601842 > , @rnk wrote: >

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

On Mon, Nov 21, 2016 at 5:34 PM, Mehdi Amini wrote: > > On Nov 21, 2016, at 2:27 PM, Nico Weber wrote: > > On Mon, Nov 21, 2016 at 5:19 PM, Mehdi AMINI via cfe-commits lists.llvm.org> wrote: > >> mehdi_amini added a comment. >> >> In https://reviews.llvm.org/D25932#601842, @rnk wrote: >> >> > I

[PATCH] D26940: [libc++] Remove unneeded visibility pragmas

smeenai created this revision. smeenai added reviewers: EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. The function definitions being guarded by the pragma were all static, so they wouldn't be exported anyway. In any case, we should prefer the visibility macros. No functional change

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

rnk added a comment. What if we only warn if `D.isUsingLTO()`? Things are only going to go wrong if *this* version of clang generates LLVM IR not understood by the system libLTO. Presumably bitcode from static archives will work with the system version of libLTO. Repository: rL LLVM https:

[PATCH] D26944: Suppress -Wliblto warning when -flto is not present

rnk created this revision. rnk added reviewers: mehdi_amini, thakis. rnk added a subscriber: cfe-commits. Without -flto, it's unlikely that users will experience LLVM version skew. The system installation of libLTO should be able to handle any pre-compiled LLVM bitcode from static archives. http

r287599 - Indicate in AST dump whether special member functions are defaulted and trivial.

Author: rsmith Date: Mon Nov 21 17:43:54 2016 New Revision: 287599 URL: http://llvm.org/viewvc/llvm-project?rev=287599&view=rev Log: Indicate in AST dump whether special member functions are defaulted and trivial. Modified: cfe/trunk/lib/AST/ASTDumper.cpp cfe/trunk/test/Misc/ast-dump-colo

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

> On Nov 21, 2016, at 2:44 PM, Nico Weber wrote: > > On Mon, Nov 21, 2016 at 5:34 PM, Mehdi Amini > wrote: > >> On Nov 21, 2016, at 2:27 PM, Nico Weber > > wrote: >> >> On Mon, Nov 21, 2016 at 5:19 PM, Mehdi AMINI via cfe-commits >> m

r287600 - Sema, CodeGen: Ensure that an implicit copy ctor is available more often under the Microsoft C++ ABI.

Author: pcc Date: Mon Nov 21 18:21:43 2016 New Revision: 287600 URL: http://llvm.org/viewvc/llvm-project?rev=287600&view=rev Log: Sema, CodeGen: Ensure that an implicit copy ctor is available more often under the Microsoft C++ ABI. This is needed because whether the constructor is deleted can co

r287602 - Fix -Asserts build, and add some more test cases.

Author: pcc Date: Mon Nov 21 18:43:30 2016 New Revision: 287602 URL: http://llvm.org/viewvc/llvm-project?rev=287602&view=rev Log: Fix -Asserts build, and add some more test cases. Modified: cfe/trunk/test/CodeGenCXX/uncopyable-args.cpp Modified: cfe/trunk/test/CodeGenCXX/uncopyable-args.cpp

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

> On Nov 21, 2016, at 4:29 PM, Mehdi Amini wrote: > >> >> On Nov 21, 2016, at 2:44 PM, Nico Weber > > wrote: >> >> On Mon, Nov 21, 2016 at 5:34 PM, Mehdi Amini > > wrote: >> >>> On Nov 21, 2016, at 2:27 PM, Nico Weber >>

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, howard.hinnant, mclow.lists. smeenai added a subscriber: cfe-commits. Use the libc++abi visibility macros instead of pragmas or using visibility attributes directly. Clean up redundant attributes on definitions (where the de

[PATCH] D26950: [libc++abi] Add _LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS

smeenai created this revision. smeenai added reviewers: EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. It's useful to be able to disable visibility annotations entirely; for example, if we're building libc++abi static to include in another library, and we don't want any libc++abi fu

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

smeenai added a comment. General coding style question. Over here, I'm creating a local helper function. However, that helper needs to access member functions of Sema, which is why I made it a private member function right now, which also unfortunately makes the change somewhat non-local (since

[PATCH] D22862: [analyzer] Fix for PR15623: eliminate unwanted ProgramState checker data propagation.

ayartsev updated this revision to Diff 78810. ayartsev added a comment. The updated patch implements Devin's solution. Please review. https://reviews.llvm.org/D22862 Files: lib/StaticAnalyzer/Core/ExprEngineC.cpp lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp test/Analysis/unwanted-p

[PATCH] D26903: [libcxx] Add tests (but not implementation)

STL_MSFT added a comment. Found some minor issues. Comment at: test/std/utilities/variant/variant.get/get_if_index.pass.cpp:92 +V v(42l); +ASSERT_SAME_TYPE(decltype(std::get_if<1>(std::addressof(v))), long*); +assert(*std::get_if<1>(std::addressof(v)) ==

[PATCH] D26953: clang-format: handle formatting on constexpr if

thegameg created this revision. thegameg added reviewers: djasper, mprobst, ioeric, klimek. thegameg added a subscriber: cfe-commits. c++1z adds the following constructions to the language: if constexpr (cond) statement1; else if constexpr (cond) statement2; else if constexpr (cond) st

[PATCH] D26955: Fix bitwidth for x87 extended-precision floating-point type

ddcc created this revision. ddcc added a reviewer: rsmith. ddcc added a subscriber: cfe-commits. llvm::APFloat::x87DoubleExtended is defined as having 80 bits of size https://reviews.llvm.org/D26955 Files: lib/Basic/TargetInfo.cpp Index: lib/Basic/TargetInfo.cpp

[PATCH] D26955: Fix bitwidth for x87 extended-precision floating-point type

ddcc added a comment. I could be completely mistaken here, but currently `Ctx.getRealTypeForBitwidth(llvm::APFloat::getSizeInBits(llvm::APFloat::x87DoubleExtended))` with a `ASTContext Ctx` does not round-trip correctly. https://reviews.llvm.org/D26955 __

[PATCH] D26903: [libcxx] Add tests (but not implementation)

EricWF added a comment. Thanks guys! I'll address all these tomorrow! https://reviews.llvm.org/D26903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26442: [analyzer] Fix crash on getSVal: handle case of CompoundVal

This revision was automatically updated to reflect the committed changes. Closed by commit rL287618: [analyzer] Fix a crash on accessing a field within a literal-initialized union. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D26442?vs=77316&id=78826#toc Repositor

r287618 - [analyzer] Fix a crash on accessing a field within a literal-initialized union.

Author: dergachev Date: Mon Nov 21 22:29:23 2016 New Revision: 287618 URL: http://llvm.org/viewvc/llvm-project?rev=287618&view=rev Log: [analyzer] Fix a crash on accessing a field within a literal-initialized union. Because in case of unions we currently default-bind compound values in the store,

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

In what way is this chromium specific? It's "all non-xcode uses of clang on mac", no? On Nov 21, 2016 7:29 PM, "Mehdi Amini" wrote: > > On Nov 21, 2016, at 2:44 PM, Nico Weber wrote: > > On Mon, Nov 21, 2016 at 5:34 PM, Mehdi Amini > wrote: > >> >> On Nov 21, 2016, at 2:27 PM, Nico Weber wrot

Re: [PATCH] D26944: Suppress -Wliblto warning when -flto is not present

Lgtm, works for me. Seems like a good compromise. On Nov 21, 2016 6:29 PM, "Reid Kleckner" wrote: > rnk created this revision. > rnk added reviewers: mehdi_amini, thakis. > rnk added a subscriber: cfe-commits. > > Without -flto, it's unlikely that users will experience LLVM version > skew. The s

Re: [PATCH] D26944: Suppress -Wliblto warning when -flto is not present

FYI, doesn’t look good to me, cf what I described on the other thread. > On Nov 21, 2016, at 9:51 PM, Nico Weber wrote: > > Lgtm, works for me. Seems like a good compromise. > > > On Nov 21, 2016 6:29 PM, "Reid Kleckner" > wrote: > rnk created this revision. > rnk adde

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

AFAIK any clang build open-source ships with libLTO. Not having libLTO built with clang is a Chromium oddity, unless I missed the obvious somewhere. > On Nov 21, 2016, at 9:50 PM, Nico Weber wrote: > > In what way is this chromium specific? It's "all non-xcode uses of clang on > mac", no? >

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

Double-checked on the latest binary release on llvm.org, it ships with clang+llvm-3.9.0-x86_64-apple-darwin/lib/libLTO.dylib I also can’t find any CMake option that disable LTO support at build time for clang. > On Nov 21, 2016, at 9:53 PM, Mehdi Amini via cfe-commits > wrote: > > AFAIK any

r287628 - Rename option to -lto-pass-remarks-output

Author: anemet Date: Tue Nov 22 01:35:19 2016 New Revision: 287628 URL: http://llvm.org/viewvc/llvm-project?rev=287628&view=rev Log: Rename option to -lto-pass-remarks-output The new option -pass-remarks-output broke LLVM_LINK_LLVM_DYLIB because of the duplicate option name with opt. Modified: