Author: rksimon
Date: Wed Nov 16 03:27:40 2016
New Revision: 287088
URL: http://llvm.org/viewvc/llvm-project?rev=287088&view=rev
Log:
[X86][AVX512] Replace lossless i32/u32 to f64 conversion intrinsics with
generic IR
Both the (V)CVTDQ2PD (i32 to f64) and (V)CVTUDQ2PD (u32 to f64) conversion
in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287088: [X86][AVX512] Replace lossless i32/u32 to f64
conversion intrinsics with… (authored by RKSimon).
Changed prior to commit:
https://reviews.llvm.org/D26686?vs=78038&id=78146#toc
Repository:
rL
ioeric updated this revision to Diff 78148.
ioeric added a comment.
- Don't fix base class initializers at all.
https://reviews.llvm.org/D26637
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
test/change-namespace/lambda-function.cpp
unittests/change-names
malcolm.parsons added inline comments.
Comment at: test/clang-tidy/modernize-use-default.cpp:142
+// CHECK-MESSAGES: :[[@LINE-2]]:1: warning: use '= default'
+// CHECK-FIXES: TempODef::~TempODef() = default;
+
aaron.ballman wrote:
> malcolm.parsons wrote:
> > aar
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287091: [clang-tidy] Handle template instantiations in
modenize-use-default check (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26582?vs=77728&id=78151#toc
Repositor
Author: malcolm.parsons
Date: Wed Nov 16 03:51:40 2016
New Revision: 287091
URL: http://llvm.org/viewvc/llvm-project?rev=287091&view=rev
Log:
[clang-tidy] Handle template instantiations in modenize-use-default check
Summary:
Duplicate fixes were being created for explicit template instantiations
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:414
+ Optional> InMovedSymbolNames;
for (StringRef ClassName : Spec.Names) {
llvm::StringRef GlobalClassName = ClassName.trim().ltrim(':');
s/ClassName/SymbolName/
Comm
A backup ping. Sorry for the noise but this would be a very useful patch to
get done and dusted.
On 10 November 2016 at 08:17, Alexey Bataev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> ABataev added a comment.
>
> Ping
>
>
> https://reviews.llvm.org/D22955
>
>
>
> _
hokein added inline comments.
Comment at: test/clang-move/move-function.cpp:9
+// CHECK-NEW-TEST-H-CASE1: #define {{.*}}NEW_FUNCTION_TEST_H
+// CHECK-NEW-TEST-H-CASE1: inline int g() { return 0; }
+// CHECK-NEW-TEST-H-CASE1: #endif // {{.*}}NEW_FUNCTION_TEST_H
io
hokein updated this revision to Diff 78160.
hokein marked 4 inline comments as done.
hokein added a comment.
Add one more test and rename variables.
https://reviews.llvm.org/D26665
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/function_test.cpp
test/clang-move/Inputs/function_tes
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg with two nits.
Comment at: clang-move/ClangMove.cpp:145
+ void run(const MatchFinder::MatchResult &Result) override {
+auto *SM = &Result.Context->getSourceManager();
Author: joey
Date: Wed Nov 16 05:34:09 2016
New Revision: 287100
URL: http://llvm.org/viewvc/llvm-project?rev=287100&view=rev
Log:
[OpenCL] Use the semantic spelling of the Access attribute, rather than a
string.
Also fix a latent bug, due to an incorrect traversal of the AttributeList.
Mod
joey closed this revision.
joey added a comment.
Committed as r287100.
Comment at: test/SemaOpenCL/access-qualifier.cl:71
+
+#if __OPENCL_C_VERSION__ >= 200
+void myPipeWrite(write_only pipe int); // expected-note {{passing argument to
parameter here}}
This wa
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, alexfh.
malcolm.parsons added a subscriber: cfe-commits.
Warn about special member functions that only contain a comment.
Report the location of the special member function, unless it is
defined in a macro. Rep
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, klimek, teemperor, doug.gregor.
malcolm.parsons added a subscriber: cfe-commits.
https://reviews.llvm.org/D26742
Files:
include/clang/AST/RecursiveASTVisitor.h
unittests/AST/PostOrderASTVisitor.cpp
Index:
sepavloff updated this revision to Diff 78167.
sepavloff added a comment.
Limit the patch by named configuration files only
Follow advice of @mgorny and removed all features from the patch except
named config files. These are files specified explicitly by option
`--config` or encoded in executabl
hokein updated this revision to Diff 78171.
hokein added a comment.
Fix nits.
https://reviews.llvm.org/D26665
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/function_test.cpp
test/clang-move/Inputs/function_test.h
test/clang-move/move-function.cpp
Index: test/clang-move/move-fu
Author: hokein
Date: Wed Nov 16 07:05:19 2016
New Revision: 287101
URL: http://llvm.org/viewvc/llvm-project?rev=287101&view=rev
Log:
[clang-move] Support moving function.
Reviewers: ioeric
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D26665
Added:
clang-tools-ex
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287101: [clang-move] Support moving function. (authored by
hokein).
Changed prior to commit:
https://reviews.llvm.org/D26665?vs=78171&id=78174#toc
Repository:
rL LLVM
https://reviews.llvm.org/D26665
EricWF created this revision.
EricWF added reviewers: alexfh, hokein, aaron.ballman.
EricWF added a subscriber: cfe-commits.
This patch adds handling for member initializers in a constructors initializer
list. Previously we only handled base-class and delegating initializers, which
are transform
Author: yrnkrn
Date: Wed Nov 16 07:45:34 2016
New Revision: 287102
URL: http://llvm.org/viewvc/llvm-project?rev=287102&view=rev
Log:
Rangify for loop, NFC.
Modified:
cfe/trunk/lib/Sema/SemaTemplate.cpp
Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp
URL:
http://llvm.org/viewvc/llvm-project/c
echuraev created this revision.
echuraev added a reviewer: cfe-commits.
Herald added a subscriber: yaxunl.
Patch by Guy Benyei
https://reviews.llvm.org/D26735
Files:
include/clang/Basic/DiagnosticParseKinds.td
lib/Parse/ParseExpr.cpp
test/SemaOpenCL/ampamp-gnu.cl
Index: test/SemaOpenCL/
bkramer created this revision.
bkramer added a reviewer: klimek.
bkramer added a subscriber: cfe-commits.
This can be used to append alternative typo corrections to an existing diag.
include-fixer can use it to suggest includes to be added.
https://reviews.llvm.org/D26745
Files:
include/clang
ioeric updated this revision to Diff 78180.
ioeric added a comment.
- Minor fix
https://reviews.llvm.org/D26637
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
test/change-namespace/lambda-function.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
I
bkramer marked 2 inline comments as done.
bkramer added inline comments.
Comment at: test/clang-tidy/google-global-names.cpp:13-14
+// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: 'i' declared in the global
namespace
+extern int ii = 0;
+// CHECK-MESSAGES: :[[@LINE-1]]:12: warning:
hokein added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:346
+ hasDeclaration(DeclMatcher.bind("from_decl"),
+
unless(hasAncestor(typeLoc(loc(qualType(hasDeclaration(
+ decl
bkramer added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:546
+ << llvm::toString(std::move(Err)) << "\n";
+assert(false);
+ }
So is this an error or not? If you can hit this by using the tool it should
bail out here. I
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D26745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
joey created this revision.
joey added a subscriber: cfe-commits.
joey set the repository for this revision to rL LLVM.
Herald added a subscriber: yaxunl.
Split the PipeType into two derived classes. This allows Sema to diagnose
passing read_only to write_only and vice versa.
Repository:
rL L
Author: dcoughlin
Date: Wed Nov 16 08:23:41 2016
New Revision: 287105
URL: http://llvm.org/viewvc/llvm-project?rev=287105&view=rev
Log:
[www] Fix spelling error in checker release notes.
Modified:
cfe/trunk/www/analyzer/release_notes.html
Modified: cfe/trunk/www/analyzer/release_notes.html
U
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added inline comments.
Comment at: clang-tidy/google/GlobalNamesCheck.cpp:62
+Result.SourceManager->getExpansionLoc(D->getLocStart( {
+ // unless that file is a header.
+ if (!utils::isSpelling
ioeric updated this revision to Diff 78183.
ioeric marked 8 inline comments as done.
ioeric added a comment.
- Addressed comments.
https://reviews.llvm.org/D26637
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
unittests/change-namespace/ChangeNamespaceTests
Author: xazax
Date: Wed Nov 16 08:42:10 2016
New Revision: 287107
URL: http://llvm.org/viewvc/llvm-project?rev=287107&view=rev
Log:
[clang-tidy] New check to prefer transparent functors to non-transparent ones.
Added:
clang-tools-extra/trunk/clang-tidy/modernize/UseTransparentFunctorsCheck.cp
xazax.hun closed this revision.
xazax.hun marked 2 inline comments as done.
xazax.hun added a comment.
Thanks for the reviews, committed in https://reviews.llvm.org/rL287107 .
https://reviews.llvm.org/D24894
___
cfe-commits mailing list
cfe-commits@
amehsan added inline comments.
Comment at: lib/Headers/altivec.h:350
+__tempc = __tempc & 0x0001;
+unsigned long long __longa = (unsigned long long) __tempa;
+unsigned long long __longb = (unsigned long long) __tempb;
kbarton wrote:
> nemanjai wro
hokein added inline comments.
Comment at: test/change-namespace/lambda-function.cpp:2
+// RUN: clang-change-namespace -old_namespace "na::nb" -new_namespace "x::y"
--file_pattern ".*" %s -- -std=c++11 | sed 's,// CHECK.*,,' | FileCheck %s
+#include
+// CHECK: namespace x {
Author: ericwf
Date: Wed Nov 16 08:48:42 2016
New Revision: 287109
URL: http://llvm.org/viewvc/llvm-project?rev=287109&view=rev
Log:
Fix -verify tests for older ccache versions
Modified:
libcxx/trunk/test/libcxx/test/format.py
Modified: libcxx/trunk/test/libcxx/test/format.py
URL:
http://ll
EricWF accepted this revision.
EricWF added inline comments.
This revision is now accepted and ready to land.
Comment at: src/new.cpp:163
-_LIBCPP_WEAK _LIBCPP_NEW_DELETE_VIS
void*
You should be able to remove the macro on the definitions since they're
redund
EricWF added a comment.
What happens on windows when `operator new` isn't overridden and has to be
imported from the DLL? Does that work?
https://reviews.llvm.org/D26702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
ioeric updated this revision to Diff 78188.
ioeric added a comment.
- Add lambda-function.cpp test back.
https://reviews.llvm.org/D26637
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
test/change-namespace/lambda-function.cpp
unittests/change-namespace/Ch
Author: pjaaskel
Date: Wed Nov 16 09:22:31 2016
New Revision: 287112
URL: http://llvm.org/viewvc/llvm-project?rev=287112&view=rev
Log:
Add a little endian variant of TCE.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/lib/CodeGen/TargetInfo.cpp
cfe/trunk/lib/Driver/Driver.cpp
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM once nits get fixed.
Comment at: change-namespace/ChangeNamespace.cpp:346
+ hasDeclaration(DeclMatcher.bind("from_decl"),
+
ioeric updated this revision to Diff 78190.
ioeric added a comment.
- nits
https://reviews.llvm.org/D26637
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
test/change-namespace/lambda-function.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index:
rogfer01 added inline comments.
Comment at: include/clang/Basic/Specifiers.h:119-140
enum ExprObjectKind {
/// An ordinary object is located at an address in memory.
OK_Ordinary,
/// A bitfield object is a bitfield on a C or C++ record.
OK_BitField,
---
Author: rksimon
Date: Wed Nov 16 10:11:08 2016
New Revision: 287114
URL: http://llvm.org/viewvc/llvm-project?rev=287114&view=rev
Log:
Remove duplicate condition (PR30648). NFCI.
We only need to check that the bitstream entry is a Record.
Modified:
cfe/trunk/lib/Serialization/ASTReader.cpp
M
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, Eugene.Zelenko, alexfh.
malcolm.parsons added a subscriber: cfe-commits.
Herald added subscribers: modocache, mgorny.
Fixes PR18858
https://reviews.llvm.org/D26750
Files:
clang-tidy/modernize/CMakeLists.txt
Author: ioeric
Date: Wed Nov 16 10:54:53 2016
New Revision: 287118
URL: http://llvm.org/viewvc/llvm-project?rev=287118&view=rev
Log:
[change-namespace] handle constructor initializer: Derived : Base::Base() {}
and added conflict detections
Summary:
namespace nx { namespace ny { class Base { publ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287118: [change-namespace] handle constructor initializer:
Derived : Base::Base() {}… (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D26637?vs=78190&id=78201#toc
Repository:
Author: pjaaskel
Date: Wed Nov 16 10:21:59 2016
New Revision: 287115
URL: http://llvm.org/viewvc/llvm-project?rev=287115&view=rev
Log:
target-data test update for TCE and TCELE
Modified:
cfe/trunk/test/CodeGen/target-data.c
Modified: cfe/trunk/test/CodeGen/target-data.c
URL:
http://llvm.org
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, alexfh.
malcolm.parsons added a subscriber: cfe-commits.
Template instantiations were causing misplaced fixits.
https://reviews.llvm.org/D26751
Files:
clang-tidy/modernize/UseEqualsDeleteCheck.cpp
test/cl
rsmith added a comment.
Hmm, this won't help when building libc++ as a module, and we don't have a
wrapper header to hold these undefs since is not part of c++.
So either that combination of includes gives a broken or a broken
, or we do something nonstandard like reimplementing the latter in
mclow.lists added a comment.
I'll do some research.
https://reviews.llvm.org/D26376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added a comment.
In https://reviews.llvm.org/D26657#596897, @smeenai wrote:
> In https://reviews.llvm.org/D26657#596759, @hans wrote:
>
> > > On MSVC, if an implicit instantiation already exists and an explicit
> > > instantiation definition with a DLL attribute is created, the DLL
> > > a
Anastasia added a comment.
It seems that this bit is accepted under -std=c99 and the warning is given with
the -pedantic flag. I am not sure whether it adds much deviating the
implementation from C here. The OpenCL spec doesn't seem to contain anything on
this matter? But if we decide to be mor
mclow.lists added a comment.
Ok - looking just at `kill_dependency`, this was added to the C standard in
C11. It's required to be a macro.
`atomic_is_lock_free` appears to be a function, as does `atomic_load`. Haven't
checked the rest.
I see that Bionic (sometimes) defines `atomic_is_lock_free`
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-default-member-init.rst:7
+This check converts a default constructor's member initializers into default
+member initializers. Other member initializers that match the default
+member initializ
On 16 Nov 2016 10:04 am, "Marshall Clow" wrote:
mclow.lists added a comment.
Ok - looking just at `kill_dependency`, this was added to the C standard in
C11. It's required to be a macro.
`atomic_is_lock_free` appears to be a function, as does `atomic_load`.
Haven't checked the rest.
That's a b
Anastasia added a comment.
Earlier related discussion: https://reviews.llvm.org/D17821
Repository:
rL LLVM
https://reviews.llvm.org/D26746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
rogfer01 marked 15 inline comments as done.
rogfer01 added a comment.
I am retaking this, will upload an updated patch soon.
Comment at: lib/AST/Decl.cpp:3523
+ return !isBitField() &&
+ (this->hasAttr() || getParent()->hasAttr()) &&
+ Context.getDeclAlign(this
rogfer01 updated this revision to Diff 78209.
rogfer01 added a comment.
Changes:
- Rebase patch to trunk
- Fixes as pointed out by reviewers
TODO:
- Diagnose and drop the packed attribute of a class with a nontrivially
constructed data member.
https://reviews.llvm.org/D23325
Files:
includ
bkramer created this revision.
bkramer added reviewers: klimek, hokein, ioeric.
bkramer added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.
- Refactor the external sema source into a visible class
- Add support for emitting FixIts
- Wrap up include fixer as a plugin as I did with c
bruno added a comment.
Ping!
https://reviews.llvm.org/D26267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin created this revision.
a.sidorin added reviewers: spyffe, khazem.
a.sidorin added a subscriber: cfe-commits.
- Support template partial specialization
- Avoid infinite recursion in IsStructurallyEquivalent for TemplateArgument
with implementing IsStructurallyEquivalent for TemplateName
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287128: [Frontend] Allow attaching an external sema source
to compiler instance and… (authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D26745?vs=78179&id=78213#toc
Repository:
rL L
Author: d0k
Date: Wed Nov 16 12:15:26 2016
New Revision: 287128
URL: http://llvm.org/viewvc/llvm-project?rev=287128&view=rev
Log:
[Frontend] Allow attaching an external sema source to compiler instance and
extra diags to TypoCorrections
This can be used to append alternative typo corrections to
Author: spyffe
Date: Wed Nov 16 12:21:00 2016
New Revision: 287129
URL: http://llvm.org/viewvc/llvm-project?rev=287129&view=rev
Log:
Fixed layout of test/ASTMerge.
As outlined in a previous RFC, the test/ASTMerge/Inputs folder is getting full
and the tests are starting to become interdependent.
spyffe closed this revision.
spyffe added a comment.
Committed r287129
Repository:
rL LLVM
https://reviews.llvm.org/D26571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rSerge updated this revision to Diff 78216.
rSerge added a comment.
Rebased to the latest version of LLVM sources.
https://reviews.llvm.org/D26415
Files:
lib/Driver/Tools.cpp
test/Driver/XRay/xray-instrument-cpu.c
test/Driver/XRay/xray-instrument-os.c
Index: test/Driver/XRay/xray-instru
arphaman updated this revision to Diff 78218.
arphaman marked 4 inline comments as done.
arphaman added a comment.
Addressed review comments by renaming the diagnostic and simplifying the name
and the use of the `expectIdentifier ` method.
Repository:
rL LLVM
https://reviews.llvm.org/D26503
arphaman added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:5405
+ // Objective-C++: Detect C++ keywords and try to prevent further errors
by
+ // treating these keyword as valid member names.
+ if (getLangOpts().ObjC1 && getLangOpts().CPlusPlus &&
---
khazem added a comment.
Thanks very much for this patch! It certainly fixes the infinite recursion
issue on our codebase. It LGTM, but I'd like to add a test case before landing
it.
https://reviews.llvm.org/D26753
___
cfe-commits mailing list
cfe-
mclow.lists added a comment.
More info - The following code:
#include
int main () {}
fails to compile on either gcc 6.2 (locally), gcc 7 head (online compiler) or
MSVC (online compiler).
https://reviews.llvm.org/D26376
___
cfe-commits mailin
Author: adrian
Date: Wed Nov 16 12:49:47 2016
New Revision: 287134
URL: http://llvm.org/viewvc/llvm-project?rev=287134&view=rev
Log:
Fix PR31029 by attaching an artificial debug location to msabi thunks.
This was a latent bug that was recently uncovered by r286400.
Added:
cfe/trunk/test/CodeG
teemperor added a reviewer: rsmith.
teemperor added a comment.
Looks good to me. I'll add Richard because he also merged/approved the original
post-order patch.
https://reviews.llvm.org/D26742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
This looks amazing. I have a few minor quibbles and a testing concern, but
overall this looks like a great step forward! Thank you!
Comment at: lib/AST/ASTImport
Author: yrnkrn
Date: Wed Nov 16 13:24:10 2016
New Revision: 287138
URL: http://llvm.org/viewvc/llvm-project?rev=287138&view=rev
Log:
Rangify for loops, NFC.
Modified:
cfe/trunk/lib/Frontend/DependencyFile.cpp
Modified: cfe/trunk/lib/Frontend/DependencyFile.cpp
URL:
http://llvm.org/viewvc/l
Author: adrian
Date: Wed Nov 16 13:26:11 2016
New Revision: 287139
URL: http://llvm.org/viewvc/llvm-project?rev=287139&view=rev
Log:
Add the missing FileCheck invocation to this testcase.
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-thunk-msabi.cpp
Modified: cfe/trunk/test/CodeGenCXX/debug
Author: adrian
Date: Wed Nov 16 13:31:44 2016
New Revision: 287141
URL: http://llvm.org/viewvc/llvm-project?rev=287141&view=rev
Log:
Relax testcase.
This removes checks that are irrelevant for what is being tested.
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-thunk-msabi.cpp
Modified: cfe/
hans added a subscriber: srhines.
hans added a comment.
I'm still skeptical, but I think this is an improvement over the previous patch.
I think your best bet to get this landed is to find someone from the cfe-dev
thread who is in favour of config files and have them review it.
I'm also cc'ing
krasin updated this revision to Diff 78240.
krasin marked an inline comment as done.
krasin added a comment.
Sync to Clang ToT.
https://reviews.llvm.org/D26559
Files:
lib/CodeGen/CGExprCXX.cpp
test/CodeGenCXX/ubsan-vtable-checks.cpp
Index: test/CodeGenCXX/ubsan-vtable-checks.cpp
==
k-wisniewski created this revision.
k-wisniewski added reviewers: a.sidorin, NoQ, dcoughlin, zaks.anna.
k-wisniewski added a subscriber: cfe-commits.
This patch adds getArgsSVal method to ProgramState that allows the user to
obtain SVals of argumetns used in a call that created the given StackFra
k-wisniewski created this revision.
k-wisniewski added reviewers: NoQ, dcoughlin, zaks.anna, a.sidorin.
k-wisniewski added a subscriber: cfe-commits.
Hi!
I've noticed that check::RegionChanges::wantsRegionChangeUpdate is no longer
used - as far as the discussion went it has been unused at least
k-wisniewski created this revision.
k-wisniewski added reviewers: a.sidorin, zaks.anna, NoQ, dcoughlin.
k-wisniewski added subscribers: cfe-commits, NoQ.
Artem Dergachev (@NoQ ) helped me correctly handle C++ method calls in my
RecursionChecker (that finds infnite recursion) and this is the metho
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Looks great!
https://reviews.llvm.org/D26759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/CheckerManager.cpp:535
+ ExplicitRegions, Regions,
+ Call, LCtx);
}
Looks like the other patch leaked i
smeenai added a comment.
In https://reviews.llvm.org/D26702#597377, @EricWF wrote:
> What happens on windows when `operator new` isn't overridden and has to be
> imported from the DLL? Does that work?
Yup. If you have a function that isn't marked `dllimport` and it's not found
locally, the li
mgorny created this revision.
mgorny added a reviewer: kcc.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: dberris, kubabrecka.
Use the __SSE2__ to determine whether SSE2 is enabled in the ASAN tests
rather than relying on either of the __i686__ and __x86_64__. The former
is onl
NoQ added a comment.
I think this method, unlike https://reviews.llvm.org/D26760, doesn't have the
problem with overwriting the location in the top frame, because the location of
C++ "this" cannot really be assigned to.
https://reviews.llvm.org/D26762
___
NoQ added a comment.
I'm ok with constructing `SymbolRegionValue` for `ArgLoc` manually and adding a
comment like `FIXME: leaking implementation details of RegionStoreManager`.
https://reviews.llvm.org/D26760
___
cfe-commits mailing list
cfe-commit
mgorny created this revision.
mgorny added reviewers: samsonov, etienneb, beanz.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: dberris, kubabrecka.
Remove the explicit i686 target that is completely duplicate to
the i386 target, with the latter being used more commonly.
1. The
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D26741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
k-wisniewski updated this revision to Diff 78249.
k-wisniewski added a comment.
Removed a line that leaked from another diff - thanks Anna!
https://reviews.llvm.org/D26759
Files:
include/clang/StaticAnalyzer/Core/Checker.h
include/clang/StaticAnalyzer/Core/CheckerManager.h
include/clang/S
smeenai added a comment.
In https://reviews.llvm.org/D26657#597523, @hans wrote:
> In https://reviews.llvm.org/D26657#596897, @smeenai wrote:
>
> > In https://reviews.llvm.org/D26657#596759, @hans wrote:
> >
> > > > On MSVC, if an implicit instantiation already exists and an explicit
> > > > ins
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:681
+
+for (auto Init : Decl->inits()) {
+ if (!Init->isWritten() || Init->isInClassMemberInitializer())
Please use `const auto *` instead of just `auto`.
EricWF marked an inline comment as done.
EricWF added inline comments.
Comment at: test/clang-tidy/readability-identifier-naming.cpp:155
// CHECK-FIXES: {{^}}class CMyClass {{{$}}
+public:
my_class();
aaron.ballman wrote:
> Why set the access specifier here
EricWF updated this revision to Diff 78252.
EricWF added a comment.
Fix `auto` usage.
https://reviews.llvm.org/D26744
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
test/clang-tidy/readability-identifier-naming.cpp
Index: test/clang-tidy/readability-identifier-naming.cpp
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: test/clang-tidy/readability-identifier-naming.cpp:155
// CHECK-FIXES: {{^}}class CMyClass {{{$}}
+public:
my_class();
E
Author: ericwf
Date: Wed Nov 16 15:15:58 2016
New Revision: 287153
URL: http://llvm.org/viewvc/llvm-project?rev=287153&view=rev
Log:
[clang-tidy] Fix identifier naming for initializer list member initializers.
Summary:
This patch adds handling for member initializers in a constructors initializer
rsmith added a comment.
Please don't ban things just because you can. If there's some reason why this
doesn't make sense in OpenCL, this may be fine, but generally you shouldn't be
making this language mode deviate from clang's normal behaviour regarding
extensions.
(It would be great if we ha
pcc added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:1769
+ SourceLocation CallLoc;
+ if (DE)
+CallLoc = DE->getExprLoc();
DE will always be non-null at this point.
Comment at: test/CodeGenCXX/ubsan-vtable-checks.cpp:23
+ //
1 - 100 of 144 matches
Mail list logo
