This revision was automatically updated to reflect the committed changes.
Closed by commit rL287012: [CUDA] Mark __libcpp_{isnan,isinf,isfinite} as
constexpr. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25403?vs=77271&id=78041#toc
Repository:
rL LLVM
https://rev
beanz accepted this revision.
beanz added a comment.
Yep. Can we maybe add an error to that effect? I really don't want the build
system ignoring invalid configurations.
Otherwise LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D26649
___
cf
phosek updated this revision to Diff 78045.
phosek added a comment.
Added error message for Darwin, does this look good to you?
Repository:
rL LLVM
https://reviews.llvm.org/D26649
Files:
CMakeLists.txt
Index: CMakeLists.txt
rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D26464
___
cfe-commits mailing list
cfe-co
mehdi_amini added a comment.
@beanz : don't you think that it should be handled at the top level and not in
the bootstrap logic?
Right now we don't error when invoking cmake with `-DLLVM_ENABLE_LLD=ON` and
`-DLLVM_ENABLE_LTO=ON` on Darwin.
Repository:
rL LLVM
https://reviews.llvm.org/D2664
ddcc updated this revision to Diff 78049.
ddcc added a comment.
Rebase on recent changes
https://reviews.llvm.org/D26061
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h
include/clang/StaticAnalyzer/Core/PathSensitive/SimpleConstraintManager.h
lib/StaticAnalyzer/
rsmith added inline comments.
Comment at: lib/Lex/LiteralSupport.cpp:768
.Cases("il", "i", "if", true)
+ .Case("sv", true)
.Default(false);
aaron.ballman wrote:
> mclow.lists wrote:
> > aaron.ballman wrote:
> > > malcolm.parsons wrote:
> > > >
steven_wu created this revision.
steven_wu added a reviewer: mehdi_amini.
steven_wu added a subscriber: cfe-commits.
-fembed-bitcode infers -bitcode_bundle to ld64 but it is not correctly
passed when using LTO. LTO is a special case of -fembed-bitcode which
it doesn't require embed the bitcode in
phosek added a comment.
In https://reviews.llvm.org/D26649#596209, @mehdi_amini wrote:
> @beanz : don't you think that it should be handled at the top level and not
> in the bootstrap logic?
> Right now we don't error when invoking cmake with `-DLLVM_ENABLE_LLD=ON`
> and `-DLLVM_ENABLE_LTO=ON
Author: ericwf
Date: Tue Nov 15 14:21:30 2016
New Revision: 287020
URL: http://llvm.org/viewvc/llvm-project?rev=287020&view=rev
Log:
Add .clang-format to libc++
Adding a Clang Format file to libc++ and which style it should use has been
discussed a couple of times. This patch finally adds a .clan
aaron.ballman added a comment.
I think this meets my needs for the cert-oop11-cpp check as it appears to be
preserving the original behavior. If a user has the `UseCERTSemantics` option
set in one of their scripts, that appears to be silently accepted and discarded
currently, so I don't think t
smeenai added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7669
+// Fix a TSK_ExplicitInstantiationDeclaration or a
TSK_ImplicitInstantiation
+// followed by a TSK_ExplicitInstantiationDefinition
+if ((Old_TSK == TSK_ExplicitInstantiationDeclaration ||
ddcc created this revision.
ddcc added reviewers: zaks.anna, dcoughlin.
ddcc added a subscriber: cfe-commits.
Split out formatting and style changes from https://reviews.llvm.org/D26061
https://reviews.llvm.org/D26691
Files:
lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
lib/StaticAnaly
krasin added a comment.
Friendly ping.
https://reviews.llvm.org/D26559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: akirtzidis
Date: Tue Nov 15 14:51:46 2016
New Revision: 287024
URL: http://llvm.org/viewvc/llvm-project?rev=287024&view=rev
Log:
[libclang] Generalize clang_getNumTemplateArguments and
clang_getTemplateArgumentAsType to other kind of specializations.
Patch by Emilio Cobos Álvarez!
https:
Author: abataev
Date: Tue Nov 15 14:57:18 2016
New Revision: 287025
URL: http://llvm.org/viewvc/llvm-project?rev=287025&view=rev
Log:
[OPENMP] Fix stack use after delete, NFC.
Fixed possible use of stack variable after deletion.
Modified:
cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
Modified: cfe
beanz added a comment.
Failing on `-DLLVM_ENABLE_LLD=ON` and `-DLLVM_ENABLE_LTO=ON` in LLVM seems fine
to me.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
ddcc created this revision.
ddcc added reviewers: zaks.anna, dcoughlin.
ddcc added a subscriber: cfe-commits.
The basic constraint solver was dropped in https://reviews.llvm.org/rL162384,
leaving the range constraint solver as the default and only constraint solver.
Explicitly specifying it is u
vitalybuka created this revision.
vitalybuka added a reviewer: ABataev.
vitalybuka added a subscriber: cfe-commits.
It introduced stack-use-after-return detected by ASAN.
Here:
'''
auto &&CodeGen = [ELoc](CodeGenFunction &CGF) {
CGF.CGM.getOpenMPRuntime().emitForStaticFinish(CGF, ELoc);
mehdi_amini added inline comments.
Comment at: lib/Driver/Tools.cpp:8326
- if (C.getDriver().embedBitcodeEnabled() ||
- C.getDriver().embedBitcodeMarkerOnly()) {
-// Check if the toolchain supports bitcode build flow.
Why aren't these tests returning tr
steven_wu added inline comments.
Comment at: lib/Driver/Tools.cpp:8326
- if (C.getDriver().embedBitcodeEnabled() ||
- C.getDriver().embedBitcodeMarkerOnly()) {
-// Check if the toolchain supports bitcode build flow.
mehdi_amini wrote:
> Why aren't these
Author: mcrosier
Date: Tue Nov 15 15:34:31 2016
New Revision: 287037
URL: http://llvm.org/viewvc/llvm-project?rev=287037&view=rev
Log:
[AArch64] Add driver tests for Qualcomm's Falkor CPU.
Differential Revision: https://reviews.llvm.org/D26674
Modified:
cfe/trunk/test/Driver/aarch64-cpus.c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287037: [AArch64] Add driver tests for Qualcomm's Falkor
CPU. (authored by mcrosier).
Changed prior to commit:
https://reviews.llvm.org/D26674?vs=78002&id=78070#toc
Repository:
rL LLVM
https://revie
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26453#596254, @aaron.ballman wrote:
> (This part of the check is one half modernization, one half performance, and
> one half correctness, depending on which lens you view the code through.)
The performance part should be handled by
Author: mehdi_amini
Date: Tue Nov 15 15:47:11 2016
New Revision: 287039
URL: http://llvm.org/viewvc/llvm-project?rev=287039&view=rev
Log:
Improve handling of __FUNCTION__ and other predefined expression for
Objective-C Blocks
Instead of always displaying the mangled name, try to do better
and ge
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287039: Improve handling of __FUNCTION__ and other
predefined expression for Objective… (authored by mehdi_amini).
Changed prior to commit:
https://reviews.llvm.org/D26522?vs=77682&id=78073#toc
Reposit
Author: jlebar
Date: Tue Nov 15 16:03:29 2016
New Revision: 287041
URL: http://llvm.org/viewvc/llvm-project?rev=287041&view=rev
Log:
[libcxx] Mark xonstexpr-fns.pass.cpp as XFAIL: gcc.
This fails with gcc because __builtin_isnan and friends, which
libcpp_isnan and friends call, are not themselves
zaks.anna added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/Checker.h:325
+ const CallEvent *Call,
+ const LocationContext *LCtx) {
+return ((const CHECKER *) checker)->checkRegionChanges(state, invalidated,
---
- Original Message -
> From: "Aaron Ballman via cfe-commits"
> To: "Joshua Hurwitz"
> Cc: "cfe-commits"
> Sent: Tuesday, November 15, 2016 12:17:28 PM
> Subject: Re: [PATCH] Warning for main returning a bool.
>
> On Fri, Oct 14, 2016 at 1:17 PM, Joshua Hurwitz via cfe-commits
> wrote:
vitalybuka added a comment.
This is probably caused by this patch
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/649/steps/check-clang%20msan/logs/stdio
Repository:
rL LLVM
https://reviews.llvm.org/D26522
___
cfe-commits mai
Author: mehdi_amini
Date: Tue Nov 15 16:19:50 2016
New Revision: 287043
URL: http://llvm.org/viewvc/llvm-project?rev=287043&view=rev
Log:
Revert "Improve handling of __FUNCTION__ and other predefined expression for
Objective-C Blocks"
This reverts commit r287039, tests are broken.
Removed:
mehdi_amini added a comment.
Already reverted
Repository:
rL LLVM
https://reviews.llvm.org/D26522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dergachev
Date: Tue Nov 15 16:22:57 2016
New Revision: 287045
URL: http://llvm.org/viewvc/llvm-project?rev=287045&view=rev
Log:
[analyzer] NumberObjectConversion: Workaround for a linker error with modules.
A combination of C++ modules, variadic functions with more than one argument,
and
On Tue, Nov 15, 2016 at 5:22 PM, Hal Finkel wrote:
> - Original Message -
>> From: "Aaron Ballman via cfe-commits"
>> To: "Joshua Hurwitz"
>> Cc: "cfe-commits"
>> Sent: Tuesday, November 15, 2016 12:17:28 PM
>> Subject: Re: [PATCH] Warning for main returning a bool.
>>
>> On Fri, Oct 14
pcc added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:1928-1933
+SourceLocation CallLoc;
+if (E)
+ CallLoc = E->getExprLoc();
+EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+ CallLoc, Ptr.getPointer(),
+ DeleteTy);
--
- Original Message -
> From: "Aaron Ballman"
> To: "Hal Finkel"
> Cc: "cfe-commits" , "Joshua Hurwitz"
>
> Sent: Tuesday, November 15, 2016 4:42:05 PM
> Subject: Re: [PATCH] Warning for main returning a bool.
>
> On Tue, Nov 15, 2016 at 5:22 PM, Hal Finkel wrote:
> > - Original Me
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
This is a generalization of `_LIBCPP_NEW_DELETE_VIS`; the new macro name
captures the semantics better, and also allows us to get rid of the
`_WIN32` check in `include/ne
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26435#595282, @dtarditi wrote:
> What platform/OS did you build on?
I build release with asserts on 64 bit Linux. My host compiler is gcc.
https://reviews.llvm.org/D26435
___
cfe-commi
mehdi_amini added inline comments.
Comment at: lib/Driver/Tools.cpp:8326
- if (C.getDriver().embedBitcodeEnabled() ||
- C.getDriver().embedBitcodeMarkerOnly()) {
-// Check if the toolchain supports bitcode build flow.
steven_wu wrote:
> mehdi_amini wrot
On Tue, Nov 15, 2016 at 5:44 PM, Hal Finkel wrote:
> - Original Message -
>> From: "Aaron Ballman"
>> To: "Hal Finkel"
>> Cc: "cfe-commits" , "Joshua Hurwitz"
>>
>> Sent: Tuesday, November 15, 2016 4:42:05 PM
>> Subject: Re: [PATCH] Warning for main returning a bool.
>>
>> On Tue, Nov
manmanren added a comment.
Cheers,
Manman
Comment at: include/clang/Basic/DiagnosticParseKinds.td:442
+/// Objective-C++ parser diagnostics
+def err_expected_objcxx_keyword : Error<
+ "expected %0; %1 is a keyword in Objective-C++">;
This name is a little misl
Hi Richard,
Our internal ASan bot started failing after this and r286678:
ASAN:DEADLYSIGNAL
=
==95464==ERROR: AddressSanitizer: stack-overflow on address 0x7fff56c68b40 (pc
0x000110c582a2 bp 0x7fff56c69970 sp 0x7fff56c68b40 T0)
With this patch it's "after-scope" instead of return but still there:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/650/steps/check-clang%20asan/logs/stdio
On Tue, Nov 15, 2016 at 1:07 PM Alexey Bataev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: abataev
>
Author: rsmith
Date: Tue Nov 15 18:03:24 2016
New Revision: 287057
URL: http://llvm.org/viewvc/llvm-project?rev=287057&view=rev
Log:
PR23281: Fix implementation of DR1891 to implement the intent: that is, a
lambda-expression does not have a move-assignment operator.
Modified:
cfe/trunk/includ
phosek updated this revision to Diff 78096.
phosek added a comment.
I've removed the error message and moved it to https://reviews.llvm.org/D26715.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
Files:
CMakeLists.txt
Index: CMakeLists.txt
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini added a comment.
Patch still LGTM!
Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Tue, Nov 15, 2016 at 2:55 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Nov 15, 2016 at 5:44 PM, Hal Finkel wrote:
> > - Original Message -
> >> From: "Aaron Ballman"
> >> To: "Hal Finkel"
> >> Cc: "cfe-commits" , "Joshua Hurwitz" <
> hurwi...@googl
Author: dcoughlin
Date: Tue Nov 15 18:47:56 2016
New Revision: 287063
URL: http://llvm.org/viewvc/llvm-project?rev=287063&view=rev
Log:
[www] Update analyzer website for release of checker-279
Modified:
cfe/trunk/www/analyzer/index.html
cfe/trunk/www/analyzer/latest_checker.html.incl
hans added a comment.
> On MSVC, if an implicit instantiation already exists and an explicit
> instantiation definition with a DLL attribute is created, the DLL
> attribute still takes effect. Make clang match this behavior.
This is scary territory, and behaviour I think might be hard for us to
krasin updated this revision to Diff 78104.
krasin added a comment.
Address comments.
https://reviews.llvm.org/D26559
Files:
lib/CodeGen/CGExprCXX.cpp
test/CodeGenCXX/ubsan-vtable-checks.cpp
Index: test/CodeGenCXX/ubsan-vtable-checks.cpp
krasin marked 2 inline comments as done.
krasin added inline comments.
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1820-1833
+ ASTContext &Context = getContext();
+ SourceLocation CallLoc = CE ? CE->getLocStart() : SourceLocation();
+ CGF.EmitTypeCheck(CodeGenFunction::TCK_Mem
Author: rsmith
Date: Tue Nov 15 18:57:23 2016
New Revision: 287066
URL: http://llvm.org/viewvc/llvm-project?rev=287066&view=rev
Log:
Outline evaluation of calls to builtins to avoid inflating stack usage for the
common case of a call to a non-builtin, particularly for unoptimized ASan
builds (wher
On Tue, Nov 15, 2016 at 3:39 PM, Vedant Kumar wrote:
> Hi Richard,
>
> Our internal ASan bot started failing after this and r286678:
>
> ASAN:DEADLYSIGNAL
> =
> ==95464==ERROR: AddressSanitizer: stack-overflow on address 0x7fff56c68b
vitalybuka created this revision.
vitalybuka added a reviewer: ABataev.
vitalybuka added a subscriber: cfe-commits.
r286944 introduced bugs detected by ASAN as use-after-return.
r287025 have not fixed them completely.
This reverts commit r286944 and r287025.
https://reviews.llvm.org/D26720
Fil
Author: vitalybuka
Date: Tue Nov 15 19:01:22 2016
New Revision: 287069
URL: http://llvm.org/viewvc/llvm-project?rev=287069&view=rev
Log:
Revert "[OPENMP] Fixed codegen for 'omp cancel' construct."
Summary:
r286944 introduced bugs detected by ASAN as use-after-return.
r287025 have not fixed them c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287069: Revert "[OPENMP] Fixed codegen for 'omp cancel'
construct." (authored by vitalybuka).
Changed prior to commit:
https://reviews.llvm.org/D26720?vs=78107&id=78109#toc
Repository:
rL LLVM
https
I've reverted them both to fix bots: https://reviews.llvm.org/D26720
On Tue, Nov 15, 2016 at 3:40 PM Vitaly Buka wrote:
> With this patch it's "after-scope" instead of return but still there:
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/650/steps/check-clang%20asan/logs
steven_wu updated this revision to Diff 78111.
steven_wu added a comment.
Rename the functions to clarify the intention.
embedBitcodeEnabled means if any flag in -fembed-bitcode family is used so the
corresponding linker flag should be inferred. embedBitcodeInObject means if
the bitcode should be
Thank you!
The bot recovered after r287066.
vedant
> On Nov 15, 2016, at 5:09 PM, Richard Smith wrote:
>
> On Tue, Nov 15, 2016 at 3:39 PM, Vedant Kumar wrote:
> Hi Richard,
>
> Our internal ASan bot started failing after this and r286678:
>
> ASAN:DEADLYSIGNAL
> ===
On Fri, Nov 11, 2016 at 3:02 PM, Ivan Krasin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> krasin added a comment.
>
> Small correction: all UBSan type checks tests live in compiler-rt.
Actually, most of the UBSan tests live
in test/CodeGenCXX/catch-undef-behavior.cpp in Clang; the comp
Thank you, Richard.
Shall I merge the newly introduced test/CodeGenCXX/ubsan-vtable-checks.cpp
into catch-undef-behavior.cpp or it's more clear when it's standalone?
On Tue, Nov 15, 2016 at 5:51 PM, Richard Smith
wrote:
> On Fri, Nov 11, 2016 at 3:02 PM, Ivan Krasin via cfe-commits <
> cfe-comm
smeenai added a comment.
In https://reviews.llvm.org/D26657#596759, @hans wrote:
> > On MSVC, if an implicit instantiation already exists and an explicit
> > instantiation definition with a DLL attribute is created, the DLL
> > attribute still takes effect. Make clang match this behavior.
>
> T
On Tue, Nov 15, 2016 at 6:20 PM, Ivan Krasin wrote:
> Thank you, Richard.
>
> Shall I merge the newly introduced test/CodeGenCXX/ubsan-vtable-checks.cpp
> into catch-undef-behavior.cpp or it's more clear when it's standalone?
>
Up to you. catch-undef-behavior.cpp is getting unwieldy, so a separa
Okay, I will keep it as a separate file then. It's very likely that I will
soon send a follow up, as there's another very similar case known to not
work properly (based on the experience with UBSan Vptr bot in Chromium)
On Tue, Nov 15, 2016 at 6:27 PM, Richard Smith
wrote:
> On Tue, Nov 15, 2016
.. but the follow up will be in a separate CL, as I have not even started
to work on it yet.
On Tue, Nov 15, 2016 at 6:31 PM, Ivan Krasin wrote:
> Okay, I will keep it as a separate file then. It's very likely that I will
> soon send a follow up, as there's another very similar case known to not
Author: ericwf
Date: Tue Nov 15 22:45:32 2016
New Revision: 287080
URL: http://llvm.org/viewvc/llvm-project?rev=287080&view=rev
Log:
Fix non-reserved name usage
Modified:
libcxx/trunk/include/limits
Modified: libcxx/trunk/include/limits
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM!
I feel the code is cleaner like that at uses of these API :)
https://reviews.llvm.org/D26690
___
cfe-commits mailing list
cfe-co
mehdi_amini added a comment.
Ping @rsmith !
https://reviews.llvm.org/D26376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: steven_wu
Date: Wed Nov 16 00:06:44 2016
New Revision: 287084
URL: http://llvm.org/viewvc/llvm-project?rev=287084&view=rev
Log:
[Driver] Infer the correct option to ld64 for -fembed-bitcode
Summary:
-fembed-bitcode infers -bitcode_bundle to ld64 but it is not correctly
passed when using L
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287084: [Driver] Infer the correct option to ld64 for
-fembed-bitcode (authored by steven_wu).
Changed prior to commit:
https://reviews.llvm.org/D26690?vs=78111&id=78140#toc
Repository:
rL LLVM
http
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM. Always nice to see more builtins go away.
Repository:
rL LLVM
https://reviews.llvm.org/D26686
___
cfe-commits mailing list
c
Author: mehdi_amini
Date: Wed Nov 16 01:07:28 2016
New Revision: 287085
URL: http://llvm.org/viewvc/llvm-project?rev=287085&view=rev
Log:
Improve handling of __FUNCTION__ and other predefined expression for
Objective-C Blocks
Instead of always displaying the mangled name, try to do better
and ge
101 - 173 of 173 matches
Mail list logo
