This revision was automatically updated to reflect the committed changes.
Closed by commit rL286943: [clang-move] Make the output code look more pretty.
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D26493?vs=77821&id=77958#toc
Repository:
rL LLVM
https://reviews.l
Author: hokein
Date: Tue Nov 15 03:06:59 2016
New Revision: 286943
URL: http://llvm.org/viewvc/llvm-project?rev=286943&view=rev
Log:
[clang-move] Make the output code look more pretty.
Summary:
Add decent blank lines between declarations:
* Add extra blank line after #define or #includes.
* Add e
Author: abataev
Date: Tue Nov 15 03:11:50 2016
New Revision: 286944
URL: http://llvm.org/viewvc/llvm-project?rev=286944&view=rev
Log:
[OPENMP] Fixed codegen for 'omp cancel' construct.
If 'omp cancel' construct is used in a worksharing construct it may cause
hanging of the software in case if red
It would be valuable to perform that test, if clang tests don't already do
this, though I'm not sure it should be part of this particular commit as all
this commit should do is change the casts if the target doesn't support double.
Neil
> -Original Message-
> From: sca...@apple.com [mai
neil.hickey removed rL LLVM as the repository for this revision.
neil.hickey updated this revision to Diff 77961.
neil.hickey added a comment.
Fixes to tests and removal of incorrect check to stop float to float casts if
types match. This was still needed as it was an lvalue to rvalue cast. Added
xazax.hun updated this revision to Diff 77964.
xazax.hun added a comment.
- Updated to latest TOT
- Fixed review comments.
https://reviews.llvm.org/D24894
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseTransparentFunctorsChe
xazax.hun marked 2 inline comments as done.
xazax.hun added inline comments.
Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:89
+diag(FuncInst->getLocStart(), Message)
+<< (FuncClass->getName() + "<>").str();
+return;
aaron.ballma
neil.hickey retitled this revision from "[OpenCL] Improve double literal
handling" to "[OpenCL] Improve floating point literal handling".
neil.hickey updated the summary for this revision.
neil.hickey updated this revision to Diff 77975.
neil.hickey added a comment.
Fixing indentation and improvi
RKSimon added a comment.
Abandon this patch? We replaced the x86 vector non-temporal store builtins with
__builtin_nontemporal_store directly in the headers.
https://reviews.llvm.org/D20358
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
arphaman created this revision.
arphaman added reviewers: manmanren, mehdi_amini.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes an infinite loop that occurs when clang tries to iterate over
redeclaration of a method that was d
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/Checker.h:325
+ const CallEvent *Call,
+ const LocationContext *LCtx) {
+return ((const CHECKER *) checker)->checkRegionChanges(state, invalidated,
-
Author: mgorny
Date: Tue Nov 15 06:54:10 2016
New Revision: 286952
URL: http://llvm.org/viewvc/llvm-project?rev=286952&view=rev
Log:
[test] Correctly include build llvm_shlib_dir in stand-alone builds
Add the build llvm_shlib_dir into LD_LIBRARY_PATH before the directory
specified as llvm_libs_di
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286952: [test] Correctly include build llvm_shlib_dir in
stand-alone builds (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D26115?vs=76296&id=77982#toc
Repository:
rL LLVM
h
The reason these commits bring it up is that I don’t see it clearly documented
whether:
float x = 340282356779733661637539395458142568447.0;
is interpreted as
float x = 340282356779733661637539395458142568447.0f; // x is FLT_MAX
or as
float x = (float)(3402823567797336
Author: abataev
Date: Tue Nov 15 07:15:20 2016
New Revision: 286953
URL: http://llvm.org/viewvc/llvm-project?rev=286953&view=rev
Log:
[OPENMP] Fix for PR30632: Name mangling issue.
Reworked fix after comments from Richard Smith. We must skip all
CapturedDecl-based contexts when trying to get corr
ioeric added a comment.
Test comment.
Repository:
rL LLVM
https://reviews.llvm.org/D26592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
RKSimon added a comment.
Close this? It appears to have been committed, including the auto upgrade tests
requested by Craig.
https://reviews.llvm.org/D20359
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
SilverGeri updated this revision to Diff 77972.
SilverGeri added a comment.
update tests with "CHECK-FIXES-NOT" parts
https://reviews.llvm.org/D21298
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeleteNullPointerCheck.cpp
clang-tidy/readability/DeleteNullPointerChec
k-wisniewski added a comment.
Hi again!
Thanks for review! I'll upload updated version of this patch today in the
evening/tomorrow. As Anna suggested I'll split it into two parts - one
regarding extraction of argument SVals for StackFrameCtx and another one adding
LocationContext to check::Reg
ioeric added a comment.
Test comment to check if cfe-commits is in the email cc list
https://reviews.llvm.org/D26637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kbarton added a comment.
Did you upload a new patch? The diff doesn't appear to change for me.
Repository:
rL LLVM
https://reviews.llvm.org/D26546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
hokein added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:343
+ // FIXME(ioeric): this will change a base-class constructor initializer from
+ // "Base::Base(...)" to "ns::Base()", which compiles but is not perfect.
Finder->addMatcher(nestedNameSpecifier
kbarton added a comment.
There are several inline comments that need to be addressed.
I also think it's worthwhile putting a comment at the top of the review
indicating the (assumed) semantics for the vec_sube and vec_subec instructions
that are being implemented (i.e., the behaviour mimics the
Author: jtony
Date: Tue Nov 15 08:30:56 2016
New Revision: 286971
URL: http://llvm.org/viewvc/llvm-project?rev=286971&view=rev
Log:
[PowerPC] Implement BE VSX load/store builtins - clang portion.
This patch implements all the overloads for vec_xl_be and vec_xst_be. On BE,
they behaves exactly the
mclow.lists created this revision.
mclow.lists added a reviewer: rsmith.
mclow.lists added a subscriber: cfe-commits.
Last week, WG21 approved a paper (http://wg21.link/P0403) for allowing literal
suffixes for `string_view`. This means that should be able to write:
constexpr std::string_view s
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D26627
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
mclow.lists added a comment.
I'm working on this, too.
Trying to decide what the right choice is here.
https://reviews.llvm.org/D26623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joey created this revision.
joey added a subscriber: cfe-commits.
joey set the repository for this revision to rL LLVM.
Herald added a subscriber: yaxunl.
Use the semantic spelling (an enum) rather than a string, to determine what
access qualifier is used.
Repository:
rL LLVM
https://reviews
aaron.ballman added a comment.
Testcases?
https://reviews.llvm.org/D26667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malcolm.parsons added inline comments.
Comment at: lib/Lex/LiteralSupport.cpp:768
.Cases("il", "i", "if", true)
+ .Case("sv", true)
.Default(false);
This is in `NumericLiteralParser::isValidUDSuffix()`.
If a change is needed for `"sv"`, wouldn
mclow.lists added a comment.
We've been using a different pattern for this kind of tests (as we support more
and more noexcept cases). Something like this (for the second change):
template
void
test(const S& s, typename S::size_type pos, typename
Author: cameron314
Date: Tue Nov 15 09:07:07 2016
New Revision: 286973
URL: http://llvm.org/viewvc/llvm-project?rev=286973&view=rev
Log:
[clang-format] Fixed line merging of more than two lines
Differential Revision: https://reviews.llvm.org/D19063
Modified:
cfe/trunk/lib/Format/UnwrappedLin
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaType.cpp:1212
-static StringRef getImageAccessAttrStr(AttributeList *attrs) {
+static OpenCLAccessAttr::Spelling getImageAccessAttr(AttributeList *attrs) {
if (attrs) {
Since we're updating this,
mclow.lists added inline comments.
Comment at: lib/Lex/LiteralSupport.cpp:768
.Cases("il", "i", "if", true)
+ .Case("sv", true)
.Default(false);
malcolm.parsons wrote:
> This is in `NumericLiteralParser::isValidUDSuffix()`.
>
> If a change is
aaron.ballman added inline comments.
Comment at: lib/Lex/LiteralSupport.cpp:768
.Cases("il", "i", "if", true)
+ .Case("sv", true)
.Default(false);
mclow.lists wrote:
> malcolm.parsons wrote:
> > This is in `NumericLiteralParser::isValidUDSuffix
malcolm.parsons added inline comments.
Comment at: lib/Lex/LiteralSupport.cpp:768
.Cases("il", "i", "if", true)
+ .Case("sv", true)
.Default(false);
aaron.ballman wrote:
> mclow.lists wrote:
> > malcolm.parsons wrote:
> > > This is in `NumericL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286973: [clang-format] Fixed line merging of more than two
lines (authored by cameron314).
Changed prior to commit:
https://reviews.llvm.org/D19063?vs=53572&id=77996#toc
Repository:
rL LLVM
https://
aaron.ballman added inline comments.
Comment at: lib/Lex/LiteralSupport.cpp:768
.Cases("il", "i", "if", true)
+ .Case("sv", true)
.Default(false);
malcolm.parsons wrote:
> aaron.ballman wrote:
> > mclow.lists wrote:
> > > malcolm.parsons wrote:
arphaman created this revision.
arphaman added reviewers: rnk, rsmith.
arphaman added subscribers: cfe-commits, lhames.
arphaman set the repository for this revision to rL LLVM.
This patch avoids the -Wshadow warning for parameters that shadow fields of
their enclosing record and that are defined
mcrosier created this revision.
mcrosier added reviewers: rengolin, t.p.northover.
mcrosier added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
LLVM implementation here: https://reviews.llvm.org/D26673.
Chad
https://reviews.llvm.org/D26674
Files:
test/Driver/aarch64-cpus.c
arphaman updated this revision to Diff 78004.
arphaman added a comment.
The updated patch fixes a copy-pasted comment.
Repository:
rL LLVM
https://reviews.llvm.org/D26672
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
svenvh added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:3732
// If this is an implicit conversion from float -> double, remove it.
if (ImplicitCastExpr *Cast = dyn_cast(OrigArg)) {
The comment should mention float -> float now as well.
svenvh added a comment.
Thanks, lgtm!
https://reviews.llvm.org/D24235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: syzaara
Date: Tue Nov 15 09:57:33 2016
New Revision: 286977
URL: http://llvm.org/viewvc/llvm-project?rev=286977&view=rev
Log:
test commmit
Modified:
cfe/trunk/lib/Headers/altivec.h
Modified: cfe/trunk/lib/Headers/altivec.h
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Heade
arphaman updated this revision to Diff 78005.
arphaman added a comment.
Fixed an existing comment that now became partially invalid.
Repository:
rL LLVM
https://reviews.llvm.org/D26672
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
include/cla
aaron.ballman added a comment.
In https://reviews.llvm.org/D24289#592592, @mehdi_amini wrote:
> > So when this modification tells the developer to add 'unsigned' to their
> > enum, they are subsequently causing a warning to occur in GCC.
> >
> > I have commented on the bug on GCC for this
> >
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/RedundantMemberInitCheck.cpp:57
"initializer for base class %0 is redundant")
- << Init->getTypeSourceInfo()->getType()
+ << Construct->getType()
<< FixItHint::CreateR
hxy9243 added a comment.
Ping. @mclow.lists, @EricWF, any ideas on this patch?
Thanks very much!
https://reviews.llvm.org/D24991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 updated this revision to Diff 78012.
rogfer01 added a comment.
Restructure to minimize code duplication.
https://reviews.llvm.org/D26612
Files:
test/std/strings/basic.string/string.capacity/capacity.pass.cpp
test/std/strings/basic.string/string.ops/string_substr/substr.pass.cpp
I
malcolm.parsons added inline comments.
Comment at: clang-tidy/readability/RedundantMemberInitCheck.cpp:57
"initializer for base class %0 is redundant")
- << Init->getTypeSourceInfo()->getType()
+ << Construct->getType()
<< FixItHint::Creat
a.sidorin added a comment.
@spyffe : It seems to be OK.
Repository:
rL LLVM
https://reviews.llvm.org/D26571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: stl_msft
Date: Tue Nov 15 11:00:24 2016
New Revision: 286982
URL: http://llvm.org/viewvc/llvm-project?rev=286982&view=rev
Log:
[libcxx] [test] D26624: Fix bucket_count() assumptions.
With a max_load_factor of 1.0, the only guarantee is that
bucket_count() >= size(). (Note: setting max_loa
Author: stl_msft
Date: Tue Nov 15 11:00:32 2016
New Revision: 286983
URL: http://llvm.org/viewvc/llvm-project?rev=286983&view=rev
Log:
[libcxx] [test] D26625: future_error::what() is implementation-defined.
Modified:
libcxx/trunk/test/std/thread/futures/futures.future_error/what.pass.cpp
Mod
Author: stl_msft
Date: Tue Nov 15 11:00:38 2016
New Revision: 286984
URL: http://llvm.org/viewvc/llvm-project?rev=286984&view=rev
Log:
[libcxx] [test] D26627: Fix ordering assumptions in unordered container tests.
Modified:
libcxx/trunk/test/std/containers/unord/unord.multimap/unord.multimap
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM, thks.
(See one inline comment to fix though)
Comment at: lib/AST/DeclObjC.cpp:841
+return nullptr;
+ if (const auto *Ctx = cast(Redecl->getDeclContext())
STL_MSFT closed this revision.
STL_MSFT added a comment.
r286983, thanks.
https://reviews.llvm.org/D26625
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
r286984, thanks.
https://reviews.llvm.org/D26627
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added inline comments.
Comment at: lib/AST/DeclObjC.cpp:841
+return nullptr;
+ if (const auto *Ctx = cast(Redecl->getDeclContext()))
+if (Ctx->isInvalidDecl())
mehdi_amini wrote:
> Either you should use `dyn_cast`, or you should just `cast` but
STL_MSFT closed this revision.
STL_MSFT added a comment.
r286982, thanks.
https://reviews.llvm.org/D26624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: clang-tidy/readability/RedundantMemberInitCheck.cpp:57
"initializer for base class %0 is redundant")
- << Init->getTypeSo
joey updated this revision to Diff 78017.
joey added a comment.
Fixed a latent infinite loop bug in 'getImageAccess', it was dereferencing
Attrs, instead of Next.
Repository:
rL LLVM
https://reviews.llvm.org/D26668
Files:
lib/Sema/SemaType.cpp
test/SemaOpenCL/access-qualifier.cl
test/
joey marked an inline comment as done.
joey added inline comments.
Comment at: lib/Sema/SemaType.cpp:1224
}
- return "";
+ return OpenCLAccessAttr::Keyword_read_only;
}
aaron.ballman wrote:
> The caller can no longer tell the difference between a real-only
iid_iunknown updated this revision to Diff 78019.
iid_iunknown added a comment.
Tests added.
Repository:
rL LLVM
https://reviews.llvm.org/D26464
Files:
lib/Sema/SemaChecking.cpp
test/Sema/aarch64-special-register.c
test/Sema/arm-special-register.c
Index: test/Sema/arm-special-register
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, with one minor nit.
Comment at: lib/Sema/SemaType.cpp:1629
+ Result = Context.Id##ROTy; break; \
+default: assert(0 && "Unknown access attribute!
iid_iunknown updated this revision to Diff 78021.
iid_iunknown added a comment.
Tests extended to check for more corner cases.
Repository:
rL LLVM
https://reviews.llvm.org/D26464
Files:
lib/Sema/SemaChecking.cpp
test/Sema/aarch64-special-register.c
test/Sema/arm-special-register.c
Ind
iid_iunknown added a comment.
In https://reviews.llvm.org/D26464#594228, @rengolin wrote:
> Looks like an oversight. Aren't there any tests for this? Maybe there should
> be one.
Thanks Renato!
I updated the tests to check the upper bounds for CRn/CRm/Op.
Repository:
rL LLVM
https://revie
erik.pilkington added inline comments.
Comment at: lib/AST/DeclObjC.cpp:841
+return nullptr;
+ if (const auto *Ctx = cast(Redecl->getDeclContext()))
+if (Ctx->isInvalidDecl())
arphaman wrote:
> mehdi_amini wrote:
> > Either you should use `dyn_cast`, or
Author: malcolm.parsons
Date: Tue Nov 15 11:49:00 2016
New Revision: 286990
URL: http://llvm.org/viewvc/llvm-project?rev=286990&view=rev
Log:
[clang-tidy] Change readability-redundant-member-init to get base type from
constructor
Summary: Fixes PR30835
Reviewers: alexfh, hokein, aaron.ballman
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286990: [clang-tidy] Change
readability-redundant-member-init to get base type from… (authored by
malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26118?vs=76797&id=78024#toc
Repos
aaron.ballman added a comment.
In https://reviews.llvm.org/D26540#593433, @phosek wrote:
> That makes sense for diagnostics, but this attribute is only an optimization
> hint, so compiler should be allowed to ignore it. I can take a look how
> difficult it'd be to actually implement this attrib
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
This looks awesome! Since it depends on your other outstanding patches can you
hold off committing until those land?
Repository:
rL LLVM
https://reviews.llvm.org/D26654
__
aaron.ballman added inline comments.
Comment at: test/clang-tidy/modernize-use-default.cpp:142
+// CHECK-MESSAGES: :[[@LINE-2]]:1: warning: use '= default'
+// CHECK-FIXES: TempODef::~TempODef() = default;
+
Would it be better if the `= default` were on the inlin
arphaman added inline comments.
Comment at: lib/AST/DeclObjC.cpp:841
+return nullptr;
+ if (const auto *Ctx = cast(Redecl->getDeclContext()))
+if (Ctx->isInvalidDecl())
erik.pilkington wrote:
> arphaman wrote:
> > mehdi_amini wrote:
> > > Either you shou
beanz accepted this revision.
beanz added a comment.
LGTM! Thanks for doing this Sean!
Repository:
rL LLVM
https://reviews.llvm.org/D26571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
On Fri, Oct 14, 2016 at 1:17 PM, Joshua Hurwitz via cfe-commits
wrote:
> See attached.
>
> Returning a bool from main is a special case of return type mismatch. The
> common convention when returning a bool is that 'true' (== 1) indicates
> success and 'false' (== 0) failure. But since main expect
Author: syzaara
Date: Tue Nov 15 12:04:13 2016
New Revision: 286994
URL: http://llvm.org/viewvc/llvm-project?rev=286994&view=rev
Log:
vector load store with length (left justified) clang portion
Modified:
cfe/trunk/include/clang/Basic/BuiltinsPPC.def
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
beanz added a comment.
On Darwin you don't want to set `DARWIN_LTO_LIBRARY` on the next stage if
you're intending the next stage to use lld because that sets flags that aren't
supported by lld.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
__
mehdi_amini added a comment.
In https://reviews.llvm.org/D26649#596024, @beanz wrote:
> On Darwin you don't want to set `DARWIN_LTO_LIBRARY` on the next stage if
> you're intending the next stage to use lld because that sets flags that
> aren't supported by lld.
Right, but that's a separate i
EricWF accepted this revision.
EricWF added inline comments.
This revision is now accepted and ready to land.
Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp:17
+// true constexpr-ness.
+
+#include
Does GCC offer these as contexpr? If not t
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
Patch LGTM right now, let's just wait for @beanz in case he objects.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
___
cfe-com
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5348
S.Diag(LiteralLoc, diag::warn_unknown_sanitizer_ignored) <<
SanitizerName;
-else if (isGlobalVar(D) && SanitizerName != "address")
+else if (isGlobalVar(D) && SanitizerName != "address
Author: rksimon
Date: Tue Nov 15 12:28:07 2016
New Revision: 286996
URL: http://llvm.org/viewvc/llvm-project?rev=286996&view=rev
Log:
Fixed spelling in comments. NFCI.
Modified:
cfe/trunk/include/clang/AST/DeclObjC.h
cfe/trunk/include/clang/Basic/TargetInfo.h
cfe/trunk/lib/Sema/SemaEx
malcolm.parsons added inline comments.
Comment at: test/clang-tidy/modernize-use-default.cpp:142
+// CHECK-MESSAGES: :[[@LINE-2]]:1: warning: use '= default'
+// CHECK-FIXES: TempODef::~TempODef() = default;
+
aaron.ballman wrote:
> Would it be better if the `= d
jlebar added a comment.
Thanks for the review.
Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp:17
+// true constexpr-ness.
+
+#include
EricWF wrote:
> Does GCC offer these as contexpr? If not this needs a `// XFAIL: gcc`
Looks like the re
Author: dcoughlin
Date: Tue Nov 15 12:40:46 2016
New Revision: 287001
URL: http://llvm.org/viewvc/llvm-project?rev=287001&view=rev
Log:
[analyzer] Add check for when block is called with too few arguments.
The CallAndMessageChecker has an existing check for when a function pointer
is called with
compnerd added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7669
+// Fix a TSK_ExplicitInstantiationDeclaration or a
TSK_ImplicitInstantiation
+// followed by a TSK_ExplicitInstantiationDefinition
+if ((Old_TSK == TSK_ExplicitInstantiationDeclaration ||
---
Author: vedantk
Date: Tue Nov 15 12:48:36 2016
New Revision: 287004
URL: http://llvm.org/viewvc/llvm-project?rev=287004&view=rev
Log:
Revert "P0503R0, adopted in Issaquah, rewords some requirements on nullptr_t
and istream_iterator. No code changes were needed, but I updated a few tests.
Also r
EricWF added inline comments.
Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp:22
+
+#ifndef _LIBCPP_VERSION
+#error _LIBCPP_VERSION not defined
jlebar wrote:
> EricWF wrote:
> > You don't need this `_LIBCPP_VERSION` check here.
> Hm, there a
EricWF added inline comments.
Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp:17
+// true constexpr-ness.
+
+#include
jlebar wrote:
> EricWF wrote:
> > Does GCC offer these as contexpr? If not this needs a `// XFAIL: gcc`
> Looks like the r
Author: d0k
Date: Tue Nov 15 12:56:39 2016
New Revision: 287005
URL: http://llvm.org/viewvc/llvm-project?rev=287005&view=rev
Log:
[Modules] Replace arrays with init lists.
Thi way the compiler can pick the optimal storage duration. It's also
more readable. No functional change intended.
Modified
RKSimon created this revision.
RKSimon added reviewers: craig.topper, igorb, delena.
RKSimon added a subscriber: cfe-commits.
RKSimon set the repository for this revision to rL LLVM.
Both the (V)CVTDQ2PD (i32 to f64) and (V)CVTDQ2PD (u32 to f64) conversion
instructions are lossless and can be saf
Author: ioeric
Date: Tue Nov 15 13:05:40 2016
New Revision: 287008
URL: http://llvm.org/viewvc/llvm-project?rev=287008&view=rev
Log:
Add comments on how to print error retuned by tooling::Replacements::add().
Modified:
cfe/trunk/include/clang/Tooling/Core/Replacement.h
Modified: cfe/trunk/in
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:89
+diag(FuncInst->getLocStart(), Messag
Author: rampitec
Date: Tue Nov 15 12:58:03 2016
New Revision: 287006
URL: http://llvm.org/viewvc/llvm-project?rev=287006&view=rev
Log:
[AMDGPU] Add wave barrier builtin
The wave barrier represents the discardable barrier. Its main purpose is to
carry convergent attribute, thus preventing illegal
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: test/clang-tidy/modernize-use-default.cpp:142
+// CHECK-MESSAGES: :[[@LINE-2]]:1: warning: use '= default'
+// CHECK-FIXES: TempODef::~TempODe
mclow.lists added inline comments.
Comment at: lib/Lex/LiteralSupport.cpp:768
.Cases("il", "i", "if", true)
+ .Case("sv", true)
.Default(false);
aaron.ballman wrote:
> malcolm.parsons wrote:
> > aaron.ballman wrote:
> > > mclow.lists wrote:
> >
aaron.ballman added inline comments.
Comment at: lib/Lex/LiteralSupport.cpp:768
.Cases("il", "i", "if", true)
+ .Case("sv", true)
.Default(false);
mclow.lists wrote:
> aaron.ballman wrote:
> > malcolm.parsons wrote:
> > > aaron.ballman wrote:
>
benlangmuir added a comment.
I'm inclined to suggest we break that behaviour with modules and treat a user
module the same no matter where it was imported. @rsmith, what do you think?
https://reviews.llvm.org/D25916
___
cfe-commits mailing list
c
jlebar marked 6 inline comments as done.
jlebar added a comment.
Capturing an IRC conversation:
> **EricWF** jlebar: Did you test this patch with older Clangs w/o constexpr
> builtins?
> **jlebar** EricWF, Do you mean, did I test the test, or did I test that the
> non-test change does what I n
Author: jlebar
Date: Tue Nov 15 13:15:57 2016
New Revision: 287012
URL: http://llvm.org/viewvc/llvm-project?rev=287012&view=rev
Log:
[CUDA] Mark __libcpp_{isnan,isinf,isfinite} as constexpr.
Summary:
This makes these functions available on host and device, which is
necessary to compile for the d
1 - 100 of 173 matches
Mail list logo
