mgorny added a comment.
@sepavloff, my suggestion would be to rework the patch to the minimal,
acceptable feature (i.e. executable-relative config), and then possibly send
more patches for the additional features that require additional discussion.
This way, we'll at least get something done in
mgorny added reviewers: ddunbar, thakis.
mgorny added a comment.
Ping.
https://reviews.llvm.org/D24921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added reviewers: phosek, mclow.lists.
mgorny added a comment.
Ping.
https://reviews.llvm.org/D25314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
Ping.
https://reviews.llvm.org/D25686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added reviewers: rnk, hfinkel.
mgorny added a comment.
Ping.
https://reviews.llvm.org/D25949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
Ping.
https://reviews.llvm.org/D26115
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
neil.hickey updated this revision to Diff 77600.
neil.hickey added a comment.
Improving now confusing comment.
https://reviews.llvm.org/D24235
Files:
lib/Sema/SemaExpr.cpp
lib/Sema/SemaType.cpp
test/CodeGenOpenCL/fpmath.cl
test/SemaOpenCL/extensions.cl
Index: test/SemaOpenCL/extensions
I think you can go ahead and commit it, yes.
Alex
On 11 November 2016 at 05:28, Serge Pavlov wrote:
> Is it OK to commit this patch?
>
> Thanks,
> --Serge
>
> 2016-10-21 18:21 GMT+07:00 Alex Lorenz :
>
>> arphaman added a subscriber: rsmith.
>> arphaman added a comment.
>>
>> LGTM, I added Rich
Author: abataev
Date: Fri Nov 11 06:36:20 2016
New Revision: 286584
URL: http://llvm.org/viewvc/llvm-project?rev=286584&view=rev
Log:
Fix for PR28523: unexpected compilation error.
Clang emits error message for the following code:
```
template void parallel_loop(F &&f) { f(0); }
int main() {
amehsan created this revision.
amehsan added reviewers: kbarton, nemanjai, sfertile, jtony, hfinkel, syzaara,
lei.
amehsan added subscribers: cfe-commits, echristo.
This includes various overloads of the following builtins:
- vec_neg
- vec_nabs
- vec_adde
- vec_addec
- vec_sube
- vec_subec
- vec
rSerge marked an inline comment as done.
rSerge added inline comments.
Comment at: lib/Driver/Tools.cpp:4903-4906
+if (Triple.getOS() != llvm::Triple::Linux)
+ D.Diag(diag::err_drv_clang_unsupported)
+ << (std::string(XRayInstrumentOption) + " on non-Linux targe
Hmm, right now there is no way to use alpha checks in clang tidy?
Piotr
On Nov 10, 2016 10:57, "Malcolm Parsons via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> On 9 November 2016 at 18:50, Devin Coughlin wrote:
>
> > We agree that this is a valuable checker and are committed to getting i
svenvh accepted this revision.
svenvh added a comment.
LGTM!
https://reviews.llvm.org/D24235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rksimon
Date: Fri Nov 11 08:38:34 2016
New Revision: 286595
URL: http://llvm.org/viewvc/llvm-project?rev=286595&view=rev
Log:
[X86] Merge (near) duplicate scalar non-temporal store code. NFCI.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
sfertile created this revision.
sfertile added reviewers: amehsan, kbarton, nemanjai, jtony, syzaara, lei.
sfertile added subscribers: cfe-commits, echristo.
sfertile set the repository for this revision to rL LLVM.
Add macros that implement the vec_extract4b and vec_insert4b functionality.
vecto
yaxunl added a comment.
Hi John,
It seems the casting from a pointer to different address space is not affected
by this change. When a null pointer is casted to different address space, it is
casted the same way as an ordinary pointer, e.g. by addrspacecast.
I think this patch covers most of t
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
There are a *lot* of attributes GCC supports that Clang does not, and we
generally do not silence diagnostics with them as that usually does the user a
disservice because they are unaware that the attribute has no effe
aaron.ballman added a comment.
In https://reviews.llvm.org/D26511#592670, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D26511#592665, @Prazek wrote:
>
> > It is introduced because of "modernize-use-delete" was too ambiguous
> > because of operator delete, so it was changed to
> > "mode
malcolm.parsons updated this revision to Diff 77615.
malcolm.parsons added a comment.
Fix sorting.
Mention in release notes.
https://reviews.llvm.org/D26511
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseDefaultCheck.cpp
c
thakis added a comment.
(Maybe implementing real support isn't so difficult? From a quick glance, it
sounds like this is a sema-only attribute?)
Repository:
rL LLVM
https://reviews.llvm.org/D26540
___
cfe-commits mailing list
cfe-commits@lists.l
yaxunl added a comment.
My main concern is that by making the number of event be of type size_t instead
of uint we are not conforming to the spec, although I agree it is better for
the user.
Comment at: lib/CodeGen/CGBuiltin.cpp:2547
+ llvm::Value *NumEvents =
+
rogfer01 added a comment.
I'd rather not to go the way of `TEST_TRY` and `TEST_CASE` macros.
As suggested by @rmaprath, I've been playing with grouping the tests in three
categories: no exceptions (at all), should not throw, must throw. No changes
are required for the first group. The third gro
syzaara updated this revision to Diff 77618.
syzaara added a comment.
Guard for 64-bit mode.
https://reviews.llvm.org/D26304
Files:
include/clang/Basic/BuiltinsPPC.def
lib/CodeGen/CGBuiltin.cpp
lib/Headers/altivec.h
test/CodeGen/builtins-ppc-p9vector.c
Index: test/CodeGen/builtins-ppc-
sfertile added a comment.
Comment at: include/clang/Basic/BuiltinsPPC.def:385-388
+BUILTIN(__builtin_altivec_vrlwmi, "V4UiV4UiV4UiV4Ui", "")
+BUILTIN(__builtin_altivec_vrldmi, "V2ULLiV2ULLiV2ULLiV2ULLi", "")
+BUILTIN(__builtin_altivec_vrlwnm, "V4UiV4UiV4Ui", "")
+BUILTIN(__bui
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D26507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
arphaman added inline comments.
Comment at: clang/test/CodeGen/block-with-perdefinedexpr.cpp:66
+};
+ }
+};
I think you should maybe add/change one of the tests to be a block inside of a
lambda.
https://reviews.llvm.org/D26522
_
arphaman added inline comments.
Comment at: clang/lib/AST/Expr.cpp:531
+llvm::raw_svector_ostream Out(Buffer);
+if (auto *DCFunc = dyn_cast(DC)) {
+ Out << ComputeName(IT, DCFunc);
I think it's possible to avoid the braces by simplifying down to some
Author: dougk
Date: Fri Nov 11 10:51:40 2016
New Revision: 286599
URL: http://llvm.org/viewvc/llvm-project?rev=286599&view=rev
Log:
Fix mismatched enum value name and diagnostic text.
ExpectedFunctionGlobalVarMethodOrProperty
would previously say "functions and global variables"
instead of "funct
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286599: Fix mismatched enum value name and diagnostic text.
(authored by dougk).
Changed prior to commit:
https://reviews.llvm.org/D26459?vs=77367&id=77624#toc
Repository:
rL LLVM
https://reviews.ll
flx added a comment.
In https://reviews.llvm.org/D26453#590720, @malcolm.parsons wrote:
> Add ValuesOnly option to modernize-pass-by-value.
Thanks for doing this. Alex, would this work for us?
https://reviews.llvm.org/D26453
___
cfe-commits maili
Ping.
> On Nov 2, 2016, at 9:18 AM, Adrian Prantl wrote:
>
> Ping?
>
>> On Oct 31, 2016, at 12:41 PM, Adrian Prantl via cfe-commits
>> mailto:cfe-commits@lists.llvm.org>> wrote:
>>
>>>
>>> On Oct 31, 2016, at 12:09 PM, Victor Leschuk via cfe-commits
>>> mailto:cfe-commits@lists.llvm.org>> w
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
I agree with Keith. This is a starting point, not a final destination.
As we evolve this, we can start looking at better ways to improve the debug
illusion, but right now, `O1` is probably
Author: sylvestre
Date: Fri Nov 11 11:29:56 2016
New Revision: 286602
URL: http://llvm.org/viewvc/llvm-project?rev=286602&view=rev
Log:
Add a new optimization option -Og
Summary:
Just like gcc, we should have the -Og option as more and more software are
using it:
https://llvm.org/bugs/show_bug.
alekseyshl updated this revision to Diff 77631.
alekseyshl added a comment.
- Translate new driver flags to legacy -llvm ones.
https://reviews.llvm.org/D26461
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
include/clang/Frontend/CodeGenOptions.def
lib/Driver
arsenm added inline comments.
Comment at: test/CodeGenOpenCL/builtins-amdgcn-error-f16-class.cl:1-9
+// REQUIRES: amdgpu-registered-target
+// RUN: %clang_cc1 -triple amdgcn-unknown-amdhsa -target-cpu tahiti -verify -S
-o - %s
+
+#pragma OPENCL EXTENSION cl_khr_fp16 : enable
+
+
kzhuravl added inline comments.
Comment at: test/CodeGenOpenCL/builtins-amdgcn-error-f16-class.cl:1-9
+// REQUIRES: amdgpu-registered-target
+// RUN: %clang_cc1 -triple amdgcn-unknown-amdhsa -target-cpu tahiti -verify -S
-o - %s
+
+#pragma OPENCL EXTENSION cl_khr_fp16 : enable
+
arsenm added inline comments.
Comment at: test/CodeGenOpenCL/builtins-amdgcn-error-f16-class.cl:1-9
+// REQUIRES: amdgpu-registered-target
+// RUN: %clang_cc1 -triple amdgcn-unknown-amdhsa -target-cpu tahiti -verify -S
-o - %s
+
+#pragma OPENCL EXTENSION cl_khr_fp16 : enable
+
+
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I think this patch is good to land, but if you have time i'd suggest to
investigate this a little bit deeper in order to squash even more bugs.
My concern is that we've never implemented reading fro
yaxunl added inline comments.
Comment at: test/CodeGenOpenCL/builtins-amdgcn-error-f16-div-fixup.cl:8
+{
+ *out = __builtin_amdgcn_div_fixuph(a, b, c); // expected-error
{{'__builtin_amdgcn_div_fixuph' needs target feature 16-bit-insts}}
+}
The tests for checki
kzhuravl updated this revision to Diff 77633.
kzhuravl marked 4 inline comments as done.
kzhuravl added a comment.
Address review feedback: put tests in the same file, update run line, move
error tests to SemaOpenCL directory
https://reviews.llvm.org/D26476
Files:
include/clang/Basic/Builtin
kzhuravl updated this revision to Diff 77634.
kzhuravl added a comment.
Also update run line to exclude `amdhsa` from another error file.
https://reviews.llvm.org/D26476
Files:
include/clang/Basic/BuiltinsAMDGPU.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGenOpenCL/builtins-amdgcn-error.cl
t
Anastasia added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:2547
+ llvm::Value *NumEvents =
+ Builder.CreateZExtOrTrunc(EmitScalarExpr(E->getArg(3)), Int32Ty);
llvm::Value *EventList =
yaxunl wrote:
> should Int32Ty be SizeTy?
I am
pcc accepted this revision.
pcc added a reviewer: pcc.
pcc added a comment.
Seems like a reasonable enough first step. Please add a FIXME to pass these
flags as attributes.
https://reviews.llvm.org/D26461
___
cfe-commits mailing list
cfe-commits@li
Author: eugenis
Date: Fri Nov 11 12:49:49 2016
New Revision: 286613
URL: http://llvm.org/viewvc/llvm-project?rev=286613&view=rev
Log:
[cfi] Enable cfi-icall on ARM and AArch64.
Modified:
cfe/trunk/lib/Driver/ToolChain.cpp
cfe/trunk/test/Driver/fsanitize.c
Modified: cfe/trunk/lib/Driver/T
malcolm.parsons accepted this revision.
malcolm.parsons added a reviewer: malcolm.parsons.
malcolm.parsons added a comment.
This revision is now accepted and ready to land.
Your email went in my spam folder.
LGTM.
Will commit later.
https://reviews.llvm.org/D26435
Author: phosek
Date: Fri Nov 11 13:12:58 2016
New Revision: 286614
URL: http://llvm.org/viewvc/llvm-project?rev=286614&view=rev
Log:
[CMake] Check runtimes subdir when looking for libcxx and libuwind
The runtimes subdir is the new location for runtimes, we should
include it when looking for libcx
eugenis added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:732
Args.hasArg(OPT_fsanitize_coverage_trace_pc_guard);
+ Opts.SanitizeThreadMemoryAccess =
+ Args.hasFlag(OPT_fsanitize_thread_memory_access,
It looks like lib/Frontend c
Author: pcc
Date: Fri Nov 11 13:50:39 2016
New Revision: 286624
URL: http://llvm.org/viewvc/llvm-project?rev=286624&view=rev
Log:
Bitcode: Change getModuleSummaryIndex() to return an llvm::Expected.
Differential Revision: https://reviews.llvm.org/D26539
Modified:
cfe/trunk/lib/CodeGen/Backen
alekseyshl marked an inline comment as done.
alekseyshl added a comment.
Frontend options removed.
https://reviews.llvm.org/D26461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alekseyshl updated this revision to Diff 77647.
alekseyshl added a comment.
- Remove unnecessary frontend options.
https://reviews.llvm.org/D26461
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
lib/Driver/SanitizerArgs.cpp
test/Driver/fsanitize.c
Index: tes
eugenis accepted this revision.
eugenis added a comment.
LGTM
https://reviews.llvm.org/D26461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nemanjai
Date: Fri Nov 11 13:56:17 2016
New Revision: 286627
URL: http://llvm.org/viewvc/llvm-project?rev=286627&view=rev
Log:
[PowerPC] Add vector conversion builtins to altivec.h - clang portion
This patch corresponds to review:
https://reviews.llvm.org/D26308
It adds a number of vecto
pcc added inline comments.
Comment at: include/clang/Driver/Options.td:732
+def fsanitize_thread_memory_access : Flag<["-"],
"fsanitize-thread-memory-access">,
+ Group, Flags<[CC1Option]>,
+ HelpText<"Enable
alekseyshl updated this revision to Diff 77649.
alekseyshl added a comment.
- Add FIXME to address the rest of the suggestions later.
https://reviews.llvm.org/D26461
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
lib/Driver/SanitizerArgs.cpp
test/Driver/fsan
yaxunl added a comment.
I thought the number of events was also changed to size_t type. Now I
understand. Probably I was misled by the summary:
"Parameters representing number of events as well as sizes of enqueued block
arguments in enqueue_kernel function are specified as uint type. This prev
nemanjai closed this revision.
nemanjai added a comment.
Committed revision 286627.
Repository:
rL LLVM
https://reviews.llvm.org/D26308
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: dergachev
Date: Fri Nov 11 14:29:59 2016
New Revision: 286628
URL: http://llvm.org/viewvc/llvm-project?rev=286628&view=rev
Log:
[ASTMatchers] Fix a typo in cStyleCastExpr() docs. NFC.
Modified:
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Modified: cfe/trunk/include/clang/ASTMat
kzhuravl updated this revision to Diff 77654.
kzhuravl added a comment.
Leave the return type of `frexp_exph` unchanged
https://reviews.llvm.org/D26476
Files:
include/clang/Basic/BuiltinsAMDGPU.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGenOpenCL/builtins-amdgcn-error.cl
test/CodeGenOpenCL/
dougk updated this revision to Diff 77658.
dougk marked 2 inline comments as done.
dougk added a comment.
changes per Aaron Ballman
https://reviews.llvm.org/D26454
Files:
lib/CodeGen/SanitizerMetadata.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGen/asan-globals.cpp
test/SemaCXX/attr-no-sanit
Author: rtrieu
Date: Fri Nov 11 14:51:04 2016
New Revision: 286630
URL: http://llvm.org/viewvc/llvm-project?rev=286630&view=rev
Log:
When a DecompositionDecl is marked invalid, also set the child BindingDecl's to
invalid.
Modified:
cfe/trunk/lib/AST/DeclBase.cpp
cfe/trunk/test/SemaCXX/cxx
Thanks. We have some code in SemaDecl(CXX?) that was trying to do the same
thing; can it be removed now?
On 11 Nov 2016 1:00 pm, "Richard Trieu via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: rtrieu
> Date: Fri Nov 11 14:51:04 2016
> New Revision: 286630
>
> URL: http://llvm.org/v
I didn't see anything when making this patch, but I will go take a closer
look now.
On Fri, Nov 11, 2016 at 1:19 PM, Richard Smith
wrote:
> Thanks. We have some code in SemaDecl(CXX?) that was trying to do the same
> thing; can it be removed now?
>
> On 11 Nov 2016 1:00 pm, "Richard Trieu via cf
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26519
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: dcoughlin
Date: Fri Nov 11 15:31:38 2016
New Revision: 286633
URL: http://llvm.org/viewvc/llvm-project?rev=286633&view=rev
Log:
[analyzer] Teach RetainCountChecker about VTCompressionSessionEncodeFrame()
The context argument passed to VideoToolbox's
VTCompressionSessionEncodeFrame() funct
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: tstellar
Date: Fri Nov 11 15:34:47 2016
New Revision: 286634
URL: http://llvm.org/viewvc/llvm-project?rev=286634&view=rev
Log:
Fix build since llvm r286566 and require at least llvm 4.0
Modified:
libclc/trunk/configure.py
libclc/trunk/utils/prepare-builtins.cpp
Modified: libclc/t
kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D26534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Sema::FinalizeDeclaration contains the code I was thinking about.
On Fri, Nov 11, 2016 at 1:33 PM, Richard Trieu wrote:
> I didn't see anything when making this patch, but I will go take a closer
> look now.
>
>
> On Fri, Nov 11, 2016 at 1:19 PM, Richard Smith
> wrote:
>
>> Thanks. We have som
nemanjai added inline comments.
Comment at: include/clang/Basic/BuiltinsPPC.def:385-388
+BUILTIN(__builtin_altivec_vrlwmi, "V4UiV4UiV4UiV4Ui", "")
+BUILTIN(__builtin_altivec_vrldmi, "V2ULLiV2ULLiV2ULLiV2ULLi", "")
+BUILTIN(__builtin_altivec_vrlwnm, "V4UiV4UiV4Ui", "")
+BUILTIN(__
alekseyshl updated this revision to Diff 77667.
alekseyshl added a comment.
- Remove unnecessary flag qualifications.
https://reviews.llvm.org/D26461
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
lib/Driver/SanitizerArgs.cpp
test/Driver/fsanitize.c
Index:
alekseyshl marked an inline comment as done.
alekseyshl added a comment.
.
https://reviews.llvm.org/D26461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rtrieu
Date: Fri Nov 11 15:50:39 2016
New Revision: 286641
URL: http://llvm.org/viewvc/llvm-project?rev=286641&view=rev
Log:
Remove double setting of invalid flag.
In r286630, Decl::setInvalidDecl will automatically set the invalid flag for
BindingDecl for children in invalid Decompositio
That's the only one I found. Fixed in r286641.
On Fri, Nov 11, 2016 at 1:46 PM, Richard Smith
wrote:
> Sema::FinalizeDeclaration contains the code I was thinking about.
>
>
> On Fri, Nov 11, 2016 at 1:33 PM, Richard Trieu wrote:
>
>> I didn't see anything when making this patch, but I will go
alekseyshl added a comment.
PTAL
https://reviews.llvm.org/D26461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.burgess.iv updated this revision to Diff 77669.
george.burgess.iv marked an inline comment as done.
george.burgess.iv added a comment.
Thanks for the review!
I'll submit this with https://reviews.llvm.org/D14274. :)
https://reviews.llvm.org/D26410
Files:
lib/CodeGen/CGBlocks.cpp
lib
joerg created this revision.
joerg added a reviewer: hfinkel.
joerg added a subscriber: cfe-commits.
Herald added a subscriber: nemanjai.
Most of the PowerPC64 code generation already creates PIC access. This changes
to a full PIC default, similar to what GCC is doing.
Overall, a monolithic clan
On 11 November 2016 at 20:29, Artem Dergachev via cfe-commits
wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=286628&view=rev
> Log:
> [ASTMatchers] Fix a typo in cStyleCastExpr() docs. NFC.
>
> Modified:
> cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Please change docs/LibASTMatch
Author: nemanjai
Date: Fri Nov 11 16:34:44 2016
New Revision: 286650
URL: http://llvm.org/viewvc/llvm-project?rev=286650&view=rev
Log:
[PowerPC] Implement remaining permute builtins in altivec.h - Clang portion
This patch corresponds to review:
https://reviews.llvm.org/D26479
It adds the remaini
nemanjai closed this revision.
nemanjai added a comment.
Committed revision 286650.
Repository:
rL LLVM
https://reviews.llvm.org/D26479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: dergachev
Date: Fri Nov 11 16:34:53 2016
New Revision: 286651
URL: http://llvm.org/viewvc/llvm-project?rev=286651&view=rev
Log:
[ASTMatchers] Fix a typo in cStyleCastExpr() HTML docs as well. NFC.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Modified: cfe/trunk/docs/LibASTMa
hfinkel added a comment.
@wschmidt and other IBM folks, w.r.t. this and https://reviews.llvm.org/D26566,
can you please comment on what GCC does here? Does GCC use -fPIC by default for
PPC64 (literally or in effect)?
https://reviews.llvm.org/D26564
__
rSerge updated this revision to Diff 77675.
https://reviews.llvm.org/D26415
Files:
lib/Driver/Tools.cpp
test/Driver/XRay/xray-instrument-cpu.c
test/Driver/XRay/xray-instrument-os.c
Index: test/Driver/XRay/xray-instrument-os.c
===
Ouch, thanks! r286651.
On 11/11/16 2:31 PM, Malcolm Parsons wrote:
On 11 November 2016 at 20:29, Artem Dergachev via cfe-commits
wrote:
URL: http://llvm.org/viewvc/llvm-project?rev=286628&view=rev
Log:
[ASTMatchers] Fix a typo in cStyleCastExpr() docs. NFC.
Modified:
cfe/trunk/include/c
rSerge added inline comments.
Comment at: lib/Driver/Tools.cpp:4903-4906
+if (Triple.getOS() != llvm::Triple::Linux)
+ D.Diag(diag::err_drv_clang_unsupported)
+ << (std::string(XRayInstrumentOption) + " on non-Linux target OS.");
+switch (Triple.getArch()) {
pcc added a comment.
Test case?
Comment at: lib/CodeGen/CGExprCXX.cpp:93
+
+ EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+CallLoc, This, C.getRecordType(DD->getParent()));
Is it correct to emit a type check at this point? Looking at [0] it l
Author: rsmith
Date: Fri Nov 11 16:48:43 2016
New Revision: 286660
URL: http://llvm.org/viewvc/llvm-project?rev=286660&view=rev
Log:
[cxx_status] Prepare features list for WG21 motions.
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://llvm.org/view
krasin added a comment.
All UBSan test cases happen to live in compiler-rt. I have added a couple of
test cases in https://reviews.llvm.org/D26560.
Also, I am not against adding Clang counterparts for them which would test IL
instead of the output from running. But it probably deserves a separa
krasin added a comment.
Small correction: all UBSan type checks tests live in compiler-rt. There is a
test for UBsan + devirtualization inside tools/clang. My point still stands.
https://reviews.llvm.org/D26559
___
cfe-commits mailing list
cfe-comm
pcc added a comment.
We normally update the IR tests whenever we change IRgen. If we're missing test
coverage, we should add it before landing this.
https://reviews.llvm.org/D26559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
krasin added a comment.
Sounds reasonable. Will do on Monday.
https://reviews.llvm.org/D26559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini updated this revision to Diff 77680.
mehdi_amini marked 3 inline comments as done.
mehdi_amini added a comment.
Address Alex's comment.
https://reviews.llvm.org/D26522
Files:
clang/lib/AST/Expr.cpp
clang/lib/CodeGen/CGExpr.cpp
clang/test/CodeGen/block-with-perdefinedexpr.cpp
mehdi_amini updated this revision to Diff 77681.
mehdi_amini added a comment.
Fix warning for unused variable
https://reviews.llvm.org/D26522
Files:
clang/lib/AST/Expr.cpp
clang/lib/CodeGen/CGExpr.cpp
clang/test/CodeGen/block-with-perdefinedexpr.cpp
clang/test/CodeGenCXX/predefined-expr
mehdi_amini updated this revision to Diff 77682.
mehdi_amini added a comment.
Add a test inside a lambda
https://reviews.llvm.org/D26522
Files:
clang/lib/AST/Expr.cpp
clang/lib/CodeGen/CGExpr.cpp
clang/test/CodeGen/block-with-perdefinedexpr.cpp
clang/test/CodeGenCXX/predefined-expr-cxx1
Author: eugenis
Date: Fri Nov 11 17:17:36 2016
New Revision: 286669
URL: http://llvm.org/viewvc/llvm-project?rev=286669&view=rev
Log:
Tread TSan LLVM flags to driver: add TSan controlling flags to clang.
Summary:
New clang flags, all default to true:
-f[no-]sanitize-thread-data-races
-f[no-]sanit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286669: Tread TSan LLVM flags to driver: add TSan
controlling flags to clang. (authored by eugenis).
Changed prior to commit:
https://reviews.llvm.org/D26461?vs=77667&id=77683#toc
Repository:
rL LLVM
Author: zaks
Date: Fri Nov 11 17:22:44 2016
New Revision: 286672
URL: http://llvm.org/viewvc/llvm-project?rev=286672&view=rev
Log:
[tsan][clang] Introduce a function attribute to disable TSan checking at run
time
This introduces a function annotation that disables TSan checking for the
function
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286672: [tsan][clang] Introduce a function attribute to
disable TSan checking at run… (authored by zaks).
Changed prior to commit:
https://reviews.llvm.org/D25857?vs=77435&id=77686#toc
Repository:
rL
Author: rsmith
Date: Fri Nov 11 17:43:35 2016
New Revision: 286678
URL: http://llvm.org/viewvc/llvm-project?rev=286678&view=rev
Log:
[c++1z] Add constant-folding support for strcmp, strncmp, and memcmp, to
support constexpr char_traits.
Added:
cfe/trunk/test/SemaCXX/constexpr-string.cpp
phosek added a comment.
That makes sense for diagnostics, but this attribute is only an optimization
hint, so compiler should be allowed to ignore it. I can take a look how
difficult it'd be to actually implement this attribute, but I don't think it's
Sema-only attribute. I don't know if there'
1 - 100 of 119 matches
Mail list logo
