rSerge marked an inline comment as done.
rSerge added inline comments.
================
Comment at: lib/Driver/Tools.cpp:4903-4906
+ if (Triple.getOS() != llvm::Triple::Linux)
+ D.Diag(diag::err_drv_clang_unsupported)
+ << (std::string(XRayInstrumentOption) + " on non-Linux target OS.");
+ switch (Triple.getArch()) {
----------------
dberris wrote:
> Did you need to put an `else` before the switch? I don't know what happens
> when you're on Windows non-supported platform -- will this cause two
> diagnostics to be printed?
I thought that the statement after `D.Diag(diag::err_drv_clang_unsupported)`
will not be executed. Let me check...
https://reviews.llvm.org/D26415
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
