Re: [PATCH] Warning for main returning a bool.

On Fri, 14 Oct 2016 17:17:59 + Joshua Hurwitz via cfe-commits wrote: > See attached. > > Returning a bool from main is a special case of return type mismatch. The > common convention when returning a bool is that 'true' (== 1) indicates > success and 'false' (== 0) failure. But since main ex

[PATCH] D26139: Tests for strings conversions under libcpp-no-exceptions

rmaprath added a comment. In https://reviews.llvm.org/D26139#587587, @mclow.lists wrote: > > I think it might be better to add TEST_TRY and TEST_CATCH(...) macros > > defined like > > @rogfer01 said at the top that he didn't want to add "a magical TEST_TRY > macro" - and I agree. Someone tri

[PATCH] D26288: Deduplicate replacements by FileEntry instead of file names.

ioeric added a comment. Since Manuel's comment has been addressed, I'd like to land this if there is no objection. https://reviews.llvm.org/D26288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D26335: [ms] Reinstate https://reviews.llvm.org/D14748 after https://reviews.llvm.org/D20291

thakis created this revision. thakis added a reviewer: hans. thakis added a subscriber: cfe-commits. https://reviews.llvm.org/D26335 Files: lib/Headers/x86intrin.h test/Headers/tzcnt.c Index: test/Headers/tzcnt.c === --- test/H

[PATCH] D18073: Add memory allocating functions

ariccio added a comment. Nevermind, the order is correct! https://reviews.llvm.org/D18073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21298: [Clang-tidy] delete null check

SilverGeri updated this revision to Diff 76893. https://reviews.llvm.org/D21298 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DeleteNullPointerCheck.cpp clang-tidy/misc/DeleteNullPointerCheck.h clang-tidy/misc/MiscTidyModule.cpp docs/clang-tidy/checks/list.rst docs/clang-tidy/

[PATCH] D18073: Add memory allocating functions

dcoughlin added a comment. Thanks for iterating on the patch! Some comments in-line. Comment at: llvm/tools/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:569 + // allocating functions initialized to nullptr, which will never equal a + //non-null IdentifierInfo*, and nev

[PATCH] D25857: [tsan][clang] Introduce a function attribute to disable TSan checking at run time

dvyukov added inline comments. Comment at: test/CodeGen/sanitize-thread-no-checking-at-run-time.m:1 +// RUN: %clang_cc1 -triple x86_64-apple-darwin -x objective-c++ -emit-llvm -o - %s | FileCheck -check-prefix=WITHOUT %s +// RUN: %clang_cc1 -triple x86_64-apple-darwin -x objecti

[PATCH] D26340: [analyzer] Add SpinLockChecker for the Magenta kernel

khazem updated this revision to Diff 77005. khazem added a comment. Minor edit, the list of libraries in CMakeLists.txt is now in alphabetical order. https://reviews.llvm.org/D26340 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/St

[PATCH] D26288: Deduplicate replacements by FileEntry instead of file names.

ioeric updated this revision to Diff 77008. ioeric added a comment. - Merge with origin/master https://reviews.llvm.org/D26288 Files: include/clang/Tooling/Core/Replacement.h lib/Tooling/Core/Replacement.cpp lib/Tooling/Refactoring.cpp unittests/Tooling/RefactoringTest.cpp Index: unitt

r286096 - Deduplicate replacements by FileEntry instead of file names.

Author: ioeric Date: Mon Nov 7 00:08:23 2016 New Revision: 286096 URL: http://llvm.org/viewvc/llvm-project?rev=286096&view=rev Log: Deduplicate replacements by FileEntry instead of file names. Summary: The current version does not deduplicate equivalent file paths correctly. For example, a relat

[PATCH] D26288: Deduplicate replacements by FileEntry instead of file names.

This revision was automatically updated to reflect the committed changes. Closed by commit rL286096: Deduplicate replacements by FileEntry instead of file names. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D26288?vs=77008&id=77009#toc Repository: rL LLVM https://

[PATCH] D21298: [Clang-tidy] delete null check

alexfh added a comment. I guess, "readability" will be a better category for this check. https://reviews.llvm.org/D21298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r286097 - [AVX-512][Sema] Add more intrinsics to the checks for valid immediates for embedded rounding control arguments.

Author: ctopper Date: Mon Nov 7 01:01:09 2016 New Revision: 286097 URL: http://llvm.org/viewvc/llvm-project?rev=286097&view=rev Log: [AVX-512][Sema] Add more intrinsics to the checks for valid immediates for embedded rounding control arguments. Modified: cfe/trunk/lib/Sema/SemaChecking.cpp