hans closed this revision.
hans added a comment.
Ehsan added support for -o with r217615.
https://reviews.llvm.org/D3771
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane marked 11 inline comments as done.
erichkeane added a comment.
New patch incoming.
> ABataev wrote in ItaniumMangle.cpp:1236-1237
> What if function type is not a FunctionProtoType?
Right, good catch. I looked at Mangle.cpp which does something very similar,
and assumes that Funct
probinson added a comment.
As Renato points out, this addresses the user experience of tripping over the
lack of -Og, however it does not really address the intent of PR20765 which is
to provide a mode of optimizations that don't particularly interfere with
debugging.
Eventually someone needs t
hokein created this revision.
hokein added a reviewer: aaron.ballman.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D25244
Files:
clang-tidy/google/NonConstReferences.cpp
clang-tidy/google/NonConstReferences.h
docs/clang-tidy/checks/google-runtime-references.rst
test/cl
mehdi_amini added inline comments.
> spatel wrote in CGCall.cpp:1735
> Auto-upgrading is part of the solution. Based on how we've been doing this
> with vector intrinsics that get converted to IR, it's a ~3-step process:
>
> 1. Prepare the backend (DAG) to handle the expected new IR patterns an
vsk added a comment.
The ivar list is set by all_declared_ivar_begin(), which accounts for ivars
introduced by an implementation. Thanks for raising the point.
Consider this test:
@interface HasFlexibleArray {
@public char chars[0];
}
@implementation HasFlexibleArray {
@public char ch
echristo added inline comments.
> mehdi_amini wrote in CGCall.cpp:1735
> I think I remember folks being against FMF on calls (Chris Lattner?), I'll
> try to find the relevant discussion.
> Otherwise your plan seems fine to me!
Agreed. Also shouldn't hold up this patch :)
https://reviews.llvm.o
erichkeane updated this revision to Diff 73507.
erichkeane marked an inline comment as done.
erichkeane added a comment.
Herald added a subscriber: dschuff.
Fixes based on Alexey/Ried's feedback
https://reviews.llvm.org/D25204
Files:
include/clang-c/Index.h
include/clang/AST/Type.h
includ
rnk added inline comments.
> erichkeane wrote in TargetInfo.cpp:3742-3743
> That was my intent, this should allow return values to be in registers as
> well if I'm reading the spec correctly. The idea is that register use is
> 'greedy'.
But, if the return value is returned directly, it doesn'
elsteveogrande added a comment.
Thanks again @rsmith! Updates will be coming; I have some other fixes as well.
> rsmith wrote in PrintPreprocessedOutput.cpp:329
> Is this really necessary? It'll be very ugly on Windows.
Yeah, there will be tons of double-backslashes because of this. I think
vsk updated this revision to Diff 73508.
vsk added a comment.
Add tests for implementations which introduce ivars.
https://reviews.llvm.org/D7
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGenObjC/ubsan-array-bounds.m
Index: test/CodeGenObjC/ubsan-array-bounds.m
=
On Mon, Oct 3, 2016 at 2:59 PM, Peter Collingbourne wrote:
> pcc added a reviewer: rsmith.
> pcc added a comment.
>
> It seems to me that this sanitizer would break the semantics of otherwise
> well-defined programs. For example:
>
> int *x = nullptr;
> delete x;
> if (x != nullptr) {
>
majnemer added inline comments.
> majnemer wrote in PrintPreprocessedOutput.cpp:321-325
> Variables should start with uppercase characters.
Please uppercase all your other variables too.
> PrintPreprocessedOutput.cpp:344
> + */
> +bool tryGetTokenText(StringRef *text, const Token &tok) {
> + i
erichkeane added inline comments.
> rnk wrote in TargetInfo.cpp:3742-3743
> But, if the return value is returned directly, it doesn't conflict with the
> free parameter registers. In my example, the return value can use XMM0-3 and
> the parameters can use XMM0-15. Can you add this test case and
spatel added inline comments.
> mehdi_amini wrote in CGCall.cpp:1735
> I think I remember folks being against FMF on calls (Chris Lattner?), I'll
> try to find the relevant discussion.
> Otherwise your plan seems fine to me!
Yes - Chris was opposed to FMF on intrinsics (preferring parameters/me
rnk added inline comments.
> erichkeane wrote in ItaniumMangle.cpp:1236-1237
> Right, good catch. I looked at Mangle.cpp which does something very similar,
> and assumes that FunctionType is a valid cast here, so I've switched this
> here too, please let me know if that is a wrong assumption.
mclow.lists added a comment.
I had no idea that we had no tests for `vector::clear`. Oosps.
This looks good to me, but I want to play with the codegen for a bit before
approving it.
Also, you should add `cfe-commits` to the subscribers.
thanks for doing this!
> clear.pass.cpp:25
> +c.cle
rSerge removed rL LLVM as the repository for this revision.
rSerge updated this revision to Diff 73509.
rSerge added a comment.
My mistake was that initially I only enumerated the unsupported targets from
llvm\include\llvm\ADT\Triple.h . Now I've added also the cases from
llvm\lib\Support\Triple
majnemer added inline comments.
> ItaniumMangle.cpp:1413-1414
>
> -void CXXNameMangler::mangleSourceName(const IdentifierInfo *II) {
> - // ::=
> +void CXXNameMangler::mangleSourceName(const IdentifierInfo *II,
> + bool isRegCall) {
> + // ::= [__regc
elsteveogrande added a comment.
Thanks again @majnemer! Other vars are fixed, will send an update shortly.
> majnemer wrote in PrintPreprocessedOutput.cpp:344
> Could this just return a StringRef? You could use an empty StringRef on
> failure.
I'll get rid of this in favor of `PP.getSpelling
majnemer added inline comments.
> ItaniumMangle.cpp:1234
>
> - mangleSourceName(II);
> + auto FD = dyn_cast(ND);
> + bool isRegCall = (FD != nullptr) &&
`auto *`
> ItaniumMangle.cpp:1235
> + auto FD = dyn_cast(ND);
> + bool isRegCall = (FD != nullptr) &&
> +FD
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Can you double-check that the memory layout is actually what we think it is by
inspecting the generated IR? Otherwise this LGTM.
https://reviews.llvm.org/D7
_
rnk added a comment.
Let's avoid the duplicate enum, otherwise looks good
> TargetBuiltins.h:100
> + /// \brief X86-64 builtins
> + namespace X86_64 {
> + enum {
I think this would be better with just one enum to reduce compilation time:
/// \brief X86 builtins
namespace X86 {
Author: rnk
Date: Tue Oct 4 13:10:23 2016
New Revision: 283235
URL: http://llvm.org/viewvc/llvm-project?rev=283235&view=rev
Log:
Test what happens when tag lookup and redeclaration lookup disagree
Clang has a diagnostic for the what happens when an elaborated type
implicitly creates a tag declar
elsteveogrande updated this revision to Diff 73518.
elsteveogrande added a comment.
- Fix a few more style nits according to LLVM style guide.
- Further fixed w/ `clang-format -style=LLVM`, kept (most of) recommended
changes.
- Added more unit tests (more include cases: `#include_next`, `-imacro`
agutowski updated this revision to Diff 73521.
agutowski added a comment.
merge enums
https://reviews.llvm.org/D24598
Files:
include/clang/Basic/BuiltinsX86_64.def
include/clang/Basic/TargetBuiltins.h
lib/Basic/Targets.cpp
lib/CodeGen/CGBuiltin.cpp
lib/Headers/intrin.h
test/CodeGen/
Hi Richard,
Thanks for your analysis.
This patch is intended to mitigate use-after-free bugs. In that context a
“define strict behavior for invalid pointer values” we could deploy in
production code would be very useful. Maybe calling this a sanitizer is
misleading, and instead it could be pr
davidsh updated this revision to Diff 73520.
davidsh added a comment.
Adding a parameter to IgnoreContainers instead of copying the logic.
https://reviews.llvm.org/D24615
Files:
include/clang/AST/Stmt.h
lib/AST/Stmt.cpp
lib/Sema/SemaOpenMP.cpp
test/OpenMP/for_loop_messages.cpp
Index:
agutowski added inline comments.
> rnk wrote in TargetBuiltins.h:100
> I think this would be better with just one enum to reduce compilation time:
>
> /// \brief X86 builtins
> namespace X86 {
> enum {
> LastTIBuiltin = clang::Builtin::FirstTSBuiltin - 1,
> #define BUILTIN(ID
agutowski added inline comments.
> agutowski wrote in TargetBuiltins.h:100
> Nice, thanks!
> As far as I see, it creates some inconsistency in usage of the word "last",
> because it's used wrong everywhere else - LastTSBuiltin is the number of the
> last target-specific builtin **plus one**, wh
zaks.anna added a comment.
Should this revision be closed?
https://reviews.llvm.org/D23853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Fix MSVC shadow warnings in a newly added test, by renaming local variables.
https://reviews.llvm.org/D25248
Files:
test/std/utilities/utility/forward/move.pass.cpp
Index
CaseyCarter created this revision.
CaseyCarter added reviewers: EricWF, mclow.lists.
CaseyCarter added a subscriber: cfe-commits.
Changes to non-portable behavior in tests. Inline detailed description of
each change is forthcoming. Changes are almost entirely in test code, with one
behavioral c
Author: aizatsky
Date: Tue Oct 4 14:19:16 2016
New Revision: 283242
URL: http://llvm.org/viewvc/llvm-project?rev=283242&view=rev
Log:
[sancov] documentation update after r283241
Modified:
cfe/trunk/docs/SanitizerCoverage.rst
Modified: cfe/trunk/docs/SanitizerCoverage.rst
URL:
http://llvm.o
vleschuk updated this revision to Diff 73537.
vleschuk added a comment.
Pass alignment in bits instead of bytes to backend (conversion is done when
emitting DW_AT_alignment).
https://reviews.llvm.org/D24426
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
test/CodeGen/debug-i
CaseyCarter updated this revision to Diff 73538.
CaseyCarter added a comment.
Fix inadvertent whitespace changes.
https://reviews.llvm.org/D25249
Files:
.gitignore
include/any
test/libcxx/utilities/any/any.class/any.assign/value.pass.cpp
test/libcxx/utilities/any/any.class/any.cons/valu
CaseyCarter added a comment.
I'll push a revision with the whitespace changes reverted soon.
> .gitignore:59
> keep.lst
> +.vscode/
This is an editor byproduct, I suppose, not "MSVC libraries test harness". Let
me know if anyone cares and I'll add a comment.
> any:553
> +__tmp._
Author: djasper
Date: Tue Oct 4 15:18:25 2016
New Revision: 283246
URL: http://llvm.org/viewvc/llvm-project?rev=283246&view=rev
Log:
clang-format: Fix bad multi-variable for-loop formatting.
Before:
for (int*p, *q; p != q; p = p->next) {
After:
for (int *p, *q; p != q; p = p->next) {
Modif
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL282488.
https://reviews.llvm.org/D24961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
vitalybuka added a comment.
Out of curiosity, how was MSVC crash solved?
Repository:
rL LLVM
https://reviews.llvm.org/D24916
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283249: [ubsan] Disable bounds-check for flexible array
ivars (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D7?vs=73508&id=73547#toc
Repository:
rL LLVM
https://review
NoQ added a comment.
In https://reviews.llvm.org/D24916#561369, @vitalybuka wrote:
> Out of curiosity, how was MSVC crash solved?
It wasn't, unfortunately; phabricator closed this revision by looking at the
commit that was already reverted, with a delay (see
http://lists.llvm.org/pipermail/cf
vsk added a comment.
Thanks for the review!
I looked at the IR and confirmed that the ivars are laid out in the order
they're defined, that the indirect ivar offsets make sense, and that the
runtime ivar offsets match up with what we expect. E.g;
@"OBJC_IVAR_$_FlexibleArray1.chars" = global
NoQ added inline comments.
> chapuni wrote in CloneDetection.cpp:113
> You should update \param here. See also r283106.
Thanks!! Will do.
Repository:
rL LLVM
https://reviews.llvm.org/D24916
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: vedantk
Date: Tue Oct 4 15:36:04 2016
New Revision: 283249
URL: http://llvm.org/viewvc/llvm-project?rev=283249&view=rev
Log:
[ubsan] Disable bounds-check for flexible array ivars
This eliminates a class of false positives for -fsanitize=array-bounds
on instrumented ObjC projects.
Differ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283251: [clang] make reciprocal estimate codegen a function
attribute (authored by spatel).
Changed prior to commit:
https://reviews.llvm.org/D24815?vs=73364&id=73548#toc
Repository:
rL LLVM
https:/
Author: spatel
Date: Tue Oct 4 15:44:05 2016
New Revision: 283251
URL: http://llvm.org/viewvc/llvm-project?rev=283251&view=rev
Log:
[clang] make reciprocal estimate codegen a function attribute
The motivation for the change is that we can't have pseudo-global settings
for codegen living in Targe
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL281979.
https://reviews.llvm.org/D24712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D24703
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: zaks
Date: Tue Oct 4 15:49:31 2016
New Revision: 283253
URL: http://llvm.org/viewvc/llvm-project?rev=283253&view=rev
Log:
[analyzer] Add PostStmt callback for ArraySubscriptExpr
A patch by Jan Smets!
Differential Revision: https://reviews.llvm.org/D25009
Modified:
cfe/trunk/lib/Sta
Anastasia added a comment.
> Regarding the improvement proposed by us which "flatten" captured variables
> into invoke_function argument list and block_literal pointer wouldn't be
> passed as first argument(to invoke_function) anymore. The reason why it
> doesn't require global memory managem
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D24562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL281666.
https://reviews.llvm.org/D24488
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Author: hans
Date: Tue Oct 4 16:01:00 2016
New Revision: 283256
URL: http://llvm.org/viewvc/llvm-project?rev=283256&view=rev
Log:
clang-cl: expose the -fuse-ld option
Modified:
cfe/trunk/include/clang/Driver/Options.td
cfe/trunk/test/Driver/cl-link.c
Modified: cfe/trunk/include/clang/Dr
Author: hans
Date: Tue Oct 4 16:01:02 2016
New Revision: 283257
URL: http://llvm.org/viewvc/llvm-project?rev=283257&view=rev
Log:
clang-cl: Use the .obj file extension also in LTO mode
Modified:
cfe/trunk/lib/Driver/Types.cpp
cfe/trunk/test/Driver/cl-outputs.c
Modified: cfe/trunk/lib/Dr
Author: hans
Date: Tue Oct 4 16:00:57 2016
New Revision: 283255
URL: http://llvm.org/viewvc/llvm-project?rev=283255&view=rev
Log:
clang-cl: Expose the -flto option
We could hook up /GL as an alias for -flto, but that might be
confusing, as clang-cl in that mode would not be drop-in compatible
wi
Author: hans
Date: Tue Oct 4 16:01:04 2016
New Revision: 283258
URL: http://llvm.org/viewvc/llvm-project?rev=283258&view=rev
Log:
clang-cl: Make /Fo apply also when using -flto
Modified:
cfe/trunk/lib/Driver/Driver.cpp
cfe/trunk/test/Driver/cl-outputs.c
Modified: cfe/trunk/lib/Driver/Dr
rmaprath added a comment.
In https://reviews.llvm.org/D24562#561442, @Eugene.Zelenko wrote:
> Looks like patch was not committed.
Need to replicate this to as many tests as possible (~150). I was hoping to do
all that and upload another diff for a final review, couldn't get to it I'm
afraid.
parallaxe added a comment.
In https://reviews.llvm.org/D23236#557898, @dcoughlin wrote:
> Upon reflection, I don't think this is the right approach.
>
> Desugaring any AttributedType in the return type seems like a really, really
> big hammer and could be an unexpected surprise for future attrib
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
There's a macro scheme already being used for __has_feature etc. Use it for
__has_include too, which makes MSVC happy (it doesn't support __has_include
yet, and unguarded use
Author: ericwf
Date: Tue Oct 4 16:25:51 2016
New Revision: 283260
URL: http://llvm.org/viewvc/llvm-project?rev=283260&view=rev
Log:
[libcxx] [test] Guard __has_include usage with a macro
Summary: There's a macro scheme already being used for __has_feature etc. Use
it for __has_include too, whic
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Although I would have thought the first half of the conjunction would
have prevented MSVC's PP from seeing the `__has_include`.
I'll get to the rest of the patches tomorrow.
https://re
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D24598
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: zturner
Date: Tue Oct 4 16:27:09 2016
New Revision: 283261
URL: http://llvm.org/viewvc/llvm-project?rev=283261&view=rev
Log:
Make building the clang-tidy VS extension less spammy.
The package that strong name signs the 3rd party references
spams a ton of output to the log, making the bui
EricWF added a comment.
r283260.
https://reviews.llvm.org/D25251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kkwli0 added a comment.
Should we issue a warning message in this case?
https://reviews.llvm.org/D24615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
Feel free to send them in 10-20 at a time. It'll be much faster to review that
way.
https://reviews.llvm.org/D24562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
rjmccall added a comment.
LGTM, but I'm not a code owner here.
https://reviews.llvm.org/D24012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: agutowski
Date: Tue Oct 4 17:29:49 2016
New Revision: 283264
URL: http://llvm.org/viewvc/llvm-project?rev=283264&view=rev
Log:
Separate builtins for x84-64 and i386; implement __mulh and __umulh
Summary: We need x86-64-specific builtins if we want to implement some of the
MS intrinsics
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283264: Separate builtins for x84-64 and i386; implement
__mulh and __umulh (authored by agutowski).
Changed prior to commit:
https://reviews.llvm.org/D24598?vs=73521&id=73570#toc
Repository:
rL LLVM
GorNishanov created this revision.
GorNishanov added reviewers: rsmith, EricWF.
GorNishanov added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
1. Sema: Add allocation / deallocation substatements.
2. Sema: Add labels to final-suspend and deallocation substatements.
3. Sema: A
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL280306. Please specify "Differential
revision: " as last line of commit message.
https://reviews.llvm.org/D23734
___
cfe-commits mailing li
Eugene.Zelenko added a comment.
Looks like patch was not committed.
Repository:
rL LLVM
https://reviews.llvm.org/D23602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D23493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar created this revision.
jlebar added a reviewer: rnk.
jlebar added a subscriber: cfe-commits.
This will let us (in a separate patch) allocate deferred diagnostics in
the ASTContext's PartialDiagnostic arena.
https://reviews.llvm.org/D25260
Files:
clang/include/clang/AST/ASTContext.h
c
jlebar added inline comments.
> rnk wrote in Sema.h:9258
> The ASTContext should outlive IRgen, since the AST is allocated in its arena.
> Is there a separate diagnostic memory pool that I don't know about?
You're right, this is a silly bug. Fixed in a separate patch,
https://reviews.llvm.org
jlebar updated this revision to Diff 73576.
jlebar marked an inline comment as done.
jlebar added a comment.
Rebase atop https://reviews.llvm.org/D25260, which obviates the need for this
ugly PD allocation dance.
https://reviews.llvm.org/D25139
Files:
clang/include/clang/Basic/DiagnosticSemaK
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D22945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D22944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL199208.
https://reviews.llvm.org/D2526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
rnk added inline comments.
> CodeGenModule.cpp:512-513
>}
> + // Clear the deferred diags so they don't outlive the ASTContext from
> whence
> + // they're allocated.
> + DeferredDiags.clear();
The ASTContext outlives CodeGenModule, but the diagnostic allocator in the
ASTContext does no
jlebar updated this revision to Diff 73577.
jlebar added a comment.
Move everything into codegen.
https://reviews.llvm.org/D25166
Files:
clang/lib/CodeGen/CGCall.cpp
clang/lib/CodeGen/CGException.cpp
clang/test/CodeGenCUDA/convergent.cu
clang/test/CodeGenCUDA/device-var-init.cu
clang/
jlebar updated this revision to Diff 73578.
jlebar added a comment.
Update comment.
https://reviews.llvm.org/D25260
Files:
clang/include/clang/AST/ASTContext.h
clang/lib/CodeGen/CodeGenModule.cpp
Index: clang/lib/CodeGen/CodeGenModule.cpp
==
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL196887.
https://reviews.llvm.org/D2344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
majnemer added inline comments.
> CGCoroutine.cpp:68-69
> +void CodeGenFunction::EmitCoroutineBody(const CoroutineBodyStmt &S) {
> + auto *NullPtr = llvm::ConstantPointerNull::get(Builder.getInt8PtrTy());
> + // FIXME: Instead of 0, pass an equivalent of alignas(maxalign_t).
> + auto *CoroId =
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
> nothrow.cu:16
> +// DEVICE: define void @_Z3foov() [[DEVICE_ATTR:#[0-9]+]]
> +__device__ void foo() { f(); }
> +
I would check for `call void @_Z1fv` here, and ma
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar updated this revision to Diff 73579.
jlebar marked an inline comment as done.
jlebar added a comment.
Update tests.
https://reviews.llvm.org/D25166
Files:
clang/lib/CodeGen/CGCall.cpp
clang/lib/CodeGen/CGException.cpp
clang/test/CodeGenCUDA/convergent.cu
clang/test/CodeGenCUDA/de
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL196191.
https://reviews.llvm.org/D2304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Author: jlebar
Date: Tue Oct 4 18:41:45 2016
New Revision: 283271
URL: http://llvm.org/viewvc/llvm-project?rev=283271&view=rev
Log:
[CUDA] Destroy deferred diagnostics before destroying the ASTContext's
PartialDiagnostic allocator.
Summary:
This will let us (in a separate patch) allocate deferr
GorNishanov added inline comments.
> majnemer wrote in CGCoroutine.cpp:68-69
> I think that's just `CGM.getContext().getTargetInfo().getSuitableAlign() /
> CGM.getContext().getTargetInfo().getCharWidth()`
Yay! One less FIXME.
I think I will make it to match __STDCPP_DEFAULT_NEW_ALIGNMENT__:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283271: [CUDA] Destroy deferred diagnostics before
destroying the ASTContext's… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25260?vs=73578&id=73580#toc
Repository:
rL LLV
Author: jlebar
Date: Tue Oct 4 18:41:49 2016
New Revision: 283272
URL: http://llvm.org/viewvc/llvm-project?rev=283272&view=rev
Log:
[CUDA] Mark device functions as nounwind.
Summary:
This prevents clang from emitting 'invoke's and catch statements.
Things previously mostly worked thanks to TryT
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283272: [CUDA] Mark device functions as nounwind. (authored
by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25166?vs=73579&id=73581#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL196189.
https://reviews.llvm.org/D2302
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
mclow.lists accepted this revision.
mclow.lists added a comment.
I will land this, and close the other one, too.
https://reviews.llvm.org/D25053
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: jlebar
Date: Tue Oct 4 19:27:38 2016
New Revision: 283280
URL: http://llvm.org/viewvc/llvm-project?rev=283280&view=rev
Log:
[CUDA] Add missing ':' to noexcept.cu test.
Modified:
cfe/trunk/test/CodeGenCUDA/nothrow.cu
Modified: cfe/trunk/test/CodeGenCUDA/nothrow.cu
URL:
http://llvm.o
erichkeane marked 16 inline comments as done.
erichkeane added a comment.
Commenting to save my comments (don't seem to survive a refresh). Still
working on non-function mangling.
> rnk wrote in ItaniumMangle.cpp:1203
> What mangling should happen for operator overloads and all other kinds of
majnemer added inline comments.
> PrintPreprocessedOutput.cpp:101
>PrintPPOutputPPCallbacks(Preprocessor &pp, raw_ostream &os, bool
> lineMarkers,
> - bool defines, bool UseLineDirectives)
> + bool defines, bool dumpIncludeDirectives,
> +
elsteveogrande added a comment.
Thanks -- will do one more pass
> majnemer wrote in PrintPreprocessedOutput.cpp:409-411
> Why not have sanitizePath return a `std::vector`?
Hmm, good idea. Better than caller-passed vectors, and it be whatever size is
needed (in the called method I'd `CharVect
101 - 200 of 223 matches
Mail list logo
