agutowski added inline comments.

> agutowski wrote in TargetBuiltins.h:100
> Nice, thanks!
> As far as I see, it creates some inconsistency in usage of the word "last", 
> because it's used wrong everywhere else - LastTSBuiltin is the number of the 
> last target-specific builtin **plus one**, while LastX86CommonBuiltin doesn't 
> have this additional one. I would leave it like that, but wanted to point 
> that out, in case you think it's not acceptable.

Ah, now I see that LastTIBuiltin is also what its name suggests, so it's only 
LastTSBuiltin that's different.

https://reviews.llvm.org/D24598



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to