eladcohen added inline comments.
Comment at: lib/Headers/module.modulemap:133
@@ -131,2 +132,3 @@
explicit module aes {
+ export sse2
header "__wmmintrin_aes.h"
bruno wrote:
> The mmx case above makes sense to me, but I find conceptually odd that
mgorny created this revision.
mgorny added reviewers: danalbert, EricWF.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
Update LLVM_CMAKE_PATH in stand-alone builds to match the new install layout
used by LLVM 3.9+ where CMake files are installed into lib*/cmake/
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Comment at: lib/Tooling/Core/Replacement.cpp:179-181
@@ +178,5 @@
+// `R` and `Replaces` are order-independent if applying them in either order
+// has the same effect, so
hokein created this revision.
hokein added reviewers: klimek, djasper, ioeric.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
The FilePath of the Replacement constructed from a SourceManager can be
an absolute file path or a file path relative to the build directory (It
delena added inline comments.
Comment at: test/CodeGen/x86-inline-asm-v-constraint.c:2
@@ +1,3 @@
+// RUN: %clang_cc1 %s -triple x86_64-unknown-linux-gnu -emit-llvm -target-cpu
x86-64 -o - | FileCheck %s --check-prefix SSE
+// RUN: %clang_cc1 %s -triple x86_64-unknown-linux-gnu -
danielmarjamaki removed rL LLVM as the repository for this revision.
danielmarjamaki updated this revision to Diff 72775.
danielmarjamaki added a comment.
Use !isa. Suggestion by Gabor.
https://reviews.llvm.org/D24905
Files:
lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp
test/Analys
danielmarjamaki marked an inline comment as done.
Comment at: lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp:195
@@ +194,3 @@
+if (Optional S = I->getAs()) {
+ if (!isa(S->getStmt()))
+return S->getStmt();
yes I agree.
https://reviews.ll
danielmarjamaki marked an inline comment as done.
danielmarjamaki added a comment.
https://reviews.llvm.org/D24905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny created this revision.
mgorny added a reviewer: EricWF.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
Include an appropriate unwinder library (-lunwind or -lgcc_s) when constructing
a linker script for libc++. This is necessary since otherwise clang++ set
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D24905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
rmaprath added a subscriber: rmaprath.
rmaprath added a comment.
The patch generally makes sense to me.
I wonder if the test configuration can also benefit from this;
`test/libcxx/test/target_info.py` manually updates the link line to use
`-lgcc_s` or `-lunwind` depending on how the build is co
mgorny added a comment.
In https://reviews.llvm.org/D25008#555041, @rmaprath wrote:
> The patch generally makes sense to me.
>
> I wonder if the test configuration can also benefit from this;
> `test/libcxx/test/target_info.py` manually updates the link line to use
> `-lgcc_s` or `-lunwind` dep
mstorsjo retitled this revision from "Headers: Add iso_volatile load/store
intrinsics" to "[MS] Implement __iso_volatile loads/stores as builtins".
mstorsjo updated the summary for this revision.
mstorsjo updated this revision to Diff 72782.
mstorsjo added a comment.
Changed to implement it as bu
Author: mstorsjo
Date: Wed Sep 28 04:34:51 2016
New Revision: 282569
URL: http://llvm.org/viewvc/llvm-project?rev=282569&view=rev
Log:
[Headers] Replace stray indentation with tabs with spaces. NFC.
This matches the rest of the surrounding file.
Modified:
cfe/trunk/lib/Headers/intrin.h
Modi
malcolm.parsons added a subscriber: malcolm.parsons.
malcolm.parsons added a comment.
This check looks like it implements some of CppCoreGuidelines Bounds.4
https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#bounds4-dont-use-standard-library-functions-and-types-that-are-
hokein abandoned this revision.
hokein added a comment.
As discussed offline with klimek, we should change to the correct working
directory before applying the replacements. So abandon this.
https://reviews.llvm.org/D25006
___
cfe-commits mailing l
Abpostelnicu updated this revision to Diff 72790.
Abpostelnicu marked 2 inline comments as done.
Abpostelnicu added a comment.
i will add the unit tests in the next patch.
https://reviews.llvm.org/D22910
Files:
include/clang/AST/ExprCXX.h
lib/AST/Expr.cpp
Index: lib/AST/Expr.cpp
==
Author: a.sidorin
Date: Wed Sep 28 05:16:56 2016
New Revision: 282572
URL: http://llvm.org/viewvc/llvm-project?rev=282572&view=rev
Log:
[ASTImporter] Implement some expression-related AST node import (part 2)
* Some code cleanup
* Add tests not present in http://reviews.llvm.org/D14286
* Integrat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282572: [ASTImporter] Implement some expression-related AST
node import (part 2) (authored by a.sidorin).
Changed prior to commit:
https://reviews.llvm.org/D14326?vs=72625&id=72791#toc
Repository:
rL
Author: klimek
Date: Wed Sep 28 05:20:10 2016
New Revision: 282573
URL: http://llvm.org/viewvc/llvm-project?rev=282573&view=rev
Log:
Fix warnings in clang-completion-mode.el.
- Use defvar to declare variables
- Don't use delete-backward-char, which is for interactive use only
Patch by Philipp St
a.sidorin added a comment.
Committed after Aaron's comment were addressed. Big thanks to all reviewers!
Repository:
rL LLVM
https://reviews.llvm.org/D14326
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
nemanjai added a comment.
In https://reviews.llvm.org/D24397#555057, @bjope wrote:
> This test/CodeGen/builtins-ppc-p9vector.c test will fail together with this
> upcoming LLVM patch https://reviews.llvm.org/D24955
>
> Problem is that lots of your
>
> add i64 {{.*}}, 64
>
> checks will fails s
Author: danielmarjamaki
Date: Wed Sep 28 05:39:53 2016
New Revision: 282574
URL: http://llvm.org/viewvc/llvm-project?rev=282574&view=rev
Log:
[StaticAnalyzer] Fix false positives for vardecls that are technically
unreachable but they are needed.
Example:
switch (x) {
int a; // <- Thi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282574: [StaticAnalyzer] Fix false positives for vardecls
that are technically… (authored by danielmarjamaki).
Changed prior to commit:
https://reviews.llvm.org/D24905?vs=72775&id=72793#toc
Repository:
Author: asiri
Date: Wed Sep 28 05:57:15 2016
New Revision: 282575
URL: http://llvm.org/viewvc/llvm-project?rev=282575&view=rev
Log:
[libunwind] Add support for a single-threaded libunwind build
The EHABI unwinder is thread-agnostic, SJLJ unwinder and the DWARF unwinder have
a couple of pthread de
Author: a.sidorin
Date: Wed Sep 28 05:57:36 2016
New Revision: 282576
URL: http://llvm.org/viewvc/llvm-project?rev=282576&view=rev
Log:
ASTMerge: specify arch for GCCAsmStmt test explicitly to calm non-x86 buildbots
Modified:
cfe/trunk/test/ASTMerge/Inputs/exprs3.cpp
Modified: cfe/trunk/tes
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282575: [libunwind] Add support for a single-threaded
libunwind build (authored by asiri).
Changed prior to commit:
https://reviews.llvm.org/D24984?vs=72698&id=72798#toc
Repository:
rL LLVM
https://
danielmarjamaki removed rL LLVM as the repository for this revision.
danielmarjamaki updated this revision to Diff 72797.
danielmarjamaki added a comment.
Don't write warning for multiplication in LHS of <<. Often the execution order
is not important.
https://reviews.llvm.org/D24861
Files:
l
danielmarjamaki added a comment.
I updated the patch so it does not warn about 'A * B << C'. It's a simple fix.
I have not made careful measurements but I guess that the performance penalty
is acceptable.
https://reviews.llvm.org/D24861
___
cfe-co
Author: ioeric
Date: Wed Sep 28 06:02:16 2016
New Revision: 282577
URL: http://llvm.org/viewvc/llvm-project?rev=282577&view=rev
Log:
Merge conflicting replacements when they are order-independent.
Summary:
Now two replacements are considered order-independent if applying them in
either order prod
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282577: Merge conflicting replacements when they are
order-independent. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D24800?vs=72666&id=72799#toc
Repository:
rL LLVM
https
malcolm.parsons added a subscriber: malcolm.parsons.
Comment at: lib/AST/Expr.cpp:2868
@@ +2867,3 @@
+// When looking for potential side-effects, we assume that these
+// operators: assignment, increement and decrement are intended
+// to have a side-effect and other o
Author: a.sidorin
Date: Wed Sep 28 06:04:42 2016
New Revision: 282578
URL: http://llvm.org/viewvc/llvm-project?rev=282578&view=rev
Log:
ASTMerge: explicitly specify arch for GCCAsmStmt test to calm non-x86 buildbots
This should fix r282572.
Added:
cfe/trunk/test/ASTMerge/Inputs/asm-function.
danielmarjamaki updated this revision to Diff 72802.
danielmarjamaki added a comment.
Fix review comments
https://reviews.llvm.org/D24656
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tidy/readability/RedundantDeclarationCheck.cpp
cl
danielmarjamaki marked 3 inline comments as done.
Comment at: clang-tidy/readability/RedundantDeclarationCheck.cpp:39
@@ +38,3 @@
+ bool MultiVar = false;
+ if (const auto *VD = dyn_cast(D)) {
+if (VD && VD->getPreviousDecl()->getStorageClass() == SC_Extern &&
--
Author: eladcohen
Date: Wed Sep 28 06:59:09 2016
New Revision: 282581
URL: http://llvm.org/viewvc/llvm-project?rev=282581&view=rev
Log:
[X86] Remove the mm_malloc.h include guard hack from the X86 builtins tests
The X86 clang/test/CodeGen/*builtins.c tests define the mm_malloc.h include
guard as
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282581: [X86] Remove the mm_malloc.h include guard hack from
the X86 builtins tests (authored by eladcohen).
Changed prior to commit:
https://reviews.llvm.org/D24825?vs=72158&id=72805#toc
Repository:
eladcohen added a comment.
Thanks for the review! committed r282581.
Repository:
rL LLVM
https://reviews.llvm.org/D24825
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This is causing buildbot failure. I am working on a fix.
On Wed, Sep 28, 2016 at 1:11 PM Eric Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ioeric
> Date: Wed Sep 28 06:02:16 2016
> New Revision: 282577
>
> URL: http://llvm.org/viewvc/llvm-project?rev=282577&view=rev
> Log:
>
Abpostelnicu updated this revision to Diff 72806.
Abpostelnicu marked an inline comment as done.
Abpostelnicu added a comment.
corrected typo
https://reviews.llvm.org/D22910
Files:
include/clang/AST/ExprCXX.h
lib/AST/Expr.cpp
Index: lib/AST/Expr.cpp
dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.
Submitted in 282582.
https://reviews.llvm.org/D24628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
sdardis created this revision.
sdardis added reviewers: vkalintiris, zoran.jovanovic.
sdardis added a subscriber: cfe-commits.
Herald added a subscriber: sdardis.
This patch teaches clang to range check immediates for MIPS MSA instrincs. This
checking is done strictly in comparison to some existin
Author: ioeric
Date: Wed Sep 28 07:49:14 2016
New Revision: 282583
URL: http://llvm.org/viewvc/llvm-project?rev=282583&view=rev
Log:
Trying to buildbot failures caused by r282577.
Modified:
cfe/trunk/lib/Tooling/Core/Replacement.cpp
Modified: cfe/trunk/lib/Tooling/Core/Replacement.cpp
URL:
r282583 should fix this.
On Wed, Sep 28, 2016 at 2:14 PM Eric Liu wrote:
> This is causing buildbot failure. I am working on a fix.
>
> On Wed, Sep 28, 2016 at 1:11 PM Eric Liu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> Author: ioeric
> Date: Wed Sep 28 06:02:16 2016
> New Revisi
On Wed, Sep 28, 2016 at 2:58 PM Eric Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ioeric
> Date: Wed Sep 28 07:49:14 2016
> New Revision: 282583
>
> URL: http://llvm.org/viewvc/llvm-project?rev=282583&view=rev
> Log:
> Trying to buildbot failures caused by r282577.
>
A bit m
omtcyfz abandoned this revision.
omtcyfz added a comment.
Abandoning this, because https://reviews.llvm.org/rL282577, which introduces
replacement deduplication, eliminates this issue. Big thanks to Eric!
https://reviews.llvm.org/D24914
___
cfe-com
Decrementing "begin()" makes sanitizer sad. This fix makes sure "I" is
never decremented when it is the "begin".
On Wed, Sep 28, 2016 at 3:10 PM Manuel Klimek wrote:
> On Wed, Sep 28, 2016 at 2:58 PM Eric Liu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> Author: ioeric
> Date: Wed S
sebpop added inline comments.
Comment at: clang/lib/CodeGen/CGCXX.cpp:140-142
@@ +139,5 @@
+ // FIXME: An extern template instantiation will create functions with
+ // linkage "AvailableExternally". In libc++, some classes also define
+ // members with attribute "AlwaysInline"
ioeric added a comment.
Ping
https://reviews.llvm.org/D24380
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
wrmsr added a comment.
I just lost a few days diagnosing what wound up being this :(
In https://reviews.llvm.org/D23662#519445, @john.brawn wrote:
> Surely the fix then is to make sure CrashRecoveryContext::Disable //does//
> reinstall the right signal handler?
The fix is to not do this by de
coby created this revision.
coby added reviewers: echristo, delena.
coby added a subscriber: cfe-commits.
coby set the repository for this revision to rL LLVM.
Herald added a subscriber: mehdi_amini.
1. 'v' constraint for (x86) non-avx arch imitates the already implemented 'x'
constraint, i.e. al
bjope added a subscriber: bjope.
bjope added a comment.
This test/CodeGen/builtins-ppc-p9vector.c test will fail together with this
upcoming LLVM patch https://reviews.llvm.org/D24955
Problem is that lots of your
add i64 {{.*}}, 64
checks will fails since the improved analysis will find out
mharoush created this revision.
mharoush added reviewers: rnk, myatsina.
mharoush added a subscriber: cfe-commits.
mharoush set the repository for this revision to rL LLVM.
This patch is a compatibility fix for clang, matching GCC support for charter
escape when using extended in-line assembly (i
mharoush created this revision.
mharoush added reviewers: delena, myatsina, rnk, echristo.
mharoush added a subscriber: cfe-commits.
mharoush set the repository for this revision to rL LLVM.
Herald added a subscriber: mehdi_amini.
This patch enables usage of k registers in inline assembly syntax.
bjope added a comment.
In https://reviews.llvm.org/D24397#555121, @nemanjai wrote:
> In https://reviews.llvm.org/D24397#555057, @bjope wrote:
>
> > This test/CodeGen/builtins-ppc-p9vector.c test will fail together with this
> > upcoming LLVM patch https://reviews.llvm.org/D24955
> >
> > Problem
Author: ed
Date: Wed Sep 28 08:51:23 2016
New Revision: 282589
URL: http://llvm.org/viewvc/llvm-project?rev=282589&view=rev
Log:
Also use the proper register numbers on CloudABI.
Without this change applied, unw_step() fails to obtain the next frame
properly.
Modified:
libunwind/trunk/includ
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, ioeric, bkramer.
omtcyfz added subscribers: cfe-commits, aaron.ballman.
`add_new_check.py` didn't support Python 3.X for some reason, even though it
used `print` in Python 3.X-compatible way. With just a few tweaks
`add_new_check.py
hiraditya updated this revision to Diff 72827.
hiraditya added a comment.
Addressed Richard's comments.
https://reviews.llvm.org/D24682
Files:
clang/lib/CodeGen/CGCXX.cpp
clang/test/CodeGenCXX/alias-available-externally.cpp
Index: clang/test/CodeGenCXX/alias-available-externally.cpp
==
hiraditya marked 3 inline comments as done.
hiraditya added a comment.
https://reviews.llvm.org/D24682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, aaron.ballman, ioeric.
omtcyfz added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz, nemanjai.
C++ Core Guidelines Section "Expressions and statements" Suggestion 10 proposes
to split declarations with multiple na
hokein created this revision.
hokein added reviewers: klimek, bkramer.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Provide a way allowing clang clients to get the common build directory
from the compilation database.
https://reviews.llvm.org/D25027
Files:
include
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
A nice abstraction and cleanup. LGTM.
Comment at: lib/Driver/Driver.cpp:1625
@@ +1624,3 @@
+ // architecture. If we are in host-only mode we return 'success' so that
+
Author: emaste
Date: Wed Sep 28 10:37:21 2016
New Revision: 282599
URL: http://llvm.org/viewvc/llvm-project?rev=282599&view=rev
Log:
libunwind: Add OpenBSD case for _Unwind_Ptr typedef
Patch by Mark Kettenis
Modified:
libunwind/trunk/src/AddressSpace.hpp
Modified: libunwind/trunk/src/Addres
spatel added a subscriber: spatel.
spatel added a comment.
Having a clang regression/unit test that depends on optimizer behavior is
generally viewed as wrong. Can the tests be split into front-end (clang) tests
and separate tests for the IR optimizer? Both x86 and AArch64 have done
something l
vsk accepted this revision.
vsk added a reviewer: vsk.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
https://reviews.llvm.org/D24601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
akyrtzi added a comment.
> I could disable crash recovery by calling clang_toggleCrashRecovery(false)
> after clang_createIndex has been called but this doesn't work because the
> right JVM handler isn't reinstalled
Could you explain more why this doesn't work ? Is it a bug with the crash
han
nemanjai added a comment.
In https://reviews.llvm.org/D24397#555470, @spatel wrote:
> Having a clang regression/unit test that depends on optimizer behavior is
> generally viewed as wrong. Can the tests be split into front-end (clang)
> tests and separate tests for the IR optimizer? Both x86 an
spatel added a comment.
In https://reviews.llvm.org/D24397#52, @nemanjai wrote:
> In https://reviews.llvm.org/D24397#555470, @spatel wrote:
>
> > Having a clang regression/unit test that depends on optimizer behavior is
> > generally viewed as wrong. Can the tests be split into front-end (cl
spatel added a comment.
Should also mention:
https://reviews.llvm.org/D17999
has scripts attached that could make this kind of test generation a lot easier.
:)
Repository:
rL LLVM
https://reviews.llvm.org/D24397
___
cfe-commits mailing list
cfe-
Well, I don't know much about what Clang will actually do here, but I'll
follow your advice and add -O0 and pipe to opt -S -mem2reg. I'll also add a
test case in LLVM (test/CodeGen/PowerPC) that will test that after opt and
llc, we generate the desired code for these builtins.
Thanks Sanjay and Bj
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
https://reviews.llvm.org/D25024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
zaks.anna added inline comments.
Comment at: test/Analysis/copypaste/suspicious-clones.cpp:61
@@ -60,3 +60,3 @@
b /= a + b;
- c -= b * a; // expected-warning{{suspicious code clone detected; did you
mean to use 'a'?}}
+ c -= b * a; // expected-warning{{Suspicious code clone
mgehre added a comment.
I would like to close that particular bug report, and thus I would like to have
the reproducer of that bug as part of the test case.
The PositivePartiallyInClassInitialized is also a good test, but I fail to see
how it is proves that that particular bug is solved.
Are yo
Author: tra
Date: Wed Sep 28 12:47:35 2016
New Revision: 282609
URL: http://llvm.org/viewvc/llvm-project?rev=282609&view=rev
Log:
[CUDA] added __nvvm_atom_{sys|cta}_* builtins.
These builtins are available on sm_60+ GPU only.
Differential Revision: https://reviews.llvm.org/D24944
Modified:
rsmith added inline comments.
Comment at: clang/lib/CodeGen/CGCXX.cpp:170
@@ -170,3 +169,3 @@
// If we have a weak, non-discardable alias (weak, weak_odr), like an extern
// template instantiation or a dllexported class, avoid forming it on COFF.
We can no
Author: tra
Date: Wed Sep 28 12:47:40 2016
New Revision: 282610
URL: http://llvm.org/viewvc/llvm-project?rev=282610&view=rev
Log:
[CUDA] Added support for CUDA-8
Differential Revision: https://reviews.llvm.org/D24946
Added:
cfe/trunk/test/Driver/Inputs/CUDA/usr/local/cuda/nvvm/libdevice/lib
zaks.anna added inline comments.
Comment at: test/Analysis/copypaste/macros.cpp:8
@@ -7,3 +7,3 @@
-int foo(int a) { // expected-warning{{Detected code clone.}}
+int foo(int a) { // expected-warning{{Clones of this code were detected}}
a = a + 1;
- Duplicate c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282609: [CUDA] added __nvvm_atom_{sys|cta}_* builtins.
(authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D24944?vs=72584&id=72862#toc
Repository:
rL LLVM
https://reviews.llvm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282610: [CUDA] Added support for CUDA-8 (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D24946?vs=72707&id=72863#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24946
Files:
zaks.anna added inline comments.
Comment at: test/Analysis/copypaste/suspicious-clones.cpp:61
@@ -60,3 +60,3 @@
b /= a + b;
- c -= b * a; // expected-warning{{suspicious code clone detected; did you
mean to use 'a'?}}
+ c -= b * a; // expected-warning{{Suspicious code clone
mgehre added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.cpp:25
@@ -23,2 +24,3 @@
- Finder->addMatcher(cxxReinterpretCastExpr().bind("cast"), this);
+ std::vector Rules{"type", "type.1",
"cppcoreguidelines-pro-type-reinterpret-cast"};
bruno added a comment.
@rnk, do you have any concerns about this patch?
https://reviews.llvm.org/D24472
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgehre added a comment.
In the C++ Core Guidelines issue on namespaceing of the [[suppress]], it was
state that Microsoft uses
[[gsl::suppress]] and it is the intent to update the C++ Core Guidelines to
[[gsl::suppress]].
https://reviews.llvm.org/D24886
_
hfinkel added a comment.
The naming here is a bit hard to follow, we have 'dependent action',
'dependency action', 'depending action', and I think they're all supposed to
mean the same thing. Only 'dependent action' sounds right to me, can we use
that universally (i.e. in all comments and names
hfinkel added inline comments.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:163
@@ +162,3 @@
+def err_drv_expecting_fopenmp_with_fopenmp_targets : Error<
+ "The option -fopenmp-targets must be used in conjunction with a -fopenmp
option compatible with offloading.">;
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: jhen, cfe-commits.
https://reviews.llvm.org/D25036
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/include/clang/Sema/Sema.h
clang/lib/Sema/SemaCUDA.cpp
clang/lib/Sema/SemaExprCXX.cpp
cla
rmaprath added a comment.
@EricWF: Gentle ping.
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hfinkel added inline comments.
Comment at: lib/Driver/Driver.cpp:1836
@@ +1835,3 @@
+ActionBuilderReturnCode
+getDeviceDepences(OffloadAction::DeviceDependences &DA, phases::ID
CurPhase,
+ phases::ID FinalPhase, PhasesTy &Phases) override {
--
malcolm.parsons added a comment.
In https://reviews.llvm.org/D24848#555636, @mgehre wrote:
> Are you okay with me committing this as it currently is?
Yes.
https://reviews.llvm.org/D24848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/cppcoreguidelines/OneNamePerDeclarationCheck.cpp:26
@@ +25,3 @@
+
+} // end anonymous namespace
+
Namespace is inconsistent with following ones. It I'm not mistaken, **//
namespace** is prevailing form
hfinkel added inline comments.
Comment at: lib/Driver/Tools.cpp:243
@@ +242,3 @@
+// ignore inputs that refer to OpenMP offloading devices - they will be
+// embedded recurring to a proper linker script.
+if (auto *IA = II.getAction())
recurring -> acc
Author: rsmith
Date: Wed Sep 28 14:09:10 2016
New Revision: 282619
URL: http://llvm.org/viewvc/llvm-project?rev=282619&view=rev
Log:
Re-commit r282556, reverted in r282564, with a fix to CallArgList::addFrom to
function correctly when targeting MS ABIs (this appears to have never mattered
prior to
malcolm.parsons added a subscriber: malcolm.parsons.
Comment at: clang-tidy/cppcoreguidelines/OneNamePerDeclarationCheck.cpp:30
@@ +29,3 @@
+ Finder->addMatcher(
+ declStmt(declCountIsGreaterThan(1)).bind("multipleNameDeclaration"),
+ this);
Can declCou
hfinkel added inline comments.
Comment at: lib/Driver/ToolChains.cpp:2834
@@ +2833,3 @@
+ // If this tool chain is used for an OpenMP offloading device we have to make
+ // sure we always generate a shared library regardless the commands the user
+ // passed to the host. This i
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D21852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: rsmith
Date: Wed Sep 28 14:22:36 2016
New Revision: 282621
URL: http://llvm.org/viewvc/llvm-project?rev=282621&view=rev
Log:
Long-overdue update to cxx_status: C++14 is no longer "upcoming".
Modified:
cfe/trunk/www/cxx_status.html
Modified: cfe/trunk/www/cxx_status.html
URL:
http://
hfinkel added inline comments.
Comment at: include/clang/Driver/Action.h:504
@@ +503,3 @@
+ /// unbundling action.
+ struct DependingActionInfoTy final {
+/// \brief The tool chain of the depending action.
Don't need 'Ty' in the name of this struct.
===
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D21856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
omtcyfz updated this revision to Diff 72881.
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
Address couple comments.
https://reviews.llvm.org/D25024
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-ti
omtcyfz added inline comments.
Comment at: clang-tidy/cppcoreguidelines/OneNamePerDeclarationCheck.cpp:26
@@ +25,3 @@
+
+} // end anonymous namespace
+
Eugene.Zelenko wrote:
> Namespace is inconsistent with following ones. It I'm not mistaken, **//
> namespace**
1 - 100 of 171 matches
Mail list logo
