Re: [PATCH] D24903: [libcxx] [include] Declare __STDC_*_MACROS for C++11 compat in old libc

mgorny updated this revision to Diff 72441. https://reviews.llvm.org/D24903 Files: include/inttypes.h include/stdint.h Index: include/stdint.h === --- /dev/null +++ include/stdint.h @@ -0,0 +1,121 @@ +// -*- C++ -*- +//===--

Re: [PATCH] D24903: [libcxx] [include] Declare __STDC_*_MACROS for C++11 compat in old libc

mgorny marked an inline comment as done. mgorny added a comment. In https://reviews.llvm.org/D24903#551890, @rmaprath wrote: > When the `` headers where split into `` and `` headers in > https://reviews.llvm.org/D12747, we have left out `` and ``. > I was going to put up a patch to fix this but

Re: [PATCH] D24903: [libcxx] [include] Declare __STDC_*_MACROS for C++11 compat in old libc

mgorny added inline comments. Comment at: include/stdint.h:25 @@ +24,3 @@ +INT8_MAX +INT16_MAX +INT32_MAX Are you referring to the way __STDC_LIMIT_MACROS etc. is handled there? Or something more? https://reviews.llvm.org/D24903 _

[clang-tools-extra] r282386 - [clang-tidy] make readability-redundant-smartptr-get report get() usage in conditions

Author: omtcyfz Date: Mon Sep 26 02:22:37 2016 New Revision: 282386 URL: http://llvm.org/viewvc/llvm-project?rev=282386&view=rev Log: [clang-tidy] make readability-redundant-smartptr-get report get() usage in conditions This patch extends clang-tidy's readability-redundant-smartptr-get to produc

Re: [PATCH] D24893: [clang-tidy] make readability-redundant-smartptr-get report get() usage in conditions

This revision was automatically updated to reflect the committed changes. Closed by commit rL282386: [clang-tidy] make readability-redundant-smartptr-get report get() usage in… (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D24893?vs=72422&id=72442#toc Repository: r

[clang-tools-extra] r282388 - [clang-rename] Use checktime when reloading vim buffer after applying clang-rename

Author: omtcyfz Date: Mon Sep 26 02:26:32 2016 New Revision: 282388 URL: http://llvm.org/viewvc/llvm-project?rev=282388&view=rev Log: [clang-rename] Use checktime when reloading vim buffer after applying clang-rename After applying `clang-rename` to a vim buffer (using `clang-rename.py` as part

Re: [PATCH] D24791: Use checktime when reloading vim buffer after applying clang-rename

This revision was automatically updated to reflect the committed changes. Closed by commit rL282388: [clang-rename] Use checktime when reloading vim buffer after applying clang… (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D24791?vs=72011&id=72443#toc Repository:

Re: [PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

bmharper updated this revision to Diff 72444. bmharper added a comment. This revision merges NestingLevel and IndentLevel into an std::pair, as suggested by @djasper. IMO this makes the code slightly harder to read, because you lose the unique variable names "IndentLevel" and "NestingLevel". Tho

Re: [PATCH] D24380: [migrate-tool] Framework for a codebase-dependent migration tool.

klimek added inline comments. Comment at: migrate-tool/AffectedFilesFinder.h:24-25 @@ +23,4 @@ +public: + // Get all files that need to be updated when a symbol is renamed and/or + // moved. + virtual llvm::Expected> Comment a bit on what the contract here is:

[PATCH] D24905: Fix unreachable code false positive, vardecl in switch

danielmarjamaki created this revision. danielmarjamaki added subscribers: cfe-commits, NoQ, zaks.anna, a.sidorin, xazax.hun. danielmarjamaki set the repository for this revision to rL LLVM. This patch fixes false positives for vardecls that are technically unreachable but they are needed. ```

Re: [PATCH] D24903: [libcxx] [include] Declare __STDC_*_MACROS for C++11 compat in old libc

rmaprath added a comment. In https://reviews.llvm.org/D24903#551926, @mgorny wrote: > I'm sorry but could you be a little more specific, please? I've looked into > that diff, and it seems that the cstdint resembles e.g. cinttypes already -- > i.e. there's only the include, and 'using' lines the

Re: [PATCH] D24903: [libcxx] [include] Declare __STDC_*_MACROS for C++11 compat in old libc

rmaprath added a comment. In https://reviews.llvm.org/D24903#551938, @mgorny wrote: > I see that libcxx already has a pretty complete test for stdint.h. Hmm, now I see that too :) Thanks for the patch. / Asiri https://reviews.llvm.org/D24903 __

Re: [PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris added inline comments. Comment at: lib/Driver/Tools.cpp:4777-4780 @@ +4776,6 @@ +{ + std::string Feature(XRayInstrumentOption); + Feature += " on "; + Feature += Triple.getArchName().data(); + D.Diag(diag::err_drv_clang_unsupported) << Feature; +

Re: [PATCH] D24848: [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init with in-class initializers

malcolm.parsons added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:372 @@ +371,3 @@ + +struct Bug30487 +{ There's already this test: ``` struct NegativeInClassInitialized { int F = 0; NegativeInClassInitialized

Re: [PATCH] D24905: Fix unreachable code false positive, vardecl in switch

danielmarjamaki updated this revision to Diff 72455. danielmarjamaki added a comment. Minor updates of testcase Repository: rL LLVM https://reviews.llvm.org/D24905 Files: lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp test/Analysis/unreachable-code-path.c Index: test/Analysis/un

[PATCH] D24907: NFC: separate file for fp denormal regression tests

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: rengolin, jmolloy, olista01. SjoerdMeijer added a subscriber: cfe-commits. For clarity, this moves checks for -fdenormal-fp-math values from fast-math.c to a new separate file. https://reviews.llvm.org/D24907 Files: test/Driver

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

Hi Eric, Ping... On 19-Sep-16 13:57, Eric Fiselier wrote: I'll look at these first thing next week. If you remember please ping me. (It's Cppcon this week) Sorry I haven't reviewed this already. Thank you for working on this. On Sep 18, 2016 11:55 PM, "Igor Kudrin"

Re: [PATCH] D24759: [RFC][StaticAnalyser] fix unreachable code false positives when block numbers mismatch

danielmarjamaki added inline comments. Comment at: lib/Analysis/CFG.cpp:2986 @@ -2985,3 +2985,1 @@ -if (!KnownVal.isFalse()) { - // Add an intermediate block between the BodyBlock and the dcoughlin wrote: > You need to keep this check so that the optimi

Re: [PATCH] D24759: [RFC][StaticAnalyser] fix unreachable code false positives when block numbers mismatch

danielmarjamaki updated this revision to Diff 72461. danielmarjamaki marked 2 inline comments as done. danielmarjamaki added a comment. Fixed review comments by Devin. It works better now! https://reviews.llvm.org/D24759 Files: lib/Analysis/CFG.cpp test/Analysis/unreachable-code-path.c Ind

[PATCH] D24909: fix for not copying fp denormal and trapping options.

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: rengolin, jmolloy, olista01. SjoerdMeijer added a subscriber: cfe-commits. This is a fix for not copying fp denormal and trapping options, and depends on the nfc cleanups in D24906 and D24907. https://reviews.llvm.org/D24909 File

r282400 - update the link to the code coverage

Author: sylvestre Date: Mon Sep 26 07:53:53 2016 New Revision: 282400 URL: http://llvm.org/viewvc/llvm-project?rev=282400&view=rev Log: update the link to the code coverage Modified: cfe/trunk/www/menu.html.incl Modified: cfe/trunk/www/menu.html.incl URL: http://llvm.org/viewvc/llvm-project

r282402 - In the get started page, also explain how to start the testsuite

Author: sylvestre Date: Mon Sep 26 08:22:34 2016 New Revision: 282402 URL: http://llvm.org/viewvc/llvm-project?rev=282402&view=rev Log: In the get started page, also explain how to start the testsuite Modified: cfe/trunk/www/get_started.html Modified: cfe/trunk/www/get_started.html URL: htt

Re: [PATCH] D24652: [clang-tidy] readability-avoid-const-params-in-decls template instantiation bugfix

malcolm.parsons updated this revision to Diff 72476. malcolm.parsons added a comment. Expand code comment https://reviews.llvm.org/D24652 Files: clang-tidy/readability/AvoidConstParamsInDecls.cpp test/clang-tidy/readability-avoid-const-params-in-decls.cpp Index: test/clang-tidy/readability

Re: [PATCH] D24652: [clang-tidy] readability-avoid-const-params-in-decls template instantiation bugfix

malcolm.parsons added inline comments. Comment at: clang-tidy/readability/AvoidConstParamsInDecls.cpp:39 @@ -38,2 +38,3 @@ // generate a non-definition FunctionDecl too. Ignore those. - unless(cxxMethodDecl(ofClass(cxxRecordDecl(isLambda()

Re: [PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge added inline comments. Comment at: lib/Driver/Tools.cpp:4777-4780 @@ +4776,6 @@ +{ + std::string Feature(XRayInstrumentOption); + Feature += " on "; + Feature += Triple.getArchName().data(); + D.Diag(diag::err_drv_clang_unsupported) << Feature; +

Re: [PATCH] D24669: {Sema] Gcc compatibility of vector shift.

aaron.ballman added a comment. In https://reviews.llvm.org/D24669#548984, @vbyakovlcl wrote: > Clang 3.8 balances vector shift operand erroneous using CheckVectorOperands > which converts one of operand to the type of another. In > https://reviews.llvm.org/D21678 it was fixed by using checkVect

Re: [PATCH] D24444: [clang-tidy] modernize-use-default default constructor bugfix

malcolm.parsons added a comment. ping https://reviews.llvm.org/D2 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24800: Merge conflicting replacements when they are order-independent.

ioeric added a comment. Friendly ping :) https://reviews.llvm.org/D24800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24862: Workaround ASTMatcher crashes. Added some more test cases.

aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Comment at: change-namespace/ChangeNamespace.cpp:279-281 @@ -276,3 +278,5 @@ Finder->addMatche

Re: [PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

rmaprath updated this revision to Diff 72478. rmaprath added a comment. Use `__internal_linkage__` attribute to control visibility following https://reviews.llvm.org/D24642. https://reviews.llvm.org/D24864 Files: include/__cxxabi_config.h src/config.h src/cxa_exception.cpp src/cxa_exce

Re: [PATCH] D24444: [clang-tidy] modernize-use-default default constructor bugfix

alexfh accepted this revision. alexfh added a reviewer: alexfh. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! https://reviews.llvm.org/D2 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

Re: [PATCH] D24278: [analyzer] Extend bug reports with extra notes.

NoQ updated this revision to Diff 72480. NoQ added a comment. This diff is a part of the original diff that contains core changes without checker changes (in particular, without tests). No changes were made, no comments addressed, just removed checker stuff. Uploading it separately so that it w

Re: [PATCH] D24652: [clang-tidy] readability-avoid-const-params-in-decls template instantiation bugfix

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D24652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D24914: [clang-rename] Do not print out error message upon encountering multiple replacements in the same SourceLocation.

omtcyfz created this revision. omtcyfz added a reviewer: alexfh. omtcyfz added a subscriber: cfe-commits. `clang-rename` might sometimes have multiple replacements at one SourceLocation, both trying to perform the same renaming. While this issue should be addressed properly at some point, for no

Re: [PATCH] D24887: [clang-tidy] cert-err58-cpp should not apply to function scope objects

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Good catch, I will fix up the CERT rule to match the check accordingly. Thank you for this! https://reviews.llvm.org/D24887 ___

[PATCH] D24915: [analyzer] Extend bug reports with extra notes - ObjCDeallocChecker

NoQ created this revision. NoQ added reviewers: zaks.anna, dcoughlin. NoQ added a subscriber: cfe-commits. This patch applies the bug reporting technique that is being introduced in D24278 to ObjCDeallocChecker. Extra notes highlight instance variable or property declarations that are of relevan

[PATCH] D24916: [analyzer] Extend bug reports with extra notes - CloneChecker

NoQ created this revision. NoQ added reviewers: zaks.anna, dcoughlin, v.g.vassilev, teemperor. NoQ added a subscriber: cfe-commits. This patch applies the bug reporting technique that is being introduced in D24278 to CloneChecker. Extra notes highlight cloned code sections. Examples of HTML repo

Re: [PATCH] D24444: [clang-tidy] modernize-use-default default constructor bugfix

malcolm.parsons added a comment. I don't have commit access, so please commit this and https://reviews.llvm.org/D24652 for me. Thanks. https://reviews.llvm.org/D2 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [PATCH] D24887: [clang-tidy] cert-err58-cpp should not apply to function scope objects

malcolm.parsons added a comment. I don't have commit access, so please commit it for me. Thanks. https://reviews.llvm.org/D24887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24917: Resolve response file names relative to including file

sepavloff created this revision. sepavloff added a reviewer: rnk. sepavloff added a subscriber: cfe-commits. If a response file included by construct @file itself includes a response file and that file is specified by relative file name, resolve the name relative to the including file. With this

[clang-tools-extra] r282409 - Silence a false positive with the cert-err58-cpp check; now allows objects with static or thread storage duration at function block scope.

Author: aaronballman Date: Mon Sep 26 10:00:45 2016 New Revision: 282409 URL: http://llvm.org/viewvc/llvm-project?rev=282409&view=rev Log: Silence a false positive with the cert-err58-cpp check; now allows objects with static or thread storage duration at function block scope. Patch by Malcolm P

Re: [PATCH] D24887: [clang-tidy] cert-err58-cpp should not apply to function scope objects

aaron.ballman closed this revision. aaron.ballman added a comment. Commit in r282409 https://reviews.llvm.org/D24887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23236: When ARC is enabled, no warning will be generated when a method1. Returns 'nil' in a method that is attributed to return a 'nonnull'2. The return-statement is a ConditionalOperator

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please wait for @dcoughlin or @ahatanak to chime in as well. https://reviews.llvm.org/D23236 ___ cfe-commits mailing list

r282410 - clang-format: Only special-case top-level */& in multivar-declstmts.

Author: djasper Date: Mon Sep 26 10:14:24 2016 New Revision: 282410 URL: http://llvm.org/viewvc/llvm-project?rev=282410&view=rev Log: clang-format: Only special-case top-level */& in multivar-declstmts. Before (even with PointerAlignment: Left): vector a, b; After: vector a, b; Modified:

r282411 - [analyzer] Improve CastToStruct checker so it can also detect widening casts of struct data

Author: danielmarjamaki Date: Mon Sep 26 10:17:18 2016 New Revision: 282411 URL: http://llvm.org/viewvc/llvm-project?rev=282411&view=rev Log: [analyzer] Improve CastToStruct checker so it can also detect widening casts of struct data Example: struct AB { int A; int B; }; struct ABC { int

Re: [PATCH] D24903: [libcxx] [include] Declare __STDC_*_MACROS for C++11 compat in old libc

mgorny updated this revision to Diff 72492. https://reviews.llvm.org/D24903 Files: include/inttypes.h include/stdint.h Index: include/stdint.h === --- /dev/null +++ include/stdint.h @@ -0,0 +1,132 @@ +// -*- C++ -*- +//===--

Re: [PATCH] D24903: [libcxx] [include] Declare __STDC_*_MACROS for C++11 compat in old libc

mgorny added a comment. @EricWF, I've copied the additional unset logic from clang. Does this address all of your concerns? By the way, I think clang misses __STDC_FORMAT_MACROS for inttypes.h. I'll write a patch for that as well, for consistency. https://reviews.llvm.org/D24903 __

Re: [PATCH] D24886: Add [[clang::suppress(rule, ...)]] attribute

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. I'm generally in favor of this patch, but it's missing some pieces, like test cases. Also, I suspect we will want this attribute to also be written on types, but there

[PATCH] D24921: [PATCH] [Headers] Fix inttypes.h macros visibility in C++ with C99-compliant libc

mgorny created this revision. mgorny added a reviewer: rsmith. mgorny added a subscriber: cfe-commits. Define `__STDC_FORMAT_MACROS` in order to enable all macros defined by inttypes.h in C++ mode, as was required by the C99 standard and was enforced by multiple old glibc versions. This extends

Re: [PATCH] D24921: [PATCH] [Headers] Fix inttypes.h macros visibility in C++ with C99-compliant libc

mgorny added a comment. By the way, if anyone happens to have a 'more final' copy of the standards handy, feel free to provide a more consistent footnote numbers ;-). https://reviews.llvm.org/D24921 ___ cfe-commits mailing list cfe-commits@lists.ll

Re: [PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:377 @@ +376,3 @@ +else if (type->isIntegerType()) + Initializer = " = 0"; +else if (type->isFloatingType()) What about cases where a s

Re: [PATCH] D24888: [clang-tidy] Use [[clang::suppress]] with cppcoreguidelines-pro-type-reinterpret-cast

aaron.ballman added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.cpp:25 @@ -23,2 +24,3 @@ - Finder->addMatcher(cxxReinterpretCastExpr().bind("cast"), this); + std::vector Rules{"type", "type.1", "cppcoreguidelines-pro-type-reinterpret-

Re: [PATCH] D24848: [clang-tidy] fix false-positive for cppcoreguidelines-pro-type-member-init with in-class initializers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with Malcom's test suggestions addressed. https://reviews.llvm.org/D24848 ___ cfe-commits mailing list cfe-commits@lists.llvm.

Re: [PATCH] D24821: [ASTMatcher] Add isStaticStorageClass matcher for varDecl and functionDecl.

This revision was automatically updated to reflect the committed changes. Closed by commit rL282415: [ASTMatcher] Add isStaticStorageClass matcher for varDecl and functionDecl. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D24821?vs=72141&id=72502#toc Repository: rL

r282415 - [ASTMatcher] Add isStaticStorageClass matcher for varDecl and functionDecl.

Author: hokein Date: Mon Sep 26 11:01:52 2016 New Revision: 282415 URL: http://llvm.org/viewvc/llvm-project?rev=282415&view=rev Log: [ASTMatcher] Add isStaticStorageClass matcher for varDecl and functionDecl. Reviewers: klimek Subscribers: cfe-commits, klimek Differential Revision: https://revi

Re: [PATCH] D24914: [clang-rename] Do not print out error message upon encountering multiple replacements in the same SourceLocation.

arphaman added a subscriber: arphaman. Comment at: clang-rename/RenamingAction.cpp:75 @@ +74,3 @@ + // has been matched multiple times (which shouldn't happen in reality, + // need to fix that) or when it's a specific header. For now, just ingore + // there error th

Re: [PATCH] D24821: [ASTMatcher] Add isStaticStorageClass matcher for varDecl and functionDecl.

aaron.ballman added a subscriber: aaron.ballman. Comment at: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h:3391 @@ +3390,3 @@ +/// \brief Matches variable/function declarations that have static storage class +/// (with "static" key word) written in the source. +/// --

[PATCH] D24922: [clang-move] Make it support both relative and absolute file path arguments.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D24922 Files: clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/ClangMoveMain.cpp test/clang-move/Inputs/database_template.json test/clang-move/I

Re: [PATCH] D24820: Add -stats-stats option

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks Matthias LGTM! Repository: rL LLVM https://reviews.llvm.org/D24820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

Re: [PATCH] D24821: [ASTMatcher] Add isStaticStorageClass matcher for varDecl and functionDecl.

hokein added inline comments. Comment at: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h:3391 @@ +3390,3 @@ +/// \brief Matches variable/function declarations that have static storage class +/// (with "static" key word) written in the source. +/// aaron.ballma

Re: [PATCH] D24516: [Driver][Diagnostics] Make 'show option names' default for driver warnings

bruno added a comment. Ping https://reviews.llvm.org/D24516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24361: hasDeclaration(qualType(...)) matcher should unwrap ElaboratedType and TemplateSpecializationType

lukasza added inline comments. Comment at: unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:2119 @@ +2118,3 @@ + "template \n" + "void Function(Namespace::Template param) {\n" + " param.Method();\n" klimek wrote: > Given your use case: why do we

[PATCH] D24928: [ASTMatcher] Clarify isStaticStorageClass and hasStaticStorageDuration documents.

hokein created this revision. hokein added a reviewer: aaron.ballman. hokein added a subscriber: cfe-commits. Herald added a subscriber: klimek. https://reviews.llvm.org/D24928 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchers

Re: [PATCH] D24914: [clang-rename] Do not print out error message upon encountering multiple replacements in the same SourceLocation.

omtcyfz updated this revision to Diff 72511. omtcyfz marked 2 inline comments as done. omtcyfz added a comment. Address two comments. https://reviews.llvm.org/D24914 Files: clang-rename/RenamingAction.cpp Index: clang-rename/RenamingAction.cpp

Re: [PATCH] D24914: [clang-rename] Do not print out error message upon encountering multiple replacements in the same SourceLocation.

omtcyfz added a comment. @arphaman, thank you for the comments! Improved the wording. https://reviews.llvm.org/D24914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24669: {Sema] Gcc compatibility of vector shift.

vbyakovlcl added inline comments. Comment at: llvm/tools/clang/include/clang/Basic/DiagnosticGroups.td:522 @@ -521,2 +521,3 @@ def GNUZeroVariadicMacroArguments : DiagGroup<"gnu-zero-variadic-macro-arguments">; +def GNUVecElemSize : DiagGroup<"gnu-vec-elem-size">; def Fallback

Re: [PATCH] D24928: [ASTMatcher] Clarify isStaticStorageClass and hasStaticStorageDuration documents.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the clarifications! Comment at: include/clang/ASTMatchers/ASTMatchers.h:3395 @@ -3392,1 +3394,3 @@ +/// \brief Matches variable/function decl

r282417 - Complete support for the cxxCtorInitializer() AST matcher so that it can be used as a top-level matcher.

Author: aaronballman Date: Mon Sep 26 12:04:27 2016 New Revision: 282417 URL: http://llvm.org/viewvc/llvm-project?rev=282417&view=rev Log: Complete support for the cxxCtorInitializer() AST matcher so that it can be used as a top-level matcher. Modified: cfe/trunk/include/clang/ASTMatchers/AS

Re: [PATCH] D24874: Fully implement the matcher for CXXCtorInitializer

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! Commit in r282417 https://reviews.llvm.org/D24874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24278: [analyzer] Extend bug reports with extra notes.

NoQ updated this revision to Diff 72519. NoQ marked 10 inline comments as done. NoQ added a comment. Addressed inline comments. Renamed extra notes to notes. https://reviews.llvm.org/D24278 Files: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h include/clang/StaticAnalyzer/Core/BugRepor

Re: [PATCH] D24915: [analyzer] Extend bug reports with extra notes - ObjCDeallocChecker

NoQ updated this revision to Diff 72520. NoQ added a comment. Addressed two inline comments by Devin in the original review https://reviews.llvm.org/D24278. Rebased on top of the updated https://reviews.llvm.org/D24278. https://reviews.llvm.org/D24915 Files: lib/StaticAnalyzer/Checkers/Chec

Re: [PATCH] D24813: Driver: Add a test for triple with opencl environment

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D24813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [PATCH] D24916: [analyzer] Extend bug reports with extra notes - CloneChecker

NoQ updated this revision to Diff 72521. NoQ added a comment. Addressed inline comments on the original review https://reviews.llvm.org/D24278. Rebased on top of the updated https://reviews.llvm.org/D24278. Changed warning messages completely according to Anna's comments in https://reviews.llvm

[PATCH] D24932: Fix PR 30440

arphaman created this revision. arphaman added a reviewer: DmitryPolukhin. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch fixes PR 30440 by initializing CXXNameMangler's FunctionTypeDepth in the two constructors added in r274222 (The

[PATCH] D24933: Enable configuration files in clang

sepavloff created this revision. sepavloff added reviewers: rnk, ddunbar. sepavloff added a subscriber: cfe-commits. The implementation follows the discussion in mail list (http://lists.llvm.org/pipermail/cfe-dev/2016-September/050776.html). Main part of the config file support is implemented in l

Re: [PATCH] D24862: Workaround ASTMatcher crashes. Added some more test cases.

hokein accepted this revision. hokein added a comment. LGTM. https://reviews.llvm.org/D24862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24864: [libcxxabi] Refactor pthread usage into a separate API

compnerd added inline comments. Comment at: src/config.h:41 @@ +40,3 @@ +defined(__CloudABI__) || \ +defined(__sun__) +# define _LIBCXXABI_HAS_THREAD_API_PTHREAD Can you change this to `defined(__sun__) && defined(_POSIX_THREADS)` at the very least? The

Re: [PATCH] D24916: [analyzer] Extend bug reports with extra notes - CloneChecker

v.g.vassilev added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CloneChecker.cpp:102 @@ -95,5 +101,3 @@ // as a note. -DiagEngine.Report(Group.Sequences.front().getStartLoc(), WarnID); -for (unsigned i = 1; i < Group.Sequences.size(); ++i) { - DiagEng

r282426 - CC1: Add -save-stats option

Author: matze Date: Mon Sep 26 13:53:34 2016 New Revision: 282426 URL: http://llvm.org/viewvc/llvm-project?rev=282426&view=rev Log: CC1: Add -save-stats option This option behaves in a similar spirit as -save-temps and writes internal llvm statistics in json format to a file. Differential Revisi

Re: [PATCH] D24820: Add -stats-stats option

This revision was automatically updated to reflect the committed changes. Closed by commit rL282426: CC1: Add -save-stats option (authored by matze). Changed prior to commit: https://reviews.llvm.org/D24820?vs=72376&id=72532#toc Repository: rL LLVM https://reviews.llvm.org/D24820 Files: c

Re: r282426 - CC1: Add -save-stats option

Nice! -Hal - Original Message - > From: "Matthias Braun via cfe-commits" > To: cfe-commits@lists.llvm.org > Sent: Monday, September 26, 2016 1:53:34 PM > Subject: r282426 - CC1: Add -save-stats option > > Author: matze > Date: Mon Sep 26 13:53:34 2016 > New Revision: 282426 > > URL: h

Re: [PATCH] D24933: Enable configuration files in clang

ddunbar added a comment. I am too out of the loop on Clang development to be able to comment on the specific direction, but I will just say that I am highly in favor of adding new features in this direction. Thank you! https://reviews.llvm.org/D24933

Re: [PATCH] D24932: Fix PR 30440

DmitryPolukhin added a comment. LGTM, added Richard in case he has something to add. Repository: rL LLVM https://reviews.llvm.org/D24932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

mstorsjo added a comment. Ping, can someone commit this one now? https://reviews.llvm.org/D24609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24886: Add [[clang::suppress(rule, ...)]] attribute

rsmith added a comment. Giving this the name `[[clang::suppress(...)]]` seems unhelpful. This attribute is specified by the C++ core guidelines, not by clang, and presumably we want code using this attribute to be portable across implementations of the C++ code guidelines. I'd suggest asking th

Re: [PATCH] D24886: Add [[clang::suppress(rule, ...)]] attribute

aaron.ballman added a comment. In https://reviews.llvm.org/D24886#552859, @rsmith wrote: > Giving this the name `[[clang::suppress(...)]]` seems unhelpful. This > attribute is specified by the C++ core guidelines, not by clang, and > presumably we want code using this attribute to be portable a

Re: [PATCH] D24903: [libcxx] [include] Declare __STDC_*_MACROS for C++11 compat in old libc

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Please remove the `LIBCXX` macros before committing. Comment at: include/stdint.h:118 @@ +117,3 @@ +# define __STDC_CONSTANT_MACROS +# define __STDC_CONSTANT_MACROS_

Re: [PATCH] D17979: [OPENMP] Add regression test for codegen of distribute pragma for NVPTX

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. Repository: rL LLVM https://reviews.llvm.org/D17979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D17890: [OpenMP][NVPTX][CUDA] Adding support for printf for an NVPTX OpenMP device.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D17890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D17840: [OPENMP] Private, firstprivate, and lastprivate clauses for distribute, host code generation

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. Repository: rL LLVM https://reviews.llvm.org/D17840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D24903: [libcxx] [include] Declare __STDC_*_MACROS for C++11 compat in old libc

mgorny added a comment. Ok. Thanks for the review. https://reviews.llvm.org/D24903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r282435 - [include] Declare __STDC_*_MACROS for C++11 compat in old libc

Author: mgorny Date: Mon Sep 26 15:20:00 2016 New Revision: 282435 URL: http://llvm.org/viewvc/llvm-project?rev=282435&view=rev Log: [include] Declare __STDC_*_MACROS for C++11 compat in old libc Declare __STDC_FORMAT_MACROS, __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS before including real in

Re: [PATCH] D24903: [libcxx] [include] Declare __STDC_*_MACROS for C++11 compat in old libc

This revision was automatically updated to reflect the committed changes. Closed by commit rL282435: [include] Declare __STDC_*_MACROS for C++11 compat in old libc (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D24903?vs=72492&id=72552#toc Repository: rL LLVM https:

Re: [PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

andriigrynenko added inline comments. Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:176-199 @@ -164,7 +175,26 @@ ret += Run(argc - 1, 0, stack); +// CHECK: Child stack: [[CHILD_STACK:0x[0-9a-f]*]] +// CHECK: Main context from: [[CHILD_STACK]] 524288

Re: [PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D17469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge updated this revision to Diff 72554. rSerge added a comment. Implemented a workaround for XFAIL not differentiating between `x86` and `x86_64` because it searches for a substring in the triple string, thus `x86` matches both `x86-X-Y-Z` and `x86_64-X-Y-Z`. https://reviews.llvm.org/D2479

Re: [PATCH] D24820: Add -stats-stats option

MatzeB added inline comments. Comment at: test/Driver/save-stats.c:12 @@ +11,3 @@ +// RUN: %clang -target x86_64-apple-darwin -save-stats=obj -c -o obj/dir/save-stats.o %s -### 2>&1 | FileCheck %s -check-prefix=CHECK-OBJ +// CHECK-OBJ: "-stats-file=obj/dir{{/|}}save-stats.sta

r282438 - Fix test on windows

Author: matze Date: Mon Sep 26 15:48:34 2016 New Revision: 282438 URL: http://llvm.org/viewvc/llvm-project?rev=282438&view=rev Log: Fix test on windows Modified: cfe/trunk/test/Driver/save-stats.c Modified: cfe/trunk/test/Driver/save-stats.c URL: http://llvm.org/viewvc/llvm-project/cfe/trun

Re: [PATCH] D17469: [libcxx] Add deployment knobs to tests (for Apple platforms)

Correct. I haven't had a chance to get back to this. I'm aiming to pick it up again in the next week or two, but if this is specifically blocking you, feel free to rebase and commit on my behalf. > On 2016-Sep-26, at 13:39, Eugene Zelenko wrote: > > Eugene.Zelenko added a subscriber: Eugene.

Re: [PATCH] D17815: [libc++abi] Use fallback_malloc to allocate __cxa_eh_globals in case of dynamic memory exhaustion.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after addressing the inline comments. Comment at: src/fallback_malloc.cpp:58 @@ +57,3 @@ + +#define HEAP_SIZE 512 +char heap [ HEAP_SIZE ]; A static co

  1   2   >