klimek added inline comments. ================ Comment at: migrate-tool/AffectedFilesFinder.h:24-25 @@ +23,4 @@ +public: + // Get all files that need to be updated when a symbol is renamed and/or + // moved. + virtual llvm::Expected<std::vector<std::string>> ---------------- Comment a bit on what the contract here is: will these be absolute or relative paths?
================ Comment at: migrate-tool/BuildManager.h:28 @@ +27,3 @@ + + // Adds a new dependency to the build target. + virtual bool addDependency(llvm::StringRef BuildTarget, ---------------- I think this needs more comments explaining what BuildTarget / Dependency will be. Similarly for Name above. ================ Comment at: migrate-tool/DummyMigrationEnvironment.h:18-20 @@ +17,5 @@ + +// Creates a dummy migration environment whose components do not perform actual +// work and only print messages. +std::unique_ptr<MigrationEnvironment> createDummyMigrationEnvironment(); + ---------------- Do we perhaps want to create fakes here, where we can later query the libraries / dependencies that exist? https://reviews.llvm.org/D24380 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
