Re: [PATCH] D23452: [OpenCL] Release 3.9 notes

2016-08-12 Thread Hans Wennborg via cfe-commits
hans added a comment. In https://reviews.llvm.org/D23452#514110, @Anastasia wrote: > Thanks! Is there a way to check the doc before committing? I am not sure how > to make the html generated out of this. I build the docs like this: cmake -GNinja -DLLVM_ENABLE_SPHINX=ON -DLLVM_BUILD_DOCS=ON

Re: [PATCH] D23429: [CUDA] Place GPU binary into .nv_fatbin section and align it by 8.

2016-08-12 Thread Artem Belevich via cfe-commits
This revision was automatically updated to reflect the committed changes. tra marked an inline comment as done. Closed by commit rL278549: [CUDA] Place GPU binary into .nv_fatbin section and align it by 8. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D23429?vs=67851&id=6

r278549 - [CUDA] Place GPU binary into .nv_fatbin section and align it by 8.

2016-08-12 Thread Artem Belevich via cfe-commits
Author: tra Date: Fri Aug 12 13:44:01 2016 New Revision: 278549 URL: http://llvm.org/viewvc/llvm-project?rev=278549&view=rev Log: [CUDA] Place GPU binary into .nv_fatbin section and align it by 8. This matches the way nvcc encapsulates GPU binaries into host object file. Now cuobjdump can deal wi

[clang-tools-extra] r278553 - [clang-tidy] MPIBufferDerefCheck

2016-08-12 Thread Alexander Droste via cfe-commits
Author: alexander_droste Date: Fri Aug 12 14:30:31 2016 New Revision: 278553 URL: http://llvm.org/viewvc/llvm-project?rev=278553&view=rev Log: [clang-tidy] MPIBufferDerefCheck ... This check verifies if a buffer passed to an MPI (Message Passing Interface) function is sufficiently dereferenced. B

Re: [PATCH] D22729: MPIBufferDerefCheck for Clang-Tidy

2016-08-12 Thread Alexander Droste via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL278553: [clang-tidy] MPIBufferDerefCheck (authored by Alexander_Droste). Changed prior to commit: https://reviews.llvm.org/D22729?vs=66971&id=67884#toc Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D23462: Emit debug info for abstract classes if they are imported from a DLL

2016-08-12 Thread Adrian McCarthy via cfe-commits
amccarth created this revision. amccarth added a reviewer: rnk. amccarth added a subscriber: cfe-commits. With -debug-info-kind=limited, we omit debug info for abstract classes that live in other TUs. This reduces duplicate type information. When statically linked, the type information comes t

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

2016-08-12 Thread Yaxun Liu via cfe-commits
yaxunl added a comment. Actually we need to assume ndrange_t is a user defined typedef instead of struct due to the way its used in the spec, e.g. void f(ndrange_t x); instead of void f(struct ndrange_t x); Then it may be a little bit tricky to decide whether a type is ndrange_t type. An

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

2016-08-12 Thread Yaxun Liu via cfe-commits
yaxunl added a comment. How about we decide if a type is ndrange_t type based on their canonical types. If the canonical type of type X is the same as the canonical type of ndrange_t type, then type X is treated as ndrange_t type. Is this reasonable? Repository: rL LLVM https://reviews.llvm

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

2016-08-12 Thread Zachary Turner via cfe-commits
zturner added a comment. This is starting to get fairly difficult, and I'm afraid it may require someone more knowledgable about clang-format's internals than me. I wrote a test to have it use a fixed compilation database, and I was able to make that test pass, but it breaks many other tests.

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

2016-08-12 Thread Zachary Turner via cfe-commits
zturner updated this revision to Diff 67915. zturner added a comment. Update with changes needed to make fixed compilation database work (which also breaks many other tests) https://reviews.llvm.org/D23455 Files: include/clang/Tooling/CompilationDatabase.h lib/Tooling/CommonOptionsParser.c

[PATCH] D23471: [Documentation] Improve checks groups descriptions in clang-tidy/index.rst

2016-08-12 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Use table to avoid tautology. List all existing checks groups. Use alphabetical order. Rece

[PATCH] D23476: Allow manual specification of the binary directory in check_clang_tidy.py

2016-08-12 Thread Zachary Turner via cfe-commits
zturner created this revision. zturner added reviewers: alexfh, djasper. zturner added a subscriber: cfe-commits. When you run the script from lit it starts in the right directory so it can find `FileCheck` and `clang-tidy`, but when you manually run `check-clang-tidy.py` from a command line it

[libcxxabi] r278579 - Fix ASAN failures in the demangler

2016-08-12 Thread Mehdi Amini via cfe-commits
Author: mehdi_amini Date: Fri Aug 12 19:02:33 2016 New Revision: 278579 URL: http://llvm.org/viewvc/llvm-project?rev=278579&view=rev Log: Fix ASAN failures in the demangler These were found fuzzing with ASAN. Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_demang

Re: [PATCH] D23329: [NFC] Reducing allocations in AST attributes

2016-08-12 Thread David Majnemer via cfe-commits
majnemer added a subscriber: majnemer. majnemer accepted this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision is now accepted and ready to land. LGTM Comment at: include/clang/AST/AttrIterator.h:42 @@ -41,3 +41,3 @@ /// AttrVec - A vector

Re: [libcxxabi] r278579 - Fix ASAN failures in the demangler

2016-08-12 Thread Kostya Serebryany via cfe-commits
Sweet! Did you fix all of the known crashers? On Fri, Aug 12, 2016 at 5:02 PM, Mehdi Amini via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mehdi_amini > Date: Fri Aug 12 19:02:33 2016 > New Revision: 278579 > > URL: http://llvm.org/viewvc/llvm-project?rev=278579&view=rev > Log: >

Re: [libcxxabi] r278579 - Fix ASAN failures in the demangler

2016-08-12 Thread Mehdi Amini via cfe-commits
This fixes all the crashers on Darwin (clang+libc++), that I could reproduce with ASAN+libFuzzer. It does not mean that there is no leaks, or that you won’t find more crashes with libstdc++ for instance. — Mehdi > On Aug 12, 2016, at 5:21 PM, Kostya Serebryany wrote: > > Sweet! > Did you fi

Re: [libcxxabi] r278579 - Fix ASAN failures in the demangler

2016-08-12 Thread Kostya Serebryany via cfe-commits
On Fri, Aug 12, 2016 at 5:26 PM, Mehdi Amini wrote: > This fixes all the crashers on Darwin (clang+libc++), that I could > reproduce with ASAN+libFuzzer. > It does not mean that there is no leaks, or that you won’t find more > crashes with libstdc++ for instance. > Yea... On linux I hit a leak r

Re: [libcxxabi] r278579 - Fix ASAN failures in the demangler

2016-08-12 Thread Duncan P. N. Exon Smith via cfe-commits
This seems like a good candidate to cherry-pick to 3.9. > On 2016-Aug-12, at 17:02, Mehdi Amini via cfe-commits > wrote: > > Author: mehdi_amini > Date: Fri Aug 12 19:02:33 2016 > New Revision: 278579 > > URL: http://llvm.org/viewvc/llvm-project?rev=278579&view=rev > Log: > Fix ASAN failures i

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

2016-08-12 Thread Zachary Turner via cfe-commits
zturner updated this revision to Diff 67947. zturner added a comment. After much head banging I think I finally figured this out. I'm putting this back to my original revision, unchanged. The problem is not the original patch. The original patch is perfectly fine. The problem is the way i wa

Re: [libcxxabi] r278579 - Fix ASAN failures in the demangler

2016-08-12 Thread Mehdi Amini via cfe-commits
CC hans. > On Aug 12, 2016, at 5:50 PM, Duncan P. N. Exon Smith > wrote: > > This seems like a good candidate to cherry-pick to 3.9. > >> On 2016-Aug-12, at 17:02, Mehdi Amini via cfe-commits >> wrote: >> >> Author: mehdi_amini >> Date: Fri Aug 12 19:02:33 2016 >> New Revision: 278

[PATCH] D23480: Add a test for clang-tidy using the clang cl driver

2016-08-12 Thread Zachary Turner via cfe-commits
zturner created this revision. zturner added a reviewer: alexfh. zturner added a subscriber: cfe-commits. In order to get this to work, the positional arguments must use `--driver-mode=cl `, and NOT `clang-cl `. In the latter case, clang-tidy has to try really hard to "guess" whether the first

r278586 - Fix build broken after llvm/ADT/DenseMap.h replacement of climits with limits.

2016-08-12 Thread Eugene Zelenko via cfe-commits
Author: eugenezelenko Date: Fri Aug 12 20:05:35 2016 New Revision: 278586 URL: http://llvm.org/viewvc/llvm-project?rev=278586&view=rev Log: Fix build broken after llvm/ADT/DenseMap.h replacement of climits with limits. Modified: cfe/trunk/lib/Basic/FileManager.cpp Modified: cfe/trunk/lib/Bas

Re: [PATCH] D22555: [Clang] Fix RHEL 6 build and other Include What You Use warnings

2016-08-12 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko abandoned this revision. Eugene.Zelenko added a comment. Committed as fix for build failure after llvm/ADT/DenseMap.h in r278583. Repository: rL LLVM https://reviews.llvm.org/D22555 ___ cfe-commits mailing list cfe-commits@lists.ll

Re: [PATCH] D23241: Add the notion of deferred diagnostics.

2016-08-12 Thread Reid Kleckner via cfe-commits
rnk added a comment. Sorry for the delay, was trying to stay focused on debugging Comment at: clang/include/clang/AST/Decl.h:1647 @@ +1646,3 @@ + /// clears this list) needs to be a logically-const operation. + mutable std::unique_ptr> DeferredDiags; + Decl me

Re: [PATCH] D23329: [NFC] Reducing allocations in AST attributes

2016-08-12 Thread Eugene via cfe-commits
kevgs updated this revision to Diff 67955. kevgs added a comment. clang-formatted + dead code removed https://reviews.llvm.org/D23329 Files: include/clang/AST/AttrIterator.h Index: include/clang/AST/AttrIterator.h === --- includ

Re: [PATCH] D23329: [NFC] Reducing allocations in AST attributes

2016-08-12 Thread Eugene via cfe-commits
kevgs added a comment. I have no commit rights. https://reviews.llvm.org/D23329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2