majnemer added a subscriber: majnemer. majnemer accepted this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: include/clang/AST/AttrIterator.h:42 @@ -41,3 +41,3 @@ /// AttrVec - A vector of Attr, which is how they are stored on the AST. -typedef SmallVector<Attr*, 2> AttrVec; -typedef SmallVector<const Attr*, 2> ConstAttrVec; +typedef SmallVector<Attr*, 4> AttrVec; +typedef SmallVector<const Attr*, 4> ConstAttrVec; ---------------- Might as well clang-format this line. ================ Comment at: include/clang/AST/AttrIterator.h:43 @@ -44,1 +42,3 @@ +typedef SmallVector<Attr*, 4> AttrVec; +typedef SmallVector<const Attr*, 4> ConstAttrVec; ---------------- I'd delete this. https://reviews.llvm.org/D23329 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
