Re: [PATCH] D21198: RenderScript support in the Frontend

2016-06-09 Thread Pirama Arumuga Nainar via cfe-commits
pirama updated this revision to Diff 60252. pirama added a comment. Cleanup bad merge http://reviews.llvm.org/D21198 Files: include/clang/Basic/Attr.td include/clang/Basic/LangOptions.def include/clang/Frontend/FrontendOptions.h lib/Frontend/CompilerInvocation.cpp lib/Frontend/Fronten

r272318 - Fix a crash in the AST dumper.

2016-06-09 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Thu Jun 9 17:03:04 2016 New Revision: 272318 URL: http://llvm.org/viewvc/llvm-project?rev=272318&view=rev Log: Fix a crash in the AST dumper. Boxed expressions in a template context may have a null method decl. If so, don't try to access the selector. Modified: cfe/tru

[PATCH] D21206: clang-format: [JS] recognized named functions in AnnotatingParser.

2016-06-09 Thread Martin Probst via cfe-commits
mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. This also fixes union type formatting in function parameter types. http://reviews.llvm.org/D21206 Files: lib/Format/TokenAnnotator.cpp unittests/Forma

Re: [PATCH] D20389: NVPTX: Add supported CL features

2016-06-09 Thread Jan Vesely via cfe-commits
jvesely updated this revision to Diff 60257. jvesely added a comment. add back require registered target Repository: rL LLVM http://reviews.llvm.org/D20389 Files: lib/Basic/Targets.cpp test/Misc/nvptx.languageOptsOpenCL.cl Index: test/Misc/nvptx.languageOptsOpenCL.cl ===

Re: [PATCH] D20388: AMDGPU: Fix supported CL features

2016-06-09 Thread Jan Vesely via cfe-commits
jvesely updated this revision to Diff 60259. jvesely added a comment. tests all extensions against expected outcome (add negative tests) enable cl_khr_icd (works ok with mesa) Repository: rL LLVM http://reviews.llvm.org/D20388 Files: lib/Basic/Targets.cpp test/Misc/amdgcn.languageOptsOpe

Re: [PATCH] D20388: AMDGPU: Fix supported CL features

2016-06-09 Thread Jan Vesely via cfe-commits
jvesely marked an inline comment as done. jvesely added a comment. Repository: rL LLVM http://reviews.llvm.org/D20388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272323 - [CMake] Version is aways greater than 3

2016-06-09 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Thu Jun 9 17:38:40 2016 New Revision: 272323 URL: http://llvm.org/viewvc/llvm-project?rev=272323&view=rev Log: [CMake] Version is aways greater than 3 We don't need any checks for this code anymore. Since CMake version is always greater than 3 we can always generate the

Re: [PATCH] D21206: clang-format: [JS] recognized named functions in AnnotatingParser.

2016-06-09 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. The change looks good, but can you add a before/after example to change description? http://reviews.llvm.org/D21206 ___ cfe-commits mailing li

r272324 - [CMake] Cleaning up CMake version checks in ExternalProject calls

2016-06-09 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Thu Jun 9 17:38:42 2016 New Revision: 272324 URL: http://llvm.org/viewvc/llvm-project?rev=272324&view=rev Log: [CMake] Cleaning up CMake version checks in ExternalProject calls Now that we're on CMake 3.4.3 all the ExternalProject features we use are supported everywhere

r272325 - Redirect unused output in test to /dev/null

2016-06-09 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Thu Jun 9 17:39:20 2016 New Revision: 272325 URL: http://llvm.org/viewvc/llvm-project?rev=272325&view=rev Log: Redirect unused output in test to /dev/null Discard unused output so when the test fails, it only prints information that is helpful about the failure. No function

r272330 - clang-format: [JS] recognized named functions in AnnotatingParser.

2016-06-09 Thread Martin Probst via cfe-commits
Author: mprobst Date: Thu Jun 9 17:49:04 2016 New Revision: 272330 URL: http://llvm.org/viewvc/llvm-project?rev=272330&view=rev Log: clang-format: [JS] recognized named functions in AnnotatingParser. Summary: This also fixes union type formatting in function parameter types. Before: function x(

Re: [PATCH] D21206: clang-format: [JS] recognized named functions in AnnotatingParser.

2016-06-09 Thread Martin Probst via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272330: clang-format: [JS] recognized named functions in AnnotatingParser. (authored by mprobst). Changed prior to commit: http://reviews.llvm.org/D21206?vs=60254&id=60268#toc Repository: rL LLVM ht

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

2016-06-09 Thread Eric Niebler via cfe-commits
eric_niebler added inline comments. Comment at: lib/Lex/PPDirectives.cpp:33 @@ -28,2 +32,2 @@ #include "llvm/Support/Path.h" #include "llvm/Support/SaveAndRestore.h" rsmith wrote: > eric_niebler wrote: > > You mean, instead of the `StringSet` below? Looks like `

Re: [PATCH] D21198: RenderScript support in the Frontend

2016-06-09 Thread Pirama Arumuga Nainar via cfe-commits
pirama updated this revision to Diff 60277. pirama added a comment. Reorder IK_RenderScript before IK_AST like Richard had requested. http://reviews.llvm.org/D21198 Files: include/clang/Basic/Attr.td include/clang/Basic/LangOptions.def include/clang/Frontend/FrontendOptions.h lib/Fronte

Re: [PATCH] D21198: RenderScript support in the Frontend

2016-06-09 Thread Pirama Arumuga Nainar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272342: RenderScript support in the Frontend (authored by pirama). Changed prior to commit: http://reviews.llvm.org/D21198?vs=60277&id=60279#toc Repository: rL LLVM http://reviews.llvm.org/D21198 F

r272342 - RenderScript support in the Frontend

2016-06-09 Thread Pirama Arumuga Nainar via cfe-commits
Author: pirama Date: Thu Jun 9 18:34:20 2016 New Revision: 272342 URL: http://llvm.org/viewvc/llvm-project?rev=272342&view=rev Log: RenderScript support in the Frontend Summary: Create a new Frontend LangOpt to specify the renderscript language. It is enabled by the "-x renderscript" option fro

[PATCH] D21212: Add documentation for RenderScript changes

2016-06-09 Thread Pirama Arumuga Nainar via cfe-commits
pirama created this revision. pirama added a reviewer: rsmith. pirama added subscribers: srhines, cfe-commits. Herald added subscribers: danalbert, tberghammer. - Document the new 'kernel' attribute - Mention RenderScript support in the Release Notes. http://reviews.llvm.org/D21212 Files: docs

Re: [PATCH] D21198: RenderScript support in the Frontend

2016-06-09 Thread Pirama Arumuga Nainar via cfe-commits
pirama added a comment. Thanks for the review. Docs update is in http://reviews.llvm.org/D21212 Repository: rL LLVM http://reviews.llvm.org/D21198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

2016-06-09 Thread Eric Niebler via cfe-commits
eric_niebler updated this revision to Diff 60281. eric_niebler added a comment. Replace `StringSet` with `StringSwitch`, ASCII range ends at 0x7f not 0xff, miscellaneous formatting tweaks. http://reviews.llvm.org/D19843 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Basic/F

r272350 - Add doxygen comments to mmintrin.h's intrinsics.

2016-06-09 Thread Ekaterina Romanova via cfe-commits
Author: kromanova Date: Thu Jun 9 19:10:40 2016 New Revision: 272350 URL: http://llvm.org/viewvc/llvm-project?rev=272350&view=rev Log: Add doxygen comments to mmintrin.h's intrinsics. The doxygen comments are automatically generated based on Sony's intrinsics docu ment. I got an OK from Eric Ch

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-09 Thread Joerg Sonnenberger via cfe-commits
On Wed, Jun 08, 2016 at 01:12:31AM +, Hans Wennborg via cfe-commits wrote: > There has been a patch for this before (http://reviews.llvm.org/D2972), > but this one is more general, as it works on the virtual filesystem > layer, and also supports case-insensitive lookups of parent directories >

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

2016-06-09 Thread Richard Smith via cfe-commits
rsmith added a comment. Thanks for the updates, LGTM (@bruno, did you get the performance numbers you wanted?) http://reviews.llvm.org/D19843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

r272357 - Remove CXXConstructExpr::getFoundDecl(); it turned out to not be useful.

2016-06-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Jun 9 19:58:19 2016 New Revision: 272357 URL: http://llvm.org/viewvc/llvm-project?rev=272357&view=rev Log: Remove CXXConstructExpr::getFoundDecl(); it turned out to not be useful. Modified: cfe/trunk/include/clang/AST/ExprCXX.h cfe/trunk/include/clang/Sema/Sema.h

Re: [PATCH] D19260: [analyzer][scan-build-py] subprocess output handling reviewed in clang module

2016-06-09 Thread Devin Coughlin via cfe-commits
dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. This looks good to me. I've run this on a suite of open source projects and it reported no changes in the reference results. Thanks for simplifying and adding the extra tests!

Re: [PATCH] D21163: Strip Android version when looking up toolchain paths.

2016-06-09 Thread Josh Gao via cfe-commits
jmgao updated this revision to Diff 60294. jmgao added a comment. Add test. http://reviews.llvm.org/D21163 Files: lib/Driver/Driver.cpp test/Driver/Inputs/android_triple_version/bin/arm-linux-androideabi-ld test/Driver/Inputs/android_triple_version/bin/arm-linux-androideabi-ld.exe test/

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

2016-06-09 Thread Vedant Kumar via cfe-commits
vsk added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:41 @@ +40,3 @@ + // (and destructed) as in push_back case. + auto isCtorOfSmartPtr = hasDeclaration(cxxConstructorDecl( + ofClass(hasAnyName("std::shared_ptr", "std::unique_ptr", "std::auto_ptr"

r272361 - Reduce sizeof(CXXConstructorDecl) by 4-8 bytes.

2016-06-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Jun 9 21:01:28 2016 New Revision: 272361 URL: http://llvm.org/viewvc/llvm-project?rev=272361&view=rev Log: Reduce sizeof(CXXConstructorDecl) by 4-8 bytes. Modified: cfe/trunk/include/clang/AST/DeclCXX.h Modified: cfe/trunk/include/clang/AST/DeclCXX.h URL: http://ll

Re: [PATCH] D21163: Strip Android version when looking up toolchain paths.

2016-06-09 Thread Tim Northover via cfe-commits
t.p.northover accepted this revision. t.p.northover added a reviewer: t.p.northover. t.p.northover added a comment. This revision is now accepted and ready to land. I think that looks good. Thanks for adding the test! Tim. http://reviews.llvm.org/D21163 __

r272366 - Fix recognition of shadowed template parameter

2016-06-09 Thread Serge Pavlov via cfe-commits
Author: sepavloff Date: Thu Jun 9 23:39:07 2016 New Revision: 272366 URL: http://llvm.org/viewvc/llvm-project?rev=272366&view=rev Log: Fix recognition of shadowed template parameter Crash reported in PR28023 is caused by the fact that non-type template parameters are found by tag name lookup. I

Re: [PATCH] D21204: clang-format: [JS] post-fix non-null assertion operator.

2016-06-09 Thread Daniel Jasper via cfe-commits
djasper added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2127 @@ +2126,3 @@ +// Postfix non-null assertion operator, as in `foo!.bar()`. +if (Right.is(tok::exclaim) && Right.Next && +Right.Next->isNot(tok::identifier) && !Right.Next->Tok.isLiteral()

r272368 - Check for null pointers before calling the Stmt Profiler

2016-06-09 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Thu Jun 9 23:52:09 2016 New Revision: 272368 URL: http://llvm.org/viewvc/llvm-project?rev=272368&view=rev Log: Check for null pointers before calling the Stmt Profiler Some calls from OMPClauseProfiler were calling the Stmt Profiler with null pointers, but the profiler can o

Re: [PATCH] D21204: clang-format: [JS] post-fix non-null assertion operator.

2016-06-09 Thread Martin Probst via cfe-commits
mprobst updated this revision to Diff 60308. mprobst marked an inline comment as done. mprobst added a comment. - invert check to whitelist known tokens that can precede a non-null assertion. http://reviews.llvm.org/D21204 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestJS.c

Re: [PATCH] D21204: clang-format: [JS] post-fix non-null assertion operator.

2016-06-09 Thread Martin Probst via cfe-commits
mprobst added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2127 @@ +2126,3 @@ +// Postfix non-null assertion operator, as in `foo!.bar()`. +if (Right.is(tok::exclaim) && Right.Next && +Right.Next->isNot(tok::identifier) && !Right.Next->Tok.isLiteral()

Re: [PATCH] D21204: clang-format: [JS] post-fix non-null assertion operator.

2016-06-09 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. This revision is now accepted and ready to land. Comment at: lib/Format/TokenAnnotator.cpp:2128 @@ +2127,3 @@ +if (Right.is(tok::exclaim) && +(Left.isOneOf(tok::identifier, tok::r_paren, tok::r_square) || + Left.Tok.isLiteral()))

Re: [PATCH] D21204: clang-format: [JS] post-fix non-null assertion operator.

2016-06-09 Thread Martin Probst via cfe-commits
mprobst updated this revision to Diff 60311. mprobst added a comment. - more tests http://reviews.llvm.org/D21204 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestJS.cpp Index: unittests/Format/FormatTestJS.cpp

Re: [PATCH] D21204: clang-format: [JS] post-fix non-null assertion operator.

2016-06-09 Thread Martin Probst via cfe-commits
mprobst added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2128 @@ +2127,3 @@ +if (Right.is(tok::exclaim) && (Left.isOneOf(tok::identifier, tok::r_paren, +tok::r_square, tok::r_brace) || +

<    1   2