Re: [PATCH] D20933: Preallocate ExplodedNode hash table

2016-06-07 Thread Ben Craig via cfe-commits
bcraig added a comment. tldr; I'm going to recommend we stick with the current algorithm, but I only have partial data to back that up. For the pile of LLVM projects that I am currently building (llvm, clang, libcxx, libcxxabi), 18.9% of all analyzed functions hit the maximum step count. For

Re: 3.8 Merge Request: r259776

2016-06-07 Thread Alexey Bataev via cfe-commits
Hi Tom, I'm on a vacation right now without an access to the computer. Could you do it yourself? Best regards, Alexey Bataev Отправлено с iPhone > 7 июня 2016 г., в 22:49, Tom Stellard написал(а): > > Hi Alexy, > > Can you merge this? > > Thanks, > Tom > >> On Tue, Jun 07, 2016 at 09:40:44A

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

2016-06-07 Thread Ben Craig via cfe-commits
bcraig updated this revision to Diff 59950. bcraig added a comment. Uploading more context. http://reviews.llvm.org/D20933 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h lib/StaticAnalyzer/Core/CoreEngine.cpp Index: lib/StaticAnalyzer/Core/CoreEngine.cpp ===

Re: [PATCH] D21066: Pass MCSubtargetInfo instead of CPU and Triple to createMCAsmBackend

2016-06-07 Thread Eric Christopher via cfe-commits
echristo requested changes to this revision. echristo added a comment. This revision now requires changes to proceed. I followed up in the original thread, I don't think this is going to be the right direction. Thanks. -eric http://reviews.llvm.org/D21066 __

Re: [PATCH] D17516: AMDGPU: Verify subtarget specific builtins

2016-06-07 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Seems pretty reasonable. If I missed anything we can pick it up later. -eric Comment at: lib/Basic/Targets.cpp:2010 @@ +2009,3 @@ + + // XXX - What does the member GPU m

[PATCH] D21104: [CodeGen][ObjC] Block captures should inherit the type of the captured field in the enclosing lambda or block

2016-06-07 Thread Akira Hatanaka via cfe-commits
ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a subscriber: cfe-commits. This patch fixes a bug in code-gen where it uses the type of the declared variable rather than the type of the capture of the enclosing lambda or block for the block capture. For exampl

r272067 - [docs] Coverage: Explain how to avoid static initializers

2016-06-07 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Tue Jun 7 17:25:29 2016 New Revision: 272067 URL: http://llvm.org/viewvc/llvm-project?rev=272067&view=rev Log: [docs] Coverage: Explain how to avoid static initializers Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified: cfe/trunk/docs/SourceBasedCodeCoverag

[PATCH] D21107: Generate codeview for array types

2016-06-07 Thread Adrian McCarthy via cfe-commits
amccarth created this revision. amccarth added a reviewer: rnk. amccarth added a subscriber: cfe-commits. Creates codeview type records for arrays and adds a simple test for one. http://reviews.llvm.org/D21107 Files: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp lib/CodeGen/AsmPrinter/CodeViewD

Re: [PATCH] D21107: Generate codeview for array types

2016-06-07 Thread David Majnemer via cfe-commits
majnemer added a subscriber: majnemer. Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:785 @@ +784,3 @@ + TypeIndex IndexType = Asm->MAI->getPointerSize() == 8 ? + TypeIndex(SimpleTypeKind::UInt64) : + TypeIndex(SimpleTypeKind::UInt32); They don't

Re: [PATCH] D21107: Generate codeview for array types

2016-06-07 Thread Adrian McCarthy via cfe-commits
amccarth added inline comments. Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:785 @@ +784,3 @@ + TypeIndex IndexType = Asm->MAI->getPointerSize() == 8 ? + TypeIndex(SimpleTypeKind::UInt64) : + TypeIndex(SimpleTypeKind::UInt32); majnemer wrote: >

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

2016-06-07 Thread Eric Niebler via cfe-commits
eric_niebler updated the summary for this revision. eric_niebler updated this revision to Diff 59974. eric_niebler added a comment. Rework the patch to only warn by default for include files //not// found in system include directories, unless they are known "standard" headers that should be port

r272080 - [Sema] Teach CheckPlaceholderExpr about unaddressable functions.

2016-06-07 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Tue Jun 7 19:34:22 2016 New Revision: 272080 URL: http://llvm.org/viewvc/llvm-project?rev=272080&view=rev Log: [Sema] Teach CheckPlaceholderExpr about unaddressable functions. Given the following C++: ``` void foo(); void foo() __attribute__((enable_if(false, ""))); bool bar

r272079 - [ItaniumMangle] Mangle dependent __underlying_type correctly

2016-06-07 Thread David Majnemer via cfe-commits
Author: majnemer Date: Tue Jun 7 19:34:15 2016 New Revision: 272079 URL: http://llvm.org/viewvc/llvm-project?rev=272079&view=rev Log: [ItaniumMangle] Mangle dependent __underlying_type correctly We attempted to use the UnaryTransformType's UnderlyingType instead of it's BaseType. This is not co

[PATCH] D21111: Avoid accessing an invalid PresumedLoc

2016-06-07 Thread Jordan Rose via cfe-commits
jordan_rose created this revision. jordan_rose added a reviewer: rsmith. jordan_rose added a subscriber: cfe-commits. jordan_rose set the repository for this revision to rL LLVM. DiagnosticNoteRenderer asserts trying to emit its "while building module Foo imported from bar.h:5" note when the pres

[PATCH] D21113: Add support for case-insensitive header lookup

2016-06-07 Thread Hans Wennborg via cfe-commits
hans created this revision. hans added reviewers: rsmith, rnk, thakis. hans added subscribers: compnerd, majnemer, benlangmuir, cfe-commits. This is useful when dealing with headers that are normally used on case-insensitive filesystems, such as the Windows SDK, when cross-compiling from a file-

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-07 Thread Hans Wennborg via cfe-commits
hans updated this revision to Diff 59982. hans added a comment. Add --show-includes test. http://reviews.llvm.org/D21113 Files: include/clang/Basic/VirtualFileSystem.h include/clang/Driver/Options.td include/clang/Lex/HeaderSearchOptions.h lib/Basic/VirtualFileSystem.cpp lib/Driver/To

Re: [PATCH] D20709: For RenderScript, set alignment and width of long to 64-bits

2016-06-07 Thread Richard Smith via cfe-commits
rsmith added a comment. In http://reviews.llvm.org/D20709#446595, @srhines wrote: > There is a coming patch that adds a single attribute (for "kernel"), that has > error checking to ensure that it is only used by our RenderScript targets. I > assume that the cleanest way to retain that diagnost

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

2016-06-07 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. I guess you can remove // UNSUPPORTED: mingw32 added by cfe/trunk@271509 Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

r272091 - AMDGPU: Verify subtarget specific builtins

2016-06-07 Thread Matt Arsenault via cfe-commits
Author: arsenm Date: Tue Jun 7 20:56:42 2016 New Revision: 272091 URL: http://llvm.org/viewvc/llvm-project?rev=272091&view=rev Log: AMDGPU: Verify subtarget specific builtins Cleanup setup of subtarget features. Added: cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn-error.cl cfe/trunk/test

Re: [PATCH] D17516: AMDGPU: Verify subtarget specific builtins

2016-06-07 Thread Matt Arsenault via cfe-commits
arsenm closed this revision. arsenm added a comment. r272091 http://reviews.llvm.org/D17516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21113: Add support for case-insensitive header lookup

2016-06-07 Thread Saleem Abdulrasool via cfe-commits
compnerd added a comment. This looks good to me. Thanks for picking this up! And thanks for the perf numbers! Comment at: lib/Basic/VirtualFileSystem.cpp:401 @@ +400,3 @@ +IntrusiveRefCntPtr Base) +: Base(Base) {} + Probably can inline this in the hea

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

2016-06-07 Thread Vitaly Buka via cfe-commits
vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Actually there are other tests with -fsanitize=address I see only difference in %clang vs %clang_cc1? Could you try this? Repository: rL LLVM http://reviews.llvm.org/D21082 _

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

2016-06-07 Thread Vitaly Buka via cfe-commits
vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. It was accepted accidentally. Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@li

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

2016-06-07 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. Oh, I see, most asan tests in clang use cross-compiler, e.g.: -target x86_64-linux-gnu Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D21117: Specify target in lifetime-asan test.

2016-06-07 Thread Vitaly Buka via cfe-commits
vitalybuka created this revision. vitalybuka added reviewers: pcc, eugenis. vitalybuka added subscribers: kubabrecka, chapuni, christof, cfe-commits. Some target platforms -fsanitize=address. http://reviews.llvm.org/D21117 Files: test/CodeGen/lifetime-asan.c Index: test/CodeGen/lifetime-asan.

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

2016-06-07 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. http://reviews.llvm.org/D21117 Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r272100 - Creating release directory for release_381.

2016-06-07 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Tue Jun 7 22:27:19 2016 New Revision: 272100 URL: http://llvm.org/viewvc/llvm-project?rev=272100&view=rev Log: Creating release directory for release_381. Added: libcxx/tags/RELEASE_381/ ___ cfe-commits mailing list cfe-comm

[libunwind] r272114 - Creating release directory for release_381.

2016-06-07 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Tue Jun 7 22:27:34 2016 New Revision: 272114 URL: http://llvm.org/viewvc/llvm-project?rev=272114&view=rev Log: Creating release directory for release_381. Added: libunwind/tags/RELEASE_381/ ___ cfe-commits mailing list cfe-c

[libcxx] r272101 - Creating release candidate rc1 from release_381 branch

2016-06-07 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Tue Jun 7 22:27:21 2016 New Revision: 272101 URL: http://llvm.org/viewvc/llvm-project?rev=272101&view=rev Log: Creating release candidate rc1 from release_381 branch Added: libcxx/tags/RELEASE_381/rc1/ (props changed) - copied from r272100, libcxx/branches/rele

[libcxxabi] r272102 - Creating release directory for release_381.

2016-06-07 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Tue Jun 7 22:27:22 2016 New Revision: 272102 URL: http://llvm.org/viewvc/llvm-project?rev=272102&view=rev Log: Creating release directory for release_381. Added: libcxxabi/tags/RELEASE_381/ ___ cfe-commits mailing list cfe-c

[libunwind] r272115 - Creating release candidate rc1 from release_381 branch

2016-06-07 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Tue Jun 7 22:27:35 2016 New Revision: 272115 URL: http://llvm.org/viewvc/llvm-project?rev=272115&view=rev Log: Creating release candidate rc1 from release_381 branch Added: libunwind/tags/RELEASE_381/rc1/ - copied from r272114, libunwind/branches/release_38/ ___

[libcxxabi] r272103 - Creating release candidate rc1 from release_381 branch

2016-06-07 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Tue Jun 7 22:27:23 2016 New Revision: 272103 URL: http://llvm.org/viewvc/llvm-project?rev=272103&view=rev Log: Creating release candidate rc1 from release_381 branch Added: libcxxabi/tags/RELEASE_381/rc1/ (props changed) - copied from r272102, libcxxabi/branche

r272119 - [AVX512] Reformat macro intrinsics, ensure arguments have proper typecasts, ensure result is typecasted back to the generic types.

2016-06-07 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Jun 8 01:08:07 2016 New Revision: 272119 URL: http://llvm.org/viewvc/llvm-project?rev=272119&view=rev Log: [AVX512] Reformat macro intrinsics, ensure arguments have proper typecasts, ensure result is typecasted back to the generic types. Modified: cfe/trunk/lib/Hea

r272118 - [X86] Put parentheses around macro arguments in intrinsics.

2016-06-07 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Jun 8 01:08:04 2016 New Revision: 272118 URL: http://llvm.org/viewvc/llvm-project?rev=272118&view=rev Log: [X86] Put parentheses around macro arguments in intrinsics. Modified: cfe/trunk/lib/Headers/avx512fintrin.h Modified: cfe/trunk/lib/Headers/avx512fintrin.h UR

[PATCH] D21120: clang-rename: implement renaming of classes inside dynamic_cast

2016-06-07 Thread Miklos Vajna via cfe-commits
vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. Refactor to do the same as what is done already for static_cast. http://reviews.llvm.org/D21120 Files: clang-rename/USRLocFinder.cpp test/clang-rename/DynamicCastExpr.cpp Index: test/cl

<    1   2