Re: [PATCH] D20382: Add postorder support to RecursiveASTVisitor

teemperor added a comment. The previous stats were wrong (only applied this patch, not the patch using the code): Release: 63311672 Byte -> 77212960 Byte (+22% or +13.8 MB) http://reviews.llvm.org/D20382 ___ cfe-commits mailing list cfe-commits@li

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

alexfh added inline comments. Comment at: clang-tidy/modernize/UseAutoCheck.cpp:338 @@ -329,8 +337,3 @@ -// Remove explicitly written '*' from declarations where there's more than -// one declaration in the declaration list. -if (Dec == *D->decl_begin()) - conti

Re: r271692 - Don't pass --build-id to ld by default.

On 3 June 2016 at 15:53, Nico Weber via cfe-commits wrote: > Can you add this to the release notes? It'll for example break chromium's > crash server (we can fix this on our end by explicitly passing > -Wl,--build-id for release builds, but we only saw this commit fly by by > chance.) Good point.

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

Prazek added inline comments. Comment at: clang-tidy/modernize/UseAutoCheck.cpp:338 @@ -329,8 +337,3 @@ -// Remove explicitly written '*' from declarations where there's more than -// one declaration in the declaration list. -if (Dec == *D->decl_begin()) - conti

[PATCH] D20985: [CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.

tra created this revision. tra added reviewers: rsmith, jlebar. tra added a subscriber: cfe-commits. Fixes clang crash reported in PR27778. http://reviews.llvm.org/D20985 Files: lib/Sema/SemaDeclAttr.cpp test/CodeGenCUDA/launch-bounds.cu test/SemaCUDA/pr27778.cu Index: test/SemaCUDA/pr277

Re: [PATCH] D20985: [CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.

jlebar added a comment. How is this different from test/SemaCUDA/launch_bounds.cu:27-28? It does const int constint = 512; __launch_bounds__(constint) void TestConstInt(void); which looks verbatim the same as this testcase. http://reviews.llvm.org/D20985 ___

Re: [PATCH] D20985: [CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.

tra added a comment. In http://reviews.llvm.org/D20985#448822, @jlebar wrote: > How is this different from test/SemaCUDA/launch_bounds.cu:27-28? It does > > const int constint = 512; > __launch_bounds__(constint) void TestConstInt(void); > > > which looks verbatim the same as this testcas

Re: [PATCH] D20985: [CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.

jlebar added a comment. In http://reviews.llvm.org/D20985#448836, @tra wrote: > In http://reviews.llvm.org/D20985#448822, @jlebar wrote: > > > How is this different from test/SemaCUDA/launch_bounds.cu:27-28? It does > > > > const int constint = 512; > > __launch_bounds__(constint) void TestC

[libunwind] r271737 - [libunwind] Remove unused code.

Author: asiri Date: Fri Jun 3 15:57:48 2016 New Revision: 271737 URL: http://llvm.org/viewvc/llvm-project?rev=271737&view=rev Log: [libunwind] Remove unused code. The whole file is guarded with #if _LIBUNWIND_ARM_EHABI, and then in the middle we have these two blocks, which render them pretty un

[clang-tools-extra] r271739 - [clang-tidy] modernize-use-auto: don't remove stars by default

Author: alexfh Date: Fri Jun 3 16:22:58 2016 New Revision: 271739 URL: http://llvm.org/viewvc/llvm-project?rev=271739&view=rev Log: [clang-tidy] modernize-use-auto: don't remove stars by default Summary: By default, modernize-use-auto check will retain stars when replacing an explicit type with

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL271739: [clang-tidy] modernize-use-auto: don't remove stars by default (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D20917?vs=59599&id=59625#toc Repository: rL LLVM http://

Re: [PATCH] D20985: [CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.

tra updated this revision to Diff 59624. tra added a comment. Addressed Justin's comments. http://reviews.llvm.org/D20985 Files: lib/Sema/SemaDeclAttr.cpp test/CodeGenCUDA/launch-bounds.cu test/SemaCUDA/pr27778.cu Index: test/SemaCUDA/pr27778.cu ==

Re: [PATCH] D20985: [CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.

jlebar accepted this revision. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaDeclAttr.cpp:4044 @@ +4043,3 @@ +// Checks whether an argument of launch_bounds attribute is +// acceptable, performs implicit conversion to Rvalue and returns +// non-nullptr

Re: [PATCH] D20856: [clang-tidy] readability-identifier-naming - Support for Type Aliases

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Thank you for the patch! Do you need me to submit it? http://reviews.llvm.org/D20856 ___ cfe-commits mailing list cfe-commits@lists.l

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

I'm getting lots of warnings like so: In file included from ..\..\tools\win\static_initializers\static_initializers.cc:5: C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\DIA SDK\include\dia2.h(30,10): error: non-portable path to file '"Windows.h"'; specified path

Re: [PATCH] D20853: [clang-tidy] misc-macro-parentheses: Don't insert parentheses in variable declarations. Fixes bugzilla 26273

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with a few style comments. Comment at: clang-tidy/misc/MacroParenthesesCheck.cpp:82 @@ +81,3 @@ + + // If we see int/short/struct etc just assume this is a variabl

[libcxx] r271741 - [libcxx] Fix c++98 test failures.

Author: asiri Date: Fri Jun 3 16:40:03 2016 New Revision: 271741 URL: http://llvm.org/viewvc/llvm-project?rev=271741&view=rev Log: [libcxx] Fix c++98 test failures. Adds XFAIL/UNSUPPORTED lit tags as appropriate. Gets a clean test run for -std=c++98 on Fedora 20. NFC. Modified: libcxx/trun

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

Also, once that is resolved, this warning tells people that #include is wrong: ..\..\third_party\ffmpeg\compat/w32pthreads.h(39,10): warning: non-portable path to file ''; specified path differs in case from file name on disk [-Wnonportable-include-path] #include ^~~

Re: [PATCH] D20133: [OpenCL] Fix __builtin_astype for vec3 types.

yaxunl updated this revision to Diff 59630. yaxunl marked 10 inline comments as done. yaxunl added a comment. Add a sema test for mismatched type size. Fix codegen test. http://reviews.llvm.org/D20133 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGenOpenCL/as_type.cl test/SemaOpenCL/as_typ

Re: [PATCH] D20133: [OpenCL] Fix __builtin_astype for vec3 types.

yaxunl added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:3394 @@ +3393,3 @@ + if (NumElementsDst == 4) +Args.push_back(llvm::UndefValue::get(CGF.Int32Ty)); + llvm::Constant *Mask = llvm::ConstantVector::get(Args); Anastasia wrote: > should this

Re: [PATCH] D20985: [CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.

tra updated this revision to Diff 59631. tra marked an inline comment as done. tra added a comment. Rephrased comments http://reviews.llvm.org/D20985 Files: lib/Sema/SemaDeclAttr.cpp test/CodeGenCUDA/launch-bounds.cu test/SemaCUDA/pr27778.cu Index: test/SemaCUDA/pr27778.cu ==

Re: [PATCH] D20985: [CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.

tra marked 3 inline comments as done. Comment at: lib/Sema/SemaDeclAttr.cpp:4046 @@ +4045,3 @@ +// non-nullptr Expr result on success. Returns nullptr otherwise and +// may output an error. +static Expr *makeLaunchBoundsArgExpr(Sema &S, Expr *E, jlebar wrote: > Pr

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

It's not just windows.h, but windows sdk headers in general (#include , #include #include #include etc). Here's what the warning does on the first few files in Chromium: https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/8155/steps/compile/logs/stdio (We add /FIIntrin.h -- but

Re: [PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

alexfh added a comment. In http://reviews.llvm.org/D20689#443266, @varjujan wrote: > Yes, I did. The results from running the checker on LLVM are in the attached > file. Sadly, I could'nt find any real mistakes but as I wrote in the summary, > false positives can still indicate bad naming conve

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

alexfh resigned from this revision. alexfh removed a reviewer: alexfh. alexfh added a comment. Cleaning up my Phab dashboard. If http://reviews.llvm.org/D20428 doesn't happen and we'll have to return to this implementation, please re-add me to the reviewers. http://reviews.llvm.org/D18575 _

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

I can investigate the system header issue. And I could add a special exception for if folks feel that that’s the right thing to do. If we’re really worried about how noisy this warning could be, the warning could be disabled by default. Thoughts? Eric On 6/3/16, 2:46 PM, "tha...@google.com

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

I just checked, and warnings are not emitted from files in an -isystem path. I didn’t have to do anything special to get that behavior. I don’t know about -imsvc. Is that a clang-cl thing? I can’t say at this point why the diagnostics system treats -isystem and -imsvc differently. How about thi

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

hintonda abandoned this revision. hintonda added a comment. This revision is OBE. http://reviews.llvm.org/D18575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

On Fri, Jun 3, 2016 at 6:14 PM, Eric Niebler wrote: > I just checked, and warnings are not emitted from files in an -isystem > path. I didn’t have to do anything special to get that behavior. I don’t > know about -imsvc. Is that a clang-cl thing? I can’t say at this point why > the diagnostics sy

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/performance/InefficientStringConcatenationCheck.cpp:31 @@ +30,3 @@ +MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus) return; + clang-format

Re: [PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Removing from my dashboard until http://reviews.llvm.org/D20428 is submitted. http://reviews.llvm.org/D20693 ___ cfe-commits mailing li

Re: [PATCH] D19165: [clang-tidy] Add modernize-increment-bool check.

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. > -Wdeprecated-increment-bool does it. But what I see from SemaExpr.cpp in > CheckIncrementDecrementOperand, it doesn't have any fixits. If an automated fix for this issue makes sen

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

On Fri, Jun 3, 2016 at 7:07 PM, Eric Niebler wrote: > On 6/3/16, 3:24 PM, "tha...@google.com on behalf of Nico Weber" < > tha...@google.com on behalf of tha...@chromium.org> wrote: > > On Fri, Jun 3, 2016 at 6:14 PM, Eric Niebler wrote: > >> I just checked, and warnings are not emitted from file

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

On 6/3/16, 3:24 PM, "tha...@google.com on behalf of Nico Weber" wrote: > On Fri, Jun 3, 2016 at 6:14 PM, Eric Niebler wrote: >> I just checked, and warnings are not emitted from files in an -isystem path. >> I didn’t have to do anything special to get that behavior. >> I don’t know about -imsvc

r271747 - Bump libclang API minor version after r271351.

Author: mren Date: Fri Jun 3 18:11:41 2016 New Revision: 271747 URL: http://llvm.org/viewvc/llvm-project?rev=271747&view=rev Log: Bump libclang API minor version after r271351. Also use the next enum value for CXObjCPropertyAttr_class. Modified: cfe/trunk/include/clang-c/Index.h Modified:

r271750 - CodeGen: correct assertion

Author: compnerd Date: Fri Jun 3 18:26:30 2016 New Revision: 271750 URL: http://llvm.org/viewvc/llvm-project?rev=271750&view=rev Log: CodeGen: correct assertion The assertion added earlier was overly strict. We need to strip the pointer casts (as when constructing the GV). Correct the types (F

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

Taewook Oh via cfe-commits writes: > Author: twoh > Date: Fri Jun 3 13:52:51 2016 > New Revision: 271708 > > URL: http://llvm.org/viewvc/llvm-project?rev=271708&view=rev > Log: > Use the name of the file on disk to issue a new diagnostic about > non-portable #include and #import paths. > > Differ

Re: [PATCH] D20985: [CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.

jlebar added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:4079 @@ +4078,3 @@ + if (ValArg.isInvalid()) +return nullptr; + OK, so then we want an assert, not an if? http://reviews.llvm.org/D20985 ___ c

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

I think this should be reverted until we figure out how to solve it. Moreover, it looks expensive to check for each file if it's within a system path. I would really like to measure compile time for this change before it goes definitely in. On Fri, Jun 3, 2016 at 4:53 PM, Justin Bogner via cfe-com

r271754 - PR27989: only enqueue binary operators into the data recursive int expression

Author: rsmith Date: Fri Jun 3 19:22:31 2016 New Revision: 271754 URL: http://llvm.org/viewvc/llvm-project?rev=271754&view=rev Log: PR27989: only enqueue binary operators into the data recursive int expression evaluator if they are actually int expressions. Modified: cfe/trunk/lib/AST/ExprCo

Re: [PATCH] D20942: [LockFileManager] Improve error output by adding error messages

bruno closed this revision. bruno added a comment. Applied your suggestions and committed in r271755! Thanks http://reviews.llvm.org/D20942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: docs/clang-tidy/checks/bugprone-bool-to-integer-conversion.rst:37 @@ +36,3 @@ + +It turns out that the common bug is to have function returning only bools but having int as retur

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

The information about whether the file is in a system path is already being computed, so it would incur no extra overhead. I'm not sure that's the right fix. You are more than welcome to revert the (clang) commit while we think of the right fix. \e On Jun 3, 2016 5:25 PM, "Bruno Cardoso Lopes" wr

r271758 - [Modules] Improve diagnostics for LockFileManager errors

Author: bruno Date: Fri Jun 3 20:13:22 2016 New Revision: 271758 URL: http://llvm.org/viewvc/llvm-project?rev=271758&view=rev Log: [Modules] Improve diagnostics for LockFileManager errors Uses error message now provided by LockFileManager in LLVM r271755. rdar://problem/26529101 Modified:

Re: [PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

alexfh added a comment. Most of the fixits are still useless, but I didn't notice any false positives (i.e. all warnings would be useful to some degree). So I suggest disabling the fixes completely at least for now. Comment at: include/llvm-c/Core.h:604 @@ -603,3 +603,3 @@ *

Re: r271293 - Fixed bug

Hi, please write better change descriptions. I just looked through a regression range with `svn log -r271271:271293`, and for this change I had to look up the change instead of skimming the change description before I could be sure that this change isn't related to what I'm currently looking at.

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

alexfh added a comment. Looks like a useful check to have. I'm not sure though, that it has anything to do with "modernize". I'd suggest adding a new "bugprone" module (should be added by http://reviews.llvm.org/D18821, hopefully soon) and moving the check there. Comment at:

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

> The information about whether the file is in a system path is already being > computed, so it would incur no extra overhead. I'm not sure that's the right > fix. You are more than welcome to revert the (clang) commit while we think > of the right fix. I'm not sure what the right fix is either, b

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

zaks.anna added a comment. Ben, By the way, thanks for the patch! It's a clever idea. > The implementation of FoldingSet has a vector of bucket pointers. Reserve > preallocates that vector of > bucket pointers to the correct size to avoid rehashing. The allocation of > the nodes themselves

Re: [clang-tools-extra] r261991 - [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

On Thu, Jun 02, 2016 at 01:27:51PM +0200, Alexander Kornienko wrote: > Thank you, Tom. I'm not very familiar with the release process and it will > indeed be better, if you merge the patch. > Hi, There were some merge conflicts, so I wasn't sure about merging the patch. Can you either port the p

r271761 - Revert commit r271708

Author: twoh Date: Fri Jun 3 22:14:43 2016 New Revision: 271761 URL: http://llvm.org/viewvc/llvm-project?rev=271761&view=rev Log: Revert commit r271708 Removed: cfe/trunk/test/Lexer/Inputs/case-insensitive-include.h cfe/trunk/test/Lexer/case-insensitive-include-ms.c cfe/trunk/test/L

r271762 - Sema: do not attempt to sizeof a dependent type

Author: compnerd Date: Fri Jun 3 22:16:21 2016 New Revision: 271762 URL: http://llvm.org/viewvc/llvm-project?rev=271762&view=rev Log: Sema: do not attempt to sizeof a dependent type We would attempt to evaluate the sizeof a dependent type to check for an integral overflow. However, because the

Re: r271761 - Revert commit r271708

On Fri, Jun 3, 2016 at 8:21 PM Taewook Oh via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: twoh > Date: Fri Jun 3 22:14:43 2016 > New Revision: 271761 > > URL: http://llvm.org/viewvc/llvm-project?rev=271761&view=rev > Log: > Revert commit r271708 > Please actually explain why you a

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

I reverted the patch with r271761 and r271764. Thanks, Taewook On 6/3/16, 6:40 PM, "Bruno Cardoso Lopes" wrote: >> The information about whether the file is in a system path is already being >> computed, so it would incur no extra overhead. I'm not sure that's the right >> fix. You are more tha

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

twoh added a comment. Reverted in r271761. http://reviews.llvm.org/D19843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r271778 - [X86] Use unsigned types for vector arithmetic in intrinsics to avoid undefined behavior for signed integer overflow.

Author: ctopper Date: Sat Jun 4 00:43:41 2016 New Revision: 271778 URL: http://llvm.org/viewvc/llvm-project?rev=271778&view=rev Log: [X86] Use unsigned types for vector arithmetic in intrinsics to avoid undefined behavior for signed integer overflow. This is really only needed for addition, sub

r271777 - [AVX512] Remove space in -1 constants. NFC

Author: ctopper Date: Sat Jun 4 00:43:37 2016 New Revision: 271777 URL: http://llvm.org/viewvc/llvm-project?rev=271777&view=rev Log: [AVX512] Remove space in -1 constants. NFC Modified: cfe/trunk/lib/Headers/avx512dqintrin.h cfe/trunk/lib/Headers/avx512ifmaintrin.h cfe/trunk/lib/Head

<    1   2