r271368 - [Clang][Intrinsics][avx512] Adding round roundscale to clang

Author: mzuckerm Date: Wed Jun 1 02:35:44 2016 New Revision: 271368 URL: http://llvm.org/viewvc/llvm-project?rev=271368&view=rev Log: [Clang][Intrinsics][avx512] Adding round roundscale to clang Differential Revision: http://reviews.llvm.org/D20815 Modified: cfe/trunk/lib/Headers/avx512fint

Re: [PATCH] D20815: [Clang][Intrinsics][avx512] Adding round roundscale to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL271368: [Clang][Intrinsics][avx512] Adding round roundscale to clang (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D20815?vs=59064&id=59175#toc Repository: rL LLVM http://

Re: [PATCH] D20359: [LLVM][AVX512][Intrinsics] Convert AVX non-temporal store builtins to LLVM-native IR.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [PATCH] D20359: [LLVM][AVX512][Intrinsics] Convert AVX non-temporal store builtins to LLVM-native IR.

craig.topper requested changes to this revision. craig.topper added a comment. This revision now requires changes to proceed. Actually can you add autoupgrade support? http://reviews.llvm.org/D20359 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 updated this revision to Diff 59178. rogfer01 marked an inline comment as done. rogfer01 added a comment. Do not warn if the alignment of the type of the field is already 1 as packed does not have any effect on those fields. http://reviews.llvm.org/D20561 Files: include/clang/Basic/

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 marked an inline comment as done. rogfer01 added a comment. http://reviews.llvm.org/D20561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r271373 - [Clang][Intrinsics][avx512] Adding round intrinsics fot max/min/sqrt instruction set to clang

Author: mzuckerm Date: Wed Jun 1 03:34:03 2016 New Revision: 271373 URL: http://llvm.org/viewvc/llvm-project?rev=271373&view=rev Log: [Clang][Intrinsics][avx512] Adding round intrinsics fot max/min/sqrt instruction set to clang Differential Revision: http://reviews.llvm.org/D20812 Modified:

Re: [PATCH] D20827: [include-fixer] Use YAML format in -output-headers and -insert-header mode.

hokein updated this revision to Diff 59183. hokein added a comment. Get rid of yaml dependency, using json module. http://reviews.llvm.org/D20827 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixerContext.h include-fixer/tool/ClangIncludeFixer.cpp include-fixer/tool/clang-i

Re: [PATCH] D20827: [include-fixer] Use YAML format in -output-headers and -insert-header mode.

hokein marked 2 inline comments as done. hokein added a comment. http://reviews.llvm.org/D20827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20827: [include-fixer] Use YAML format in -output-headers and -insert-header mode.

hokein updated this revision to Diff 59184. hokein added a comment. Show error message when clang-include-fixer died with a fatal error. http://reviews.llvm.org/D20827 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixerContext.h include-fixer/tool/ClangIncludeFixer.cpp incl

Re: [PATCH] D20827: [include-fixer] Use YAML format in -output-headers and -insert-header mode.

bkramer added inline comments. Comment at: include-fixer/tool/ClangIncludeFixer.cpp:160 @@ +159,3 @@ + for (const auto &Header : Context.Headers) { +// Escape double quote. +if (Header.front() == '"') Can you just llvm::yaml::escape the string? http://r

Re: [PATCH] D20827: [include-fixer] Use YAML format in -output-headers and -insert-header mode.

hokein updated this revision to Diff 59185. hokein added a comment. Use llvm::yaml::escape to escape double quote. http://reviews.llvm.org/D20827 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixerContext.h include-fixer/tool/ClangIncludeFixer.cpp include-fixer/tool/clang-i

[PATCH] D20853: [clang-tidy] misc-macro-parentheses: Don't insert parentheses in variable declarations. Fixes bugzilla 26273

danielmarjamaki created this revision. danielmarjamaki added subscribers: cfe-commits, alexfh. danielmarjamaki set the repository for this revision to rL LLVM. This is a quick fix for bugzilla 26273. parentheses should not be inserted in variable declarations. This patch will introduce false neg

Re: [PATCH] D20827: [include-fixer] Use YAML format in -output-headers and -insert-header mode.

hokein marked an inline comment as done. hokein added a comment. http://reviews.llvm.org/D20827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20827: [include-fixer] Use YAML format in -output-headers and -insert-header mode.

bkramer added inline comments. Comment at: include-fixer/tool/ClangIncludeFixer.cpp:160 @@ +159,3 @@ + for (const auto &Header : Context.Headers) { +// Escape double quote. +if (Header.front() == '"') I think we should do the escaping always and not just

Re: [PATCH] D20827: [include-fixer] Use YAML format in -output-headers and -insert-header mode.

hokein marked an inline comment as done. hokein added a comment. http://reviews.llvm.org/D20827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20827: [include-fixer] Use YAML format in -output-headers and -insert-header mode.

hokein updated this revision to Diff 59187. hokein added a comment. Always escape headers. http://reviews.llvm.org/D20827 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixerContext.h include-fixer/tool/ClangIncludeFixer.cpp include-fixer/tool/clang-include-fixer.py test/i

Re: [PATCH] D20853: [clang-tidy] misc-macro-parentheses: Don't insert parentheses in variable declarations. Fixes bugzilla 26273

danielmarjamaki added a comment. > The "possibleVarDecl" could be much more clever. For instance, variable > declarations can at least contain :: < & also, I could handle those better > also but that would mean more false negatives. I now saw bugzilla 27399 also. I do need to handle templates

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

sbarzowski added a comment. Note ``FunctionProtoType::getNoExceptExpr`` is weird. If you have the same expr in multiple noexcepts, then it returns the same object for all of them, so it is useless for determining the location in code. I ended up finding it all "by hand" with lexer (looking for

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

sbarzowski updated the summary for this revision. sbarzowski removed rL LLVM as the repository for this revision. sbarzowski updated this revision to Diff 59179. http://reviews.llvm.org/D19201 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/ThrowWith

[PATCH] D20856: [clang-tidy] readability-identifier-naming - Support for Type Aliases

JamesReynolds created this revision. JamesReynolds added a reviewer: alexfh. JamesReynolds added a subscriber: cfe-commits. Added support for Type Alias declarations. http://reviews.llvm.org/D20856 Files: clang-tidy/readability/IdentifierNamingCheck.cpp test/clang-tidy/readability-identifier

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. In http://reviews.llvm.org/D19201#445406, @sbarzowski wrote: > Note ``FunctionProtoType::getNoExceptExpr`` is weird. If you have the same > expr in multiple noexcepts, t

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added a comment. In http://reviews.llvm.org/D19201#445496, @aaron.ballman wrote: > In http://reviews.llvm.org/D19201#445406, @sbarzowski wrote: > > > Note ``FunctionProtoType::getNoExceptExpr`` is weird. If you have the same > > expr in multiple noexcepts, then it returns the same object

Re: [PATCH] D20821: Fix a few issues while skipping function bodies

ogoffart updated this revision to Diff 59197. ogoffart added a comment. Right, i forgot about the C++11 initializer list syntax. I hope I got it right now. http://reviews.llvm.org/D20821 Files: lib/Parse/ParseCXXInlineMethods.cpp lib/Parse/ParseObjc.cpp lib/Parse/ParseStmt.cpp lib/Par

Re: [PATCH] D20855: [include-fixer] use includer of .inc header to be the file path of a symbol from .inc header.

bkramer accepted this revision. This revision is now accepted and ready to land. Comment at: include-fixer/find-all-symbols/PathConfig.cpp:20 @@ +19,3 @@ + llvm::StringRef FilePath; + while (true) { +if (!Loc.isValid() || SM.isInMainFile(Loc)) Maybe add a co

[clang-tools-extra] r271382 - [include-fixer] Use YAML format in -output-headers and -insert-header mode.

Author: hokein Date: Wed Jun 1 06:43:10 2016 New Revision: 271382 URL: http://llvm.org/viewvc/llvm-project?rev=271382&view=rev Log: [include-fixer] Use YAML format in -output-headers and -insert-header mode. Summary: And some improvements: * Show better error messages on unfound symbols. * Fix a

Re: [PATCH] D20827: [include-fixer] Use YAML format in -output-headers and -insert-header mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271382: [include-fixer] Use YAML format in -output-headers and -insert-header mode. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20827?vs=59187&id=59198#toc Repository: rL

[PATCH] D20858: [clang-format] make header guard identification stricter in header insertion.

ioeric created this revision. ioeric added a reviewer: djasper. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. don't just identify first #define as header guard anymore. Use #ifndef #define to tell if a #define belongs to header guard. http://reviews.llvm.org/D20858 F

Re: [PATCH] D20855: [include-fixer] use includer of .inc header to be the file path of a symbol from .inc header.

ioeric updated this revision to Diff 59200. ioeric added a comment. - Addressed reviewer's comments. http://reviews.llvm.org/D20855 Files: include-fixer/find-all-symbols/CMakeLists.txt include-fixer/find-all-symbols/FindAllMacros.cpp include-fixer/find-all-symbols/FindAllSymbols.cpp inc

Re: [PATCH] D20855: [include-fixer] use includer of .inc header to be the file path of a symbol from .inc header.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271385: [include-fixer] use includer of .inc header to be the file path of a symbol… (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D20855?vs=59200&id=59202#toc Repository: rL

r271387 - Adding front-end support to several intrinsics (bit scanning, conversion and state reading intrinsics)

Author: mzuckerm Date: Wed Jun 1 07:21:00 2016 New Revision: 271387 URL: http://llvm.org/viewvc/llvm-project?rev=271387&view=rev Log: Adding front-end support to several intrinsics (bit scanning, conversion and state reading intrinsics) Adding LLVM front-end support to two intrinsics dealing w

[clang-tools-extra] r271385 - [include-fixer] use includer of .inc header to be the file path of a symbol from .inc header.

Author: ioeric Date: Wed Jun 1 07:01:06 2016 New Revision: 271385 URL: http://llvm.org/viewvc/llvm-project?rev=271385&view=rev Log: [include-fixer] use includer of .inc header to be the file path of a symbol from .inc header. Summary: added PathConfig.cpp and use includer of .inc header to be t

Re: [PATCH] D20858: [clang-format] make header guard identification stricter in header insertion.

ioeric updated this revision to Diff 59206. ioeric added a comment. - Use iterator looping to simplify code. http://reviews.llvm.org/D20858 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp

Re: [PATCH] D20853: [clang-tidy] misc-macro-parentheses: Don't insert parentheses in variable declarations. Fixes bugzilla 26273

danielmarjamaki removed rL LLVM as the repository for this revision. danielmarjamaki updated this revision to Diff 59208. danielmarjamaki added a comment. Updated diff. Now also handles bugzilla 27399. http://reviews.llvm.org/D20853 Files: clang-tidy/misc/MacroParenthesesCheck.cpp test/clan

[PATCH] D20859: [X86][SSE] Replace (V)CVTTPS2DQ and VCVTTPD2DQ truncating (round to zero) f32/f64 to i32 with generic IR (clang)

RKSimon created this revision. RKSimon added reviewers: ab, mkuper, craig.topper, spatel, andreadb. RKSimon added a subscriber: cfe-commits. RKSimon set the repository for this revision to rL LLVM. The 'cvtt' truncation (round to zero) conversions can be safely represented as generic __builtin_co

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:25 @@ +24,3 @@ + Finder->addMatcher( + cxxThrowExpr(stmt(hasAncestor(functionDecl(isNoThrow()).bind("func" + .bind("throw"), you can use forFunction instead of

[PATCH] D20861: [AVX512] add missing integer to float conversion

AsafBadouh created this revision. AsafBadouh added reviewers: m_zuckerman, opaparo, igorb, delena, craig.topper. AsafBadouh added a subscriber: cfe-commits. AsafBadouh set the repository for this revision to rL LLVM. I used SSE intrinsics to implement some of the conversion. for example: ``` #de

Re: [PATCH] D20858: [clang-format] make header guard identification stricter in header insertion.

djasper added inline comments. Comment at: lib/Format/Format.cpp:1472 @@ -1471,2 +1471,3 @@ llvm::Regex IncludeRegex(IncludeRegexPattern); - llvm::Regex DefineRegex(R"(^[\t\ ]*#[\t\ ]*define[\t\ ]*[^\\]*$)"); + llvm::Regex IfNDefRegex(R"(^[\t\ ]*#[\t\ ]*ifndef[\t\ ]*([^\\]*)$

[libcxxabi] r271388 - Missed part of D16545 (static lib testing)

Author: bcraig Date: Wed Jun 1 07:50:30 2016 New Revision: 271388 URL: http://llvm.org/viewvc/llvm-project?rev=271388&view=rev Log: Missed part of D16545 (static lib testing) http://reviews.llvm.org/D16545 Modified: libcxxabi/trunk/CMakeLists.txt Modified: libcxxabi/trunk/CMakeLists.txt UR

Re: [PATCH] D16545: [libcxxabi] Enable testing for static libc++abi

bcraig added a comment. In http://reviews.llvm.org/D16545#444869, @bcraig wrote: > In http://reviews.llvm.org/D16545#444854, @rmaprath wrote: > > > Perhaps you forgot to commit that file? > > > Hrm, you're right, it didn't go in. I'll get it in tomorrow morning. Should be in now. r271388. h

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:32 @@ +31,3 @@ +// token including trailing whitespace. +static SourceRange FindToken(const SourceManager &Sources, LangOptions LangOpts, + SourceLocation StartLoc, So

Re: [PATCH] D20858: [clang-format] make header guard identification stricter in header insertion.

ioeric added inline comments. Comment at: lib/Format/Format.cpp:1472 @@ -1471,2 +1471,3 @@ llvm::Regex IncludeRegex(IncludeRegexPattern); - llvm::Regex DefineRegex(R"(^[\t\ ]*#[\t\ ]*define[\t\ ]*[^\\]*$)"); + llvm::Regex IfNDefRegex(R"(^[\t\ ]*#[\t\ ]*ifndef[\t\ ]*([^\\]*)$)

Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

Prazek added a comment. ping http://reviews.llvm.org/D18821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20561: Warn when taking address of packed member

aaron.ballman added a comment. This is getting really close, I mostly only have nits left. Comment at: lib/Sema/SemaExpr.cpp:10529 @@ +10528,3 @@ +bool ByteAligned = Context.getTypeAlignInChars(MD->getType()).isOne(); +if (ByteAligned) // packed has had not any effect on

Re: [PATCH] D19165: [clang-tidy] Add modernize-increment-bool check.

aaron.ballman added a comment. In http://reviews.llvm.org/D19165#419848, @Prazek wrote: > ping @Alexfh have you check it? I would still strongly prefer to see this fixed in `CheckIncrementDecrementOperand` instead of creating an entire clang-tidy check for it. http://reviews.llvm.org/D19165

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

aaron.ballman requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:25 @@ +24,3 @@ + Finder->addMatcher( + cxxThrowExpr(stmt(hasAncestor(functionDecl(isNoThrow()).bind("func" + .

Re: [PATCH] D20810: [Clang][Intrinsics][avx512] Continue Adding round cvt to clang

AsafBadouh accepted this revision. AsafBadouh added a comment. This revision is now accepted and ready to land. minor fixes, LGTM Comment at: lib/Headers/avx512fintrin.h:3658 @@ +3657,3 @@ +_mm256_undefined_si256 (),\ +

r271392 - Fix the CLANG_ENABLE_STATIC_ANALYZER=OFF build.

Author: yrnkrn Date: Wed Jun 1 08:47:26 2016 New Revision: 271392 URL: http://llvm.org/viewvc/llvm-project?rev=271392&view=rev Log: Fix the CLANG_ENABLE_STATIC_ANALYZER=OFF build. tools/clang/tools/CMakeLists.txt does not create the clang-check target when CLANG_ENABLE_STATIC_ANALYZER=OFF. Mod

Re: [PATCH] D20811: [analyzer] Model some library functions

xazax.hun added a comment. It is great to model more widely used functions! However I think the LibraryFunctionsChecker name might be a bit to broad, wouldn't something like StdCLibraryFunctions be more informative? http://reviews.llvm.org/D20811

[PATCH] D20863: [analyzer] Fix for the strdup family in unix.malloc checker

baloghadamsoftware created this revision. baloghadamsoftware added a reviewer: dcoughlin. baloghadamsoftware added subscribers: cfe-commits, xazax.hun, o.gyorgy. The strdup family was only partially handled in the original checker. As a consequence it did not recognize leaks where a variable whic

[PATCH] D20864: Adding support for Cortex-A73

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: rengolin, t.p.northover. SjoerdMeijer added a subscriber: cfe-commits. This adds target support and tests for Cortex-A73 http://reviews.llvm.org/D20864 Files: lib/Basic/Targets.cpp lib/Driver/Tools.cpp test/CodeGen/arm-targe

[PATCH] D20866: [Clang][AVX512]Adding set4 intrinsics

m_zuckerman created this revision. m_zuckerman added reviewers: delena, AsafBadouh, igorb. m_zuckerman added a subscriber: cfe-commits. http://reviews.llvm.org/D20866 Files: lib/Headers/avx512fintrin.h test/CodeGen/avx512f-builtins.c Index: test/CodeGen/avx512f-builtins.c ===

Re: [PATCH] D20866: [Clang][AVX512]Adding set4 intrinsics

AsafBadouh added inline comments. Comment at: test/CodeGen/avx512f-builtins.c:6161 @@ +6160,3 @@ + +__m512i test_mm512_setr4_epi32(e0,e1,e2,e3) +{ types are missing http://reviews.llvm.org/D20866 ___ cfe-commits mai

r271398 - [Clang][Intrinsics][avx512] Continue Adding round cvt to clang

Author: mzuckerm Date: Wed Jun 1 09:41:41 2016 New Revision: 271398 URL: http://llvm.org/viewvc/llvm-project?rev=271398&view=rev Log: [Clang][Intrinsics][avx512] Continue Adding round cvt to clang And remove trailing spaces in intrinsic f test Differential Revision: http://reviews.llvm.org/D2081

Add Comments::const_child_iterator and (const_)child_range

Hi all, this is my first patch, so please be patient. I normaly submit to gfortran and their policies for submission are somewhat different. Subject of the patch: The patch adds the missing const_child_iterator to all Comment classes and changes the mutable child_iterator to be mutable again.

Re: [PATCH] D20810: [Clang][Intrinsics][avx512] Continue Adding round cvt to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL271398: [Clang][Intrinsics][avx512] Continue Adding round cvt to clang (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D20810?vs=59048&id=59223#toc Repository: rL LLVM http:

Re: [PATCH] D20859: [X86][SSE] Replace (V)CVTTPS2DQ and VCVTTPD2DQ truncating (round to zero) f32/f64 to i32 with generic IR (clang)

ab accepted this revision. ab added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D20859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D20447: [OpenCL] Fixup extension list

Anastasia added inline comments. Comment at: test/SemaOpenCL/extension-version.cl:41 @@ +40,3 @@ + +// COre features in CL 1.1 +#if (__OPENCL_C_VERSION__ < 110) Anastasia wrote: > COre -> core Actually looking at other comments -> Core Repository: rL LLVM htt

Re: [PATCH] D20447: [OpenCL] Fixup extension list

Anastasia added inline comments. Comment at: test/SemaOpenCL/extension-version.cl:41 @@ +40,3 @@ + +// COre features in CL 1.1 +#if (__OPENCL_C_VERSION__ < 110) COre -> core Comment at: test/SemaOpenCL/extension-version.cl:73 @@ +72,3 @@ + +#endi

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. It came to my mind that might be good idea adding one of those "fix-it" suggestions so the user knows it can silence the warning by using parentheses. What do you think? http://reviews.llvm.org/D20561 ___ cfe-commits mail

Re: [PATCH] D20798: clang-format: [JS] Sort imported symbols.

mprobst marked an inline comment as done. mprobst added a comment. http://reviews.llvm.org/D20798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20798: clang-format: [JS] Sort imported symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271400: clang-format: [JS] Sort imported symbols. (authored by mprobst). Changed prior to commit: http://reviews.llvm.org/D20798?vs=59070&id=59226#toc Repository: rL LLVM http://reviews.llvm.org/D20

Re: [PATCH] D20561: Warn when taking address of packed member

aaron.ballman added a comment. In http://reviews.llvm.org/D20561#445730, @rogfer01 wrote: > It came to my mind that might be good idea adding one of those "fix-it" > suggestions so the user knows it can silence the warning by using > parentheses. What do you think? I don't think that would be

r271401 - clang-format: [JS] no ASI on `import {x as\n y}`.

Author: mprobst Date: Wed Jun 1 10:22:47 2016 New Revision: 271401 URL: http://llvm.org/viewvc/llvm-project?rev=271401&view=rev Log: clang-format: [JS] no ASI on `import {x as\n y}`. Summary: ASI did not handle the ES6 `as` operator correctly. Reviewers: djasper Subscribers: klimek, cfe-commit

Re: [PATCH] D20817: clang-format: [JS] no ASI on `import {x as\n y}`.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271401: clang-format: [JS] no ASI on `import {x as\n y}`. (authored by mprobst). Changed prior to commit: http://reviews.llvm.org/D20817?vs=59074&id=59227#toc Repository: rL LLVM http://reviews.llvm

Re: [PATCH] D20389: NVPTX: Add supported CL features

Anastasia added inline comments. Comment at: test/Misc/nvptx.languageOptsOpenCL.cl:1 @@ +1,2 @@ +// REQUIRES: nvptx-registered-target +// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple nvptx-unknown-unknown Should we check for errors on unsupported extensions

r271400 - clang-format: [JS] Sort imported symbols.

Author: mprobst Date: Wed Jun 1 10:19:53 2016 New Revision: 271400 URL: http://llvm.org/viewvc/llvm-project?rev=271400&view=rev Log: clang-format: [JS] Sort imported symbols. Summary: E.g. sort `import {b, a} from 'x';` into `import {a, b} from 'x';`. Reviewers: djasper Subscribers: cfe-commit

Re: [PATCH] D20388: AMDGPU: Fix supported CL features

Anastasia added inline comments. Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:1 @@ +1,2 @@ +// REQUIRES: amdgpu-registered-target +// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple amdgcn-unknown-unknown Negative testing? Repository: rL LLVM http:/

[PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

pgousseau created this revision. pgousseau added reviewers: rsmith, thakis. pgousseau added subscribers: cfe-commits, wristow, probinson, gbedwell, bruno, cameron314. On Linux, if the timestamp of a header file, included in the pch, is modified, then including the pch without regenerating it cau

Re: [PATCH] D20744: [OpenCL] Disable warning about core features by default

Anastasia accepted this revision. Anastasia added a comment. LGTM! Repository: rL LLVM http://reviews.llvm.org/D20744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17438: [OpenCL] Add Sema checks for atomics and implicit declaration

Anastasia added a comment. In http://reviews.llvm.org/D17438#443422, @pxli168 wrote: > Yes, I found although the khronos have make a clarify with implicit > declarations but they sames to be useful with some program link. And I found > some test case about link could not pass by this reason. >

Re: r271399 - It seems we need to add SemaExpr.cpp to the /bigobj list; I am getting consistent failures of hitting the section count limit.

Thanks! I've just noticed this today locally. It happens with unoptimized builds only so the bots are not catching it. 2016-06-01 18:17 GMT+03:00 Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org>: > Author: aaronballman > Date: Wed Jun 1 10:17:54 2016 > New Revision: 271399 > > URL:

r271399 - It seems we need to add SemaExpr.cpp to the /bigobj list; I am getting consistent failures of hitting the section count limit.

Author: aaronballman Date: Wed Jun 1 10:17:54 2016 New Revision: 271399 URL: http://llvm.org/viewvc/llvm-project?rev=271399&view=rev Log: It seems we need to add SemaExpr.cpp to the /bigobj list; I am getting consistent failures of hitting the section count limit. Modified: cfe/trunk/lib/Se

Re: [PATCH] D20843: ObjC lifetime: pull sugar off when the qualifiers conflict.

rjmccall added a comment. Oh sure, because we don't strip the original type if there isn't a conflict. LGTM. http://reviews.llvm.org/D20843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D20843: ObjC lifetime: pull sugar off when the qualifiers conflict.

manmanren added a comment. In http://reviews.llvm.org/D20843#445756, @rjmccall wrote: > Oh sure, because we don't strip the original type if there isn't a conflict. > LGTM. Exactly, thanks for reviewing! Manman http://reviews.llvm.org/D20843 _

Re: [PATCH] D20844: FixIt: correctly set DeclSpec's range end for a type name annotation.

rjmccall added a comment. Hmm. No, I think the original code is correct here — RangeEnd is a token range, and those are generally inclusive rather than exclusive. The fix-it needs to be inserting at the end of the token. http://reviews.llvm.org/D20844 _

Re: [PATCH] D20630: [OpenCL] Allow -std={cl|CL}{|1.1|1.2|2.0} in driver

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! http://reviews.llvm.org/D20630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 marked 2 inline comments as done. rogfer01 added a comment. Well, the assignment-vs-comparison warning does emit a fix-it in `Sema::DiagnoseAssignmentAsCondition(Expr *E)` Diag(Loc, diag::note_condition_assign_silence) << FixItHint::CreateInsertion(Open, "(") << FixItH

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

Anastasia added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:1782 @@ -1773,2 +1781,3 @@ Opts.RTTIData = Opts.RTTI && !Args.hasArg(OPT_fno_rtti_data); - Opts.Blocks = Args.hasArg(OPT_fblocks); + Opts.Blocks = Args.hasArg(OPT_fblocks) || (Opts.OpenCL +&&

[PATCH] D20870: [Clang][AVX512][INTRINSICS] adding round cvt and fix regular cvtps_ph

m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. http://reviews.llvm.org/D20870 Files: lib/Headers/avx512vlintrin.h test/CodeGen/avx512vl-builtins.c Index: test/CodeGen/avx512vl-builtins.c

Re: [PATCH] D20447: [OpenCL] Fixup extension list

jvesely marked 2 inline comments as done. Comment at: test/SemaOpenCL/extension-version.cl:73 @@ +72,3 @@ + +#endif + Anastasia wrote: > Could you put a comment to make it more readable, something like > > #endif // (__OPENCL_C_VERSION__ < 110) These large block

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. I think I wasn't clear with the purpose of the fix-it: there are a few cases where getting the address of an unaligned pointer is safe (i.e. false positives). For instance, when I checked Firefox and Chromium there are cases where getting the address of an unaligned p

[PATCH] D20871: [Clang][AVX512][Intrinsics] Adding two definitions _mm512_setzero and _mm512_setzero_epi32

m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. http://reviews.llvm.org/D20871 Files: lib/Headers/avx512fintrin.h Index: lib/Headers/avx512fintrin.h =

Re: [PATCH] D20447: [OpenCL] Fixup extension list

Anastasia added inline comments. Comment at: test/SemaOpenCL/extension-version.cl:73 @@ +72,3 @@ + +#endif + jvesely wrote: > Anastasia wrote: > > Could you put a comment to make it more readable, something like > > > > #endif // (__OPENCL_C_VERSION__ < 110) > T

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 marked 5 inline comments as done. rogfer01 added a comment. http://reviews.llvm.org/D20561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20447: [OpenCL] Fixup extension list

jvesely updated this revision to Diff 59240. jvesely added a comment. Fix typo: COre -> Core Repository: rL LLVM http://reviews.llvm.org/D20447 Files: include/clang/Basic/OpenCLExtensions.def test/SemaOpenCL/extension-version.cl Index: test/SemaOpenCL/extension-version.cl ==

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 updated this revision to Diff 59241. rogfer01 added a comment. This change adds a fix-it suggesting parentheses to silence the warning. http://reviews.llvm.org/D20561 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/Sema/address-packed.c test/SemaCXX

Re: [PATCH] D20447: [OpenCL] Fixup extension list

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rL LLVM http://reviews.llvm.org/D20447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

Re: [PATCH] D16545: [libcxxabi] Enable testing for static libc++abi

rmaprath added a comment. Works great. Thanks! http://reviews.llvm.org/D16545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko added a comment. There is a way to tell IWYU about compound headers with pragmas . I also suggested to make this possible via file with compound headers list. But person who knows LLVM/C

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

bruno added inline comments. Comment at: test/PCH/include-timestamp.cpp:5 @@ +4,3 @@ +// Check timestamp is included by default. +// RUN: %clang_cc1 -x c++-header -emit-pch -o %t %S/Inputs/include-timestamp-pch.h +// RUN: touch %S/Inputs/include-timestamp.h Can y

r271409 - ObjC lifetime: pull sugar off when the qualifiers conflict.

Author: mren Date: Wed Jun 1 12:14:19 2016 New Revision: 271409 URL: http://llvm.org/viewvc/llvm-project?rev=271409&view=rev Log: ObjC lifetime: pull sugar off when the qualifiers conflict. It's possible to have multiple local ObjCLifetime qualifiers. When there is a conflict, we can't stop afte

Re: [PATCH] D20843: ObjC lifetime: pull sugar off when the qualifiers conflict.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271409: ObjC lifetime: pull sugar off when the qualifiers conflict. (authored by mren). Changed prior to commit: http://reviews.llvm.org/D20843?vs=59149&id=59249#toc Repository: rL LLVM http://revie

Re: [Diffusion] rL249410: [Tooling] Reuse FileManager in ASTUnit.

cameron314 added a subscriber: cfe-commits. http://reviews.llvm.org/rL249410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

etienneb added a comment. In http://reviews.llvm.org/D20714#445911, @Eugene.Zelenko wrote: > There is a way to tell IWYU about compound headers with pragmas > . > I also suggested to make this possible

Re: [PATCH] D20447: [OpenCL] Fixup extension list

This revision was automatically updated to reflect the committed changes. jvesely marked 5 inline comments as done. Closed by commit rL271413: Fixup list of available extensions (authored by jvesely). Changed prior to commit: http://reviews.llvm.org/D20447?vs=59240&id=59254#toc Repository: r

Re: [PATCH] D20744: [OpenCL] Disable warning about core features by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL271414: Disable warning about core features by default (authored by jvesely). Changed prior to commit: http://reviews.llvm.org/D20744?vs=59079&id=59255#toc Repository: rL LLVM http://reviews.llvm.or

r271414 - Disable warning about core features by default

Author: jvesely Date: Wed Jun 1 13:04:53 2016 New Revision: 271414 URL: http://llvm.org/viewvc/llvm-project?rev=271414&view=rev Log: Disable warning about core features by default Reviewers: Anastasia, yaxunl Differential Revision: http://reviews.llvm.org/D20744 Modified: cfe/trunk/include

r271413 - Fixup list of available extensions

Author: jvesely Date: Wed Jun 1 13:04:50 2016 New Revision: 271413 URL: http://llvm.org/viewvc/llvm-project?rev=271413&view=rev Log: Fixup list of available extensions Reviewers: Anastasia Differential Revision: http://reviews.llvm.org/D20447 Added: cfe/trunk/test/SemaOpenCL/extension-vers

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko added a comment. See https://github.com/include-what-you-use/include-what-you-use/issues/292 and https://github.com/include-what-you-use/include-what-you-use/issues/301. Repository: rL LLVM http://reviews.llvm.org/D20714 ___ cfe-c

  1   2   >