rmaprath added a comment.
Would you / community be open to the idea of hiding the os syscalls behind an
API? (like we are doing for pthreads)?
I think this is the only way we could get at least some of this functionality
working on bare-metal ARM (it should work on arm-linux without much troubl
EricWF added a comment.
Ah I figured it out! The test suite has symlinks within it. Git handles them
properly but they obviously don't survive the round trip to phabricator and
back. So all of the tests that depend on them fail (with is evidently a lot).
http://reviews.llvm.org/D16948
_
Author: ctopper
Date: Tue May 31 01:58:07 2016
New Revision: 271253
URL: http://llvm.org/viewvc/llvm-project?rev=271253&view=rev
Log:
[AVX512] Convert masked load builtins to generic masked load intrinsics instead
of the x86 specific ones.
This will allow the x86 intrinsics to be removed from th
rmaprath added a comment.
In http://reviews.llvm.org/D16948#444010, @EricWF wrote:
> Ah I figured it out! The test suite has symlinks within it. Git handles them
> properly but they obviously don't survive the round trip to phabricator and
> back. So all of the tests that depend on them fail (w
EricWF added a comment.
In http://reviews.llvm.org/D16948#444009, @rmaprath wrote:
> Would you / community be open to the idea of hiding the os syscalls behind an
> API? (like we are doing for pthreads)?
Yes I would be very open to that. Then I could also have test shims in order to
test trul
EricWF added a comment.
The git branch I develop on is public:
https://github.com/efcs/libcxx/tree/filesystem-ts
You can download or clone from there (and it will always be up to date!).
http://reviews.llvm.org/D16948
___
cfe-commits mailing list
rmaprath added a comment.
In http://reviews.llvm.org/D16948#444013, @EricWF wrote:
> The git branch I develop on is public:
> https://github.com/efcs/libcxx/tree/filesystem-ts
>
> You can download or clone from there (and it will always be up to date!).
All tests pass! :-)
I'll try to find an
djasper added inline comments.
Comment at: lib/Format/Format.cpp:1549
@@ -1408,3 +1548,3 @@
// We need to use lambda function here since there are two versions of
// `cleanup`.
auto Cleanup = [](const FormatStyle &Style, StringRef Code,
So, add a copy con
craig.topper closed this revision.
craig.topper added a comment.
Commited in r271246.
http://reviews.llvm.org/D20782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek added a comment.
In http://reviews.llvm.org/D20277#436725, @flx wrote:
> In http://reviews.llvm.org/D20277#436717, @Prazek wrote:
>
> > Cool check! Did you think about sugesting std::move for rvalue references
> > if they are used once?
>
>
> Thanks! I'm not sure this fits with what a use
ioeric updated this revision to Diff 59017.
ioeric added a comment.
- Use std::set_difference in fixCppIncludeInsertions()
http://reviews.llvm.org/D20734
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format/CleanupTest.cpp
==
hokein updated this revision to Diff 59018.
hokein marked 2 inline comments as done.
hokein added a comment.
Fix code style.
http://reviews.llvm.org/D20621
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncl
klimek added a reviewer: bkramer.
klimek added a comment.
Generally makes sense; adding d0k for additional thoughts.
http://reviews.llvm.org/D20382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
LG. Can't wait to use it myself :)
http://reviews.llvm.org/D20621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
ioeric created this revision.
ioeric added a reviewer: bkramer.
ioeric added subscribers: djasper, hokein, cfe-commits.
[include-fixer] collect the number of times a symbols is found in an
indexing run and use it for symbols popularity ranking.
http://reviews.llvm.org/D20804
Files:
include-fix
bkramer added a comment.
Having postorder traversal makes sense to me. The thing I'm worried about is
how much this will bloat object code. RecursiveASTVisitor is already a major
contributor to the size of clang's binary and we've hit issues with it in the
past (hitting .obj size limits on Wind
bkramer added inline comments.
Comment at: include-fixer/find-all-symbols/tool/FindAllSymbolsMain.cpp:91
@@ -90,2 +90,3 @@
std::set UniqueSymbols;
+ std::map NumOccurrences;
std::mutex SymbolMutex;
Can we remove the set now? 2 copies of all SymbolInfos seem
djasper added inline comments.
Comment at: lib/Format/Format.cpp:1444
@@ +1443,3 @@
+ if (!llvm::Regex(IncludeRegexPattern).match(Replace.getReplacementText())) {
+llvm::errs() << "Insertions other than header #include insertion are "
+"not supported! "
--
hokein updated this revision to Diff 59026.
hokein added a comment.
Update a out-of-date comment.
http://reviews.llvm.org/D20621
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixe
klimek added inline comments.
Comment at: include-fixer/IncludeFixer.h:74
@@ +73,3 @@
+/// \return Replacements for inserting and sorting headers.
+std::vector createInsertHeaderReplacements(
+StringRef Code, StringRef FilePath, StringRef Header,
This is still
ioeric updated this revision to Diff 59027.
ioeric added a comment.
- Removed a redundant set of symbols during merging.
http://reviews.llvm.org/D20804
Files:
include-fixer/find-all-symbols/SymbolInfo.cpp
include-fixer/find-all-symbols/SymbolInfo.h
include-fixer/find-all-symbols/tool/Find
hokein updated this revision to Diff 59028.
hokein added a comment.
Add -1U comment back.
http://reviews.llvm.org/D20621
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/tool/c
hokein marked an inline comment as done.
hokein added a comment.
http://reviews.llvm.org/D20621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D20804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: hokein
Date: Tue May 31 04:31:51 2016
New Revision: 271258
URL: http://llvm.org/viewvc/llvm-project?rev=271258&view=rev
Log:
[include-fixer] Create a mode in vim integration to show multiple potential
headers.
Summary:
Some changes in the patch:
* Add two commandline flags in clang-incl
klimek accepted this revision.
klimek added a reviewer: klimek.
klimek added a comment.
lg
http://reviews.llvm.org/D20621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271258: [include-fixer] Create a mode in vim integration to
show multiple potential… (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20621?vs=59028&id=59030#toc
Repository:
rL
hokein added a comment.
In http://reviews.llvm.org/D20621#444050, @bkramer wrote:
> LG. Can't wait to use it myself :)
Currently, the header is only inserted at the first line of the file because we
don't output the FirstIncludeOffset to py script. A follow-up patch will come
soon.
Reposito
rengolin added a comment.
In http://reviews.llvm.org/D20709#443950, @srhines wrote:
> Correct. This is only used by RenderScript, and unfortunately can't be done
> any differently. We had hoped to just predicate this with our own LangOpt
> (the patch that adds the RenderScript LangOpt is coming
Author: hokein
Date: Tue May 31 05:06:12 2016
New Revision: 271261
URL: http://llvm.org/viewvc/llvm-project?rev=271261&view=rev
Log:
[include-fixer] Add missing dependency.
Modified:
clang-tools-extra/trunk/include-fixer/tool/CMakeLists.txt
Modified: clang-tools-extra/trunk/include-fixer/too
Author: d0k
Date: Tue May 31 05:17:46 2016
New Revision: 271262
URL: http://llvm.org/viewvc/llvm-project?rev=271262&view=rev
Log:
[CommonOptionsParser] Return source paths as const ref.
This saves a superfluous copy and makes managing the lifetime of the
returned strings a bit easier.
Modified:
ioeric added inline comments.
Comment at: unittests/Format/CleanupTest.cpp:310
@@ +309,3 @@
+
+ Context.createInMemoryFile("fix.cpp", Code);
+ tooling::Replacements Replaces;
djasper wrote:
> I'd pull out a lot of these environment setup things into abstractions
ioeric updated this revision to Diff 59035.
ioeric marked 7 inline comments as done.
ioeric added a comment.
- Addressed commments.
http://reviews.llvm.org/D20734
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format/CleanupTe
rogfer01 reclaimed this revision.
rogfer01 added a comment.
This revision is now accepted and ready to land.
Well, seems that Renato reverted the changes, so this still holds.
http://reviews.llvm.org/D20283
___
cfe-commits mailing list
cfe-commits@l
rogfer01 added a comment.
Ping?
Thank you very much
http://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper added inline comments.
Comment at: unittests/Format/CleanupTest.cpp:310
@@ +309,3 @@
+ Context.createInMemoryFile("fix.cpp", Code);
+ tooling::Replacements Replaces = {
+ tooling::Replacement("fix.cpp", UINT_MAX, 0, "#include \"b.h\"")};
Well, the o
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
* Abstract the DB setting code to a function.
* Remove the unused FallbackStyle.
http://reviews.llvm.org/D20808
Files:
include-fixer/IncludeFixer.cpp
include-fixer/tool/ClangIncludeFixer.c
Author: abataev
Date: Tue May 31 06:17:08 2016
New Revision: 271263
URL: http://llvm.org/viewvc/llvm-project?rev=271263&view=rev
Log:
[OPENMP] Update in ReleaseNotes for OpenMP support.
Added notes about full support of all non-offloading features of OpenMP
4.5 + info about option -fopenmp-versio
Author: mzuckerm
Date: Tue May 31 06:27:34 2016
New Revision: 271265
URL: http://llvm.org/viewvc/llvm-project?rev=271265&view=rev
Log:
[Clang][Intrinsics][avx512] Adding round cvt to clang
Differential Revision: http://reviews.llvm.org/D20790
Modified:
cfe/trunk/lib/Headers/avx512fintrin.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271265: [Clang][Intrinsics][avx512] Adding round cvt to
clang (authored by mzuckerm).
Changed prior to commit:
http://reviews.llvm.org/D20790?vs=58957&id=59040#toc
Repository:
rL LLVM
http://reviews
Author: d0k
Date: Tue May 31 06:28:34 2016
New Revision: 271266
URL: http://llvm.org/viewvc/llvm-project?rev=271266&view=rev
Log:
Make the vim integration output a bit prettier and drop the -debug flag.
Modified:
clang-tools-extra/trunk/include-fixer/tool/clang-include-fixer.py
Modified: cla
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
Also some misc tweaks.
http://reviews.llvm.org/D20809
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/t
hokein updated this revision to Diff 59042.
hokein added a comment.
Rebase
http://reviews.llvm.org/D20809
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixerContext.h
include-fixer/tool/ClangIncludeFixer.cpp
include-fixer/tool/clang-include-fixer.py
Index: include-fixer/to
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D20808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ioeric added inline comments.
Comment at: unittests/Format/CleanupTest.cpp:310
@@ +309,3 @@
+ Context.createInMemoryFile("fix.cpp", Code);
+ tooling::Replacements Replaces = {
+ tooling::Replacement("fix.cpp", UINT_MAX, 0, "#include \"b.h\"")};
djasper wrot
ioeric updated this revision to Diff 59043.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Addressed reviewer's comments.
http://reviews.llvm.org/D20734
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271268: [include-fixer] collect the number of times a
symbols is found in an indexing… (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D20804?vs=59027&id=59045#toc
Repository:
Author: ioeric
Date: Tue May 31 07:01:48 2016
New Revision: 271268
URL: http://llvm.org/viewvc/llvm-project?rev=271268&view=rev
Log:
[include-fixer] collect the number of times a symbols is found in an indexing
run and use it for symbols popularity ranking.
Summary:
[include-fixer] collect the n
Author: asiri
Date: Tue May 31 07:01:32 2016
New Revision: 271267
URL: http://llvm.org/viewvc/llvm-project?rev=271267&view=rev
Log:
[libcxxabi] Introduce a -fno-exceptions libc++abi libary variant
Currently there is only support for a -fno-exceptions libc++ build. This is
problematic for function
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271267: [libcxxabi] Introduce a -fno-exceptions libc++abi
libary variant (authored by asiri).
Changed prior to commit:
http://reviews.llvm.org/D20677?vs=59009&id=59044#toc
Repository:
rL LLVM
http:/
rengolin added a comment.
In http://reviews.llvm.org/D18035#440107, @rsmith wrote:
> Please try to appropriately apportion the responsibility here; if your
> distribution opted into a non-standard ABI for their C++ standard library,
> you should point out to them that they made a mistake.
I t
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
A few nitpicks, but otherwise looks good.
Comment at: lib/Format/Format.cpp:1287
@@ +1286,3 @@
+int Ret = INT_MAX;
+for (unsigned I = 0, E = CategoryRegexs.size(); I
Author: d0k
Date: Tue May 31 07:12:19 2016
New Revision: 271270
URL: http://llvm.org/viewvc/llvm-project?rev=271270&view=rev
Log:
[find-all-symbols] Add a test to make sure merging actually works.
Added:
clang-tools-extra/trunk/test/include-fixer/Inputs/merge/
clang-tools-extra/trunk/test
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D20773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
m_zuckerman created this revision.
m_zuckerman added reviewers: AsafBadouh, igorb, delena.
m_zuckerman added a subscriber: cfe-commits.
http://reviews.llvm.org/D20810
Files:
lib/Headers/avx512fintrin.h
test/CodeGen/avx512f-builtins.c
Index: test/CodeGen/avx512f-builtins.c
===
aaron.ballman added a comment.
In http://reviews.llvm.org/D20561#442051, @rogfer01 wrote:
> Only warn if the expression is of the form &a.x this way &(a.x) can be used
> to silence the warning.
I think this is a reasonable idea, but would still like to make sure we have a
low false-positive r
Author: hokein
Date: Tue May 31 08:23:00 2016
New Revision: 271273
URL: http://llvm.org/viewvc/llvm-project?rev=271273&view=rev
Log:
[include-fixer] Code cleanup.
Summary:
* Abstract the DB setting code to a function.
* Remove the unused FallbackStyle.
Reviewers: bkramer
Subscribers: cfe-commit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271273: [include-fixer] Code cleanup. (authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D20808?vs=59038&id=59052#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20808
Files:
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin.
NoQ added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
I've put together a simple checker that throws no warnings, but models some
library functions, which has already helped us to suppress some false positiv
ioeric updated this revision to Diff 59053.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Nits fixed.
http://reviews.llvm.org/D20734
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format/CleanupTest.cpp
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271275: [ARM] Add load/store co-processor intrinsics.
(authored by rsingh).
Changed prior to commit:
http://reviews.llvm.org/D20563?vs=58314&id=59055#toc
Repository:
rL LLVM
http://reviews.llvm.org/
Author: rsingh
Date: Tue May 31 08:31:25 2016
New Revision: 271275
URL: http://llvm.org/viewvc/llvm-project?rev=271275&view=rev
Log:
[ARM] Add load/store co-processor intrinsics.
Differential Revision: http://reviews.llvm.org/D20563
Modified:
cfe/trunk/include/clang/Basic/BuiltinsARM.def
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271276: [clang-format] insert new #includes into correct
blocks when cleaning up… (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D20734?vs=59053&id=59056#toc
Repository:
rL LL
Author: ioeric
Date: Tue May 31 08:34:20 2016
New Revision: 271276
URL: http://llvm.org/viewvc/llvm-project?rev=271276&view=rev
Log:
[clang-format] insert new #includes into correct blocks when cleaning up
Replacement with cleanupAroundReplacements().
Summary:
When a replacement's offset is set
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
nice cleanup
http://reviews.llvm.org/D20813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: ioeric
Date: Tue May 31 08:52:59 2016
New Revision: 271279
URL: http://llvm.org/viewvc/llvm-project?rev=271279&view=rev
Log:
[include-fixer] use tooling::Replacements since the order of replacements don't
matter anymore.
Summary: [include-fixer] use tooling::Replacements since the order
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271279: [include-fixer] use tooling::Replacements since the
order of replacements… (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D20813?vs=59060&id=59061#toc
Repository:
rL L
bkramer created this revision.
bkramer added reviewers: ioeric, djasper.
bkramer added a subscriber: cfe-commits.
This sorts based on the popularity of the header, not the symbol. If
there are mutliple matching symbols in one header we take the maximum
popularity for that header and deduplicate. I
djasper added a comment.
In general, this is lacking test cases for imports that are wrapped over
multiple lines to start with. Should probably add those both for the old and
for the new behavior.
Comment at: lib/Format/Format.cpp:1229
@@ -1227,9 +1228,3 @@
// the entire bl
Burt Wesarg points out on cfe-dev that this commit message doesn't match
the patch (nor the description provided in the code review thread that lead
to this commit) - this one might be worth reverting and recommitting with a
more accurate commit message (I don't usually suggest this for most commit
Author: d0k
Date: Tue May 31 09:14:42 2016
New Revision: 271280
URL: http://llvm.org/viewvc/llvm-project?rev=271280&view=rev
Log:
Avoid unused variable warning in release builds.
Modified:
cfe/trunk/lib/Format/Format.cpp
Modified: cfe/trunk/lib/Format/Format.cpp
URL:
http://llvm.org/viewvc/
Author: marshall
Date: Tue May 31 09:29:38 2016
New Revision: 271282
URL: http://llvm.org/viewvc/llvm-project?rev=271282&view=rev
Log:
Issues for Oulu
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-project/l
djasper accepted this revision.
This revision is now accepted and ready to land.
Comment at: include-fixer/SymbolIndexManager.cpp:25
@@ +24,3 @@
+ // First collect occurrences per header file.
+ std::map HeaderPopularity;
+ for (const SymbolInfo &Symbol : Symbols) {
---
bader added a comment.
Sorry for the delay.
Is this code valid:
clk_event_t e1, e2, e3;
clk_event_t events[] = {e1, e2};
enqueue_kernel(get_default_queue(), 0, get_ndrange(), 2, events, &e3, ...);
With this patch clang rejects it with an error:
'illegal call to enqueue_kernel, expected
Author: d0k
Date: Tue May 31 09:33:28 2016
New Revision: 271283
URL: http://llvm.org/viewvc/llvm-project?rev=271283&view=rev
Log:
[include-fixer] Rank symbols based on the number of occurrences we found while
merging.
This sorts based on the popularity of the header, not the symbol. If
there are
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271283: [include-fixer] Rank symbols based on the number of
occurrences we found… (authored by d0k).
Changed prior to commit:
http://reviews.llvm.org/D20814?vs=59062&id=59065#toc
Repository:
rL LLVM
Author: d0k
Date: Tue May 31 09:37:10 2016
New Revision: 271284
URL: http://llvm.org/viewvc/llvm-project?rev=271284&view=rev
Log:
[include-fixer] Use a DenseMap, order doesn't matter here.
Modified:
clang-tools-extra/trunk/include-fixer/SymbolIndexManager.cpp
Modified: clang-tools-extra/trun
Author: d0k
Date: Tue May 31 09:40:10 2016
New Revision: 271285
URL: http://llvm.org/viewvc/llvm-project?rev=271285&view=rev
Log:
[include-fixer] Inline trivial methods.
Putting them into the .cpp file is both more verbose and slower than
having them in the header. No functional change intended.
rogfer01 marked 3 inline comments as done.
Comment at: lib/Sema/SemaExpr.cpp:10527
@@ +10526,3 @@
+if (RD->hasAttr() ||
+ME->getMemberDecl()->hasAttr()) {
+ Diag(OpLoc, diag::warn_taking_address_of_packed_member)
aaron.ballman wrote:
> Ah, I forgo
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Look at all this annoying preprocessor code going away! I love it.
http://reviews.llvm.org/D20816
___
cfe-commits mailing list
cfe-commits@list
Author: ioeric
Date: Tue May 31 09:48:45 2016
New Revision: 271287
URL: http://llvm.org/viewvc/llvm-project?rev=271287&view=rev
Log:
[include-fixer] use clang-format cleaner to insert header.
Summary: clang-format's cleanupAroundReplacements() takes care of header
insertions.
Reviewers: bkramer
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271287: [include-fixer] use clang-format cleaner to insert
header. (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D20816?vs=59067&id=59069#toc
Repository:
rL LLVM
http://revi
flx added a comment.
In http://reviews.llvm.org/D20277#444023, @Prazek wrote:
> In http://reviews.llvm.org/D20277#436725, @flx wrote:
>
> > In http://reviews.llvm.org/D20277#436717, @Prazek wrote:
> >
> > > Cool check! Did you think about sugesting std::move for rvalue references
> > > if they a
mprobst marked 4 inline comments as done.
mprobst added a comment.
Done regarding the tests. We do have an unrelated issue with formatting `import
{x as foo}`, will send a fix later.
http://reviews.llvm.org/D20798
___
cfe-commits mailing list
cfe-c
hokein added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:29
@@ -28,3 +28,3 @@
class Action;
The forward declaration can be removed too.
Repository:
rL LLVM
http://reviews.llvm.org/D20816
___
mprobst updated this revision to Diff 59070.
mprobst added a comment.
- multiline tests, review comments
http://reviews.llvm.org/D20798
Files:
lib/Format/Format.cpp
lib/Format/SortJavaScriptImports.cpp
unittests/Format/SortImportsTestJS.cpp
Index: unittests/Format/SortImportsTestJS.cpp
=
mprobst added a comment.
Done regarding the tests. We do have an unrelated issue with formatting `import
{x as foo}`, will send a fix later.
http://reviews.llvm.org/D20798
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
a.sidorin added a comment.
Ping?
http://reviews.llvm.org/D14326
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sbenza added inline comments.
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:34
@@ -29,1 +33,3 @@
+template bool isSetDifferenceEmpty(const S &S1, const S &S2) {
+ for (const auto &E : S1)
isSubset?
Comment at: clang-tidy/u
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
ASI did not handle the ES6 `as` operator correctly.
http://reviews.llvm.org/D20817
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTe
Author: prazek
Date: Tue May 31 10:25:05 2016
New Revision: 271288
URL: http://llvm.org/viewvc/llvm-project?rev=271288&view=rev
Log:
[ASTMatchers] Breaking change of `has` matcher
has matcher can now match to implicit and paren casts
http://reviews.llvm.org/D20801
Modified:
cfe/trunk/docs/R
Author: prazek
Date: Tue May 31 10:26:56 2016
New Revision: 271289
URL: http://llvm.org/viewvc/llvm-project?rev=271289&view=rev
Log:
[ASTMatchers] Added ignoringParenImpCasts to has matchers
has matcher changed behaviour, and now it matches "as is" and
doesn't skip implicit and paren casts
http:
majnemer added inline comments.
Comment at: src/experimental/operations.cpp:529
@@ +528,3 @@
+
+if (::utimensat(AT_FDCWD, p.c_str(), tbuf, 0) == -1) {
+m_ec = detail::capture_errno();
SUSv4 says:
> The utime() function is marked obsolescent.
However,
This broke the build:
http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/36968/steps/cmake-configure/logs/stdio
On 31 May 2016 at 08:25, Piotr Padlewski via cfe-commits
wrote:
> Author: prazek
> Date: Tue May 31 10:25:05 2016
> New Revision: 271288
>
> URL: http://llvm.org/viewvc/l
Author: ehsan
Date: Tue May 31 10:39:10 2016
New Revision: 271291
URL: http://llvm.org/viewvc/llvm-project?rev=271291&view=rev
Log:
Revert r253909 because it was committed with an incorrect message
Removed:
cfe/trunk/test/Index/symbol-visibility.c
Modified:
cfe/trunk/include/clang-c/Index
majnemer added inline comments.
Comment at: src/experimental/operations.cpp:128-129
@@ +127,4 @@
+bool stat_equivalent(struct ::stat& st1, struct ::stat& st2) {
+return (st1.st_dev == st2.st_dev && st1.st_ino == st2.st_ino);
+}
+
It is possible for `st_ino` to
Yep, sending fix
2016-05-31 17:45 GMT+02:00 Rafael Espíndola :
> This broke the build:
>
> http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/36968/steps/cmake-configure/logs/stdio
>
> On 31 May 2016 at 08:25, Piotr Padlewski via cfe-commits
> wrote:
> > Author: prazek
> > Date: T
dunno why but I can't fetch from upstream
Can you push this change?
- include/clang/CMakeLists.txt
-
index 96905c9..feb81f0 100644
@@ -5,4 +5,3 @@ add_subdirectory(Parse)
add_subdirectory(Sema)
add_subdirectory(Serialization)
add_subdirectory(Sta
jvesely updated this revision to Diff 59079.
jvesely added a comment.
fixup additional tests that checked for the warning
Repository:
rL LLVM
http://reviews.llvm.org/D20744
Files:
include/clang/Basic/DiagnosticParseKinds.td
test/Parser/opencl-atomics-cl20.cl
test/SemaOpenCL/extension-v
jvesely updated the summary for this revision.
jvesely updated this revision to Diff 59080.
jvesely added a comment.
add has_fp64 macro
Repository:
rL LLVM
http://reviews.llvm.org/D20388
Files:
lib/Basic/Targets.cpp
test/Misc/amdgcn.languageOptsOpenCL.cl
test/Misc/r600.languageOptsOpen
1 - 100 of 186 matches
Mail list logo
