Author: ctopper
Date: Fri May 27 01:59:39 2016
New Revision: 270970
URL: http://llvm.org/viewvc/llvm-project?rev=270970&view=rev
Log:
[AVX512][Builtin] Fix palignr intrinsic for avx512vlbw. The immediate should
not be multiplied by 8.
The 512-bit version was fixed recently but this was missed.
The same bug existed in avx512vlbwintrin.h too. Fixed in r270970.
On Wed, May 25, 2016 at 8:05 AM, Michael Zuckerman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: mzuckerm
> Date: Wed May 25 10:05:03 2016
> New Revision: 270707
>
> URL: http://llvm.org/viewvc/llvm-project?rev=270
silvas added subscribers: MaggieYi, phillip.power.
silvas added a comment.
This is looking really good. So based on reading this, a rough sketch of how we
can expand this to PGO would be something like:
- there is a separate PGO page that has similar structure, but is more tuned
for the PGO use
Author: ioeric
Date: Fri May 27 03:20:02 2016
New Revision: 270971
URL: http://llvm.org/viewvc/llvm-project?rev=270971&view=rev
Log:
[clang-format] moved unit tests related to replacements cleaner from
FormatTest.cpp to CleanUpTest.cpp.
Modified:
cfe/trunk/unittests/Format/CleanupTest.cpp
Author: asiri
Date: Fri May 27 03:29:27 2016
New Revision: 270972
URL: http://llvm.org/viewvc/llvm-project?rev=270972&view=rev
Log:
[libunwind] Disable cross-unwinding by default.
Cross unwinding requires larger sizes for unw_context_t and unw_cursor_t
buffers (large enough to hold the VRS of any
Thanks. r270962 seems to have fixed the buildbot.
> -Original Message-
> From: Daniel Sanders
> Sent: 26 May 2016 16:24
> To: 'Alexey Bataev'; cfe-commits@lists.llvm.org
> Subject: RE: r270838 - [OPENMP] Add option '-fopenmp-version=[31|40|45]'
> allowing choosing
>
> Hi,
>
> I think thi
Author: dpolukhin
Date: Fri May 27 03:52:34 2016
New Revision: 270974
URL: http://llvm.org/viewvc/llvm-project?rev=270974&view=rev
Log:
[MSVC2015] Fix mangling for static variables initialization guards
It seems that suffix '@4HA' was omitted for unknown reason. It is
non-cont non-volatile 'int'
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270974: [MSVC2015] Fix mangling for static variables
initialization guards (authored by dpolukhin).
Changed prior to commit:
http://reviews.llvm.org/D20683?vs=58611&id=58759#toc
Repository:
rL LLVM
Author: djasper
Date: Fri May 27 03:59:34 2016
New Revision: 270975
URL: http://llvm.org/viewvc/llvm-project?rev=270975&view=rev
Log:
clang-format: Allow splitting the line after /**/-comments.
While it might change the meaning of the comment in rare circumstances,
it is better than violating the
rogfer01 added a comment.
Forget my wrong comment about packed fields that might actually be aligned. It
does not make sense.
Regarding the way to selectively disable this, there is little syntax available
at this point that we can leverage, so I propose to use parentheses as a way to
disable
rogfer01 updated this revision to Diff 58760.
rogfer01 added a comment.
Only warn if the expression is of the form &a.x this way &(a.x) can be used to
silence the warning.
http://reviews.llvm.org/D20561
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
test/Sema/add
m_zuckerman accepted this revision.
m_zuckerman added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D20614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Author: d0k
Date: Fri May 27 06:48:53 2016
New Revision: 270983
URL: http://llvm.org/viewvc/llvm-project?rev=270983&view=rev
Log:
Convert assert to static_assert. NFC.
Modified:
cfe/trunk/include/clang/AST/Type.h
Modified: cfe/trunk/include/clang/AST/Type.h
URL:
http://llvm.org/viewvc/llvm-
Author: dsanders
Date: Fri May 27 06:51:02 2016
New Revision: 270984
URL: http://llvm.org/viewvc/llvm-project?rev=270984&view=rev
Log:
[mips] Fold MipsTargetInfoBase subclasses into MipsTargetInfoBase and rename to
MipsTargetInfo. NFC
Summary:
This unifies mips/mipsel and mips64/mips64el into a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270984: [mips] Fold MipsTargetInfoBase subclasses into
MipsTargetInfoBase and rename… (authored by dsanders).
Changed prior to commit:
http://reviews.llvm.org/D20678?vs=58604&id=58770#toc
Repository:
Author: grimar
Date: Fri May 27 07:15:25 2016
New Revision: 270985
URL: http://llvm.org/viewvc/llvm-project?rev=270985&view=rev
Log:
Update for following LLVM commit.
It will be:
Recommit 270977 - [llvm-mc] - Teach llvm-mc to generate zlib styled compression
sections.
Modified:
cfe/trunk/to
dsanders updated this revision to Diff 58772.
dsanders added a comment.
Herald added subscribers: sdardis, emaste.
Removed the 'eabi' from Tools.cpp this revealed three driver tests for passing
-mabi to the assembler but the ABI itself is still completely untested.
http://reviews.llvm.org/D20679
dsanders added a comment.
Just to double-check: Do you still agree we should kill this now that the
number of tests covering EABI-specific behaviour is non-zero?
I think we should on the basis that we still have no backend tests and no
buildbots. The only tests we have check that the driver pas
bcraig added a comment.
LGTM. You may want to wait on Marshall's approval though. Thanks for being
patient with me, and thanks for the patch!
http://reviews.llvm.org/D20334
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
atanasyan added a comment.
In http://reviews.llvm.org/D20679#442121, @dsanders wrote:
> Just to double-check: Do you still agree we should kill this now that the
> number of tests covering EABI-specific behaviour is non-zero?
>
> I think we should on the basis that we still have no backend tests
Author: d0k
Date: Fri May 27 07:49:58 2016
New Revision: 270989
URL: http://llvm.org/viewvc/llvm-project?rev=270989&view=rev
Log:
[include-fixer] Add a missing .h.
Modified:
clang-tools-extra/trunk/include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp
Modified:
clang-tools-extra/trunk/inc
Author: d0k
Date: Fri May 27 07:52:19 2016
New Revision: 270991
URL: http://llvm.org/viewvc/llvm-project?rev=270991&view=rev
Log:
[Frontend] StringRefize and fix bad indentation.
NFC intended.
Modified:
cfe/trunk/lib/Frontend/HeaderIncludeGen.cpp
Modified: cfe/trunk/lib/Frontend/HeaderInclu
sdardis created this revision.
sdardis added reviewers: dsanders, atanasyan.
sdardis added a subscriber: cfe-commits.
Herald added a reviewer: vkalintiris.
Herald added a subscriber: sdardis.
This patch adds the commandline option
-mcompact-branches={never,optimal,always),
which controls how LLVM
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM with some nits
Comment at: lib/Driver/Tools.cpp:1446
@@ +1445,3 @@
+CmdArgs.push_back(Args.MakeArgString("-mips-compact-branches=" + Val));
+
+ } else
Author: d0k
Date: Fri May 27 08:36:58 2016
New Revision: 270994
URL: http://llvm.org/viewvc/llvm-project?rev=270994&view=rev
Log:
Turn copies into references as suggested by clang-tidy's
performance-unnecessary-copy-initialization.
Modified:
cfe/trunk/lib/Analysis/CFG.cpp
cfe/trunk/lib/D
alexfh added a comment.
Thank you for the new check!
Before starting with the review, I'd like to clarify one important thing. It's
not immediately obvious that the pattern the check detects is actually a good
indicator of a programming mistake. Did you try to run the check on a large
enough c
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D20666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D20010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
m_zuckerman added inline comments.
Comment at: test/CodeGen/avx512f-builtins.c:1927
@@ +1926,3 @@
+ // check-label: @test_mm512_div_pd
+ // check: @llvm.x86.avx512.mask.div.pd.512
+ return _mm512_div_pd(__a,__b);
craig.topper wrote:
> delena wrote:
> > I don't
Author: d0k
Date: Fri May 27 09:27:13 2016
New Revision: 270996
URL: http://llvm.org/viewvc/llvm-project?rev=270996&view=rev
Log:
Apply clang-tidy's misc-move-constructor-init throughout Clang.
No functionality change intended, maybe a tiny performance improvement.
Modified:
cfe/trunk/includ
Author: dsanders
Date: Fri May 27 09:30:23 2016
New Revision: 270998
URL: http://llvm.org/viewvc/llvm-project?rev=270998&view=rev
Log:
[mips] Kill 'support' for untested EABI.
Summary:
There are no llvm backend tests* for EABI and no EABI buildbots. There were only
three clang tests, all of which
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270998: [mips] Kill 'support' for untested EABI. (authored
by dsanders).
Changed prior to commit:
http://reviews.llvm.org/D20679?vs=58772&id=58782#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20
sfantao added a comment.
In http://reviews.llvm.org/D18110#441959, @ABataev wrote:
> Hi Daniel,
> Will fix it ASAP
Hi Alexey,
Just to make sure: the bug I am talking about is fixed by this patch, that's
why I didn't abandon this patch, instead I just rebased it. Sorry if my comment
was misl
rmaprath created this revision.
rmaprath added a reviewer: EricWF.
rmaprath added a subscriber: cfe-commits.
We seem to have quite a few tests where an entire test is conditionalized over
some range of `_LIBCPP_STD_VER`. We should consider getting rid of these and
using the UNSUPPORTED lit direc
aaron.ballman updated this revision to Diff 58784.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Updated based on review comments.
http://reviews.llvm.org/D20428
Files:
include/clang/AST/Decl.h
include/clang/AST/TypeLoc.h
lib/AST/Decl.cpp
lib/Parse/Parse
aaron.ballman added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3427
@@ -3402,5 +3402,6 @@
// recovery, but emit a diagnostic and don't store the results.
- SourceRange NoexceptRange;
+ SourceRange NoexceptRange(Tok.getLocation(),
+
yaxunl added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:11
@@ +10,3 @@
+#endif
+#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable
+
Anastasia wrote:
> jvesely wrote:
> > Anastasia wrote:
> > > jvesely wrote:
> > > > Anastasi
rmaprath added a comment.
In http://reviews.llvm.org/D20320#439368, @bcraig wrote:
> LGTM. You probably need to get an approval from someone else though, as I
> haven't really established myself in the libunwind code base.
>
> As a side note... one of these days clang / llvm stack compaction ma
john.brawn created this revision.
john.brawn added reviewers: faisalv, rsmith, jyknight.
john.brawn added a subscriber: cfe-commits.
john.brawn set the repository for this revision to rL LLVM.
When static variables are used in inline functions in header files anything
that uses that function ends
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
Probably worth doing the same thing for the non-EHABI non-SJLJ implementation,
too (that can of course go in a separate commit).
LGTM
http://reviews.llvm.org/D20320
__
Author: sdardis
Date: Fri May 27 10:13:31 2016
New Revision: 271000
URL: http://llvm.org/viewvc/llvm-project?rev=271000&view=rev
Log:
[mips] Compact branch policy setting.
This patch adds the commandline option
-mcompact-branches={never,optimal,always),
which controls how LLVM generates compact
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271000: [mips] Compact branch policy setting. (authored by
sdardis).
Changed prior to commit:
http://reviews.llvm.org/D20729?vs=58778&id=58789#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20729
sdardis added a comment.
Thanks for the review.
Repository:
rL LLVM
http://reviews.llvm.org/D20729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sfantao
Date: Fri May 27 10:21:27 2016
New Revision: 271001
URL: http://llvm.org/viewvc/llvm-project?rev=271001&view=rev
Log:
[OpenMP] Fix SEMA bug in the capture of global variables in template functions.
Summary:
Target regions require globals to be captured. This patch fixes a bug expo
Anastasia added inline comments.
Comment at: test/CodeGenOpenCL/vla.cl:1
@@ +1,2 @@
+// RUN: %clang_cc1 -emit-llvm -O0 -o - %s | FileCheck %s
+// RUN: %clang_cc1 -emit-llvm -O0 -cl-std=CL2.0 -DCL20 -o - %s | FileCheck %s
--check-prefix=CL20
pxli168 wrote:
> Anast
rivanvx added a comment.
@Anastasia I looked into introducing a separate getOpenCLVersion() function (or
perhaps three - major version, minor version and version string). This would
have to be used in lib/CodeGen/TargetInfo.cpp and lib/Parse/ParseDecl.cpp, and
I am undecided on where should one
Author: asiri
Date: Fri May 27 10:41:45 2016
New Revision: 271004
URL: http://llvm.org/viewvc/llvm-project?rev=271004&view=rev
Log:
[libunwind] Improve unwinder stack usage - II
unwind_phase1 and unwind_phase2 allocate their own copies of unw_cursor_t
buffers
on the stack. This can blow-up stack
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271004: [libunwind] Improve unwinder stack usage - II
(authored by asiri).
Changed prior to commit:
http://reviews.llvm.org/D20320?vs=57452&id=58794#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
Anastasia added a comment.
Since it has been in review for quite a while, should we try to commit it ASAP?
I think Richard can give us his feedback later as well.
http://reviews.llvm.org/D18369
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Anastasia added a comment.
In http://reviews.llvm.org/D19780#442305, @rivanvx wrote:
> @Anastasia I looked into introducing a separate getOpenCLVersion() function
> (or perhaps three - major version, minor version and version string). This
> would have to be used in lib/CodeGen/TargetInfo.cpp a
Author: kcc
Date: Fri May 27 10:49:32 2016
New Revision: 271005
URL: http://llvm.org/viewvc/llvm-project?rev=271005&view=rev
Log:
[msan] add a sentence about inline assembly
Modified:
cfe/trunk/docs/MemorySanitizer.rst
Modified: cfe/trunk/docs/MemorySanitizer.rst
URL:
http://llvm.org/viewvc
hintonda added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3428
@@ -3402,6 +3402,7 @@
// If we already had a dynamic specification, parse the noexcept for,
// recovery, but emit a diagnostic and don't store the results.
- SourceRange NoexceptRange;
+ Sourc
Author: dehao
Date: Fri May 27 11:14:35 2016
New Revision: 271010
URL: http://llvm.org/viewvc/llvm-project?rev=271010&view=rev
Log:
Add instcombine pass if sampleprofile pass is enabled.
Summary: Sample profile pass need to have instcombine pass. A related change is
http://reviews.llvm.org/D1774
ioeric created this revision.
ioeric added reviewers: djasper, klimek.
ioeric added subscribers: bkramer, cfe-commits.
Herald added a subscriber: klimek.
When a replacement's offset is set to UINT_MAX or -1U, it is treated as
a header insertion replacement by cleanupAroundReplacements(). The new #
hintonda added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3428
@@ -3402,6 +3402,7 @@
// If we already had a dynamic specification, parse the noexcept for,
// recovery, but emit a diagnostic and don't store the results.
- SourceRange NoexceptRange;
+ Sourc
RKSimon added inline comments.
Comment at: lib/Headers/emmintrin.h:598
@@ -594,3 +597,3 @@
static __inline__ void __DEFAULT_FN_ATTRS
-_mm_store_pd(double *__dp, __m128d __a)
+_mm_store_pd1(double *__dp, __m128d __a)
{
majnemer wrote:
> You could use `__attribute
aaron.ballman added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3428
@@ -3402,6 +3402,7 @@
// If we already had a dynamic specification, parse the noexcept for,
// recovery, but emit a diagnostic and don't store the results.
- SourceRange NoexceptRange;
+
Eugene.Zelenko updated this revision to Diff 58803.
Eugene.Zelenko added a comment.
More diff content.
Repository:
rL LLVM
http://reviews.llvm.org/D20714
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticCo
aaron.ballman updated this revision to Diff 58804.
aaron.ballman marked 3 inline comments as done.
aaron.ballman added a comment.
Updating based on further review comments.
http://reviews.llvm.org/D20428
Files:
include/clang/AST/Decl.h
include/clang/AST/TypeLoc.h
lib/AST/Decl.cpp
lib/Se
On Fri, May 27, 2016 at 12:19 PM, don hinton wrote:
> hintonda added inline comments.
>
>
> Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3428
> @@ -3402,6 +3402,7 @@
>// If we already had a dynamic specification, parse the noexcept for,
>// recovery, but emit a diagnostic a
alexeagle added a comment.
ping @djasper we need this fix in order to format angular 2 repo again
http://reviews.llvm.org/D20632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added inline comments.
Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3428
@@ -3402,6 +3402,7 @@
// If we already had a dynamic specification, parse the noexcept for,
// recovery, but emit a diagnostic and don't store the results.
- SourceRange NoexceptRange;
+ Sourc
bcraig added a comment.
In http://reviews.llvm.org/D20320#442246, @rmaprath wrote:
> Do you know if there are clang / llvm passes that attempts to achieve some
> sort of stack compaction? I couldn't find much.
I'm not sure if it belongs to its own pass, or if it is part of another pass,
but t
bcraig added subscribers: mclow.lists, bcraig.
bcraig added a comment.
LGTM. Add @mclow.lists as a reviewer.
http://reviews.llvm.org/D20730
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
mprobst added a comment.
Alex, do you accept this revision?
http://reviews.llvm.org/D20632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jvesely updated this revision to Diff 58806.
jvesely added a comment.
add detection of extensions in early CL versions to test.
Repository:
rL LLVM
http://reviews.llvm.org/D20447
Files:
include/clang/Basic/OpenCLExtensions.def
test/SemaOpenCL/extension-version.cl
Index: test/SemaOpenCL/
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Refactors AnnotatedLine.startsWith/endsWith by extracting the core functionality
into FormatToken.startsSequence/endsSequence. This allows checking tokens w
mprobst updated this revision to Diff 58809.
mprobst added a comment.
- fix description
http://reviews.llvm.org/D20737
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.h
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.c
arsenm added a subscriber: arsenm.
Comment at: test/SemaOpenCL/extension-version.cl:12
@@ +11,3 @@
+#ifndef cl_clang_storage_class_specifiers
+#error "Missing cl_clang_storage_class_specifiers define"
+#endif
When the AMD compiler added these warnings a long time
vsk updated this revision to Diff 58810.
vsk marked 4 inline comments as done.
vsk added a comment.
Thanks for the feedback!
- Addressed Sean's review comments.
- Fixed the line count displayed in the summary view of `foo`.
http://reviews.llvm.org/D20715
Files:
docs/SourceBasedCodeCoverage.r
ah, indeed :/
On Fri, May 27, 2016 at 10:55 AM, Eric Fiselier wrote:
> > As for tests - XFAILing seems a bit general when there's really not
> much value in running any of the tests anyway. REQUIRES, perhaps?
>
> Unfortunately REQUIRES is a conjunction so the obvious "// REQUIRES:
> c++98, c++03
> As for tests - XFAILing seems a bit general when there's really not much
value in running any of the tests anyway. REQUIRES, perhaps?
Unfortunately REQUIRES is a conjunction so the obvious "// REQUIRES: c++98,
c++03, c++11, c++14" won't work.
On Thu, May 26, 2016 at 11:32 AM, David Blaikie wro
Author: ab
Date: Fri May 27 12:57:23 2016
New Revision: 271022
URL: http://llvm.org/viewvc/llvm-project?rev=271022&view=rev
Log:
[Headers] Remove redundant typedef. NFC.
Modified:
cfe/trunk/lib/Headers/smmintrin.h
Modified: cfe/trunk/lib/Headers/smmintrin.h
URL:
http://llvm.org/viewvc/llvm-
pirama updated this revision to Diff 58813.
pirama added a comment.
Switched to emitting errors when rgba is used in OpenCL < 2.2. Also, fixed the
diagnostic's name mismatch at its point of issue.
http://reviews.llvm.org/D20602
Files:
include/clang/AST/Type.h
include/clang/Basic/Diagnostic
ab added a subscriber: ab.
ab accepted this revision.
ab added a reviewer: ab.
ab added a comment.
This revision is now accepted and ready to land.
I'd add the unsigned typedefs with their signed counterparts; no reason not to.
With that, LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D206
mclow.lists added a comment.
If you're really going to do this, you should probably empty out most of the
routines in src/cxa_exception.cpp as well.
http://reviews.llvm.org/D20677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
EricWF added a comment.
I have an issue with this change since it allows a libc++abi built without
exceptions to be used in a program compiled with them. I assert that this
should not be supported in any way.
My personal preference would be to remove as much of the exception API from the
libra
jvesely created this revision.
jvesely added reviewers: Anastasia, yaxunl.
jvesely added subscribers: cfe-commits, arsenm.
jvesely set the repository for this revision to rL LLVM.
Repository:
rL LLVM
http://reviews.llvm.org/D20744
Files:
include/clang/Basic/DiagnosticParseKinds.td
test/Sem
jvesely marked 7 inline comments as done.
Comment at: test/SemaOpenCL/extension-version.cl:12
@@ +11,3 @@
+#ifndef cl_clang_storage_class_specifiers
+#error "Missing cl_clang_storage_class_specifiers define"
+#endif
arsenm wrote:
> When the AMD compiler added thes
Hi,
I want to discuss the issue in PR27895,
https://llvm.org/bugs/show_bug.cgi?id=27895
But I will give a slightly different example for this discussion.
The issue can be demonstrated by this standalone code. Should this example link
successfully?
-
eric_niebler updated this revision to Diff 58828.
eric_niebler added a comment.
Add fixit tests, fix path separator fixit issue on Windows.
http://reviews.llvm.org/D19843
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticLexKinds.td
include/clang/Basic/FileManag
ahatanak added a comment.
Thanks!
Marshall, I've filed a PR for this bug:
https://llvm.org/bugs/show_bug.cgi?id=27915
http://reviews.llvm.org/D20334
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
yaxunl retitled this revision from "[OpenCL] Include opencl-c.h by default as a
module" to "[OpenCL] Include opencl-c.h by default as a clang module".
yaxunl updated the summary for this revision.
yaxunl updated this revision to Diff 58830.
yaxunl added a comment.
Revised as Anastasia suggested.
yaxunl marked an inline comment as done.
Comment at: include/clang/Basic/LangOptions.def:220
@@ -219,3 +219,3 @@
ENUM_LANGOPT(AddressSpaceMapMangling , AddrSpaceMapMangling, 2, ASMM_Target,
"OpenCL address space map mangling mode")
-
+LANGOPT(IncludeDefaultHeader, 1, 0, "Include
davide created this revision.
davide added reviewers: rafael, vsk.
davide added a subscriber: cfe-commits.
See http://reviews.llvm.org/D20735 for more context.
Implementing this clang-side is not as terrible as I originally thought. Maybe
needs a test case, but I wasn't able to reduce one easily
Author: bruno
Date: Fri May 27 15:43:00 2016
New Revision: 271042
URL: http://llvm.org/viewvc/llvm-project?rev=271042&view=rev
Log:
[Driver] Fix driver support for color diagnostics
Diagnostics that happen during driver time do not have color output support
unless -fcolor-diagonostic is explicitl
pcc created this revision.
pcc added reviewers: rsmith, rjmccall, rafael, mehdi_amini, aaron.ballman,
majnemer, rnk.
pcc added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
I'd like to propose this patch as an alternative to D17893 and D18199
that approaches the user interfac
rmaprath added a comment.
In http://reviews.llvm.org/D20677#442559, @EricWF wrote:
> I have an issue with this change since it allows a libc++abi built without
> exceptions to be used in a program compiled with them. I assert that this
> should not be supported in any way.
>
> My personal prefe
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D20744
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
RKSimon added a comment.
In http://reviews.llvm.org/D20684#442514, @ab wrote:
> I'd add the unsigned typedefs with their signed counterparts; no reason not
> to.
> With that, LGTM.
Thanks, I'll do that as a follow up commit.
Repository:
rL LLVM
http://reviews.llvm.org/D20684
_
EricWF added a comment.
In http://reviews.llvm.org/D20677#442687, @rmaprath wrote:
> In http://reviews.llvm.org/D20677#442559, @EricWF wrote:
>
> > I have an issue with this change since it allows a libc++abi built without
> > exceptions to be used in a program compiled with them. I assert that
vsk added a comment.
Comments on this patch -- The increment and decrement snippets seem like they
could be pulled into helper methods. That should make it easier to update all
users of LLVMIRGeneration. I wasn't able to come up with a regression test, but
I do think this patch needs one.
Over
rmaprath added a comment.
In http://reviews.llvm.org/D20677#442713, @EricWF wrote:
> In http://reviews.llvm.org/D20677#442687, @rmaprath wrote:
>
> > In http://reviews.llvm.org/D20677#442559, @EricWF wrote:
> >
> > > I have an issue with this change since it allows a libc++abi built
> > > withou
On 27 May 2016 at 17:32, Vedant Kumar wrote:
> vsk added a comment.
>
> Comments on this patch -- The increment and decrement snippets seem like they
> could be pulled into helper methods. That should make it easier to update all
> users of LLVMIRGeneration. I wasn't able to come up with a regre
rmaprath added a comment.
> I have a small concern about how difficult this would make things for us
> though - our toolchain setup uses `-ffunction-sections` and `-fdata-sections`
> along with linker's unused-section elimination to get rid of most of the
> stuff not necessary for the final i
> On May 27, 2016, at 2:55 PM, Rafael Espíndola
> wrote:
>
> On 27 May 2016 at 17:32, Vedant Kumar wrote:
>> vsk added a comment.
>>
>> Comments on this patch -- The increment and decrement snippets seem like
>> they could be pulled into helper methods. That should make it easier to
>> upda
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM once the LLVM side is landed.
Comment at: include/clang/Basic/DiagnosticLexKinds.td:278
@@ +277,3 @@
+def pp_nonportable_path : Warning<
EricWF created this revision.
EricWF added reviewers: ddunbar, rnk.
EricWF added subscribers: cfe-commits, llvm-commits.
EricWF set the repository for this revision to rL LLVM.
This patch adds a "REQUIRES-ANY" feature test that is disjunctive. This marks a
test as `UNSUPPORTED` if none of the spe
eric_niebler added a comment.
Awesome, thanks.
Comment at: include/clang/Basic/DiagnosticLexKinds.td:278
@@ +277,3 @@
+def pp_nonportable_path : Warning<
+ "non-portable path '%0' found in preprocessor directive">,
+ InGroup;
rsmith wrote:
> The fix-it hints a
On Fri, May 27, 2016 at 1:03 PM, Srivastava, Sunil via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi,
>
>
>
> I want to discuss the issue in PR27895,
>
>https://llvm.org/bugs/show_bug.cgi?id=27895
>
>
>
> But I will give a slightly different example for this discussion.
>
>
>
> The
1 - 100 of 121 matches
Mail list logo
