> On May 27, 2016, at 2:55 PM, Rafael Espíndola <rafael.espind...@gmail.com> > wrote: > > On 27 May 2016 at 17:32, Vedant Kumar <v...@apple.com> wrote: >> vsk added a comment. >> >> Comments on this patch -- The increment and decrement snippets seem like >> they could be pulled into helper methods. That should make it easier to >> update all users of LLVMIRGeneration. I wasn't able to come up with a >> regression test, but I do think this patch needs one. >> >> Overall comments -- My main concern is that this isn't the only affected >> user of the Timer class. I have a preference for >> http://reviews.llvm.org/D20735 because it defines the underlying problem >> away. I'll defer to someone else on this (maybe @rafael?). > > What is the other recursive use?
I meant to say: it may not be the only affected user. E.g I don't know if there are affected users out-of-tree. Some in-tree users are ASTReader, AnalysisConsumer::HandleTranslationUnit, and BackendConsumer. It's not obvious to me at a glance that BackendConsumer is the only affected user, but that could be the case. vedant > > Cheers, > Rafael _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
