EricWF added a comment.
Added cfe-commits.
Repository:
rL LLVM
http://reviews.llvm.org/D20270
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: abataev
Date: Tue May 24 02:40:12 2016
New Revision: 270536
URL: http://llvm.org/viewvc/llvm-project?rev=270536&view=rev
Log:
[OPENMP] Fixed codegen for firstprivate vars in standalone worksharing
directives.
If firstprivate variable is is captured by value in outlined region and then
us
rogfer01 created this revision.
rogfer01 added a reviewer: rsmith.
rogfer01 added a subscriber: cfe-commits.
This patch implements PR#22821.
Taking the address of a packed member is dangerous since the reduced
alignment of the pointee is lost. This can lead to memory alignment
faults in some arch
EricWF added a comment.
Ping. Marshall do you have any objections to this change.
http://reviews.llvm.org/D19250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
m_zuckerman updated this revision to Diff 58201.
http://reviews.llvm.org/D20359
Files:
include/llvm/IR/IntrinsicsX86.td
lib/Target/X86/X86ISelLowering.cpp
lib/Target/X86/X86IntrinsicsInfo.h
test/CodeGen/X86/avx512-intrinsics.ll
Index: lib/Target/X86/X86IntrinsicsInfo.h
==
jacob_hansen updated this revision to Diff 58199.
jacob_hansen added a comment.
Updated against latest master in preparation for commit.
http://reviews.llvm.org/D20419
Files:
lib/Basic/Targets.cpp
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/CodeGen/function-target-features.c
test/Dri
m_zuckerman added a comment.
Yes, we can delete it. We don't need it any more .
http://reviews.llvm.org/D20359
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jacob_hansen updated this revision to Diff 58203.
jacob_hansen added a comment.
Corrected formatting of a line that exceeded 80 columns.
http://reviews.llvm.org/D20419
Files:
lib/Basic/Targets.cpp
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/CodeGen/function-target-features.c
test/Dri
Author: jacob_hansen
Date: Tue May 24 03:30:08 2016
New Revision: 270538
URL: http://llvm.org/viewvc/llvm-project?rev=270538&view=rev
Log:
[Sparc] Add software float option -msoft-float
Summary:
Following patch D19265 which enable software floating point support in the
Sparc backend, this patch
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270538: [Sparc] Add software float option -msoft-float
(authored by jacob_hansen).
Changed prior to commit:
http://reviews.llvm.org/D20419?vs=58203&id=58204#toc
Repository:
rL LLVM
http://reviews.ll
jojo added inline comments.
Comment at: include/llvm/Support/AArch64TargetParser.def:20
@@ +19,3 @@
+AARCH64_ARCH("armv8-a", AK_ARMV8A, "8-A", "v8", ARMBuildAttrs::CPUArch::v8_A,
+ FK_CRYPTO_NEON_FP_ARMV8, (AArch64::AEK_CRC | AArch64::AEK_CRYPTO |
AArch64::AEK_FP | AArch
jojo set the repository for this revision to rL LLVM.
jojo changed the visibility of this Differential Revision from "Public (No
Login Required)" to "All Users".
jojo updated this revision to Diff 58205.
jojo added a comment.
1.include/llvm/Support/AArch64TargetParser.def
Format this file.
2.
pgousseau updated this revision to Diff 58207.
pgousseau added a comment.
Moving REQUIRE line higher following Bruno's comments.
http://reviews.llvm.org/D20243
Files:
lib/Frontend/FrontendActions.cpp
lib/Serialization/ASTReader.cpp
test/PCH/Inputs/pragma-once2-pch.h
test/PCH/Inputs/prag
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D20537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
pgousseau added a comment.
In http://reviews.llvm.org/D20243#437192, @thakis wrote:
> Hm, the ASTReader code this works around is over 6 years old (r100866). Maybe
> we could try enabling the access time check instead?
Yes the issue described in ASTReader lacks a reproducible so it makes sense
jojo added a comment.
> While I agree with Bradley that the repetition is not pretty, I think it will
> expose all issues to make a class design simple and straightforward, once we
> get all the sharp edges out. But we need to know what are the difficulties on
> Clang, llc and the back-ends, an
jojo set the repository for this revision to rL LLVM.
jojo changed the visibility of this Differential Revision from "Public (No
Login Required)" to "All Users".
jojo updated this revision to Diff 58210.
jojo added a comment.
Adjust "getAArch64ArchFeaturesFromMarch" logic.In file lib/Driver/Tools
Hi,
On Sun, May 22, 2016 at 9:18 PM, Simon Atanasyan via cfe-commits
wrote:
> Author: atanasyan
> Date: Sun May 22 13:18:07 2016
> New Revision: 270373
>
> URL: http://llvm.org/viewvc/llvm-project?rev=270373&view=rev
> Log:
> [driver][mips] Support new versions of MIPS CodeScape toolchains
Two t
sdefresne added a comment.
Thank you for the comment.
I think my change still needs to be reviewed and approved by someone (at least
in the Phabricator interface it still appears as "Need review"). Can you do the
review and give approval if it looks good to you?
Once this is approved, should I
m_zuckerman created this revision.
m_zuckerman added reviewers: AsafBadouh, igorb, delena.
m_zuckerman added a subscriber: cfe-commits.
http://reviews.llvm.org/D20562
Files:
lib/Headers/avx512fintrin.h
test/CodeGen/avx512f-builtins.c
Index: test/CodeGen/avx512f-builtins.c
===
rs created this revision.
rs added a reviewer: rengolin.
rs added a subscriber: cfe-commits.
Patch adds intrinsics for ldc, ldcl, ldc2, ldc2l, stc, stcl, stc2 and stc2l.
http://reviews.llvm.org/D20563
Files:
include/clang/Basic/BuiltinsARM.def
test/CodeGen/builtins-arm.c
test/Sema/builtins
rs added a comment.
LLVM part of the patch is here http://reviews.llvm.org/D20564
http://reviews.llvm.org/D20563
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia updated this revision to Diff 58219.
Anastasia added a comment.
- Improved with suggestions from Sam: reformatting, renaming!
- Removed unused err_opencl_function_not_supported diagnostic.
- Rebased and changed to_addr builtins to allow the same identifier to be used
in earlier than CL
Anastasia marked 6 inline comments as done.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7820
@@ -7819,3 +7819,3 @@
"kernel must have void return type">;
def err_sampler_argument_required : Error<
"sampler_t variable required - got %0">;
It's not
Author: vvassilev
Date: Tue May 24 07:10:36 2016
New Revision: 270553
URL: http://llvm.org/viewvc/llvm-project?rev=270553&view=rev
Log:
[modules] Ask the canonical decl whether the constructor was defaulted.
In case of template instantiations query the template instantiation pattern,
which had ac
ioeric created this revision.
ioeric added reviewers: bkramer, klimek.
ioeric added subscribers: hokein, cfe-commits.
[find-all-symbols] Added hardcode header mapping from header postfix to header
name for STL symbols.
http://reviews.llvm.org/D20566
Files:
include-fixer/find-all-symbols/CMake
Hi,
On Tue, May 24, 2016 at 12:37 PM, Ismail Donmez wrote:
>
> On Sun, May 22, 2016 at 9:18 PM, Simon Atanasyan via cfe-commits
> wrote:
>> Author: atanasyan
>> Date: Sun May 22 13:18:07 2016
>> New Revision: 270373
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=270373&view=rev
>> Log:
>> [d
ioeric updated this revision to Diff 58228.
ioeric added a comment.
- fixed nits.
http://reviews.llvm.org/D20566
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllMacros.cpp
include-fixer/find-all-symbols/FindAllSymbols.cpp
include-fixer/find-all
ioeric added a comment.
This patch is now ready for review.
Sorry that I also refactored `FindAllSymbolsAction` into a separate file in
this patch...should've done that in a separate patch at the very beginning.
http://reviews.llvm.org/D20566
___
rengolin added a subscriber: rengolin.
rengolin added a comment.
Ping?
Can we get some traction on this one, please? The 3.8.1 deadline is tomorrow
and I'd really like to see these two patches (plus the related fixes) in it, or
some LTS Linux distributions will live without them, and thus with
fowles added a comment.
LGTM, but I will wait for people who know this stuff better to sign off
http://reviews.llvm.org/D20010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added a comment.
Hi Jojo,
I've just mapped these changes to the current ARM implementation and they look
correct. I only have two minor comments and I'm happy with it, but I'll let
Bradley have the final review.
Bradley,
If history is of any help, Jojo will have to change a few thing
avt77 updated this revision to Diff 58233.
avt77 added a comment.
I built the project from scratch and found an issue in Clang build system.
There was a problem with undefined DiagGroup in DiagnosticSemaKinds.td: the
error message was generated but all executables were created that's why I was
bkramer added inline comments.
Comment at: include-fixer/find-all-symbols/tool/STLPostfixHeaderMap.cpp:15
@@ +14,3 @@
+
+const HeaderMapCollector::HeaderMap STLPostfixHeaderMap = {
+{"include/__stddef_max_align_t.h", ""},
I wonder if it's worth lazy-initializi
Anastasia added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:11
@@ +10,3 @@
+#endif
+#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable
+
Could you use standard diagnostic check please:
expected-warning{{unknown OpenCL extens
bader added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:81
@@ +80,3 @@
+static bool checkBlockArgs(Sema &S, Expr *BlockArg) {
+ const BlockPointerType *BPT = cast(BlockArg->getType());
+ ArrayRef Params =
There should be some check before cast.
Here i
ioeric updated this revision to Diff 58235.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Fixed postfix header mapping.
http://reviews.llvm.org/D20566
Files:
include-fixer/find-all-symbols/CMakeLists.txt
include-fixer/find-all-symbols/FindAllMacros.cpp
include-fixer/f
Author: madsravn
Date: Tue May 24 10:00:16 2016
New Revision: 270565
URL: http://llvm.org/viewvc/llvm-project?rev=270565&view=rev
Log:
[clang-tidy] modernize-pass-by-value bugfix
Modified the clang-tidy PassByValue check. It now stops adding std::move to
type which is trivially copyable because
Author: ioeric
Date: Tue May 24 10:10:58 2016
New Revision: 270566
URL: http://llvm.org/viewvc/llvm-project?rev=270566&view=rev
Log:
[find-all-symbols] Added hardcode header mapping from header postfix to header
name for STL symbols.
Summary: [find-all-symbols] Added hardcode header mapping from
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270566: [find-all-symbols] Added hardcode header mapping
from header postfix to… (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D20566?vs=58235&id=58237#toc
Repository:
rL LLV
Author: madsravn
Date: Tue May 24 10:13:44 2016
New Revision: 270567
URL: http://llvm.org/viewvc/llvm-project?rev=270567&view=rev
Log:
[clang-tidy] modernize-pass-by-value bugfix. Reverting lit-style test
Adding to revision 270565. The lit-style test was wrong. This is being fixed by
this commit
cameron314 added a comment.
I'm not sure how to test this (originally I found this bug by stepping through
with a debugger) -- is there a way to determine if an ASTUnit used a PCH for
the preamble or not? I'd call the `getMainBufferWithPrecompiledPreamble` method
manually but it's private.
Re
Author: ioeric
Date: Tue May 24 10:34:37 2016
New Revision: 270571
URL: http://llvm.org/viewvc/llvm-project?rev=270571&view=rev
Log:
[include-fixer][find-all-symbols] removed unused const member from YamlReporter
to fix build bot failure.
Modified:
clang-tools-extra/trunk/include-fixer/find
jroelofs added a comment.
In http://reviews.llvm.org/D20119#437191, @rmaprath wrote:
> In http://reviews.llvm.org/D20119#436849, @jroelofs wrote:
>
> > In http://reviews.llvm.org/D20119#431997, @rmaprath wrote:
> >
> > > Addressing review comments from @jroelofs:
> > >
> > > - Moved the assertion
Author: majnemer
Date: Tue May 24 11:09:25 2016
New Revision: 270576
URL: http://llvm.org/viewvc/llvm-project?rev=270576&view=rev
Log:
[MS Volatile] Don't make volatile loads/stores to underaligned objects atomic
Underaligned atomic LValues require libcalls which MSVC doesn't have.
MSVC doesn't s
Author: madsravn
Date: Tue May 24 11:09:24 2016
New Revision: 270575
URL: http://llvm.org/viewvc/llvm-project?rev=270575&view=rev
Log:
[clang-tidy] modernize-pass-by-value bugfix. Reverting lit-style test
Adding to revision 270567. The lit-style test was wrong. This is being fixed by
this commit
rnk added a comment.
lgtm
http://reviews.llvm.org/D18953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 58252.
sfantao added a comment.
- Rebase after last changes related to first private.
http://reviews.llvm.org/D20111
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/target_codegen.cpp
test/OpenMP/target_codegen_registration.cpp
test/OpenMP/target
Author: ioeric
Date: Tue May 24 11:35:24 2016
New Revision: 270578
URL: http://llvm.org/viewvc/llvm-project?rev=270578&view=rev
Log:
[include-fixer][find-all-symbols] added missing dependencies.
Modified:
clang-tools-extra/trunk/include-fixer/find-all-symbols/CMakeLists.txt
Modified: clang-t
sfantao updated this revision to Diff 58253.
sfantao marked 2 inline comments as done.
sfantao added a comment.
- Rebase after last changes related to first private.
http://reviews.llvm.org/D20112
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/target_firstprivate_codegen.cpp
test/Open
On 24 May 2016 at 16:13, Mads Ravn via cfe-commits
wrote:
> Author: madsravn
> Date: Tue May 24 10:13:44 2016
> New Revision: 270567
>
> URL: http://llvm.org/viewvc/llvm-project?rev=270567&view=rev
> Log:
> [clang-tidy] modernize-pass-by-value bugfix. Reverting lit-style test
>
> Adding to revisio
t.p.northover added a subscriber: t.p.northover.
t.p.northover added a comment.
Just one suggestion for the tests here:
Comment at: test/Sema/builtins-arm.c:50
@@ -49,2 +49,3 @@
void test6(int a, int b, int c) {
+ __builtin_arm_ldc(a, 2, &a); // expected-error {{argument to
bcraig created this revision.
bcraig added reviewers: rmaprath, mclow.lists, EricWF.
bcraig added a subscriber: cfe-commits.
The existing pthread detection code in __config is pretty good for common
operating systems. It doesn't allow cmake-time choices to be made for uncommon
operating systems
bcraig created this revision.
bcraig added reviewers: rmaprath, mclow.lists, EricWF.
bcraig added a subscriber: cfe-commits.
Companion to http://reviews.llvm.org/D20573
When building libcxxabi in tree (i.e. in llvm/projects/libcxxabi, along with
llvm/projects/libcxx), libcxx's __config_site.in d
Author: majnemer
Date: Tue May 24 11:53:13 2016
New Revision: 270580
URL: http://llvm.org/viewvc/llvm-project?rev=270580&view=rev
Log:
[Lex] Support more type-traits in __has_feature
It looks like we forgot to update the __has_feature support when we
added some of the type traits.
Modified:
Author: d0k
Date: Tue May 24 11:54:26 2016
New Revision: 270581
URL: http://llvm.org/viewvc/llvm-project?rev=270581&view=rev
Log:
[clang-tidy] Don't rely on being available.
The STL isn't necessarily around when running tests. Make our own fake
std::array to test this.
Modified:
clang-tools
On 24 May 2016 at 17:09, Mads Ravn via cfe-commits
wrote:
> Author: madsravn
> Date: Tue May 24 11:09:24 2016
> New Revision: 270575
>
> URL: http://llvm.org/viewvc/llvm-project?rev=270575&view=rev
> Log:
> [clang-tidy] modernize-pass-by-value bugfix. Reverting lit-style test
This seems to have d
Anastasia added a comment.
Sam, there are a few small comments, otherwise it seems to be in a good shape.
@rsmith, do you think you could take a look here? The OpenCL side is fine, but
I was just wondering if you see any issue with us adding a header of ~17K
lines. It is all part of OpenCL stan
bcraig added a comment.
Note: You'll want to look at http://reviews.llvm.org/D20573, as there will be
confilicts for whoever submits second.
Comment at: include/__threading_support:201
@@ +200,3 @@
+// Mutex
+#define _LIBCPP_MUTEX_INITIALIZER nullptr
+struct __libcpp_platform_m
As I recall, this was intentional. The supported way to check for these is
has_builtin. The has_feature support is provided only for backwards
compatibility.
On 24 May 2016 9:59 a.m., "David Majnemer via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: majnemer
> Date: Tue May 24 11:53:
Ilod created this revision.
Ilod added a reviewer: hans.
Ilod added a subscriber: cfe-commits.
-finline-functions and /Ob2 are currently ignored by Clang. The only way to
enable inlining is to use the global O flags, which also enable other options,
or to emit LLVM bitcode using Clang, then runn
I'm glad. I'm finally getting the hang of this (I think) :)
Best regards,
Mads Ravn
On Tue, May 24, 2016 at 7:01 PM Renato Golin
wrote:
> On 24 May 2016 at 17:09, Mads Ravn via cfe-commits
> wrote:
> > Author: madsravn
> > Date: Tue May 24 11:09:24 2016
> > New Revision: 270575
> >
> > URL: ht
jvesely added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:11
@@ +10,3 @@
+#endif
+#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable
+
Anastasia wrote:
> Could you use standard diagnostic check please:
> expected-warning{{un
On 24 May 2016 10:15 a.m., "Richard Smith" wrote:
>
> As I recall, this was intentional. The supported way to check for these
is has_builtin. The has_feature support is provided only for backwards
compatibility.
See documentation here:
http://clang.llvm.org/docs/LanguageExtensions.html#checks-for
Author: majnemer
Date: Tue May 24 12:21:42 2016
New Revision: 270583
URL: http://llvm.org/viewvc/llvm-project?rev=270583&view=rev
Log:
Revert "[Lex] Support more type-traits in __has_feature"
This reverts commit r270580. Using __has_feature to test for
type-traits is deprecated.
Modified:
c
Done with r270583, I added a note in a comment to avoid this situation in
the future.
On Tue, May 24, 2016 at 10:26 AM, Richard Smith
wrote:
> On 24 May 2016 10:15 a.m., "Richard Smith" wrote:
> >
> > As I recall, this was intentional. The supported way to check for these
> is has_builtin. The
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
http://reviews.llvm.org/D20581
Files:
include-fixer/IncludeFixer.cpp
Index: include-fixer/IncludeFixer.cpp
===
--- include-fix
ping.
> On May 17, 2016, at 12:20 PM, Akira Hatanaka via cfe-commits
> wrote:
>
> ahatanak created this revision.
> ahatanak added reviewers: mclow.lists, EricWF, howard.hinnant.
> ahatanak added a subscriber: cfe-commits.
>
> The end pointer should point to one past the end of the newly alloc
bcraig added a subscriber: bcraig.
bcraig added a comment.
I don't believe this is a libcxx bug, but it is a bug in the test code.
oss.str(); isn't required to return a null terminated string. std::cout <<
(char *) requires a null terminated string though.
http://reviews.llvm.org/D20334
_
hans added a comment.
Thanks! Some comments below:
Comment at: lib/Driver/Tools.cpp:5335
@@ -5334,3 +5334,3 @@
- if (Args.hasArg(options::OPT_fno_inline_functions))
-CmdArgs.push_back("-fno-inline-functions");
+ if (Arg* InlineArg = Args.getLastArg(options::OPT_finline_f
Author: majnemer
Date: Tue May 24 13:10:50 2016
New Revision: 270591
URL: http://llvm.org/viewvc/llvm-project?rev=270591&view=rev
Log:
[RecordLayout] Use an ASTVector instead of using a separate pointer and counter
No functional change is intended.
Modified:
cfe/trunk/include/clang/AST/Recor
ahatanak added a comment.
My understanding is that typically std::ends is explicitly appended to
null-terminate the stream buffer. The test case in the example does that.
http://en.cppreference.com/w/cpp/io/ostrstream/str
http://reviews.llvm.org/D20334
__
> On May 23, 2016, at 8:15 PM, Bob Wilson wrote:
>
> Revision r211132 was supposed to disable -Warc-repeated-use-of-weak for
> Objective-C properties marked with the IBOutlet attribute. Those properties
> are supposed to be weak but they are only accessed from the main thread so
> there is no
rmaprath added a comment.
Couple of minor comments. LGTM otherwise.
/ Asiri
Comment at: CMakeLists.txt:387
@@ -386,2 +386,3 @@
+config_define_if(LIBCXX_HAS_PTHREAD_API _LIBCPP_HAS_THREAD_API_PTHREAD)
config_define_if(LIBCXX_HAS_MUSL_LIBC _LIBCPP_HAS_MUSL_LIBC)
--
Ping,
who's going to merge? I have no commit access.
Cheers,
Edward-san
2016-05-20 18:34 GMT+02:00 Tom Stellard :
> Hi,
>
> This looks fine to me, go ahead and merge.
>
> -Tom
>
> On Thu, May 19, 2016 at 08:29:14PM +0200, Alexander Kornienko wrote:
>> On Thu, May 19, 2016 at 4:45 PM, Hans Wennb
rmaprath added inline comments.
Comment at: CMakeLists.txt:278
@@ -277,1 +277,3 @@
+if (LIBCXXABI_HAS_PTHREAD_API)
+ add_definitions(-D_LIBCPP_HAS_THREAD_API_PTHREAD)
Shouldn't there be an `option()` line for this new build option? Also a check
for compatibili
Anastasia added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:11
@@ +10,3 @@
+#endif
+#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable
+
jvesely wrote:
> Anastasia wrote:
> > Could you use standard diagnostic check please:
> >
rmaprath added inline comments.
Comment at: include/__threading_support:201
@@ +200,3 @@
+// Mutex
+#define _LIBCPP_MUTEX_INITIALIZER nullptr
+struct __libcpp_platform_mutex_t;
bcraig wrote:
> I'm not sure I like taking the freedom to define _LIBCPP_MUTEX_INITIALI
> On May 24, 2016, at 11:21 AM, Manman wrote:
>
>
>> On May 23, 2016, at 8:15 PM, Bob Wilson wrote:
>>
>> Revision r211132 was supposed to disable -Warc-repeated-use-of-weak for
>> Objective-C properties marked with the IBOutlet attribute. Those properties
>> are supposed to be weak but the
> On May 24, 2016, at 11:42 AM, Bob Wilson wrote:
>
>>
>> On May 24, 2016, at 11:21 AM, Manman wrote:
>>
>>
>>> On May 23, 2016, at 8:15 PM, Bob Wilson wrote:
>>>
>>> Revision r211132 was supposed to disable -Warc-repeated-use-of-weak for
>>> Objective-C properties marked with the IBOutle
Hi Sam,
I think this commit broke Clang.
It seems we are no longer able to pass the -std=CL2.0, which is important for
the standalone Clang OpenCL users as -cl-std is frontend only option.
clang -std=CL2.0 test.cl
error: invalid argument '-std=CL2.0' not allowed with 'OpenCL'
We might have t
Did clang accept -std=CL2.0 before this change?
According to this diff, the only accepted option for -std= is c99 when
compiling OpenCL programs.
Sam
-Original Message-
From: Anastasia Stulova [mailto:anastasia.stul...@arm.com]
Sent: Tuesday, May 24, 2016 2:48 PM
To: Liu, Yaxun (Sam) ;
Author: vmiklos
Date: Tue May 24 14:08:53 2016
New Revision: 270599
URL: http://llvm.org/viewvc/llvm-project?rev=270599&view=rev
Log:
clang-rename: fix renaming non-members variables when referenced as macro
arguments
The second check failed, FOO(C::X) wasn't renamed to FOO(C::Y).
Reviewers: kl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270599: clang-rename: fix renaming non-members variables
when referenced as macro… (authored by vmiklos).
Changed prior to commit:
http://reviews.llvm.org/D20537?vs=58136&id=58290#toc
Repository:
rL
bcraig added inline comments.
Comment at: include/__threading_support:201
@@ +200,3 @@
+// Mutex
+#define _LIBCPP_MUTEX_INITIALIZER nullptr
+struct __libcpp_platform_mutex_t;
rmaprath wrote:
> bcraig wrote:
> > I'm not sure I like taking the freedom to define _LIB
jvesely added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:11
@@ +10,3 @@
+#endif
+#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable
+
Anastasia wrote:
> jvesely wrote:
> > Anastasia wrote:
> > > Could you use standard diagnos
rmaprath added inline comments.
Comment at: include/__threading_support:201
@@ +200,3 @@
+// Mutex
+#define _LIBCPP_MUTEX_INITIALIZER nullptr
+struct __libcpp_platform_mutex_t;
bcraig wrote:
> rmaprath wrote:
> > bcraig wrote:
> > > I'm not sure I like taking the
yaxunl updated this revision to Diff 58297.
yaxunl added a comment.
Fix regressions in unit test due to ConstructJob disables builtin include path.
http://reviews.llvm.org/D20444
Files:
include/clang/Basic/LangOptions.def
include/clang/Driver/CC1Options.td
include/clang/Frontend/CompilerI
bcraig added inline comments.
Comment at: include/__threading_support:201
@@ +200,3 @@
+// Mutex
+#define _LIBCPP_MUTEX_INITIALIZER nullptr
+struct __libcpp_platform_mutex_t;
rmaprath wrote:
> bcraig wrote:
> > rmaprath wrote:
> > > bcraig wrote:
> > > > I'm not s
Ilod updated this revision to Diff 58302.
Ilod added a comment.
Thanks!
Updated to respect the 80-columns limit.
Updated the tests to have a clearer checks. (I don't know well the FileCheck,
so I took example from test/CodeGen/noinline.c, but this is indeed more
comprehensible).
http://review
george.burgess.iv added a comment.
Ping :)
http://reviews.llvm.org/D18540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.burgess.iv added a comment.
Ping :)
http://reviews.llvm.org/D17462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Looks good to me!
Do you have commit access, or would you like me to commit this for you?
http://reviews.llvm.org/D20576
___
cfe-commits mailing lis
Ilod added a comment.
I don't have commit access, so you can do it for me, thanks.
http://reviews.llvm.org/D20576
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig created this revision.
bcraig added reviewers: mclow.lists, EricWF, joerg, jroelofs.
bcraig added a subscriber: cfe-commits.
Herald added a subscriber: jfb.
This patch cleans up libcxx's usage of newlocale, freelocale, uselocale, and
locale_t.
First, libcxx no longer defines the posix new
rmaprath added inline comments.
Comment at: include/__threading_support:201
@@ +200,3 @@
+// Mutex
+#define _LIBCPP_MUTEX_INITIALIZER nullptr
+struct __libcpp_platform_mutex_t;
bcraig wrote:
> rmaprath wrote:
> > bcraig wrote:
> > > rmaprath wrote:
> > > > bcraig
Author: hans
Date: Tue May 24 15:40:51 2016
New Revision: 270609
URL: http://llvm.org/viewvc/llvm-project?rev=270609&view=rev
Log:
[Driver] Add support for -finline-functions and /Ob2 flags
-finline-functions and /Ob2 are currently ignored by Clang. The only way to
enable inlining is to use the g
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270609: [Driver] Add support for -finline-functions and /Ob2
flags (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D20576?vs=58302&id=58308#toc
Repository:
rL LLVM
http://review
Prazek updated this revision to Diff 58309.
Prazek added a comment.
Some small bugfixes afeter running it on llvm
http://reviews.llvm.org/D18821
Files:
clang-tidy/CMakeLists.txt
clang-tidy/bugprone/BoolToIntegerConversionCheck.cpp
clang-tidy/bugprone/BoolToIntegerConversionCheck.h
clang
sbenza created this revision.
sbenza added a reviewer: alexfh.
sbenza added a subscriber: cfe-commits.
Use a recursive visitor instead of forEachDescendant() matcher.
The latter requires several layers of virtual function calls for each node and
it is more expensive than the visitor.
Benchmark res
1 - 100 of 156 matches
Mail list logo
