t.p.northover added a subscriber: t.p.northover. t.p.northover added a comment.
Just one suggestion for the tests here: ================ Comment at: test/Sema/builtins-arm.c:50 @@ -49,2 +49,3 @@ void test6(int a, int b, int c) { + __builtin_arm_ldc(a, 2, &a); // expected-error {{argument to '__builtin_arm_ldc' must be a constant integer}} ---------------- Perhaps some no-error lines too? Otherwise we might regress to producing a warning (e.g. about pointer conversions or whatever) without knowing as CodeGen would still pass. http://reviews.llvm.org/D20563 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits