Re: [PATCH] D20500: [ms] Allow more unqualified lookup of types in dependent base classes

2016-05-23 Thread Reid Kleckner via cfe-commits
rnk updated this revision to Diff 58169. rnk marked an inline comment as done. rnk added a comment. - Share the MSVC compatibility hack between the inside a method case and the default type template argument case http://reviews.llvm.org/D20500 Files: include/clang/Sema/Sema.h lib/Parse/Par

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

2016-05-23 Thread don hinton via cfe-commits
hintonda added a comment. Actually, this will never work correctly -- in fact, raw lexing will always be problematic. Consider: void foo() #if !__has_feature(cxx_noexcept) throw(std::bad_alloc) #endif {} In this case we *could* figure out if __has_feature(cxx_noexcept) evaluated to true o

r270514 - Properly track the found declaration (possibly a using-declaration) when

2016-05-23 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon May 23 19:01:49 2016 New Revision: 270514 URL: http://llvm.org/viewvc/llvm-project?rev=270514&view=rev Log: Properly track the found declaration (possibly a using-declaration) when handling an explicit member specialization. Modified: cfe/trunk/lib/Sema/SemaTemplate.c

Re: [PATCH] D20500: [ms] Allow more unqualified lookup of types in dependent base classes

2016-05-23 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: include/clang/Sema/Sema.h:1534 @@ +1533,3 @@ + /// type name has failed in a dependent context. In these situations, we + /// automatically form DependentTypeName that will retry lookup in a related + /// scope during instantiation. ---

r270520 - clang-c: de-anonymize structure declaration

2016-05-23 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon May 23 20:23:24 2016 New Revision: 270520 URL: http://llvm.org/viewvc/llvm-project?rev=270520&view=rev Log: clang-c: de-anonymize structure declaration The statement constructed an anonymous structure which was typedefed. The anonymous structure has internal linkage, a

Re: [PATCH] D20010: [clang-tidy] UnnecessaryCopyInitialization - Extend to trigger on non-const "this" object argument if it is not modified

2016-05-23 Thread Felix Berger via cfe-commits
flx removed rL LLVM as the repository for this revision. flx updated this revision to Diff 58181. flx marked an inline comment as done. http://reviews.llvm.org/D20010 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tidy/performance/UnnecessaryCopyInitialization.h test/

r270521 - Visualize ellipses in TemplateTypeParm and TemplateTypeParmDecl

2016-05-23 Thread Mike Spertus via cfe-commits
Author: mps Date: Mon May 23 20:47:41 2016 New Revision: 270521 URL: http://llvm.org/viewvc/llvm-project?rev=270521&view=rev Log: Visualize ellipses in TemplateTypeParm and TemplateTypeParmDecl Now a TemplateTypeParm will be visualized as typename ...T if it is a pack Modified: cfe/trunk/uti

Re: [PATCH] D20010: [clang-tidy] UnnecessaryCopyInitialization - Extend to trigger on non-const "this" object argument if it is not modified

2016-05-23 Thread Felix Berger via cfe-commits
flx added a comment. In http://reviews.llvm.org/D20010#427510, @alexfh wrote: > How many more (in relative numbers) results does this check generate now? 147% more :) http://reviews.llvm.org/D20010 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] arc-repeated-use-of-weak should not warn about IBOutlet properties

2016-05-23 Thread Bob Wilson via cfe-commits
Revision r211132 was supposed to disable -Warc-repeated-use-of-weak for Objective-C properties marked with the IBOutlet attribute. Those properties are supposed to be weak but they are only accessed from the main thread so there is no risk of asynchronous updates setting them to nil. That combin

r270528 - CodeGen: indicate to the backend the exception model

2016-05-23 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon May 23 22:21:01 2016 New Revision: 270528 URL: http://llvm.org/viewvc/llvm-project?rev=270528&view=rev Log: CodeGen: indicate to the backend the exception model Thread through -fsjlj-exceptions to the backend via the TargetOptions. This is in preparation for supporting

Re: [PATCH] D20358: [Clang][AVX512][Intrinsics]Convert AVX non-temporal store builtins to LLVM-native IR.

2016-05-23 Thread Craig Topper via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [PATCH] D20359: [LLVM][AVX512][Intrinsics] Convert AVX non-temporal store builtins to LLVM-native IR.

2016-05-23 Thread Craig Topper via cfe-commits
craig.topper added inline comments. Comment at: lib/Target/X86/X86IntrinsicsInfo.h:279 @@ -278,3 +278,1 @@ X86_INTRINSIC_DATA(avx512_scattersiv8_si, SCATTER, X86::VPSCATTERDDZ256mr, 0), - X86_INTRINSIC_DATA(avx512_storent_pd_512, STOREANT, ISD::DELETED_NODE, 0), - X86_INTRIN

Re: [clang-tools-extra] r270472 - Commiting for http://reviews.llvm.org/D20365

2016-05-23 Thread Mads Ravn via cfe-commits
@Nico, Yes, I will. I'm sorry about that. I had mistakenly read that it would take the title and commit message from phabricator if I linked to that in my svn commit message. @Piotr, A test failed to build on the build server (as shown on IRC), so I quickly reverted the commit. I will remember bet

Re: [PATCH] D20365: [PATCH] clang-tidy: Bug 27731 - modernize-pass-by-value suggest using std::move for types that perform copies on move

2016-05-23 Thread Mads Ravn via cfe-commits
madsravn added a comment. @alexfh I don't know how I could miss that. But I got my commit access and committed the code myself. Thanks though. @prazek Yes I reverted. The code made the build server (as seen on IRC) fail. So I quickly reverted. I'm gonna fix the code tonight - I had to "make cle

Re: [PATCH] D20422: [MSVC2015] dllexport for defaulted special class members

2016-05-23 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270535: [MSVC2015] dllexport for defaulted special class members (authored by dpolukhin). Changed prior to commit: http://reviews.llvm.org/D20422?vs=58088&id=58197#toc Repository: rL LLVM http://rev

r270535 - [MSVC2015] dllexport for defaulted special class members

2016-05-23 Thread Dmitry Polukhin via cfe-commits
Author: dpolukhin Date: Tue May 24 01:37:14 2016 New Revision: 270535 URL: http://llvm.org/viewvc/llvm-project?rev=270535&view=rev Log: [MSVC2015] dllexport for defaulted special class members Clang doesn't dllexport defaulted special member function defaulted inside class but does it if they def

<    1   2