Author: mzuckerm
Date: Mon May 23 03:01:48 2016
New Revision: 270401
URL: http://llvm.org/viewvc/llvm-project?rev=270401&view=rev
Log:
[Clang][AVX512][BUILTIN]adding missing intrinsics for movdaq instruction set
Differential Revision: http://reviews.llvm.org/D20514
Modified:
cfe/trunk/inclu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270401: [Clang][AVX512][BUILTIN]adding missing intrinsics
for movdaq instruction set (authored by mzuckerm).
Changed prior to commit:
http://reviews.llvm.org/D20514?vs=58050&id=58074#toc
Repository:
rengolin added a comment.
Hi Jojo,
This is looking better, thanks!
While I agree with Bradley that the repetition is not pretty, but I think it
will expose all issues to make a class design simple and straightforward, once
we get all the sharp edges out. But we need to know what are the diffic
DmitryPolukhin updated this revision to Diff 58076.
DmitryPolukhin added a comment.
Fix test/PCH/attrs.c failure due to warning about unsupported abi_tag attribute
(committed in http://reviews.llvm.org/rL269869).
This patch implements abi_tag so the warning is not expected with this patch.
http
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
http://reviews.llvm.org/D20519
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-using-decls.cpp
==
ioeric updated this revision to Diff 58081.
ioeric added a comment.
- removed redundant dependency for findAllSymbols.
http://reviews.llvm.org/D20496
Files:
include-fixer/CMakeLists.txt
include-fixer/find-all-symbols/FindAllMacros.cpp
include-fixer/find-all-symbols/FindAllMacros.h
inclu
On 22 May 2016 at 23:16, Simon Atanasyan wrote:
> Hope r270380 fixes the problem.
All green, thanks!
--renato
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
avt77 added a comment.
OK, as I see all issues were resolved, right?
Could I commit the patch?
http://reviews.llvm.org/D18953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
faisalv added a comment.
*ping*
http://reviews.llvm.org/D19783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
igorb added a comment.
In http://reviews.llvm.org/D20321#436494, @craig.topper wrote:
> Looking at this again. This doesn't match the gcc implementation of the
> builtins. Unless their header file is also wrong. Can you clarify?
Thanks,
You are correct. I implemented all changes in code-gen (
John McCall may know particular reasons why these annotations are not
propagated to IR level.
> On 19 May 2016, at 19:37, Max Bazaliy via cfe-commits
> wrote:
>
> Hey,
>
> For some reason clang does not emit ObjC method and block annotations to IR.
> Here is a fix for that.
>
> --
> Max Baz
jojo added inline comments.
Comment at: lib/Driver/Tools.cpp:707
@@ -696,3 +706,3 @@
std::string MArch = arm::getARMArch(ArchName, Triple);
- if (llvm::ARM::parseArch(MArch) == llvm::ARM::AK_INVALID ||
+ if (!checkARMArchValid(MArch) || llvm::ARM::parseArch(MArch) ==
llvm::A
jojo added a comment.
> There is an awful lot of duplication/passing through to another class in
> this, it strikes me that this whole thing could benefit from some level of
> inheritance. I think it would be good to have a base class that defines the
> interface and have both ARM/AArch64 (and
jojo removed rL LLVM as the repository for this revision.
jojo changed the visibility of this Differential Revision from "All Users" to
"Public (No Login Required)".
jojo updated this revision to Diff 58071.
jojo added a comment.
1.unsigned llvm::AArch64::getArchAttr(unsigned ArchKind)
Correct
jojo removed rL LLVM as the repository for this revision.
jojo changed the visibility of this Differential Revision from "All Users" to
"Public (No Login Required)".
jojo updated this revision to Diff 58072.
jojo added a comment.
Remove checkARMArchValid & checkAArch64ArchValid logic.
http://re
WuZhao added a subscriber: WuZhao.
WuZhao added a comment.
Hi , I find one mistake in the lib/Basic/Targets.cpp. On my AIX 7.1 machine
/usr/include/sys/inttypes.h, 64 bits wchar_t is unsigned int, not signed int.
#ifndef _WCHAR_T
#define _WCHAR_T
#ifdef __64BIT__
typedef unsigned int
alexfh added inline comments.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:47
@@ +46,3 @@
+ return;
+// Ignores using-declarations defined in function definitions to avoid
+// arguement-dependent lookup.
I don't think using declarations in fu
m_zuckerman created this revision.
m_zuckerman added reviewers: AsafBadouh, igorb, delena.
m_zuckerman added a subscriber: cfe-commits.
http://reviews.llvm.org/D20521
Files:
include/clang/Basic/BuiltinsX86.def
lib/Headers/avx512vbmiintrin.h
lib/Headers/avx512vbmivlintrin.h
test/CodeGen/av
Author: jacob_hansen
Date: Mon May 23 08:12:29 2016
New Revision: 270435
URL: http://llvm.org/viewvc/llvm-project?rev=270435&view=rev
Log:
Test commit
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Dri
AsafBadouh accepted this revision.
AsafBadouh added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20521
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
DmitryPolukhin updated this revision to Diff 58088.
DmitryPolukhin added a comment.
- drop dllexport for trivial defaulted x-tors for compatibility with MSVC2015
- move checks to CheckCompletedCXXClass because completed class definition is
required to detect if x-tor is trivial
http://reviews.l
DmitryPolukhin added a comment.
PTAL
Comment at: lib/Sema/SemaDeclCXX.cpp:13113-13114
@@ -13065,28 +13112,4 @@
-if (MD->isInvalidDecl())
- return;
-
-switch (Member) {
-case CXXDefaultConstructor:
- DefineImplicitDefaultConstructor(DefaultLoc,
-
hokein added inline comments.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:47
@@ +46,3 @@
+ return;
+// Ignores using-declarations defined in function definitions to avoid
+// arguement-dependent lookup.
alexfh wrote:
> I don't think using de
flx updated this revision to Diff 58090.
http://reviews.llvm.org/D20277
Files:
clang-tidy/performance/UnnecessaryValueParamCheck.cpp
clang-tidy/performance/UnnecessaryValueParamCheck.h
clang-tidy/utils/CMakeLists.txt
clang-tidy/utils/DeclRefExprUtils.cpp
clang-tidy/utils/DeclRefExprUtil
flx added inline comments.
Comment at: clang-tidy/utils/TypeTraits.cpp:131
@@ +130,3 @@
+ return Record->hasNonTrivialMoveConstructor();
+}
+
Done. Shortened this now to just check whether the type has a non-trivial move
constructor or assignment operator. For t
flx updated this revision to Diff 58093.
flx added a comment.
Upated documentation as well.
http://reviews.llvm.org/D20277
Files:
clang-tidy/performance/UnnecessaryValueParamCheck.cpp
clang-tidy/performance/UnnecessaryValueParamCheck.h
clang-tidy/utils/CMakeLists.txt
clang-tidy/utils/De
bkramer added inline comments.
Comment at: include-fixer/find-all-symbols/FindAllSymbols.h:47
@@ +46,3 @@
+protected:
+ // The way SymbolInfo of a decl is reported can be overrided.
+ virtual void reportDecl(const SourceManager &SM, const clang::NamedDecl *ND,
o
hokein added a subscriber: hokein.
Comment at: clang-tidy/llvm/HeaderGuardCheck.h:19
@@ -18,3 +18,3 @@
/// Finds and fixes header guards that do not adhere to LLVM style.
class LLVMHeaderGuardCheck : public utils::HeaderGuardCheck {
You should add a document f
hokein added inline comments.
Comment at: include-fixer/find-stl-symbols/STLSymbolsFinder.h:25
@@ +24,3 @@
+///
+/// To decide which symbols can be #include'd from each headear, we run
+/// FindSTLSymbolsAction on each header to retrieve all symbols in the
s/heade
m_zuckerman created this revision.
m_zuckerman added reviewers: AsafBadouh, igorb, delena.
m_zuckerman added a subscriber: cfe-commits.
http://reviews.llvm.org/D20523
Files:
lib/Headers/avx512fintrin.h
test/CodeGen/avx512f-builtins.c
Index: test/CodeGen/avx512f-builtins.c
===
Prazek added a subscriber: Prazek.
Prazek added a comment.
Cool check! Did you think about sugesting std::move for rvalue references if
they are used once?
http://reviews.llvm.org/D20277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
flx added a comment.
In http://reviews.llvm.org/D20277#436717, @Prazek wrote:
> Cool check! Did you think about sugesting std::move for rvalue references if
> they are used once?
Thanks! I'm not sure this fits with what a user would expect from a check named
"unnecessary-value-param" since in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270441: [clang][AVX512][Builtin] adding missing intrinsics
for… (authored by mzuckerm).
Changed prior to commit:
http://reviews.llvm.org/D20521?vs=58086&id=58098#toc
Repository:
rL LLVM
http://revie
Author: mzuckerm
Date: Mon May 23 10:04:39 2016
New Revision: 270441
URL: http://llvm.org/viewvc/llvm-project?rev=270441&view=rev
Log:
[clang][AVX512][Builtin] adding missing intrinsics for
vpmultishiftqb{128|256|512} instruction set .
Differential Revision: http://reviews.llvm.org/D20521
Modi
sbenza added inline comments.
Comment at: include/clang/AST/ASTContext.h:824
@@ -823,1 +823,3 @@
unsigned overridden_methods_size(const CXXMethodDecl *Method) const;
+ typedef llvm::iterator_range
+ overridden_method_range;
Sure. Sorry about that.
The mai
kzhuravl added a comment.
Ping
http://reviews.llvm.org/D20336
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Thanks!
http://reviews.llvm.org/D20422
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D18953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
madsravn added inline comments.
Comment at: clang-tidy/llvm/HeaderGuardCheck.h:19
@@ -18,3 +18,3 @@
/// Finds and fixes header guards that do not adhere to LLVM style.
class LLVMHeaderGuardCheck : public utils::HeaderGuardCheck {
hokein wrote:
> You should add
RKSimon created this revision.
RKSimon added reviewers: qcolombet, craig.topper, mkuper, andreadb, spatel.
RKSimon added a subscriber: cfe-commits.
RKSimon set the repository for this revision to rL LLVM.
Both the (V)CVTDQ2PD(Y) (i32 to f64) and (V)CVTPS2PD(Y) (f32 to f64) conversion
instructions
rmaprath added a comment.
@mclow.lists, @EricWF: Any comments on this? If it helps, I could split off the
library source changes and test setup into two separate patches. I thought to
keep the two together as the test setup gives an idea of the overall objective.
Thanks.
/ Asiri
http://revie
rmaprath added a comment.
@jroelofs: OK to commit?
Thanks.
/ Asiri
http://reviews.llvm.org/D20119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added a comment.
In http://reviews.llvm.org/D20119#431997, @rmaprath wrote:
> Addressing review comments from @jroelofs:
>
> - Moved the assertion in `libunwind.cpp` back to `UnwindCursor.cpp` where it
> really belogs.
>
> @jroelofs: I just realized that, with this new native-only bui
Anastasia added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:3403
@@ +3402,3 @@
+static Value *ConvertVec3AndVec4(CGBuilderTy &Builder, CodeGenFunction &CGF,
+ Value *Src, unsigned numElementsDst) {
+ llvm::Value *UnV = llvm::UndefValue::get(Src->getType());
---
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
Do we have any test for this? Would be nice to add one if possible.
http://reviews.llvm.org/D20373
___
cfe-commits mailing list
cfe-commits
hokein added inline comments.
Comment at: clang-tidy/llvm/HeaderGuardCheck.h:19
@@ -18,3 +18,3 @@
/// Finds and fixes header guards that do not adhere to LLVM style.
class LLVMHeaderGuardCheck : public utils::HeaderGuardCheck {
madsravn wrote:
> hokein wrote:
Author: majnemer
Date: Mon May 23 12:16:12 2016
New Revision: 270457
URL: http://llvm.org/viewvc/llvm-project?rev=270457&view=rev
Log:
[MS ABI] Implement __declspec(empty_bases) and __declspec(layout_version)
The layout_version attribute is pretty straightforward: use the layout
rules from versio
mkuper added a comment.
Thanks, Simon!
This looks right, but we may lose some end-to-end tests, since right now we
have a clang-level test that checks the builtin is lowered to the intrinsic,
and (hopefully) a CG-level test that the intrinsic is lowered to the correct
instruction.
Do you know i
Author: majnemer
Date: Mon May 23 12:21:55 2016
New Revision: 270458
URL: http://llvm.org/viewvc/llvm-project?rev=270458&view=rev
Log:
Clang support for __is_assignable intrinsic
MSVC now supports the __is_assignable type trait intrinsic,
to enable easier and more efficient implementation of the
On Mon, May 23, 2016 at 1:16 PM, David Majnemer via cfe-commits
wrote:
> Author: majnemer
> Date: Mon May 23 12:16:12 2016
> New Revision: 270457
>
> URL: http://llvm.org/viewvc/llvm-project?rev=270457&view=rev
> Log:
> [MS ABI] Implement __declspec(empty_bases) and __declspec(layout_version)
>
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270458: Clang support for __is_assignable intrinsic
(authored by majnemer).
Changed prior to commit:
http://reviews.llvm.org/D20492?vs=58014&id=58112#toc
Repository:
rL LLVM
http://reviews.llvm.org/
On Mon, May 23, 2016 at 10:28 AM, Aaron Ballman
wrote:
> On Mon, May 23, 2016 at 1:16 PM, David Majnemer via cfe-commits
> wrote:
> > Author: majnemer
> > Date: Mon May 23 12:16:12 2016
> > New Revision: 270457
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=270457&view=rev
> > Log:
> > [MS
Author: majnemer
Date: Mon May 23 12:32:35 2016
New Revision: 270461
URL: http://llvm.org/viewvc/llvm-project?rev=270461&view=rev
Log:
Address post-commit review feedback to r270457
Add two tests which show our error handling behavior for invalid
parameters in the layout_version and empty_bases a
On Mon, May 23, 2016 at 1:36 PM, David Majnemer
wrote:
>
>
> On Mon, May 23, 2016 at 10:28 AM, Aaron Ballman
> wrote:
>>
>> On Mon, May 23, 2016 at 1:16 PM, David Majnemer via cfe-commits
>> wrote:
>> > Author: majnemer
>> > Date: Mon May 23 12:16:12 2016
>> > New Revision: 270457
>> >
>> > URL:
rnk marked an inline comment as done.
Comment at: lib/Parse/ParseDecl.cpp:2282
@@ -2281,3 +2281,3 @@
// Otherwise, if we don't consume this token, we are going to emit an
// error anyway. Try to recover from various common problems. Check
rsmith wrote:
>
rnk updated this revision to Diff 58119.
rnk added a comment.
- Recover in ParseImplicitInt instead
http://reviews.llvm.org/D20500
Files:
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
lib/Sema/SemaDecl.cpp
test/SemaTemplate/ms-delayed-default-template-args.cpp
test/SemaTemplate/ms
Author: madsravn
Date: Mon May 23 13:06:29 2016
New Revision: 270470
URL: http://llvm.org/viewvc/llvm-project?rev=270470&view=rev
Log:
Commiting for http://reviews.llvm.org/D20365
Modified:
clang-tools-extra/trunk/clang-tidy/misc/MacroParenthesesCheck.cpp
clang-tools-extra/trunk/test/clan
benlangmuir added a subscriber: doug.gregor.
benlangmuir added a comment.
I'd like to see Doug and/or Richard review this. It seems reasonable to me to
first blush, but I assume there was a good reason we weren't doing this
already...
http://reviews.llvm.org/D20383
Author: madsravn
Date: Mon May 23 13:15:40 2016
New Revision: 270472
URL: http://llvm.org/viewvc/llvm-project?rev=270472&view=rev
Log:
Commiting for http://reviews.llvm.org/D20365
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/PassByValueCheck.cpp
clang-tools-extra/trunk/test/clan
madsravn closed this revision.
madsravn added a comment.
Code committed.
http://reviews.llvm.org/D20365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar updated this revision to Diff 58123.
jlebar added a comment.
More tightly scope the __USE_FAST_MATH__ macro.
tra pointed out that device_functions.hpp uses __USE_FAST_MATH__ for its own
purposes. For this CL, we only want to define __USE_FAST_MATH__ around
math_functions.hpp.
http://rev
Author: madsravn
Date: Mon May 23 13:27:05 2016
New Revision: 270473
URL: http://llvm.org/viewvc/llvm-project?rev=270473&view=rev
Log:
Commiting for http://reviews.llvm.org/D20365
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/PassByValueCheck.cpp
clang-tools-extra/trunk/test/clan
tra added a comment.
LGTM.
http://reviews.llvm.org/D20493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
http://reviews.llvm.org/D20404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Next time, please use real commit messages: Describe what the change does,
and why it's being done. Include a link to the review link at the end of
the commit message. If every change just had a phab link as commit message,
people bisecting changes would have to click through for every change in
`s
bruno added a comment.
Ping!
http://reviews.llvm.org/D20451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jvesely retitled this revision from "[OpenCL] cl_khr_msaa_sharing is OpenCL1.2
extension" to "[OpenCL] Fixup extension list".
jvesely added a subscriber: cfe-commits.
jvesely updated this revision to Diff 58130.
jvesely added a comment.
I went through the specs and fixed up all I could find.
adde
rsmith added inline comments.
Comment at: include/clang/Sema/Sema.h:1536-1537
@@ -1535,3 +1535,4 @@
/// other template arguments.
ParsedType ActOnDelayedDefaultTemplateArg(const IdentifierInfo &II,
SourceLocation NameLoc);
+ Pars
vmiklos created this revision.
vmiklos added reviewers: klimek, cfe-commits.
The second check failed, FOO(C::X) wasn't renamed to FOO(C::Y).
http://reviews.llvm.org/D20537
Files:
clang-rename/USRLocFinder.cpp
test/clang-rename/DeclRefExpr.cpp
Index: test/clang-rename/DeclRefExpr.cpp
===
RKSimon added a comment.
In http://reviews.llvm.org/D20528#436893, @mkuper wrote:
> This looks right, but we may lose some end-to-end tests, since right now we
> have a clang-level test that checks the builtin is lowered to the intrinsic,
> and (hopefully) a CG-level test that the intrinsic is
Author: rsmith
Date: Mon May 23 15:03:04 2016
New Revision: 270482
URL: http://llvm.org/viewvc/llvm-project?rev=270482&view=rev
Log:
Fix filtering of prior declarations when checking for a tag redeclaration to
map to the redecl context for both decls, not just one of them, and to properly
check th
erik.pilkington added a comment.
Ping!!
http://reviews.llvm.org/D20192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mkuper added a comment.
In http://reviews.llvm.org/D20528#437090, @RKSimon wrote:
> In http://reviews.llvm.org/D20528#436893, @mkuper wrote:
>
> > This looks right, but we may lose some end-to-end tests, since right now we
> > have a clang-level test that checks the builtin is lowered to the
>
Author: jlebar
Date: Mon May 23 15:19:56 2016
New Revision: 270484
URL: http://llvm.org/viewvc/llvm-project?rev=270484&view=rev
Log:
[CUDA] Add -fcuda-approx-transcendentals flag.
Summary:
This lets us emit e.g. sin.approx.f32. See
http://docs.nvidia.com/cuda/parallel-thread-execution/#floating-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270484: [CUDA] Add -fcuda-approx-transcendentals flag.
(authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D20493?vs=58123&id=58145#toc
Repository:
rL LLVM
http://reviews.llvm.org
RKSimon updated this revision to Diff 58146.
Repository:
rL LLVM
http://reviews.llvm.org/D20528
Files:
include/clang/Basic/BuiltinsX86.def
lib/Headers/avxintrin.h
lib/Headers/emmintrin.h
test/CodeGen/avx-builtins.c
test/CodeGen/builtins-x86.c
test/CodeGen/sse2-builtins.c
test/Cod
ahatanak updated this revision to Diff 58144.
ahatanak added a comment.
Rewrote the patch based on John's review comment.
Remove typedefs and _Atomic from the return and parameter types of getters and
setters of objective-c properties.
http://reviews.llvm.org/D20407
Files:
include/clang/AST
rsmith added a comment.
It sounds like we're failing to properly inherit default template arguments
onto redeclarations generated by template instantiation, resulting in a
violation of our AST invariants. This patch will hide the problem in some
cases, but the right thing to do is to fix the ro
bruno added a subscriber: bruno.
bruno added a comment.
Hi Cameron,
Can you add a testcase?
Repository:
rL LLVM
http://reviews.llvm.org/D20338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
RKSimon added a comment.
In http://reviews.llvm.org/D20528#437117, @mkuper wrote:
> Sorry, I didn't intend to imply the rest of the llvm work is necessary for
> this to go in. Just that I'd be happier with this patch knowing that we have
> a regression test for doing the (shuffle + fpext, say)
bruno added a subscriber: bruno.
bruno added a comment.
Hi Pierre,
Comment at: test/PCH/pragma-once-timestamp.cpp:17
@@ +16,3 @@
+
+// REQUIRES: system-windows
+
Can you move this to the beginning of the file? It makes it easier to spot that
this is windows onl
Prazek updated this revision to Diff 58148.
Prazek added a comment.
+Fixed bug with operators
+ added fixup for function return type
I will post changes on clang tomorrow
http://reviews.llvm.org/D18821
Files:
clang-tidy/CMakeLists.txt
clang-tidy/bugprone/BoolToIntegerConversionCheck.cpp
BTW why did you revert this change? And why the commit message doesn't have
"revert" in name?
2016-05-23 20:51 GMT+02:00 Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org>:
> Next time, please use real commit messages: Describe what the change does,
> and why it's being done. Include a link
mkuper added a comment.
Presumably, the fast-isel lowering of the IR pattern is already correct, and in
any case, it isn't affected by this patch.
I just want to make sure we don't regress the optimized DAG codegen - that is,
it still produces the instruction we'd expect from the intrinsic (or s
ariccio added a comment.
I should elaborate. The principle of operation of this latest patch is that the
`FunctionDecl` in `IsCMemFunction` should never return a `nullptr`
`IdentifierInfo*` from `getIdentifier` (is that a valid assumption?)... Thus,
when`! isWindowsMSVCEnvironment`, I leave the
Ping on the testcase :-)
On Tue, May 17, 2016 at 9:36 AM, Nico Weber via cfe-commits
wrote:
> Is it possible to write a test for this?
>
> On Tue, May 17, 2016 at 10:34 AM, Cameron Desrochers via cfe-commits
> wrote:
>>
>> Author: cameron314
>> Date: Tue May 17 09:34:53 2016
>> New Revision: 269
hintonda updated this revision to Diff 58151.
hintonda added a comment.
Fixed matcher -- added 'unless(isImplicit())'. Thanks to Aaron Ballman for the
suggestion.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang
hintonda added a comment.
In http://reviews.llvm.org/D18575#435388, @alexfh wrote:
> Let's wait for http://reviews.llvm.org/D20428
No worries.
http://reviews.llvm.org/D18575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
rmaprath added a comment.
In http://reviews.llvm.org/D20119#436849, @jroelofs wrote:
> In http://reviews.llvm.org/D20119#431997, @rmaprath wrote:
>
> > Addressing review comments from @jroelofs:
> >
> > - Moved the assertion in `libunwind.cpp` back to `UnwindCursor.cpp` where
> > it really belog
thakis added a comment.
Hm, the ASTReader code this works around is over 6 years old (r100866). Maybe
we could try enabling the access time check instead?
http://reviews.llvm.org/D20243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
RKSimon added a comment.
In http://reviews.llvm.org/D20528#437165, @mkuper wrote:
> Presumably, the fast-isel lowering of the IR pattern is already correct, and
> in any case, it isn't affected by this patch.
> I just want to make sure we don't regress the optimized DAG codegen - that
> is, it
mkuper accepted this revision.
mkuper added a comment.
This revision is now accepted and ready to land.
> The existing llvm\test\CodeGen\X86\vec_fpext.ll and
> llvm\test\CodeGen\X86\vec_int_to_fp.ll already demonstrate the correct
> optimized DAG codegen using the same IR as output in the
> cla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270499: [X86][SSE] Replace lossless i32/f32 to f64
conversion intrinsics with generic IR (authored by RKSimon).
Changed prior to commit:
http://reviews.llvm.org/D20528?vs=58146&id=58160#toc
Repository:
Author: rksimon
Date: Mon May 23 17:13:02 2016
New Revision: 270499
URL: http://llvm.org/viewvc/llvm-project?rev=270499&view=rev
Log:
[X86][SSE] Replace lossless i32/f32 to f64 conversion intrinsics with generic IR
Both the (V)CVTDQ2PD(Y) (i32 to f64) and (V)CVTPS2PD(Y) (f32 to f64) conversion
i
alexfh added a comment.
Richard, ping.
http://reviews.llvm.org/D20428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mps
Date: Mon May 23 17:27:44 2016
New Revision: 270505
URL: http://llvm.org/viewvc/llvm-project?rev=270505&view=rev
Log:
Visualizer for Pack template arguments
Modified:
cfe/trunk/utils/ClangVisualizers/clang.natvis
Modified: cfe/trunk/utils/ClangVisualizers/clang.natvis
URL:
http
alexfh added a comment.
In http://reviews.llvm.org/D20365#436335, @madsravn wrote:
> Just curious, as I'm sort of new to this. How long will it take before its
> merged in?
I was waiting for an answer to the "Do you need me to submit the patch for
you?" question. Apparently, the answer is "no
Prazek added a comment.
Did you revert the commit? I see that it is commieted, but after it I see
revert.
Also please stick to convention of commit messages
http://llvm.org/docs/DeveloperPolicy.html#commit-messages
Commit message like "[clang-tidy] modernize-pass-by-value bugfix" would be much
Ping.
On Tue, Apr 5, 2016 at 11:46 AM NAKAMURA Takumi
wrote:
> Tom, may I commit it into release_38?
> It has been preventing "lit --use-processes" on windows.
>
> 2016-02-16 17:13 GMT+09:00 NAKAMURA Takumi via cfe-commits
> :
> > Author: chapuni
> > Date: Tue Feb 16 02:13:36 2016
> > New Revisi
Hello everyone,
Below are some buildbot numbers for the last week of 5/15/2016 - 5/21/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
1 - 100 of 116 matches
Mail list logo
