r270029 - clang-format: [JS] Fix spacing in destructuring assignments.

2016-05-19 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Thu May 19 02:18:07 2016 New Revision: 270029 URL: http://llvm.org/viewvc/llvm-project?rev=270029&view=rev Log: clang-format: [JS] Fix spacing in destructuring assignments. Before: const[a, b, c] = [1, 2, 3]; After: const [a, b, c] = [1, 2, 3]; Modified: cfe/trunk/

Re: [PATCH] D15089: Patch to google checks in clang-tidy

2016-05-19 Thread Haojian Wu via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rL LLVM http://reviews.llvm.org/D15089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

Re: [PATCH] D20370: [include-fixer] Sort headers after inserting new headers.

2016-05-19 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 57745. ioeric added a comment. - Passed Headers into IncludeFixerActionFactory so that we can know which headers are added. http://reviews.llvm.org/D20370 Files: include-fixer/CMakeLists.txt include-fixer/IncludeFixer.cpp include-fixer/IncludeFixer.h

Re: [PATCH] D20370: [include-fixer] Sort headers after inserting new headers.

2016-05-19 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D20370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang-tools-extra] r270031 - [include-fixer] Sort headers after inserting new headers.

2016-05-19 Thread Eric Liu via cfe-commits
Author: ioeric Date: Thu May 19 03:21:09 2016 New Revision: 270031 URL: http://llvm.org/viewvc/llvm-project?rev=270031&view=rev Log: [include-fixer] Sort headers after inserting new headers. Summary: [include-fixer] Sort headers after inserting new headers. Reviewers: bkramer Subscribers: klime

Re: [PATCH] D20370: [include-fixer] Sort headers after inserting new headers.

2016-05-19 Thread Eric Liu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270031: [include-fixer] Sort headers after inserting new headers. (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D20370?vs=57745&id=57746#toc Repository: rL LLVM http://revie

Re: [clang-tools-extra] r261991 - [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

2016-05-19 Thread Edoardo P. via cfe-commits
Is it possible to port this commit to 3.8.1? Cheers, Edward-san 2016-02-26 10:19 GMT+01:00 Haojian Wu via cfe-commits : > Author: hokein > Date: Fri Feb 26 03:19:33 2016 > New Revision: 261991 > > URL: http://llvm.org/viewvc/llvm-project?rev=261991&view=rev > Log: > [clang-tidy] Fix a crash issue

Re: [PATCH] D15089: Patch to google checks in clang-tidy

2016-05-19 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. As Eugene noted, the patch is seriously out of date. The only place where an old URL is still used, is docs/clang-tidy/checks/google-runtime-int.rst. However, we should check if styl

[PATCH] D20419: [Sparc] Add software float option -msoft-float

2016-05-19 Thread Jacob Baungard Hansen via cfe-commits
jacob_hansen created this revision. jacob_hansen added reviewers: jyknight, lero_chris. jacob_hansen added a subscriber: cfe-commits. Herald added a subscriber: jyknight. Following patch D19265 which enable software floating point support in the Sparc backend, this patch enables the option to be

[clang-tools-extra] r270032 - [clang-tidy] Fix doc titles.

2016-05-19 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Thu May 19 04:29:46 2016 New Revision: 270032 URL: http://llvm.org/viewvc/llvm-project?rev=270032&view=rev Log: [clang-tidy] Fix doc titles. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/google-runtime-references.rst clang-tools-extra/trunk/docs/clang-tidy

[clang-tools-extra] r270033 - [clang-tidy] Fix/add style guide links.

2016-05-19 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Thu May 19 04:31:30 2016 New Revision: 270033 URL: http://llvm.org/viewvc/llvm-project?rev=270033&view=rev Log: [clang-tidy] Fix/add style guide links. Thanks to Tim Halloran for the initial patch (http://reviews.llvm.org/D15089)! Modified: clang-tools-extra/trunk/clang-

Re: [PATCH] D15089: Patch to google checks in clang-tidy

2016-05-19 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Anyways, committed all useful changes from here in r270033. Thank you for the patch! Repository: rL LLVM http://reviews.llvm.org/D15089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D20420: [find-all-symbol] Add macro support.

2016-05-19 Thread Haojian Wu via cfe-commits
hokein created this revision. hokein added a reviewer: bkramer. hokein added subscribers: ioeric, cfe-commits. http://reviews.llvm.org/D20420 Files: include-fixer/find-all-symbols/CMakeLists.txt include-fixer/find-all-symbols/FindAllMacros.cpp include-fixer/find-all-symbols/FindAllMacros.h

Re: [PATCH] D20420: [find-all-symbol] Add macro support.

2016-05-19 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 57754. hokein added a comment. Fix code-style. http://reviews.llvm.org/D20420 Files: include-fixer/find-all-symbols/CMakeLists.txt include-fixer/find-all-symbols/FindAllMacros.cpp include-fixer/find-all-symbols/FindAllMacros.h include-fixer/find-all-

Re: [PATCH] D20419: [Sparc] Add software float option -msoft-float

2016-05-19 Thread Jacob Baungard Hansen via cfe-commits
jacob_hansen updated this revision to Diff 57755. jacob_hansen added a comment. - Corrected an error causing the "target-features"="+soft-float" attribute to not be correctly set - Improved the function-target-features test http://reviews.llvm.org/D20419 Files: lib/Basic/Targets.cpp lib/Dr

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-05-19 Thread Clement Courbet via cfe-commits
courbet updated this revision to Diff 57756. courbet added a comment. Rebase on HEAD. http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h include/clang/AST/DeclCXX.h include/clang/ASTMatchers/ASTMatchers.h lib/AST/ASTContext.cpp lib

r270034 - [X86][SSE2] Sync with llvm/test/CodeGen/X86/sse2-intrinsics-fast-isel.ll

2016-05-19 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu May 19 04:52:59 2016 New Revision: 270034 URL: http://llvm.org/viewvc/llvm-project?rev=270034&view=rev Log: [X86][SSE2] Sync with llvm/test/CodeGen/X86/sse2-intrinsics-fast-isel.ll Modified: cfe/trunk/test/CodeGen/sse2-builtins.c Modified: cfe/trunk/test/CodeGen/sse

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-05-19 Thread Clement Courbet via cfe-commits
courbet updated this revision to Diff 57757. courbet added a comment. clang-format diff http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h include/clang/AST/DeclCXX.h include/clang/ASTMatchers/ASTMatchers.h lib/AST/ASTContext.cpp l

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-05-19 Thread Clement Courbet via cfe-commits
courbet added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3776 @@ +3775,3 @@ + bool Matched = false; + for (const auto *Overridden : Node.overridden_methods()) { +BoundNodesTreeBuilder OverriddenBuilder(*Builder); Thanks for the poin

Re: [PATCH] D20420: [find-all-symbol] Add macro support.

2016-05-19 Thread Eric Liu via cfe-commits
ioeric added inline comments. Comment at: include-fixer/find-all-symbols/FindAllMacros.h:22 @@ +21,3 @@ + +/// \brief A preprocessor collects macro symbols. The contexts of a macro will +/// be ignored since they are not available during preprocessing period. nit:

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

2016-05-19 Thread Dmitry Polukhin via cfe-commits
DmitryPolukhin added a comment. One more friendly ping.. :( http://reviews.llvm.org/D18035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r270039 - [Sema] Allow an external sema source to handle delayed typo corrections.

2016-05-19 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu May 19 05:46:10 2016 New Revision: 270039 URL: http://llvm.org/viewvc/llvm-project?rev=270039&view=rev Log: [Sema] Allow an external sema source to handle delayed typo corrections. This probably isn't perfectly perfect but allows correcting function calls again. Modified:

r270042 - [X86][SSE2] Added _mm_cast* and _mm_set* tests

2016-05-19 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu May 19 06:03:48 2016 New Revision: 270042 URL: http://llvm.org/viewvc/llvm-project?rev=270042&view=rev Log: [X86][SSE2] Added _mm_cast* and _mm_set* tests Modified: cfe/trunk/test/CodeGen/sse2-builtins.c Modified: cfe/trunk/test/CodeGen/sse2-builtins.c URL: http://

r270043 - [X86][SSE2] Added _mm_move_* tests

2016-05-19 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu May 19 06:18:49 2016 New Revision: 270043 URL: http://llvm.org/viewvc/llvm-project?rev=270043&view=rev Log: [X86][SSE2] Added _mm_move_* tests Modified: cfe/trunk/test/CodeGen/sse2-builtins.c Modified: cfe/trunk/test/CodeGen/sse2-builtins.c URL: http://llvm.org/vie

Re: [PATCH] D19783: Fix cv-qualification of '*this' captures (and nasty bug PR27507 introduced by commit 263921 "Implement Lambda Capture of *this by Value as [=, *this]")

2016-05-19 Thread Faisal Vali via cfe-commits
faisalv added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:3651 @@ -3652,1 +3650,3 @@ + case AttributeList::AT_Unused: +return !ScopeName && AttrName->getName().equals("maybe_unused"); default: This whitespace change shouldn't have been included

Re: [PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

2016-05-19 Thread pierre gousseau via cfe-commits
pgousseau added a comment. In http://reviews.llvm.org/D20243#433615, @thakis wrote: > Did you see http://reviews.llvm.org/D19815 ? Does that help? Warren might > have opinions on this. Yes thanks, I agree with Warren, this is a separate issue. In the test I am adding I avoid the issue that War

[clang-tools-extra] r270045 - [include-fixer] Remove obsolete windows hack.

2016-05-19 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu May 19 06:39:56 2016 New Revision: 270045 URL: http://llvm.org/viewvc/llvm-project?rev=270045&view=rev Log: [include-fixer] Remove obsolete windows hack. Modified: clang-tools-extra/trunk/unittests/include-fixer/IncludeFixerTest.cpp Modified: clang-tools-extra/trunk/uni

Re: [PATCH] D20420: [find-all-symbol] Add macro support.

2016-05-19 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 57762. hokein marked 4 inline comments as done. hokein added a comment. Address comments. http://reviews.llvm.org/D20420 Files: include-fixer/find-all-symbols/CMakeLists.txt include-fixer/find-all-symbols/FindAllMacros.cpp include-fixer/find-all-symbol

[PATCH] D20422: [MSVC2015] dllexport for defaulted special class members

2016-05-19 Thread Dmitry Polukhin via cfe-commits
DmitryPolukhin created this revision. DmitryPolukhin added a reviewer: rnk. DmitryPolukhin added a subscriber: cfe-commits. Clang doesn't dllexport defaulted special member function defaulted inside class but does it if they defaulted outside class. MSVC doesn't make any distinction where they w

r270047 - [Clang][AVX512][intrinsics] continue completing missing set intrinsics

2016-05-19 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Thu May 19 07:07:49 2016 New Revision: 270047 URL: http://llvm.org/viewvc/llvm-project?rev=270047&view=rev Log: [Clang][AVX512][intrinsics] continue completing missing set intrinsics Differential Revision: http://reviews.llvm.org/D20160 Modified: cfe/trunk/lib/Headers

[PATCH] D20424: [include-fixer] Make search handle fully qualified names correctly.

2016-05-19 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added reviewers: hokein, ioeric. bkramer added a subscriber: cfe-commits. If a search string starts with "::" we don't want to return any results for suffixes of that string. http://reviews.llvm.org/D20424 Files: include-fixer/SymbolIndexManager.cpp uni

Re: [PATCH] D20089: Adding a TargetParser for AArch64

2016-05-19 Thread jojo.ma via cfe-commits
jojo added inline comments. Comment at: lib/Support/TargetParser.cpp:441 @@ +440,3 @@ + if (Extensions & AArch64::AEK_PROFILE) +Features.push_back("+spe"); + bsmith wrote: > For ARM there is a table that defines these extensions and how they map to > backend

Re: [PATCH] D20424: [include-fixer] Make search handle fully qualified names correctly.

2016-05-19 Thread Haojian Wu via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM with one nit. Comment at: include-fixer/SymbolIndexManager.cpp:73 @@ +72,3 @@ +if (IsFullyQualified) + IsMatched &= SymbolContext == Symbol.getContexts()

[clang-tools-extra] r270055 - [include-fixer] Make search handle fully qualified names correctly.

2016-05-19 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu May 19 07:41:56 2016 New Revision: 270055 URL: http://llvm.org/viewvc/llvm-project?rev=270055&view=rev Log: [include-fixer] Make search handle fully qualified names correctly. If a search string starts with "::" we don't want to return any results for suffixes of that string

Re: [PATCH] D20424: [include-fixer] Make search handle fully qualified names correctly.

2016-05-19 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270055: [include-fixer] Make search handle fully qualified names correctly. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D20424?vs=57766&id=57772#toc Repository: rL LLVM http:

Re: [PATCH] D20198: clang-format: [JS] sort ES6 imports.

2016-05-19 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. lg http://reviews.llvm.org/D20198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20428: Tracking exception specification source locations

2016-05-19 Thread Aaron Ballman via cfe-commits
aaron.ballman created this revision. aaron.ballman added a reviewer: rsmith. aaron.ballman added subscribers: cfe-commits, hintonda, alexfh. We do not currently track the source locations for exception specifications such that their source range can be queried through the AST. This leads to tryi

r270058 - [ARM] Fix cdp intrinsic

2016-05-19 Thread Ranjeet Singh via cfe-commits
Author: rsingh Date: Thu May 19 08:04:34 2016 New Revision: 270058 URL: http://llvm.org/viewvc/llvm-project?rev=270058&view=rev Log: [ARM] Fix cdp intrinsic - Fixed cdp intrinsic to only accept compile time constant values previously you could pass in a variable to the builtin which would res

Re: [PATCH] D20394: Fix cdp intrinsic

2016-05-19 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270058: [ARM] Fix cdp intrinsic (authored by rsingh). Changed prior to commit: http://reviews.llvm.org/D20394?vs=57698&id=5#toc Repository: rL LLVM http://reviews.llvm.org/D20394 Files: cfe/tr

[PATCH] D20429: [clang-tidy] Handle using-decls with more than one shadow decl.

2016-05-19 Thread Haojian Wu via cfe-commits
hokein created this revision. hokein added a reviewer: alexfh. hokein added subscribers: djasper, cfe-commits. http://reviews.llvm.org/D20429 Files: clang-tidy/misc/UnusedUsingDeclsCheck.cpp clang-tidy/misc/UnusedUsingDeclsCheck.h test/clang-tidy/misc-unused-using-decls.cpp Index: test/cla

Re: [PATCH] D20428: Tracking exception specification source locations

2016-05-19 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Full context diff, please. > I'm not certain of the best way to test this functionality in isolation; Same way other locations/ranges are tested in unittests/AST/SourceLocationTest.cpp? http://reviews.llvm.org/D20428 ___

[clang-tools-extra] r270059 - [include-fixer] Remove an unused local variable ExistingHeaders.

2016-05-19 Thread Haojian Wu via cfe-commits
Author: hokein Date: Thu May 19 08:23:27 2016 New Revision: 270059 URL: http://llvm.org/viewvc/llvm-project?rev=270059&view=rev Log: [include-fixer] Remove an unused local variable ExistingHeaders. Modified: clang-tools-extra/trunk/include-fixer/IncludeFixer.cpp Modified: clang-tools-extra/t

Re: [PATCH] D20428: Tracking exception specification source locations

2016-05-19 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In http://reviews.llvm.org/D20428#434238, @alexfh wrote: > Full context diff, please. Pardon my complete ignorance, but how? I generated the diff from svn the usual way, so I assume I've missed some step. > > I'm not certain of the best way to test this function

Re: [PATCH] D20429: [clang-tidy] Handle using-decls with more than one shadow decl.

2016-05-19 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:22 @@ +21,3 @@ +namespace { +bool IsValidDecl(const Decl *TargetDecl) { + // Ignores using-declarations defined in macros. -

Re: [PATCH] D20428: Tracking exception specification source locations

2016-05-19 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. In http://reviews.llvm.org/D20428#434242, @aaron.ballman wrote: > In http://reviews.llvm.org/D20428#434238, @alexfh wrote: > > > Full context diff, please. > > > Pardon my complete ignorance, but how? I generated the diff from svn the > usual way, so I assume I've missed

Re: [PATCH] D20429: [clang-tidy] Handle using-decls with more than one shadow decl.

2016-05-19 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 57785. hokein marked 4 inline comments as done. hokein added a comment. Address comments. http://reviews.llvm.org/D20429 Files: clang-tidy/misc/UnusedUsingDeclsCheck.cpp clang-tidy/misc/UnusedUsingDeclsCheck.h test/clang-tidy/misc-unused-using-decls.cp

Re: [PATCH] D20429: [clang-tidy] Handle using-decls with more than one shadow decl.

2016-05-19 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 57790. hokein added a comment. Forgot a comments. http://reviews.llvm.org/D20429 Files: clang-tidy/misc/UnusedUsingDeclsCheck.cpp clang-tidy/misc/UnusedUsingDeclsCheck.h test/clang-tidy/misc-unused-using-decls.cpp Index: test/clang-tidy/misc-unused-us

Re: [PATCH] D20429: [clang-tidy] Handle using-decls with more than one shadow decl.

2016-05-19 Thread Haojian Wu via cfe-commits
hokein marked an inline comment as done. Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:22 @@ +21,3 @@ +namespace { +bool IsValidDecl(const Decl *TargetDecl) { + // Ignores using-declarations defined in macros. alexfh wrote: > This method assumes a rather

Re: [clang-tools-extra] r261991 - [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

2016-05-19 Thread Hans Wennborg via cfe-commits
+Tom who manages 3.8.1 +Alex who's owner of clang-tidy: is this ok for 3.8.1? On Thu, May 19, 2016 at 1:56 AM, Edoardo P. via cfe-commits wrote: > Is it possible to port this commit to 3.8.1? > > Cheers, > Edward-san > > 2016-02-26 10:19 GMT+01:00 Haojian Wu via cfe-commits > : >> Author: hokein

Re: [PATCH] D20198: clang-format: [JS] sort ES6 imports.

2016-05-19 Thread Martin Probst via cfe-commits
mprobst updated this revision to Diff 57794. mprobst added a comment. - correctly insert breaks after import block http://reviews.llvm.org/D20198 Files: include/clang/Format/Format.h lib/Format/CMakeLists.txt lib/Format/Format.cpp lib/Format/FormatToken.h lib/Format/FormatTokenLexer.c

Re: [PATCH] D20198: clang-format: [JS] sort ES6 imports.

2016-05-19 Thread Martin Probst via cfe-commits
mprobst updated this revision to Diff 57795. mprobst added a comment. - ranges http://reviews.llvm.org/D20198 Files: include/clang/Format/Format.h lib/Format/CMakeLists.txt lib/Format/Format.cpp lib/Format/FormatToken.h lib/Format/FormatTokenLexer.cpp lib/Format/FormatTokenLexer.h

r270069 - [driver] Do not pass install dir to the MultilibSet include dirs callback

2016-05-19 Thread Simon Atanasyan via cfe-commits
Author: atanasyan Date: Thu May 19 10:07:21 2016 New Revision: 270069 URL: http://llvm.org/viewvc/llvm-project?rev=270069&view=rev Log: [driver] Do not pass install dir to the MultilibSet include dirs callback All additional include directories are relative to the toolchain install folder. So let

r270068 - [driver] Do not pass target triple to the MultilibSet include dirs callback

2016-05-19 Thread Simon Atanasyan via cfe-commits
Author: atanasyan Date: Thu May 19 10:07:00 2016 New Revision: 270068 URL: http://llvm.org/viewvc/llvm-project?rev=270068&view=rev Log: [driver] Do not pass target triple to the MultilibSet include dirs callback No one callback uses target triple so we can escape passing the unused argument. Mod

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

2016-05-19 Thread Aleksei Sidorin via cfe-commits
a.sidorin updated this revision to Diff 57796. a.sidorin marked an inline comment as done. a.sidorin added a comment. Add some basic tests for ExpressionTraitExpr and ArrayTypeTraitExpr. http://reviews.llvm.org/D14326 Files: include/clang/AST/ASTImporter.h include/clang/AST/DeclFriend.h l

Re: [PATCH] D20198: clang-format: [JS] sort ES6 imports.

2016-05-19 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: lib/Format/SortJavaScriptImports.cpp:160 @@ +159,3 @@ + if (i + 1 < e) { +// Insert breaks between imports. +ReferencesText += "\n"; Between categories of imports and imports and exports, right? =

Re: [PATCH] D20428: Tracking exception specification source locations

2016-05-19 Thread Aaron Ballman via cfe-commits
aaron.ballman updated this revision to Diff 57798. aaron.ballman added a comment. For noexcept specifications without an expression, now tracking the full source range. Also, added tests. http://reviews.llvm.org/D20428 Files: include/clang/AST/Decl.h include/clang/AST/TypeLoc.h lib/AST/D

r270067 - [driver][mips] Hardcode triple name in case of CodeSourcery toolchain. NFC

2016-05-19 Thread Simon Atanasyan via cfe-commits
Author: atanasyan Date: Thu May 19 10:05:22 2016 New Revision: 270067 URL: http://llvm.org/viewvc/llvm-project?rev=270067&view=rev Log: [driver][mips] Hardcode triple name in case of CodeSourcery toolchain. NFC CodeSourcery toolchain is a standalone toolchain which always uses the same triple nam

Re: [PATCH] D20428: Tracking exception specification source locations

2016-05-19 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In http://reviews.llvm.org/D20428#434270, @alexfh wrote: > In http://reviews.llvm.org/D20428#434242, @aaron.ballman wrote: > > > In http://reviews.llvm.org/D20428#434238, @alexfh wrote: > > > > > Full context diff, please. > > > > > > Pardon my complete ignorance, b

Re: [PATCH] D20198: clang-format: [JS] sort ES6 imports.

2016-05-19 Thread Martin Probst via cfe-commits
mprobst marked 2 inline comments as done. mprobst added a comment. Thanks for the review, appreciated! Comment at: lib/Format/SortJavaScriptImports.cpp:160 @@ +159,3 @@ + if (i + 1 < e) { +// Insert breaks between imports. +ReferencesText += "\n"; --

[PATCH] D20437: [MSVC] Support of __unaligned qualifier for function types

2016-05-19 Thread Andrey Bokhanko via cfe-commits
andreybokhanko created this revision. andreybokhanko added reviewers: rnk, majnemer. andreybokhanko added a subscriber: cfe-commits. This adds support of MS-specific "__unaligned" qualifier for function types and fixes errors described by David Majnemer in this thread: http://lists.llvm.org/pipe

Re: r269220 - [MSVC] Implementation of __unaligned as a proper type qualifier

2016-05-19 Thread Andrey Bokhanko via cfe-commits
David, All these cases are handled properly now. Could you, please, review? http://reviews.llvm.org/D20437 Yours, Andrey On Sat, May 14, 2016 at 6:11 AM, David Majnemer wrote: > FYI, the following is a little shorter: > using Ty = int () __unaligned; > > Also, this case (in C mode) is inter

Re: [PATCH] D20428: Tracking exception specification source locations

2016-05-19 Thread don hinton via cfe-commits
hintonda added a comment. I can already catch all of these cases, but I can't catch this one, will this catch it too? void g(void (*fp)(void) throw()) throw(); ^^^ http://reviews.llvm.org/D20428 ___ cfe-commits mail

Re: [PATCH] D20437: [MSVC] Support of __unaligned qualifier for function types

2016-05-19 Thread David Majnemer via cfe-commits
majnemer added inline comments. Comment at: include/clang/Sema/DeclSpec.h:1152-1169 @@ -1153,19 +1151,20 @@ struct ArrayTypeInfo : TypeInfoCommon { -/// The type qualifiers for the array: const/volatile/restrict/_Atomic. -unsigned TypeQuals : 4; +/// The type qual

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

2016-05-19 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 57809. pcc added a comment. - Add a test for DW_OP_stack_value http://reviews.llvm.org/D20415 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h test/Code

Re: [PATCH] D20401: [Lexer] Don't merge macro args from different macro files

2016-05-19 Thread Vedant Kumar via cfe-commits
vsk updated this revision to Diff 57810. vsk added a comment. - Fix explanation of the test case in test/CoverageMapping. http://reviews.llvm.org/D20401 Files: lib/Lex/TokenLexer.cpp test/CoverageMapping/Inputs/macros.h test/CoverageMapping/include-macros.c unittests/Lex/LexerTest.cpp

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

2016-05-19 Thread don hinton via cfe-commits
hintonda updated this revision to Diff 57811. hintonda added a comment. Adjust matcher, add better error checking, and additional test cases. We can now parse all dynamic exception specifications, but haven't been able to develop a matcher that will find the following function declaration without

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

2016-05-19 Thread don hinton via cfe-commits
hintonda added a comment. Btw, this version can successfully check libcxx. http://reviews.llvm.org/D18575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20420: [find-all-symbol] Add macro support.

2016-05-19 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. In the future I'd prefer to do renaming changes (ResultReporter->SymbolReporter) in a separate change, but this is fine now. Comment at: include-fixer/find-all-symbols/Symb

r270079 - [X86][SSE2] Fixed shuffle of results in _mm_cmpnge_sd/_mm_cmpngt_sd tests

2016-05-19 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu May 19 11:48:59 2016 New Revision: 270079 URL: http://llvm.org/viewvc/llvm-project?rev=270079&view=rev Log: [X86][SSE2] Fixed shuffle of results in _mm_cmpnge_sd/_mm_cmpngt_sd tests Modified: cfe/trunk/test/CodeGen/sse2-builtins.c Modified: cfe/trunk/test/CodeGen/ss

[clang-tools-extra] r270082 - [include-fixer] Fix unused variable warning in Release builds.

2016-05-19 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu May 19 11:57:57 2016 New Revision: 270082 URL: http://llvm.org/viewvc/llvm-project?rev=270082&view=rev Log: [include-fixer] Fix unused variable warning in Release builds. Modified: clang-tools-extra/trunk/include-fixer/IncludeFixer.cpp Modified: clang-tools-extra/trunk/

Re: [PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

2016-05-19 Thread Manman Ren via cfe-commits
manmanren added a comment. Thanks Bruno Comment at: lib/Serialization/ASTWriter.cpp:2191 @@ -2191,1 +2190,3 @@ +// We write out exported module macros for PCH as well. +if (true) { auto Leafs = PP.getLeafModuleMacros(Name); bruno wrote: > Is this

r270083 - [X86][SSE] Sync with llvm/test/CodeGen/X86/sse-intrinsics-fast-isel.ll

2016-05-19 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu May 19 12:11:31 2016 New Revision: 270083 URL: http://llvm.org/viewvc/llvm-project?rev=270083&view=rev Log: [X86][SSE] Sync with llvm/test/CodeGen/X86/sse-intrinsics-fast-isel.ll sse-builtins.c now just covers SSE1 intrinsics Modified: cfe/trunk/test/CodeGen/sse-bui

Re: [PATCH] D20428: Tracking exception specification source locations

2016-05-19 Thread Aaron Ballman via cfe-commits
aaron.ballman updated this revision to Diff 57816. aaron.ballman added a comment. Added test cases for parameter types that have exception specifications. http://reviews.llvm.org/D20428 Files: include/clang/AST/Decl.h include/clang/AST/TypeLoc.h lib/AST/Decl.cpp lib/Parse/ParseDeclCXX.c

Re: [PATCH] D20428: Tracking exception specification source locations

2016-05-19 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In http://reviews.llvm.org/D20428#434420, @hintonda wrote: > I can already catch all of these cases, but I can't catch this one, will this > catch it too? > > void g(void (*fp)(void) throw()) throw(); > ^^^ > > > Actually, I can catc

Re: [PATCH] D20428: Tracking exception specification source locations

2016-05-19 Thread don hinton via cfe-commits
hintonda added a comment. Sure that sounds good to me. However, I would like to learn how to write better ASTMatchers. In any case, this has been a great learning experience. http://reviews.llvm.org/D20428 ___ cfe-commits mailing list cfe-commits

[PATCH] [clang] Emit ObjC method and block annotation attributes to IR

2016-05-19 Thread Max Bazaliy via cfe-commits
Hey, For some reason clang does not emit ObjC method and block annotations to IR. Here is a fix for that. -- Max Bazaliy objc_blocks_emit_ir.patch Description: Binary data ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

r270084 - [CUDA] Allow sm_50,52,53 GPUs

2016-05-19 Thread Artem Belevich via cfe-commits
Author: tra Date: Thu May 19 12:47:47 2016 New Revision: 270084 URL: http://llvm.org/viewvc/llvm-project?rev=270084&view=rev Log: [CUDA] Allow sm_50,52,53 GPUs LLVM accepts them since r233575. Differential Revision: http://reviews.llvm.org/D20405 Modified: cfe/trunk/lib/Basic/Targets.cpp

Re: [PATCH] D20405: [CUDA] allow sm_50,52,53 GPUs

2016-05-19 Thread Artem Belevich via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270084: [CUDA] Allow sm_50,52,53 GPUs (authored by tra). Changed prior to commit: http://reviews.llvm.org/D20405?vs=57715&id=57822#toc Repository: rL LLVM http://reviews.llvm.org/D20405 Files: cfe

r270085 - Don't rely on value numbers in test, those are fragile and change in Release (no asserts) builds.

2016-05-19 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Thu May 19 12:57:35 2016 New Revision: 270085 URL: http://llvm.org/viewvc/llvm-project?rev=270085&view=rev Log: Don't rely on value numbers in test, those are fragile and change in Release (no asserts) builds. Modified: cfe/trunk/test/CodeGen/avx512f-builtins.c Modified: c

Re: [PATCH] D20141: Check for nullptr argument.

2016-05-19 Thread Artem Belevich via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270086: Check for nullptr argument. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D20141?vs=56832&id=57825#toc Repository: rL LLVM http://reviews.llvm.org/D20141 Files: cfe/t

r270086 - Check for nullptr argument.

2016-05-19 Thread Artem Belevich via cfe-commits
Author: tra Date: Thu May 19 13:00:18 2016 New Revision: 270086 URL: http://llvm.org/viewvc/llvm-project?rev=270086&view=rev Log: Check for nullptr argument. Addresses static analysis report in PR15492. Differential Revision: http://reviews.llvm.org/D20141 Modified: cfe/trunk/lib/CodeGen/Co

r270089 - [MS ABI] Ignore transparent contexts when determining the effective context

2016-05-19 Thread David Majnemer via cfe-commits
Author: majnemer Date: Thu May 19 13:15:53 2016 New Revision: 270089 URL: http://llvm.org/viewvc/llvm-project?rev=270089&view=rev Log: [MS ABI] Ignore transparent contexts when determining the effective context We didn't skip over extern "C++" contexts, causing us to mangle things which don't nee

Re: [clang-tools-extra] r261991 - [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

2016-05-19 Thread Alexander Kornienko via cfe-commits
On Thu, May 19, 2016 at 4:45 PM, Hans Wennborg wrote: > +Tom who manages 3.8.1 > +Alex who's owner of clang-tidy: is this ok for 3.8.1? > Yes, would be nice to have this in 3.8.1. This fixes a rather annoying problem. > > On Thu, May 19, 2016 at 1:56 AM, Edoardo P. via cfe-commits > wrote: >

Re: [PATCH] D20341: [CUDA] Enable fusing FP ops for CUDA by default.

2016-05-19 Thread Justin Lebar via cfe-commits
jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Well, if the CUDA documentation says so...let's do it. :) Thanks for your patience, everyone. http://reviews.llvm.org/D20341 ___ cfe-commits m

Re: [PATCH] D20341: [CUDA] Enable fusing FP ops for CUDA by default.

2016-05-19 Thread Artem Belevich via cfe-commits
tra added a subscriber: chandlerc. tra added a comment. Short version of offline discussion with @chandlerc : Default of -ffp-contract=fast for CUDA is fine. http://reviews.llvm.org/D20341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

r270094 - [CUDA] Enable fusing FP ops (-ffp-contract=fast) for CUDA by default.

2016-05-19 Thread Artem Belevich via cfe-commits
Author: tra Date: Thu May 19 13:44:45 2016 New Revision: 270094 URL: http://llvm.org/viewvc/llvm-project?rev=270094&view=rev Log: [CUDA] Enable fusing FP ops (-ffp-contract=fast) for CUDA by default. This matches default nvcc behavior and gives substantial performance boost on GPU where fmad is m

Re: [PATCH] D20341: [CUDA] Enable fusing FP ops for CUDA by default.

2016-05-19 Thread Artem Belevich via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270094: [CUDA] Enable fusing FP ops (-ffp-contract=fast) for CUDA by default. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D20341?vs=57541&id=57833#toc Repository: rL LLVM htt

Re: [PATCH] D20422: [MSVC2015] dllexport for defaulted special class members

2016-05-19 Thread Reid Kleckner via cfe-commits
rnk added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:4814 @@ -4813,3 +4813,3 @@ // we have a definition. auto *CXXC = dyn_cast(MD); if ((MD->isMoveAssignmentOperator() || nit, can you rename this Ctor? I definitely know that t

Re: r266719 - Warn if function or variable cannot be implicitly instantiated

2016-05-19 Thread Serge Pavlov via cfe-commits
In this case moving implementation of `Singleton::getInstance()` into a .cpp file would prevent compiler from instantiation of the method body when it sees `Singleton::getInstance()`. In this case `Singleton::getInstance()` must be instantiated in some source file either explicitly or implicitly. I

[PATCH] D20444: [OpenCL] Include opencl-c.h by default as a module

2016-05-19 Thread Yaxun Liu via cfe-commits
yaxunl created this revision. yaxunl added reviewers: Anastasia, pxli168, bader, rsmith. yaxunl added a subscriber: cfe-commits. Include opencl-c.h by default as a module to utilize the automatic AST caching mechanism of module. Add an option -fno-default-header to disable default header for Ope

Re: [PATCH] D20392: [CodeView] Modify emitTypeInformation to use MemoryTypeTableBuilder

2016-05-19 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D20392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20446: clang-rename: fix renaming members when referenced as macro arguments

2016-05-19 Thread Miklos Vajna via cfe-commits
vmiklos created this revision. vmiklos added reviewers: cfe-commits, klimek. The second check failed, FOO(C.X) wasn't renamed to FOO(C.Y). http://reviews.llvm.org/D20446 Files: clang-rename/USRLocFinder.cpp test/clang-rename/MemberExprMacro.cpp Index: test/clang-rename/MemberExprMacro.cpp =

r270107 - [CUDA] Split device-var-init.cu tests into separate Sema and CodeGen parts.

2016-05-19 Thread Artem Belevich via cfe-commits
Author: tra Date: Thu May 19 15:13:39 2016 New Revision: 270107 URL: http://llvm.org/viewvc/llvm-project?rev=270107&view=rev Log: [CUDA] Split device-var-init.cu tests into separate Sema and CodeGen parts. Codegen tests for device-side variable initialization are subset of test cases used to veri

Re: [PATCH] D20140: [CUDA] Do not allow non-empty destructors for global device-side variables.

2016-05-19 Thread Artem Belevich via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270108: [CUDA] Do not allow non-empty destructors for global device-side variables. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D20140?vs=56829&id=57849#toc Repository: rL LLV

Re: [PATCH] D20139: [CUDA] Split device-var-init.cu tests into separate Sema and CodeGen parts.

2016-05-19 Thread Artem Belevich via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270107: [CUDA] Split device-var-init.cu tests into separate Sema and CodeGen parts. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D20139?vs=56824&id=57848#toc Repository: rL LLV

r270108 - [CUDA] Do not allow non-empty destructors for global device-side variables.

2016-05-19 Thread Artem Belevich via cfe-commits
Author: tra Date: Thu May 19 15:13:53 2016 New Revision: 270108 URL: http://llvm.org/viewvc/llvm-project?rev=270108&view=rev Log: [CUDA] Do not allow non-empty destructors for global device-side variables. According to Cuda Programming guide (v7.5, E2.3.1): > __device__, __constant__ and __shared

Re: r270039 - [Sema] Allow an external sema source to handle delayed typo corrections.

2016-05-19 Thread Evgenii Stepanov via cfe-commits
Looks like this commit broke the bot: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux- bootstrap/builds/11738/steps/check-clang%20ubsan/logs/stdio On Thu, May 19, 2016 at 3:52 AM, Benjamin Kramer via cfe-commits wrote: > Author: d0k > Date: Thu May 19 05:46:10 2016 > New Revision: 270039

Re: r270047 - [Clang][AVX512][intrinsics] continue completing missing set intrinsics

2016-05-19 Thread Steven Wu via cfe-commits
Hi Michael This commit seems break darwin LTO bootstrap bot. http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_check/7916/ Also breaks the Asan Ubsan bot: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/1742/ Can you talk a look? I don't why the failure doesn't sho

Re: [PATCH] D19909: [Attr] Add support for the `ms_hook_prologue` attribute.

2016-05-19 Thread Charles Davis via cfe-commits
cdavis5x added a comment. For now, I've disallowed it with `naked` and `always_inline`/`__forceinline` attributes. Do any other attributes affect prologue generation in a way that might interfere with `ms_hook_prologue`? AFAICT, GCC only disallows `ms_hook_prologue` on a) nested functions and b

Re: [PATCH] D19909: [Attr] Add support for the `ms_hook_prologue` attribute.

2016-05-19 Thread Charles Davis via cfe-commits
cdavis5x updated this revision to Diff 57853. cdavis5x marked an inline comment as done. cdavis5x added a comment. - Add Sema tests for the `ms_hook_prologue` attribute. - Disallow `ms_hook_prologue` on architectures that Windows doesn't support. - Disallow `ms_hook_prologue` with the `naked` and

  1   2   >