rnk added inline comments.
================
Comment at: lib/Sema/SemaDeclCXX.cpp:4814
@@ -4813,3 +4813,3 @@
// we have a definition.
auto *CXXC = dyn_cast<CXXConstructorDecl>(MD);
if ((MD->isMoveAssignmentOperator() ||
----------------
nit, can you rename this Ctor? I definitely know that that is, but not
necessarily CXXC.
================
Comment at: lib/Sema/SemaDeclCXX.cpp:13111
@@ -13090,3 +13110,3 @@
llvm_unreachable("Invalid special member.");
}
} else {
----------------
Can we add `if (InClassDef) ActOnFinishInlineFunctionDef(MD);` here instead? If
the decl doesn't have dllexport, we will just defer it until its referenced,
which seems OK.
http://reviews.llvm.org/D20422
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
