r269460 - Add an AST matcher for CastExpr kind

Author: etienneb Date: Fri May 13 14:36:55 2016 New Revision: 269460 URL: http://llvm.org/viewvc/llvm-project?rev=269460&view=rev Log: Add an AST matcher for CastExpr kind Summary: This AST matcher will match a given CastExpr kind. It's an narrowing matcher on CastExpr. Reviewers: klimek, alexfh

r269463 - [ProfileData] (clang) Use Error in InstrProf and Coverage, NFC

Author: vedantk Date: Fri May 13 15:01:34 2016 New Revision: 269463 URL: http://llvm.org/viewvc/llvm-project?rev=269463&view=rev Log: [ProfileData] (clang) Use Error in InstrProf and Coverage, NFC Sync up with "(llvm) Use Error in InstrProf and Coverage". Modified: cfe/trunk/lib/CodeGen/Code

r269465 - [MS ABI] Delegating constructors should not assume they are most derived

Author: majnemer Date: Fri May 13 15:05:09 2016 New Revision: 269465 URL: http://llvm.org/viewvc/llvm-project?rev=269465&view=rev Log: [MS ABI] Delegating constructors should not assume they are most derived A constructor needs to know whether or not it is most derived in order to determine if it

r269468 - Revert "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC"

Author: vedantk Date: Fri May 13 15:10:22 2016 New Revision: 269468 URL: http://llvm.org/viewvc/llvm-project?rev=269468&view=rev Log: Revert "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC" This reverts commit r269463. It fails two llvm-profdata tests. Modified: cfe/trunk/lib

[PATCH] D20254: [Clang] Fix some Clang-tidy modernize-use-bool-literals warnings; other minor fixes.

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Fix some Include What You Use warnings. I checked this patch on my own build on RHEL 6. Regres

Re: [PATCH] D20118: Add support for injected class names and constructor initializers in C++

Thank you for your comments, I’m working on them now. Sean > On May 11, 2016, at 4:39 AM, Aleksei Sidorin wrote: > > a.sidorin added a comment. > > I' d like to have some tests for this. CXXCtorInitializers can be tested with > D14224 -like stuff or with ASTMat

Re: [PATCH] D20118: Add support for injected class names and constructor initializers in C++

spyffe added a subscriber: spyffe. spyffe added a comment. Thank you for your comments, I’m working on them now. Sean Repository: rL LLVM http://reviews.llvm.org/D20118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D20254: [Clang] Fix some Clang-tidy modernize-use-bool-literals warnings; other minor fixes.

Prazek added a subscriber: Prazek. Prazek added a comment. Can you post this review with more context? (diff -U9) Repository: rL LLVM http://reviews.llvm.org/D20254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

Re: [PATCH] D20254: [Clang] Fix some Clang-tidy modernize-use-bool-literals warnings; other minor fixes.

Eugene.Zelenko updated this revision to Diff 57250. Eugene.Zelenko added a comment. Include mode context. Repository: rL LLVM http://reviews.llvm.org/D20254 Files: include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/IdentifierTable.h lib/Basic/FileManager.cpp Index: lib/Basic/

Re: [patch] Don't use appending linkage for embeded bitcode

Attach a patch using private linkage type and adding to llvm.used. I have to recreate llvm.used when embedding bitcode. I don't really like it but I don't have better solutions. Few other options: 1. Not allowing re-embedded bitcode will simplify the code a bit but not a lot. 2. Create a new "llv

Re: [PATCH] D20118: Add support for injected class names and constructor initializers in C++

spyffe added a comment. I’m just going to use clang-format to resolve trailing whitespace/etc issues. It changes around some indentation in the class declaration for ASTImporter but that probably needs to be taken care of anyway… Sean Repository: rL LLVM http://reviews.llvm.org/D20118

Re: [PATCH] D20118: Add support for injected class names and constructor initializers in C++

I’m just going to use clang-format to resolve trailing whitespace/etc issues. It changes around some indentation in the class declaration for ASTImporter but that probably needs to be taken care of anyway… Sean > On May 13, 2016, at 1:40 PM, Sean Callanan wrote: > > spyffe added a subscriber

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

cameron314 added inline comments. Comment at: lib/Basic/FileManager.cpp:304-307 @@ -303,1 +303,6 @@ + if (UFE.isVirtual()) { +UFE.Name = InterndFileName; +return &UFE; + } + rsmith wrote: > It looks like this is unreachable: `IsVirtual` is only ever `t

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

cameron314 updated this revision to Diff 57253. cameron314 added a comment. Removed workaround for case that can no longer happen. http://reviews.llvm.org/D20137 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp Index: lib/Frontend/ASTUnit.cpp ===

Re: [patch] Don't use appending linkage for embeded bitcode

You can probably use collectUsedGlobalVariables. You can probably also delete the FIXME about llvm.used and appending linkage. I think the way to fix this is to make "can be dropped" an independent property from the linkage and then we don't need llvm.used at all. Cheers, Rafael On 13 May 2016

r269487 - ARM-MachO: stop claiming to be EABI

Author: tnorthover Date: Fri May 13 16:26:45 2016 New Revision: 269487 URL: http://llvm.org/viewvc/llvm-project?rev=269487&view=rev Log: ARM-MachO: stop claiming to be EABI Embedded ARM MachO targets are AAPCS but not full EABI (we don't use __aeabi_whatever and the functions are allowed to be ha

r269492 - Reapply "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC"

Author: vedantk Date: Fri May 13 16:51:02 2016 New Revision: 269492 URL: http://llvm.org/viewvc/llvm-project?rev=269492&view=rev Log: Reapply "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC" Sync up with "(llvm) Use Error in InstrProf and Coverage". Differential Revision: http://

Re: [PATCH] D19902: [ProfileData] (clang) Use Error in InstrProf and Coverage

This revision was automatically updated to reflect the committed changes. Closed by commit rL269492: Reapply "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC" (authored by vedantk). Changed prior to commit: http://reviews.llvm.org/D19902?vs=56346&id=57259#toc Repository: rL LL

[PATCH] D20261: [compiler-rt] Fix multi-configuration output paths

etienneb created this revision. etienneb added a reviewer: rnk. etienneb added a subscriber: cfe-commits. When using a multi-configuration build (i.e. MSVC) the output path where libraries are dropped is incorrect. Example: ``` C:\src\llvm\examples>d:\src\llvm\build\Release\bin\clang-cl.exe -fsa

Re: [PATCH] D20194: [ModuleMap][CrashReproducer] Collect headers from inner frameworks

bruno updated this revision to Diff 57263. bruno added a comment. Updated after Ben's suggestions! http://reviews.llvm.org/D20194 Files: include/clang/Lex/ModuleMap.h lib/Frontend/ModuleDependencyCollector.cpp lib/Lex/ModuleMap.cpp test/Modules/Inputs/crash-recovery/Frameworks/A.framewo

Re: [PATCH] D20194: [ModuleMap][CrashReproducer] Collect headers from inner frameworks

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

r269502 - [ModuleMap][CrashReproducer] Collect headers from inner frameworks

Author: bruno Date: Fri May 13 17:21:51 2016 New Revision: 269502 URL: http://llvm.org/viewvc/llvm-project?rev=269502&view=rev Log: [ModuleMap][CrashReproducer] Collect headers from inner frameworks (1) Collect headers under inner frameworks (frameworks inside other other frameworks). (2) Make su

Re: [PATCH] D20194: [ModuleMap][CrashReproducer] Collect headers from inner frameworks

bruno closed this revision. bruno added a comment. Thanks Ben! Committed r269502 http://reviews.llvm.org/D20194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20261: [compiler-rt] Fix multi-configuration output paths

rnk added a comment. Will this put the libraries in build/Release/bin/../lib/. aka build/Release/lib, or will they collide between build types? http://reviews.llvm.org/D20261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

Re: [patch] Don't use appending linkage for embeded bitcode

Is this something that you need the linker to treat as "used", or just something you don't want the compiler to drop? If the latter, @llvm.compiler.used seems more appropriate. > On 2016-May-13, at 14:01, Steven Wu wrote: > > Attach a patch using private linkage type and adding to llvm.used.

Re: [PATCH] D18953: [ms][dll] #26935 Defining a dllimport function should cause it to be exported

rnk added inline comments. Comment at: test/SemaCXX/dllimport.cpp:179 @@ -140,1 +178,3 @@ +template +int ExternVarTmplDeclInit = 1; avt77 wrote: > majnemer wrote: > > avt77 wrote: > > > rnk wrote: > > > > Can you check with MSVC 2015 update 2 actually does with

Re: r269220 - [MSVC] Implementation of __unaligned as a proper type qualifier

Hi David, Thanks for letting me know -- will investigate after the weekend. Yours, Andrey Отправлено с iPad > 13 мая 2016 г., в 20:33, David Majnemer написал(а): > > This seems to crash clang: > struct S { > void f() __unaligned; > }; > void S::f() __unaligned { > } > > clang/lib/Sema/Decl

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. LG, sounds like people are happy with this http://reviews.llvm.org/D20136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

Re: r269398 - Add support for derived class special members hiding functions brought in from

Update: Vassil and I have dug into this a bit offline. It looks like the root cause is a likely-pre-existing bug where we somehow import a default constructor for a class from a module but don't set the "has a default constructor" flag on the class definition. On Fri, May 13, 2016 at 2:54 AM, Vass

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

This revision was automatically updated to reflect the committed changes. amccarth marked an inline comment as done. Closed by commit rL269515: Get default -fms-compatibility-version from cl.exe's version (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D20136?vs=57196&i

r269515 - Get default -fms-compatibility-version from cl.exe's version

Author: amccarth Date: Fri May 13 18:20:11 2016 New Revision: 269515 URL: http://llvm.org/viewvc/llvm-project?rev=269515&view=rev Log: Get default -fms-compatibility-version from cl.exe's version -fms-compatibility-version was defaulting to 18 (VS 2013), which is a pain if your environment is po

Re: [PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

rsmith added inline comments. Comment at: lib/Frontend/ASTUnit.cpp:1402-1406 @@ +1401,7 @@ + +vfs::Status Status; +if (FileMgr->getNoncachedStatValue(RB.first, Status)) { + AnyFileChanged = true; + break; +} + Suppose file

[clang-tools-extra] r269517 - [Release notes] Mention Clang-tidy modernize-avoid-bind check.

Author: eugenezelenko Date: Fri May 13 18:35:56 2016 New Revision: 269517 URL: http://llvm.org/viewvc/llvm-project?rev=269517&view=rev Log: [Release notes] Mention Clang-tidy modernize-avoid-bind check. Fix some problems in its documentation. Modified: clang-tools-extra/trunk/docs/ReleaseNot

Re: [PATCH] D19667: [ubsan] Minimize size of data for type_mismatch

rsmith added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:579 @@ -578,1 +578,3 @@ +// Make sure we're not losing information. Alignment needs to be a power of 2 +assert(!AlignVal || (uint64_t)1 << llvm::Log2_64(AlignVal) == AlignVal); llvm::Constant *StaticDat

Re: [patch] Don't use appending linkage for embeded bitcode

> On May 13, 2016, at 3:56 PM, Duncan P. N. Exon Smith > wrote: > > Is this something that you need the linker to treat as "used", or just > something you don't want the compiler to drop? If the latter, > @llvm.compiler.used seems more appropriate. Bitcode is actually not really used by the

r269520 - [VFS] Add level() method to vfs::recursive_directory_iterator

Author: bruno Date: Fri May 13 19:00:18 2016 New Revision: 269520 URL: http://llvm.org/viewvc/llvm-project?rev=269520&view=rev Log: [VFS] Add level() method to vfs::recursive_directory_iterator Unlike sys::fs::recursive_directory_iterator, vfs::recursive_directory_iterator does not implement the

Re: [PATCH] D20171: Support for MSVS default calling convention options (/Gd, /Gz, /Gv, /Gr)

rnk added inline comments. Comment at: include/clang/Driver/CC1Options.td:615 @@ +614,3 @@ + HelpText<"Set default MS calling convention">; +def mrtd : Flag<["-"], "mrtd">, Group, + Alias, AliasArgs<["stdcall"]>, Doesn't this have to live in Options.td if you wa

Re: [PATCH] D20170: [clang-tidy] TypeTraits - Type is not expensive to copy when it has a deleted copy constructor.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good after addressing Etienne's comment. Thanks! http://reviews.llvm.org/D20170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

r269527 - [AVX512] Update pshufd type strings to match the backend. Also mark the immediate as an ICE instead of marking the previous vector as const.

Author: ctopper Date: Fri May 13 19:49:36 2016 New Revision: 269527 URL: http://llvm.org/viewvc/llvm-project?rev=269527&view=rev Log: [AVX512] Update pshufd type strings to match the backend. Also mark the immediate as an ICE instead of marking the previous vector as const. Modified: cfe/tru

[PATCH] D20266: [Modules] Use vfs for (recursive) directory iteration

bruno created this revision. bruno added a reviewer: benlangmuir. bruno added a subscriber: cfe-commits. Clang performs directory walk while searching headers inside modules by using the ::sys::fs instead of ::vfs. This prevents any code that uses the VFS (e.g, reproducer scripts) to actually find

r269528 - Fix some typos.

Author: rsmith Date: Fri May 13 20:21:40 2016 New Revision: 269528 URL: http://llvm.org/viewvc/llvm-project?rev=269528&view=rev Log: Fix some typos. Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/tru

Re: [PATCH] D19851: Warn on binding reference to null in copy initialization

rsmith accepted this revision. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5369 @@ -5368,1 +5368,3 @@ +def warn_binding_null_to_reference : Warning< + "binding null pointer to reference has undefined behavior">, InGroup; def note_indirection_through_null : Note<

r269530 - When typo-correcting a using-declaration, actually correct the name of the

Author: rsmith Date: Fri May 13 20:58:49 2016 New Revision: 269530 URL: http://llvm.org/viewvc/llvm-project?rev=269530&view=rev Log: When typo-correcting a using-declaration, actually correct the name of the UsingDecl (so that redeclaration lookup can find it). Modified: cfe/trunk/lib/Sema/Se

Re: r269220 - [MSVC] Implementation of __unaligned as a proper type qualifier

FYI, the following is a little shorter: using Ty = int () __unaligned; Also, this case (in C mode) is interesting: void f(int x[__unaligned 4]); DeclaratorChunk::getArray will truncate the TypeQuals because ArrayTypeInfo's TypeQuals doesn't have enough bits. similar issues arise with: struct A;

Re: [PATCH] D20261: [compiler-rt] Fix multi-configuration output paths

etienneb added a comment. In http://reviews.llvm.org/D20261#430151, @rnk wrote: > Will this put the libraries in build/Release/bin/../lib/. aka > build/Release/lib, or will they collide between build types? If I get your question correctly, they won't collide since the first folder below

r269546 - Added support to the ASTImporter for C++ constructor initializers.

Author: spyffe Date: Sat May 14 00:20:31 2016 New Revision: 269546 URL: http://llvm.org/viewvc/llvm-project?rev=269546&view=rev Log: Added support to the ASTImporter for C++ constructor initializers. Thanks to Aleksei Sidorin for review and advice. Added: cfe/trunk/test/ASTMerge/Inputs/init-

r269549 - Revert "Reapply "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC""

Author: chandlerc Date: Sat May 14 00:39:45 2016 New Revision: 269549 URL: http://llvm.org/viewvc/llvm-project?rev=269549&view=rev Log: Revert "Reapply "[ProfileData] (clang) Use Error in InstrProf and Coverage, NFC"" This reverts commit r269492 as the corresponding LLVM commit was reverted due

Re: [PATCH] D20261: [compiler-rt] Fix multi-configuration output paths

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Great! Lgtm http://reviews.llvm.org/D20261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

r269551 - Handle injected class names in the ASTImporter.

Author: spyffe Date: Sat May 14 00:43:57 2016 New Revision: 269551 URL: http://llvm.org/viewvc/llvm-project?rev=269551&view=rev Log: Handle injected class names in the ASTImporter. Every class as parsed by Clang has a forward declaration of itself as a member: class A { class A; ... } but w

r269552 - [X86] Change most 'void' pointers in builtin type lists to more correct types. Fix some unaligned load/store intrinsics to use a less aligned type in their pointer casts.

Author: ctopper Date: Sat May 14 01:03:13 2016 New Revision: 269552 URL: http://llvm.org/viewvc/llvm-project?rev=269552&view=rev Log: [X86] Change most 'void' pointers in builtin type lists to more correct types. Fix some unaligned load/store intrinsics to use a less aligned type in their pointe

r269553 - Fixed a bug where the ASTImporter didn't propagate builtin IDs at all.

Author: spyffe Date: Sat May 14 01:11:19 2016 New Revision: 269553 URL: http://llvm.org/viewvc/llvm-project?rev=269553&view=rev Log: Fixed a bug where the ASTImporter didn't propagate builtin IDs at all. IdentifierInfos are assigned builtin IDs during parsing, but Idents.get() does not do that w

r269554 - Update identifiers as needed when loading macros from serialized ASTs.

Author: spyffe Date: Sat May 14 01:24:14 2016 New Revision: 269554 URL: http://llvm.org/viewvc/llvm-project?rev=269554&view=rev Log: Update identifiers as needed when loading macros from serialized ASTs. This is essential for iterating across macros properly, which LLDB does when loading macros f

<    1   2