Author: mps
Date: Mon Apr 4 14:36:48 2016
New Revision: 265338
URL: http://llvm.org/viewvc/llvm-project?rev=265338&view=rev
Log:
Fix redundant "typename typename T" in Visual Studio Native Visualizer
Also, a little minor cleanup
Modified:
cfe/trunk/utils/ClangVisualizers/clang.natvis
Modif
Author: gbiv
Date: Mon Apr 4 14:44:16 2016
New Revision: 265341
URL: http://llvm.org/viewvc/llvm-project?rev=265341&view=rev
Log:
[Sema] Delete FIXME that has been fixed. NFC.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL:
http://llvm.org/viewvc/ll
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
This revision is now accepted and ready to land.
Comment at: lib/Lex/PPMacroExpansion.cpp:1489-1492
@@ +1488,6 @@
+// a diagnostic and a dummy value.
+if (Result.hasValue())
+ OS << Result.get
yaxunl marked an inline comment as done.
Comment at: test/CodeGenOpenCL/2016-04-01-addrcast.cl:1
@@ +1,2 @@
+// RUN: %clang_cc1 %s -triple x86_64-unknown-linux-gnu -O0 -cl-std=CL2.0
-emit-llvm -o - | FileCheck %s
+
Anastasia wrote:
> Can we rename the file to jus
yaxunl updated this revision to Diff 52607.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Removed 2016-04-01-addrcast.cl and it to address-spaces-conversions.cl.
http://reviews.llvm.org/D18713
Files:
lib/CodeGen/CGExprScalar.cpp
test/CodeGenOpenCL/address-spaces-conversio
etienneb added a subscriber: etienneb.
etienneb added a comment.
this is cool.
Comment at: clang-tidy/misc/MultipleStatementMacroCheck.cpp:33
@@ +32,3 @@
+
+namespace {
+
I feel it nicer if you merge this namespace with the one at line 20.
Comm
ahatanak updated this revision to Diff 52609.
ahatanak added a comment.
Changed the patch based on review comments.
Added code to enter RunCleanupsScope before the condition is evaluated and
force its cleanup before emitting LoopEnd.
http://reviews.llvm.org/D18618
Files:
lib/CodeGen/CGObjC.
ahatanak added a comment.
Also, fixed the regex in test case so that the test passes on release builds
too.
http://reviews.llvm.org/D18618
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: bruno
Date: Mon Apr 4 15:26:57 2016
New Revision: 265343
URL: http://llvm.org/viewvc/llvm-project?rev=265343&view=rev
Log:
[CrashReproducer] Pass -I, -F and -resource-dir to the reproducer script when
using modules/vfs
The reproducer should use -I/-F/-resource-dir in the same way as the
george.burgess.iv updated this revision to Diff 52619.
george.burgess.iv marked 4 inline comments as done.
george.burgess.iv added a comment.
Addressed most feedback; see comments. :)
http://reviews.llvm.org/D18425
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaExpr.cpp
lib/Sema/SemaOverlo
george.burgess.iv added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:5047-5098
@@ -5046,57 +5046,54 @@
+CallExpr *Sema::buildDependentCallExpr(Expr *ExecConfig, Expr *Fn,
+ MultiExprArg ArgExprs,
+
In addition to the Sema tests, this change needs tests in CodeGenObjC to
show where the attribute is applied in the IR.
--- a/lib/CodeGen/CGBlocks.cpp
+++ b/lib/CodeGen/CGBlocks.cpp
@@ -2334,5 +2334,9 @@ llvm::Constant
*CodeGenModule::getNSConcreteStackBlock() {
Author: rjmccall
Date: Mon Apr 4 15:39:50 2016
New Revision: 265344
URL: http://llvm.org/viewvc/llvm-project?rev=265344&view=rev
Log:
Fix an unused-variable warning by using the variable in the place
it was supposed to have been used.
Modified:
cfe/trunk/lib/CodeGen/SwiftCallingConv.cpp
Nah, just worth knowing. It was probably more useful to know last month.
-eric
On Mon, Apr 4, 2016 at 11:56 AM Kit Barton wrote:
> I forgot to edit the message.
> Do you think it's worth going back and fixing the log message at this
> point?
>
> Kit Barton, Ph.D.
> LLVM Development on POWER
> I
dyung updated this revision to Diff 52622.
dyung added a comment.
Moved the test to test/Preprocessor as suggested by Gao and found a nice place
to add it.
http://reviews.llvm.org/D18708
Files:
include/clang/Frontend/CompilerInvocation.h
lib/Frontend/CompilerInvocation.cpp
test/Preproces
Yeah, fair enough.
That's the downside of committing on behalf of others and focusing on throughput :(
Kit Barton, Ph.D.LLVM Development on POWERIBM Toronto Lab, D2/929/8200/MKM8200 Warden Ave, Markham, L6G 1C7(905) 413-3452kbar...@ca.ibm.com
- Original message -From: Eric Christophe
sbenza updated this revision to Diff 52625.
sbenza marked an inline comment as done.
sbenza added a comment.
Minor fixes
http://reviews.llvm.org/D18766
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MultipleStatementMacroCheck.cpp
clang-tidy/mis
sbenza marked an inline comment as done and an inline comment as not done.
Comment at: clang-tidy/misc/MultipleStatementMacroCheck.cpp:33
@@ +32,3 @@
+
+namespace {
+
etienneb wrote:
> I feel it nicer if you merge this namespace with the one at line 20.
I like to
etienneb added a comment.
thanks, lgtm.
http://reviews.llvm.org/D18766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ariccio added a comment.
Here's my confusion: don't we //kinda// have to duplicate tests? After all
these functions are //essentially// duplicate functions.
http://reviews.llvm.org/D18073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
sfantao added a comment.
I just wanted to add to what Carlo just said, that the feature to capture by
value is already used in the offloading upstreamed code. This is not a new
feature we are proposing , it is already there used in the code and tested in
relevant regression tests. This patch is
zaks.anna added a comment.
Can you add one test per new function, which tests that the function if modeled
correctly. Please, do not duplicate all tests that contain a function with it's
windows variants.
Hope this is more clear.
http://reviews.llvm.org/D18073
_
ygao accepted this revision.
ygao added a reviewer: ygao.
ygao added a comment.
The test LGTM. Thanks!
http://reviews.llvm.org/D18708
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo added a comment.
That's fascinating and terrifying all at once.
Can you rename the test to avx-v-modifier-inline-asm.c please?
One inline comment as well.
Thanks!
-eric
Comment at: lib/AST/Stmt.cpp:639
@@ +638,3 @@
+ // into "pcmpestri" otherwise.
+ if (C.
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
I'm not real fond of the testcase being in attr-target-x86, but there's not a
better place at the moment either.
-eric
http://reviews.llvm.org/D18651
_
ariccio added a comment.
So for `_wcsdup_dbg`, I should leave only `testWinWcsdupDbg`?
http://reviews.llvm.org/D18073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jyknight
Date: Mon Apr 4 17:35:56 2016
New Revision: 265355
URL: http://llvm.org/viewvc/llvm-project?rev=265355&view=rev
Log:
Fix "suggest parentheses" warning.
Modified:
cfe/trunk/lib/CodeGen/SwiftCallingConv.cpp
Modified: cfe/trunk/lib/CodeGen/SwiftCallingConv.cpp
URL:
http://llv
Author: marshall
Date: Mon Apr 4 17:49:20 2016
New Revision: 265358
URL: http://llvm.org/viewvc/llvm-project?rev=265358&view=rev
Log:
Put back the undefs that Richard removed. Boost won't build w/o these;
specifically the file 'bytes_methods.h' in Apple's python framework defines
these.
Modifi
Author: ssrivastava
Date: Mon Apr 4 17:56:05 2016
New Revision: 265359
URL: http://llvm.org/viewvc/llvm-project?rev=265359&view=rev
Log:
Set the default C standard to C99 when targeting the PS4.
Patch by Douglas Yung!
Differential Revision: http://reviews.llvm.org/D18708
Modified:
cfe/trun
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265359: Set the default C standard to C99 when targeting the
PS4. (authored by ssrivastava).
Changed prior to commit:
http://reviews.llvm.org/D18708?vs=52622&id=52633#toc
Repository:
rL LLVM
http://
jfb created this revision.
jfb added reviewers: jyknight, reames.
jfb added a subscriber: cfe-commits.
See LLVM change D18775 for details, this change depends on it.
http://reviews.llvm.org/D18776
Files:
lib/CodeGen/CGAtomic.cpp
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CGExprScalar.cpp
lib/
Author: rnk
Date: Mon Apr 4 18:14:14 2016
New Revision: 265362
URL: http://llvm.org/viewvc/llvm-project?rev=265362&view=rev
Log:
Fix test failure from r265361
Modified:
cfe/trunk/test/CodeGen/align_value.cpp
Modified: cfe/trunk/test/CodeGen/align_value.cpp
URL:
http://llvm.org/viewvc/llvm-
On Mon, Apr 4, 2016 at 3:49 PM, Marshall Clow via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: marshall
> Date: Mon Apr 4 17:49:20 2016
> New Revision: 265358
>
> URL: http://llvm.org/viewvc/llvm-project?rev=265358&view=rev
> Log:
> Put back the undefs that Richard removed. Boost wo
On Fri, Apr 1, 2016 at 6:43 PM, Douglas Yung <
douglas_y...@playstation.sony.com> wrote:
> dyung added a comment.
>
> In http://reviews.llvm.org/D18708#390166, @rsmith wrote:
>
> > In http://reviews.llvm.org/D18708#390150, @dyung wrote:
> >
> > > From my understanding, there are 2 issues that bloc
Author: marshall
Date: Mon Apr 4 18:23:35 2016
New Revision: 265363
URL: http://llvm.org/viewvc/llvm-project?rev=265363&view=rev
Log:
Remove unused internal routines. No functional change
Modified:
libcxx/trunk/include/algorithm
Modified: libcxx/trunk/include/algorithm
URL:
http://llvm.org
rsmith added a subscriber: rsmith.
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM. Post-commit review is fine for changes like this that mechanically update
Clang to match LLVM API changes.
http://rev
Author: rsmith
Date: Mon Apr 4 18:29:43 2016
New Revision: 265364
URL: http://llvm.org/viewvc/llvm-project?rev=265364&view=rev
Log:
Move local helper class into anonymous namespace.
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
Modified: cfe/trunk/lib/AST/ExprConstant.cpp
URL:
http://llvm.o
carlo.bertolli updated this revision to Diff 52640.
carlo.bertolli added a comment.
[OPENMP] Rebase patch on new support for codegen for teams in nvptx target.
private and firstprivate clauses are now dealt with in the teams patch and this
one only becomes regression tests.
Repository:
rL LL
rsmith added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:5218-5221
@@ -5209,1 +5217,6 @@
+ Fn, NDecl, LParenLoc, ArgExprs, RParenLoc, ExecConfig, IsExecConfig);
+
+ if (MakeCallInstantiationDependent)
+BuiltCall.get()->setInstantiationDependent(true);
+ return Bu
erik.pilkington updated this revision to Diff 52641.
erik.pilkington added a comment.
Include local static data member template in test. Thanks for taking a look
Richard, would you mind committing this for me?
http://reviews.llvm.org/D18653
Files:
lib/Sema/SemaDeclCXX.cpp
test/CXX/temp/tem
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D18764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
This patch add the support for detecting suspicious string
literals and their usage.
The following example shows a incorrect character escaping leading
to an embedded NUL character.
```
etienneb updated this revision to Diff 52653.
etienneb added a comment.
Fix list.rst (bad merge)
http://reviews.llvm.org/D18783
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/StringLiteralWithEmbeddedNulCheck.cpp
clang-tidy/misc/StringLiteralWit
Author: etienneb
Date: Mon Apr 4 20:41:02 2016
New Revision: 265375
URL: http://llvm.org/viewvc/llvm-project?rev=265375&view=rev
Log:
[clang-tidy] Fix documentation of misc-suspicious-missing-comma
Summary:
The clang-tidy documentation generation was broken since commit :
http://reviews.llvm.or
Tom, may I commit it into release_38?
It has been preventing "lit --use-processes" on windows.
2016-02-16 17:13 GMT+09:00 NAKAMURA Takumi via cfe-commits
:
> Author: chapuni
> Date: Tue Feb 16 02:13:36 2016
> New Revision: 260944
>
> URL: http://llvm.org/viewvc/llvm-project?rev=260944&view=rev
> L
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D18286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
pxli168 added a comment.
LGTM!
Thanks!
http://reviews.llvm.org/D17412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 147 of 147 matches
Mail list logo
