echristo added a comment.

That's fascinating and terrifying all at once.

Can you rename the test to avx-v-modifier-inline-asm.c please?

One inline comment as well.

Thanks!

-eric


================
Comment at: lib/AST/Stmt.cpp:639
@@ +638,3 @@
+      // into "pcmpestri" otherwise.
+      if (C.getTargetInfo().hasFeature("avx"))
+        CurStringPiece = "v" + CurStringPiece;
----------------
This should probably check the feature set based on the function rather than 
the feature set of the base compile yes? What does gcc do if you put it in an 
__attribute__((target("..."))) function?


http://reviews.llvm.org/D18700



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to