r264366 - Debug Info: Add a testcase for the bug introduced by r259975.

2016-03-24 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Thu Mar 24 19:20:35 2016 New Revision: 264366 URL: http://llvm.org/viewvc/llvm-project?rev=264366&view=rev Log: Debug Info: Add a testcase for the bug introduced by r259975. In r259975 we rauw'ed the scope of enum declarations without taking into account that DIBuilder strips

Re: r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

2016-03-24 Thread Adrian Prantl via cfe-commits
I added a testcase that demonstrates the problem with this commit in r264366. -- adrian > On Feb 23, 2016, at 11:07 AM, Eric Christopher wrote: > > Thanks Adrian! > > On Tue, Feb 23, 2016 at 9:19 AM Adrian Prantl wrote: > --> r261657. > > Author: adrian > Date: Tue Feb 23 17:13:47 2016 +00

[clang-tools-extra] r264367 - 3rd attempt of fixup with -std=c++11

2016-03-24 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Thu Mar 24 19:24:35 2016 New Revision: 264367 URL: http://llvm.org/viewvc/llvm-project?rev=264367&view=rev Log: 3rd attempt of fixup with -std=c++11 Modified: clang-tools-extra/trunk/test/clang-tidy/readability-redundant-string-cstr.cpp Modified: clang-tools-extra/tru

Re: r259975 - Fix a crash when emitting dbeug info for forward-declared scoped enums.

2016-03-24 Thread Eric Christopher via cfe-commits
Great, thanks! On Thu, Mar 24, 2016, 5:26 PM Adrian Prantl wrote: > I added a testcase that demonstrates the problem with this commit in > r264366. > > -- adrian > > On Feb 23, 2016, at 11:07 AM, Eric Christopher > wrote: > > > > Thanks Adrian! > > > > On Tue, Feb 23, 2016 at 9:19 AM Adrian Pra

Re: [PATCH] D18458: [CUDA] Mangle __host__ __device__ functions differently than __host__ or __device__ functions.

2016-03-24 Thread Richard Smith via cfe-commits
rsmith added a comment. This makes the "`constexpr` implies `__host__` `__device__`" patch look slightly questionable: two translation units defining the same `constexpr` function will mangle that function differently depending on whether the translation unit is built with CUDA support enabled.

r264372 - CGLoopInfo: Use the MD_loop metadata kind from r264371, NFC

2016-03-24 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Thu Mar 24 19:38:14 2016 New Revision: 264372 URL: http://llvm.org/viewvc/llvm-project?rev=264372&view=rev Log: CGLoopInfo: Use the MD_loop metadata kind from r264371, NFC Besides a small compile-time speedup, there should be no real functionality change here. Modified:

Re: [PATCH] D18458: [CUDA] Mangle __host__ __device__ functions differently than __host__ or __device__ functions.

2016-03-24 Thread Justin Lebar via cfe-commits
jlebar added a comment. In http://reviews.llvm.org/D18458#383266, @rsmith wrote: > This makes the "`constexpr` implies `__host__` `__device__`" patch look > slightly questionable: two translation units defining the same `constexpr` > function will mangle that function differently depending on w

r264377 - [modules] Store a local offset to DeclContext lexical and visible contents. Saves a few bytes for each primary DeclContext.

2016-03-24 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Mar 24 20:17:43 2016 New Revision: 264377 URL: http://llvm.org/viewvc/llvm-project?rev=264377&view=rev Log: [modules] Store a local offset to DeclContext lexical and visible contents. Saves a few bytes for each primary DeclContext. Modified: cfe/trunk/lib/Serializati

Re: [PATCH] D14905: [constexpr-lambda] Support parsing of constexpr specifier (and its inference) on lambda expressions

2016-03-24 Thread Faisal Vali via cfe-commits
faisalv marked 8 inline comments as done. faisalv added a comment. Thanks for the review - will submit a updated patch with recommended changes, shortly. http://reviews.llvm.org/D14905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: [PATCH] D14905: [constexpr-lambda] Support parsing of constexpr specifier (and its inference) on lambda expressions

2016-03-24 Thread Faisal Vali via cfe-commits
faisalv updated this revision to Diff 51627. faisalv added a comment. An updated patch that incorporates Richard's feedback. Thanks! http://reviews.llvm.org/D14905 Files: include/clang/Basic/DiagnosticASTKinds.td include/clang/Basic/DiagnosticParseKinds.td include/clang/Sema/Sema.h lib/

Re: [PATCH] D17955: [OpenCL] Fix pipe builtin bugs

2016-03-24 Thread Xiuli PAN via cfe-commits
pxli168 updated this revision to Diff 51629. pxli168 added a comment. Add test for correct case. http://reviews.llvm.org/D17955 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl Index: test/SemaOpenCL/invalid-pipe-bu

<    1   2