Re: [PATCH] D17552: Pass -backend-option to LLVM when there is no target machine

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D17552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D18210: [analyzer] Fix an assertion fail in hash generation.

xazax.hun created this revision. xazax.hun added reviewers: dcoughlin, zaks.anna. xazax.hun added subscribers: cfe-commits, dkrupp. In case the (uniqueing) location of the diagnostic is in a line that only contains whitespaces there was an assertion fail during issue hash generation. This error

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

On Wed, Mar 16, 2016 at 10:52 AM, don hinton wrote: > -Werror clean is great. > > If you could add -Wdeprecated, then we wouldn't need to delete them -- the > warning is only issued with -Wdeprecated is passed. > Right, that's what I'm saying - add a fixme so that once we turn on the deprecated

Re: [PATCH] D18196: [CodeGen] Emit lifetime.end intrinsic after destructor call in landing pad

rnk added a comment. In http://reviews.llvm.org/D18196#375997, @rjmccall wrote: > You should talk to Reid or someone else involved in MSVC-style EH support to > ensure that they generate a reasonable code pattern for this. I patched this in and verified it works. Clang makes a separate funclet

Re: r263687 - Add an optional named argument (replacement = "xxx") to AvailabilityAttr.

This change is causing ubsan bot to complain . Please fix or revert. Most likely the guilty part is this: +*getReplacementSlot() = replacementExpr; /mnt/b/sanitizer-buildbot3/san

Re: [PATCH] D18199: CodeGen: Implement IR generation for the relative vtable ABI (PR26723).

rsmith added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1153 @@ -1152,3 +1152,3 @@ unsigned Virtuality = 0; - unsigned VIndex = 0; + unsigned VIndex = -1u; Is this what debug info consumers expect for the non-virtual case? http://reviews.llv

r263686 - Reapply [2]: [VFS] Add support for handling path traversals

Author: bruno Date: Wed Mar 16 21:20:43 2016 New Revision: 263686 URL: http://llvm.org/viewvc/llvm-project?rev=263686&view=rev Log: Reapply [2]: [VFS] Add support for handling path traversals This was applied twice r261551 and 263617 and later reverted because: (1) Windows bot failing on unittes

Re: [PATCH] D18238: [clang-tidy] Fix clang-tidy crashes when using -fdelayed-template-parsing.

aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! http://reviews.llvm.org/D18238 ___ cfe-commits mailing list cfe-com

Re: [PATCH] D18203: [OPENMP] Implementation of codegen for firstprivate clause of target directive

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM http://reviews.llvm.org/D18203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [PATCH] D13704: [Fix] Allow implicit conversions of the address of overloadable functions in C + docs update

rsmith added inline comments. Comment at: lib/Sema/SemaOverload.cpp:10419 @@ -10418,3 +10429,1 @@ - ResultTy) || - (!S.getLangOpts().CPlusPlus && TargetType->isVoidPointerType())) { Matches.push_back(std::make_pair( ---

[PATCH] D18262: [clang-tidy] Skip reporting of not applicable fixes.

etienneb created this revision. etienneb added reviewers: rnk, emso, alexfh, bkramer. etienneb added a subscriber: cfe-commits. Invalid source location are causing clang-tidy to crash when manipulating an invalid file. Macro definitions on the command line have locations in a virtual buffer and

[PATCH] D18265: [clang-tidy] New: checker misc-assign-operator-return

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: alexfh, hokein. baloghadamsoftware added subscribers: cfe-commits, xazax.hun. Finds return statements in assign operator bodies where the return value is different from '*this'. Only assignment operators with correct re

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r263709 - clang-format: Slightly weaken AlignAfterOpenBracket=AlwaysBreak.

Author: djasper Date: Thu Mar 17 07:00:22 2016 New Revision: 263709 URL: http://llvm.org/viewvc/llvm-project?rev=263709&view=rev Log: clang-format: Slightly weaken AlignAfterOpenBracket=AlwaysBreak. If a call takes a single argument, using AlwaysBreak can lead to lots of wasted lines and addition

Re: [PATCH] D17840: [OPENMP] Private, firstprivate, and lastprivate clauses for distribute, host code generation

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM http://reviews.llvm.org/D17840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: r263732 - Remove defaulted move ops, the type is zero-cost copyable anyway, so there's no need for specific move ops

btw, in each case, the derived class's move ctor was called. On Thu, Mar 17, 2016 at 5:36 PM, don hinton wrote: > I just did some tests, and when a derived class is explicitly moved, e.g., > with std::move(), the current behavior is (clang++/g++/vc++): > > 1) if base has implicit move, it gets c

Re: [PATCH] D17451: PR26448: [Sema] Fix determined type of ternary operator acting on two xvalue class types

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lib/Sema/SemaExprCXX.cpp:4698 @@ +4697,3 @@ + // constraint that in the conversion the reference must bind directly to + // E1. + // -

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

steven_wu added a comment. Hi Richard Thanks for looking at the patch! Replies are inlined with the feedback. Steven Comment at: include/clang/Frontend/CodeGenOptions.def:57 @@ -56,1 +56,3 @@ +CODEGENOPT(EmbedBitcode , 1, 0) ///< Embed LLVM IR bitcode as data. +CODEGENOPT

Re: [PATCH] D18238: [clang-tidy] Fix clang-tidy crashes when using -fdelayed-template-parsing.

LegalizeAdulthood added a subscriber: LegalizeAdulthood. LegalizeAdulthood added a comment. LGTM http://reviews.llvm.org/D18238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18262: [clang-tidy] Skip reporting of not applicable fixes.

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a comment. Thank you for working on this! A question below, but also, the patch is missing test cases for the change. Comment at: ClangTidy.cpp:144 @@ -138,1 +143,3 @@ + +Diag << FixItHint::Crea

Re: [PATCH] D18238: [clang-tidy] Fix clang-tidy crashes when using -fdelayed-template-parsing.

rnk accepted this revision. rnk added a comment. lgtm, thanks! http://reviews.llvm.org/D18238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18025: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

This revision was automatically updated to reflect the committed changes. Closed by commit rL263647: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the… (authored by swiftix). Changed prior to commit: http://reviews.llvm.org/D18025?vs=50508&id=50838#toc Repository:

Re: [PATCH] D18139: [Cxx1z] Implement Lambda Capture of *this by Value as [=, *this] (P0018R3)

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: include/clang/AST/LambdaCapture.h:48 @@ +47,3 @@ + // by value or reference. + // - or, points to the VLASentinel if this represents a by VLA cap

Re: [PATCH] D17746: Fix PR26741 -- __builtin_object_size is not consistently conservative with C++ inheritance

george.burgess.iv abandoned this revision. george.burgess.iv added a comment. I don't feel strongly about how we should handle this, to be honest. Feeding your example into GCC 4.8 like so: #include struct Foo { char k[1]; }; struct Bar : Foo {}; int __attribute__((noinline)) b

Re: [PATCH] D18231: [Clang-tools-extra] Fix Clang-tidy modernize-deprecated-headers warnings; other minor fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL263726: Fix Clang-tidy modernize-deprecated-headers warnings; other minor fixes. (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D18231?vs=50881&id=50951#toc Repository:

Re: [PATCH] D17951: Implement is_always_lock_free

jfb updated this revision to Diff 51049. jfb added a comment. - Use __atomic_always_lock_free instead http://reviews.llvm.org/D17951 Files: include/atomic test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp Index: test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp

r263634 - [modules] Fix adding a templated friend functions to a namespace from another module.

Author: vvassilev Date: Wed Mar 16 06:17:04 2016 New Revision: 263634 URL: http://llvm.org/viewvc/llvm-project?rev=263634&view=rev Log: [modules] Fix adding a templated friend functions to a namespace from another module. When clang adds argument dependent lookup candidates, it can perform templ

Re: [PATCH] D17986: [ASTMatchers] New matcher hasReturnValue added

baloghadamsoftware retitled this revision from "[ASTMatchers] Existing matcher hasAnyArgument fixed and new matcher hasReturnValue added" to "[ASTMatchers] New matcher hasReturnValue added". baloghadamsoftware updated the summary for this revision. baloghadamsoftware updated this revision to Diff

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8380 @@ +8379,3 @@ +def warn_unused_abi_stability_attr : Warning< + "unused C++ ABI stability attribute on non-dynamic class">, + InGroup>; How valuable is it to warn on this? I

r263694 - Minor code cleanups. NFC.

Author: flyingforyou Date: Thu Mar 17 01:41:27 2016 New Revision: 263694 URL: http://llvm.org/viewvc/llvm-project?rev=263694&view=rev Log: Minor code cleanups. NFC. Modified: cfe/trunk/include/clang/Driver/Options.td cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/include/clang/Driver

Re: [PATCH] D17950: Implement is_always_lock_free

jfb added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:305 @@ +304,3 @@ +if (TypeWidth == TypeAlign && (TypeWidth & (TypeWidth - 1)) == 0 && +TypeWidth <= InlineWidth) + return Always; bcraig wrote: > jyknight wrote: > > jfb wrot

Re: [PATCH] D18205: [libcxxabi] Disable cxa_thread_atexit_test if unavailable

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after the inline question is addressed. Comment at: test/libcxxabi/test/config.py:38 @@ +37,3 @@ +super(Configuration, self).configure_features() +if self

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

No, that case worked already. The case you fixed is the one where Base is 'foo' and Property is 'prop'…and actually, thinking more about it, this should not be considered "exact". *sigh* The point of "exact" is "if you see this Base and Property again, are you sure it's really the same Base?". I

Re: [PATCH] D18199: CodeGen: Implement IR generation for the relative vtable ABI (PR26723).

pcc updated this revision to Diff 50998. pcc added a comment. - Update test to match committed debug info change http://reviews.llvm.org/D18199 Files: docs/UsersManual.rst lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGVTables.cpp lib/CodeGen/CGVTables.h lib/CodeGen/CodeGenFunction.h lib

r263687 - Add an optional named argument (replacement = "xxx") to AvailabilityAttr.

Author: mren Date: Wed Mar 16 22:09:55 2016 New Revision: 263687 URL: http://llvm.org/viewvc/llvm-project?rev=263687&view=rev Log: Add an optional named argument (replacement = "xxx") to AvailabilityAttr. This commit adds a named argument to AvailabilityAttr, while r263652 adds an optional string

r263752 - Revert r263687 for ubsan bot failure.

Author: mren Date: Thu Mar 17 17:13:50 2016 New Revision: 263752 URL: http://llvm.org/viewvc/llvm-project?rev=263752&view=rev Log: Revert r263687 for ubsan bot failure. Modified: cfe/trunk/include/clang/Basic/Attr.td cfe/trunk/include/clang/Basic/AttrDocs.td cfe/trunk/include/clang/Pa

Re: [PATCH] D18280: [tsan] Allow -fsanitize=thread for iOS-style simulator targets

dcoughlin updated this revision to Diff 51076. dcoughlin added a comment. Added tests for iOS and iOS simulators. http://reviews.llvm.org/D18280 Files: lib/Driver/ToolChains.cpp test/Driver/fsanitize.c Index: test/Driver/fsanitize.c =

[PATCH] D18240: Asm preprocessor fix for unknown hash-lines

andrew.zhogin created this revision. andrew.zhogin added reviewers: jordan_rose, bkramer. andrew.zhogin added a subscriber: cfe-commits. When preprocessing assembly file (with "clang -cc1 -E -x assembler-with-cpp") after every unknown-pragma line, additional empty line is added. # some comment 1

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

dexonsmith updated this revision to Diff 50869. dexonsmith added a comment. Eric and I had a quick chat on IRC. - The asymmetric usage of __extract_key and __can_extract_key was awkward, as Eric pointed out already. - However, a symmetric __extract_key would have caused Clang (and other compile

Re: r263785 - Make LookupResult movable again.

Also might be marginally tidier if Paths was a unique_ptr, then you wouldn't have to explicitly null it out. I think this is still a pretty subtle thing to allow move or copy support for & perhaps best avoided, or split into the query parameters and the result if we're going to support it. For ex

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

On Wed, Mar 16, 2016 at 10:19 AM, don hinton wrote: > The current behavior, albeit deprecated, is to implicitly define these. > Therefore, it would be incorrect not to delete them if the implicit > versions don't do the right thing. > > I'd be happy to add a FIXME, but I doubt they will ever be r

Re: [PATCH] D18191: [clang-tidy] Add check for function parameters that are const& to builtin types

LegalizeAdulthood added inline comments. Comment at: test/clang-tidy/misc-const-ref-builtin.cpp:32-34 @@ +31,4 @@ + +void f(const int& i, const int& j); +// CHECK-MESSAGES: :[[@LINE-1]]:19: warning: const reference to 'int' at parameter 'i' in function 'f' [misc-const-ref-builtin

r263652 - Add an optional string argument to DeprecatedAttr for Fix-It.

Author: mren Date: Wed Mar 16 13:50:49 2016 New Revision: 263652 URL: http://llvm.org/viewvc/llvm-project?rev=263652&view=rev Log: Add an optional string argument to DeprecatedAttr for Fix-It. We only add this to __attribute__((deprecated)). Differential Revision: http://reviews.llvm.org/D17865

Re: [PATCH] D18196: [CodeGen] Emit lifetime.end intrinsic after destructor call in landing pad

rnk added a comment. In http://reviews.llvm.org/D18196#376837, @ahatanak wrote: > I can add another RUN line to test/CodeGenCXX/microsoft-abi-eh-cleanups.cpp > that is identical to the existing RUN line except that it has "-O3 > -disable-llvm-optzns". I confirmed that the test still passes with

Re: [PATCH] D17950: Implement is_always_lock_free

jfb updated this revision to Diff 51048. jfb added a comment. - Use __atomic_always_lock_free instead http://reviews.llvm.org/D17950 Files: lib/Frontend/InitPreprocessor.cpp test/Lexer/cxx-features.cpp Index: test/Lexer/cxx-features.cpp =

Re: [PATCH] D17951: Implement is_always_lock_free

jfb added inline comments. Comment at: include/atomic:859 @@ +858,3 @@ +template <> _LIBCPP_CONSTEXPR bool __libcpp_always_lock_free = 2 == ATOMIC_CHAR32_T_LOCK_FREE; +template <> _LIBCPP_CONSTEXPR bool __libcpp_always_lock_free = 2 == ATOMIC_WCHAR_T_LOCK_FREE; +template <> _LIB

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

chapuni added a subscriber: chapuni. chapuni added a comment. Excuse me, I have reverted it in r263636. Comment at: lib/Frontend/ModuleDependencyCollector.cpp:65 @@ +64,3 @@ +static bool real_path(StringRef SrcPath, SmallVectorImpl &RealPath) { +#ifdef HAVE_REALPATH + char Cano

Re: [PATCH] D18163: Add visualizers for more clang types. Create more C++-like visualizations for existing Clang types

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D18163#376358, @mspertus wrote: > Added reference types and a more accurate AttributedType enum. I am working > on additional items for the future (cla

Re: [PATCH] D18238: [clang-tidy] Fix clang-tidy crashes when using -fdelayed-template-parsing.

etienneb updated this revision to Diff 50971. etienneb added a comment. tests added. http://reviews.llvm.org/D18238 Files: cppcoreguidelines-pro-type-member-init-delayed.cpp cppcoreguidelines/ProTypeMemberInitCheck.cpp modernize-redundant-void-arg-delayed.cpp modernize/RedundantVoidArgC

[PATCH] D18283: clang-format: [JS] do not break location pragma comments.

mprobst created this revision. mprobst added reviewers: djasper, klimek, cfe-commits. Herald added a subscriber: klimek. `import ... from ...; // from //foo:bar` serves as the equivalent if an IWYU pragma. This change matches `// from //.*` style comments and never allows them to wrap, just like

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

On Wed, Mar 16, 2016 at 7:54 AM, don hinton via cfe-commits < cfe-commits@lists.llvm.org> wrote: > hintonda updated this revision to Diff 50823. > hintonda added a comment. > > Address FIXME now that Sema::LookupInlineAsmField() has been fixed. > > > http://reviews.llvm.org/D18123 > > Files: > i

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

> On 2016-Mar-16, at 12:20, Eric Fiselier wrote: > > EricWF added a comment. > > Adding inline comments for the implementation. Comments on the tests to > follow shortly. > > > > Comment at: include/__hash_table:103 > @@ -102,1 +102,3 @@ > > +template > +struct __extract_k

Re: [PATCH] D18274: [clang-tidy] Add boost module

Prazek updated this revision to Diff 51086. http://reviews.llvm.org/D18274 Files: clang-tidy/CMakeLists.txt clang-tidy/boost/BoostTidyModule.cpp clang-tidy/boost/CMakeLists.txt clang-tidy/plugin/CMakeLists.txt clang-tidy/tool/CMakeLists.txt clang-tidy/tool/ClangTidyMain.cpp docs/cla

[PATCH] D18238: [clang-tidy] Fix clang-tidy crashes when using -fdelayed-template-parsing.

etienneb created this revision. etienneb added reviewers: rnk, alexfh, emso, bkramer. etienneb added a subscriber: cfe-commits. Herald added a subscriber: aemerson. Fix crashes caused by deferencing null pointer when declarations parsing may be delayed. The body of the declarations may be null.

Re: [PATCH] D17950: Implement is_always_lock_free

jyknight added a subscriber: jyknight. jyknight added a comment. This conflicts with http://reviews.llvm.org/D17933. Most of this change also seems unnecessary. - I think the `is_always_lock_free` function should be defined based on the existing `__atomic_always_lock_free` builtin, not on defin

Re: r263785 - Make LookupResult movable again.

On Fri, Mar 18, 2016 at 5:10 PM, David Blaikie wrote: > > > On Fri, Mar 18, 2016 at 6:31 AM, Benjamin Kramer via cfe-commits > wrote: >> >> Author: d0k >> Date: Fri Mar 18 08:31:00 2016 >> New Revision: 263785 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=263785&view=rev >> Log: >> Make Look

RE: r259776 - [OPENMP 4.0] Fixed support of array sections/array subscripts.

Hi Alexey, I think this now also affects the released version of Clang 3.8.0. Can this be merged for 3.8.1 if such a version will exist somewhen? Thanks, Jonas > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of Alexey Bataev via cfe-commit

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

rsmith added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:272-299 @@ -265,1 +271,30 @@ + // abi_tag is a gcc attribute, taking one or more strings called "tags". + // + // The goal is to annotate against which version of a library an object was + // build and to be

Re: [PATCH] D17950: Implement is_always_lock_free

I know that MIPS does that, and an out-of-tree implementation of hexagon implements 1-byte cmpxchg in terms of the 4-byte version. The emulation code isn't particularly small, and it seems reasonable to make it a libcall. The emulation code seems sketchy from a correctness perspective, as you

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rL263818: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo. (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D18268?vs=51025&id=51056#toc Repository: rL LLVM http:

Re: [PATCH] D16579: Warn if friend function depends on template parameters.

I'm not qualified to comment on the implementation, but I'm a bit skeptical that this warning is appropriate in the first place. I've often declared friend non-template functions, e.g. swap(). I've never intended to declare a friend *template specialization*. Is declaring friend template specializa

Re: [PATCH] D18149: Add check for unneeded copies of locals

fowles updated this revision to Diff 50927. http://reviews.llvm.org/D18149 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tidy/performance/UnnecessaryCopyInitialization.h docs/clang-tidy/checks/performance-unnecessary-copy-initialization.rst test/clang-tidy/performa

Re: [PATCH] D16965: Fix for Bug 14644 - clang confuses scope operator for global namespace giving extra qualification on member

dblaikie added a comment. Not sure I fully understand the issue with the existing diagnostic/change in wording. '::' is a nested name specifier, even if it's a degenerate case, I think - so the old wording doesn't seem wrong, as such (& the new text seems correct in the other cases too - shoul

Re: [PATCH] D17951: Implement is_always_lock_free

jfb added inline comments. Comment at: include/atomic:859 @@ +858,3 @@ +template <> _LIBCPP_CONSTEXPR bool __libcpp_always_lock_free = 2 == ATOMIC_CHAR32_T_LOCK_FREE; +template <> _LIBCPP_CONSTEXPR bool __libcpp_always_lock_free = 2 == ATOMIC_WCHAR_T_LOCK_FREE; +template <> _LIB

Re: [PATCH] D18136: boost-use-to-string check

LegalizeAdulthood added inline comments. Comment at: clang-tidy/boost/UseToStringCheck.cpp:56 @@ +55,3 @@ + const auto *MatchedToString = Result.Nodes.getNodeAs("to_string"); + auto Q = Result.Nodes.getNodeAs("char_type")->getAsType(); + Q seems pretty obtuse to

Re: [PATCH] D11797: [LIbClang] Report the named type for ElaboratedType

skalinichev updated this revision to Diff 51109. skalinichev added a comment. Looking a bit more at the recent commits in libclang, it seems like all recently added functions follow this naming convention: clang_Cursor_* clang_Type_* e.t.c. So I'm renaming the function to follow that style too.

r263647 - Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end

Author: swiftix Date: Wed Mar 16 13:00:46 2016 New Revision: 263647 URL: http://llvm.org/viewvc/llvm-project?rev=263647&view=rev Log: Add attributes for preserve_mostcc/preserve_allcc calling conventions to the C/C++ front-end Till now, preserve_mostcc/preserve_allcc calling convention attribute

Re: [PATCH] D13704: [Fix] Allow implicit conversions of the address of overloadable functions in C + docs update

george.burgess.iv added inline comments. Comment at: lib/Sema/SemaOverload.cpp:10419 @@ -10418,3 +10429,1 @@ - ResultTy) || - (!S.getLangOpts().CPlusPlus && TargetType->isVoidPointerType())) { Matches.push_back(std::make_pair(

Re: [PATCH] D14905: [constexpr-lambda] Support parsing of constexpr specifier (and its inference) on lambda expressions

rsmith added inline comments. Comment at: lib/AST/ExprConstant.cpp:2050 @@ +2049,3 @@ +if (!Result && isLambdaCallOperator(Frame->Callee) && +VD->getDeclContext() != Frame->Callee) { + // Assume variables referenced within a lambda's call operator that were --

Re: [PATCH] D18253: Switch AMDGPU Linker to amdphdrs + update test

tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D18253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

Re: [PATCH] D17407: [Sema] PR25755 Fix crash when initializing out-of-order struct references

rsmith added inline comments. Comment at: lib/Sema/SemaInit.cpp:1815-1816 @@ -1814,1 +1814,4 @@ // worthwhile to skip over the rest of the initializer, though. + unsigned FieldIdx = 0; + unsigned MaxFieldIdx = 0; + llvm::BitVector SeenFields; You don't need

Re: [PATCH] D17764: Add attributes for AMD GPU Tools

kzhuravl-AMD abandoned this revision. kzhuravl-AMD added a comment. After recent discussions we decided to use target specific options instead http://reviews.llvm.org/D17764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D17986: [ASTMatchers] New matcher hasReturnValue added

sbenza added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:4848 @@ +4847,3 @@ +/// \code +/// return a+b; +/// \endcode `a + b` (with spaces) A few in this comment, and one in the test. Comment at: include/clang/ASTMatche

Re: [PATCH] D17950: Implement is_always_lock_free

jfb added a comment. In http://reviews.llvm.org/D17950#377386, @cfe-commits wrote: > I know that MIPS does that, and an out-of-tree implementation of hexagon > implements 1-byte cmpxchg in terms of the 4-byte version. The emulation > code isn't particularly small, and it seems reasonable to m

Re: [PATCH] D17951: Implement is_always_lock_free

jfb added inline comments. Comment at: include/atomic:900 @@ +899,3 @@ +# if defined(_LIBCPP_LOCK_FREE_IS_SIZE_BASED) + static _LIBCPP_CONSTEXPR bool is_always_lock_free = __libcpp_always_lock_free; +# else Actually, this should be based on `sizeof(__a_)` and *n

[libcxx] r263688 - Make std::addressof constexpr in C++17 (Clang only).

Author: ericwf Date: Wed Mar 16 22:30:56 2016 New Revision: 263688 URL: http://llvm.org/viewvc/llvm-project?rev=263688&view=rev Log: Make std::addressof constexpr in C++17 (Clang only). Added: libcxx/trunk/test/std/utilities/memory/specialized.algorithms/specialized.addressof/constexpr_addre

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

Thanks Jordan. I’ve committed the patch in r263818. I didn’t understand your comment on WeakObjectProfileTy’s table (I’m assuming you are talking about the table in ScopeInfo.h:183). It looks like the entry MyClass.prop in the table already covers the case this patch fixed (in the test case I a

Re: [PATCH] D18136: boost-use-to-string check

Prazek marked 12 inline comments as done. Prazek added a comment. http://reviews.llvm.org/D18136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18205: [libcxxabi] Disable cxa_thread_atexit_test if unavailable

Hahnfeld added inline comments. Comment at: test/libcxxabi/test/config.py:38 @@ +37,3 @@ +super(Configuration, self).configure_features() +if self.get_lit_bool('thread_atexit', False): +self.config.available_features.add('thread_atexit') ---

Re: [PATCH] D18261: Show members of DeclContexts (i.e., class members) in Visual Studio native visualizers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang.natvis:77 @@ +76,3 @@ + + + mspertus wrote: > aaron.ballman wrote: > > The only hard-wiring I see uses 3 bits, so

Re: [PATCH] D18136: boost-use-to-string check

Prazek added inline comments. Comment at: test/clang-tidy/boost-use-to-string.cpp:5-11 @@ +4,9 @@ +namespace std { + +template class basic_string {}; + +using string = basic_string; +using wstring = basic_string; +} + +namespace boost { I don't see any test using

Re: [PATCH] D17865: Add an optional string argument to DeprecatedAttr for Fix-It.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. One small documentation nit, but I'm fine with you fixing it then committing (no need for another round of review). Thanks! Comment at: include/clang/Basic/Attr

r263691 - [VFS] Remove wrong header include

Author: bruno Date: Wed Mar 16 23:59:52 2016 New Revision: 263691 URL: http://llvm.org/viewvc/llvm-project?rev=263691&view=rev Log: [VFS] Remove wrong header include Follow up from r263686. Forgot to remove the wrong header file. Modified: cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp

Re: r259776 - [OPENMP 4.0] Fixed support of array sections/array subscripts.

Yes, of course Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 17.03.2016 14:18, Hahnfeld, Jonas пишет: > Hi Alexey, > > I think this now also affects the released version of Clang 3.8.0. > Can this be merged for 3.8.1 if such a version will exist somewhen? > > Tha

Re: [PATCH] D18243: [ASTMatchers] Existing matcher hasAnyArgument fixed

sbenza added a comment. Please add a test for this. http://reviews.llvm.org/D18243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17950: Implement is_always_lock_free

bcraig added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:305 @@ +304,3 @@ +if (TypeWidth == TypeAlign && (TypeWidth & (TypeWidth - 1)) == 0 && +TypeWidth <= InlineWidth) + return Always; jfb wrote: > bcraig wrote: > > jyknight w

Re: [PATCH] D18238: [clang-tidy] Fix clang-tidy crashes when using -fdelayed-template-parsing.

etienneb updated this revision to Diff 50940. etienneb marked 3 inline comments as done. etienneb added a comment. fixed. thanks. http://reviews.llvm.org/D18238 Files: cppcoreguidelines/ProTypeMemberInitCheck.cpp modernize/RedundantVoidArgCheck.cpp Index: cppcoreguidelines/ProTypeMemberIni

Re: [PATCH] D17709: [MSVC Compat] Support for '__unaligned' attribute in function declaration

aaron.ballman added a comment. In http://reviews.llvm.org/D17709#374561, @rnk wrote: > Unless there is a compelling example of Microsoft or a popular third-party > header relying on this behavior, I don't think we should implement it. Agreed. Comment at: lib/Parse/ParseDecl.

Re: [PATCH] D18163: Add visualizers for more clang types. Create more C++-like visualizations for existing Clang types

mspertus added inline comments. Comment at: clang.natvis:25 @@ +24,3 @@ +{*(clang::BuiltinType *)this} +{*(clang::PointerType *)this} +{*(clang::AttributedType *)this} aaron.ballman wrote: > If we're handling pointers, perhaps we should also do referen

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

This revision was automatically updated to reflect the committed changes. Closed by commit rL263730: Fix implicit copy ctor and copy assignment operator warnings when… (authored by dblaikie). Changed prior to commit: http://reviews.llvm.org/D18123?vs=50930&id=50961#toc Repository: rL LLVM h

r263740 - Revert "For MS ABI, emit dllexport friend functions defined inline in class"

Author: rnk Date: Thu Mar 17 15:06:58 2016 New Revision: 263740 URL: http://llvm.org/viewvc/llvm-project?rev=263740&view=rev Log: Revert "For MS ABI, emit dllexport friend functions defined inline in class" This reverts commit r263738. This appears to cause a failure in CXX/temp/temp.decls/temp.

Re: [PATCH] D16965: Fix for Bug 14644 - clang confuses scope operator for global namespace giving extra qualification on member

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: rsmith. Comment at: lib/Sema/SemaDecl.cpp:3803 @@ +3802,3 @@ + +// Per C++ standard [n3485] 3.4.4 Elaborated type specifiers, section 3: +// "Cannot introduce an qualified". --

Re: [PATCH] D17180: Fix failing python bindings test

skalinichev added a comment. It reminded me http://reviews.llvm.org/D17278 So it seems like it should be already fixed, no? Repository: rL LLVM http://reviews.llvm.org/D17180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

Re: [PATCH] D18149: Add check for unneeded copies of locals

fowles updated this revision to Diff 50878. http://reviews.llvm.org/D18149 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tidy/performance/UnnecessaryCopyInitialization.h docs/clang-tidy/checks/performance-unnecessary-copy-initialization.rst test/clang-tidy/performa

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

rjmccall added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:4935-4943 @@ +4934,11 @@ + + bool HasStableAttr = Record->hasAttr(); + bool HasUnstableAttr = Record->hasAttr(); + if (HasStableAttr && HasUnstableAttr) { +Diag(Record->getLocation(), diag::err_abi_mismatc

Re: [PATCH] D18199: CodeGen: Implement IR generation for the relative vtable ABI (PR26723).

rnk added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:1627 @@ +1626,3 @@ + +llvm::Value *CodeGenFunction::GetVirtualFunctionFromVTable(const CXXRecordDecl *RD, + llvm::Value *VTable, Maybe t

Re: [PATCH] D15591: [Bugfix] Make type deduction work more nicely with unaddressable functions

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D15591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

Great! I think we should proceed with your is_trivially_copyable idea and I'll see if I can come up with a pathological test case that breaks it. Hopefully we can find something that works. On Mar 17, 2016 2:54 PM, "Duncan P. N. Exon Smith via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > r

[libcxx] r263659 - Add __unconstref for future use

Author: ericwf Date: Wed Mar 16 15:32:07 2016 New Revision: 263659 URL: http://llvm.org/viewvc/llvm-project?rev=263659&view=rev Log: Add __unconstref for future use Modified: libcxx/trunk/include/type_traits Modified: libcxx/trunk/include/type_traits URL: http://llvm.org/viewvc/llvm-project

Re: [PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

skalinichev added a comment. I see. There were some changes recently in the indexing functionality. I'm not sure whether this change is intended or not, but since it's not your fault and we already have a lot of tests confirming that clang_CXXMethod_isDeleted is working as expected (e.g. c-inde

  1   2   3   >