LegalizeAdulthood added inline comments.
================
Comment at: clang-tidy/boost/UseToStringCheck.cpp:56
@@ +55,3 @@
+ const auto *MatchedToString = Result.Nodes.getNodeAs<CallExpr>("to_string");
+ auto Q = Result.Nodes.getNodeAs<TemplateArgument>("char_type")->getAsType();
+
----------------
Q seems pretty obtuse to me as an identifier. I normally think of template
arguments as `T`, if we are going to use a single letter. Otherwise an
intention revealing name would be better. Something like `argType` perhaps?
http://reviews.llvm.org/D18136
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
