On Mon, Feb 29, 2016 at 10:59 AM, Romanova, Katya
wrote:
> Hi Dmitri,
>
> Could you please let us know your opinion about C++ vs C-style doxygen
> comments. Read this thread for ‘pro’ and ‘con’ arguments about using C++
> headers. Will LLVM online documentation look proper if we decide to use
> C-
klimek added inline comments.
Comment at: include/clang/Format/Format.h:734-736
@@ -733,1 +733,5 @@
+/// \brief Return replacements that are merged from orginal replacements
+/// and the replacements for formatting the code after applying the orginal
+/// replacements.
+tooling:
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
Comment at: test/clang-tidy/modernize-pass-by-value-header.cpp:1
@@ +1,2 @@
+// RUN: cp %S/Inputs/modernize-pass-by-value/header.h %T/pass-by-value-header.h
+// RU
bsmith added a comment.
Ping. This change has been waiting for review for over a month now, it would be
great to get this committed. Thanks.
Repository:
rL LLVM
http://reviews.llvm.org/D15283
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
Author: klimek
Date: Tue Mar 1 04:56:19 2016
New Revision: 262318
URL: http://llvm.org/viewvc/llvm-project?rev=262318&view=rev
Log:
Optionally demote fatal errors to non-fatal errors.
This behavior is enabled when the new CXTranslationUnit_KeepGoing
option is passed to clang_parseTranslationUnit
ioeric updated this revision to Diff 49470.
ioeric marked 5 inline comments as done.
ioeric added a comment.
- Fixed commenting.
http://reviews.llvm.org/D17727
Files:
include/clang/Format/Format.h
include/clang/Tooling/Core/Replacement.h
lib/Format/Format.cpp
lib/Tooling/Core/Replacemen
Author: mzuckerm
Date: Tue Mar 1 05:38:16 2016
New Revision: 262321
URL: http://llvm.org/viewvc/llvm-project?rev=262321&view=rev
Log:
[CLANG] [AVX512] [BUILTIN] Adding PSRA{Q|D|QI|DI}{128|256|512} builtin
Differential Revision: http://reviews.llvm.org/D17693
Modified:
cfe/trunk/include/cla
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D17727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: klimek
Date: Tue Mar 1 06:37:30 2016
New Revision: 262323
URL: http://llvm.org/viewvc/llvm-project?rev=262323&view=rev
Log:
Add functions to apply replacements and reformat them.
This is a commonly useful feature to have, and we have implemented it
multiple times with different kinds of
Author: klimek
Date: Tue Mar 1 06:47:30 2016
New Revision: 262324
URL: http://llvm.org/viewvc/llvm-project?rev=262324&view=rev
Log:
Fix DLL build by adding required dependency.
Modified:
cfe/trunk/unittests/Format/CMakeLists.txt
Modified: cfe/trunk/unittests/Format/CMakeLists.txt
URL:
http
Author: mzuckerm
Date: Tue Mar 1 07:03:45 2016
New Revision: 262326
URL: http://llvm.org/viewvc/llvm-project?rev=262326&view=rev
Log:
[CLANG][AVX512][BUILTIN] Adding PSRLV builtin
Differential Revision: http://reviews.llvm.org/D17718
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
Author: klimek
Date: Tue Mar 1 06:53:18 2016
New Revision: 262325
URL: http://llvm.org/viewvc/llvm-project?rev=262325&view=rev
Log:
Fix test breakage on windows where the default std is c++11 by forcing c++03 in
the test.
Modified:
cfe/trunk/test/Index/keep-going.cpp
Modified: cfe/trunk/te
Author: chapuni
Date: Tue Mar 1 07:11:36 2016
New Revision: 262329
URL: http://llvm.org/viewvc/llvm-project?rev=262329&view=rev
Log:
FormatTests: Update libdeps corresponding to r262323.
Modified:
cfe/trunk/unittests/Format/CMakeLists.txt
Modified: cfe/trunk/unittests/Format/CMakeLists.txt
On Tue, Mar 1, 2016 at 2:16 AM, Alexander Riccio wrote:
> ariccio updated this revision to Diff 49456.
> ariccio added a comment.
>
> Nit addressed.
>
>
> http://reviews.llvm.org/D17688
>
> Files:
> llvm/tools/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
>
> Index: llvm/tools/clang/lib/St
ioeric created this revision.
ioeric added a reviewer: klimek.
ioeric added subscribers: klimek, cfe-commits.
Added applyAllReplacementsAndFormat that works for multiple files.
http://reviews.llvm.org/D17761
Files:
include/clang/Format/Format.h
include/clang/Tooling/Core/Replacement.h
lib/
Thanks for the fix! When did it start failing? The last change in this file
was quite a while ago. Did it start breaking because of a change in a
header?
On Mon, Feb 29, 2016 at 10:17 PM, Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: hans
> Date: Mon Feb 29 15:17:39
ioeric updated this revision to Diff 49487.
ioeric added a comment.
- Fixed commenting issue due to merge.
http://reviews.llvm.org/D17761
Files:
include/clang/Format/Format.h
include/clang/Tooling/Core/Replacement.h
lib/Format/CMakeLists.txt
lib/Format/Format.cpp
lib/Tooling/Core/Repl
+cfe-commits for wider audience.
Hi Piotr,
On Tue, Mar 1, 2016 at 2:36 PM, Piotr Padlewski
wrote:
> Hi Alexey,
>
I am currently writing new check
> https://llvm.org/bugs/show_bug.cgi?id=26763
>
Awesome! Sorry I didn't have time yet to comment on the issues you filed,
though I have a couple of
Author: filcab
Date: Tue Mar 1 08:08:13 2016
New Revision: 262334
URL: http://llvm.org/viewvc/llvm-project?rev=262334&view=rev
Log:
[cmake] Fallback to LLVM_EXTERNAL_COMPILER_RT_SOURCE_DIR if
COMPILER_RT_SRC_ROOT doesn't exist.
Modified:
cfe/trunk/runtime/CMakeLists.txt
Modified: cfe/trunk
Author: filcab
Date: Tue Mar 1 08:08:18 2016
New Revision: 262335
URL: http://llvm.org/viewvc/llvm-project?rev=262335&view=rev
Log:
[cmake] Use CMake's USES_TERMINAL for the test targets.
Modified:
cfe/trunk/runtime/CMakeLists.txt
Modified: cfe/trunk/runtime/CMakeLists.txt
URL:
http://llvm
Author: filcab
Date: Tue Mar 1 08:10:38 2016
New Revision: 262336
URL: http://llvm.org/viewvc/llvm-project?rev=262336&view=rev
Log:
[cmake] Pass through the cmake_3_2_USES_TERMINAL variable so we get progress
bars on an external compiler-rt build
Modified:
cfe/trunk/runtime/CMakeLists.txt
review:
http://reviews.llvm.org/D17765
2016-03-01 15:12 GMT+01:00 Piotr Padlewski :
> my pass works for things like
> (note that for test purposes I use lexical_cast that doesn't do anything,
> so the second one compiles)
>
> int a = boost::lexical_cast("42");
> long long* b = boost::lexical_cast
kzhuravl-AMD created this revision.
kzhuravl-AMD added reviewers: arsenm, tstellarAMD.
kzhuravl-AMD added a subscriber: cfe-commits.
Add following kernel function attributes for AMD GPU Tools (debugger, profiler):
- amdgpu_tools_insert_nops - insert two nop instructions for each high level
sour
my pass works for things like
(note that for test purposes I use lexical_cast that doesn't do anything,
so the second one compiles)
int a = boost::lexical_cast("42");
long long* b = boost::lexical_cast("42");
=>
auto a = boost::lexical_cast("42");
auto b = boost::lexical_cast("42");
but it doesn
Answered on the review thread. The problem is with BuiltinTypeLoc not
storing the location for the end token of builtin type names consisting of
multiple tokens. This can be worked around by re-lexing a fragment of the
code for now.
Richard, does it make sense to store the end location in BuiltinT
bkramer added a comment.
This doesn't have a test case. Also I don't understand why this is the correct
fix. If someone is calling one of those method with a file SourceLocation (as
opposed to a macro SourceLocation) they should stop doing that.
Repository:
rL LLVM
http://reviews.llvm.org/D
Author: filcab
Date: Tue Mar 1 09:07:19 2016
New Revision: 262340
URL: http://llvm.org/viewvc/llvm-project?rev=262340&view=rev
Log:
[cmake] Try to appease the buildbots.
Modified:
cfe/trunk/runtime/CMakeLists.txt
Modified: cfe/trunk/runtime/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-p
ioeric updated this revision to Diff 49493.
ioeric added a comment.
- Added getOrCreateFileID interface in SourceManager.
http://reviews.llvm.org/D17761
Files:
include/clang/Basic/SourceManager.h
include/clang/Format/Format.h
include/clang/Tooling/Core/Replacement.h
lib/Format/CMakeList
Author: filcab
Date: Tue Mar 1 09:33:52 2016
New Revision: 262341
URL: http://llvm.org/viewvc/llvm-project?rev=262341&view=rev
Log:
[cmake] Add a few more compiler-rt check-* targets for EXTERNAL_COMPILER_RT
Modified:
cfe/trunk/runtime/CMakeLists.txt
Modified: cfe/trunk/runtime/CMakeLists.t
alexfh added inline comments.
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:25-32
@@ +24,10 @@
+std::string paramNameOrIndex(StringRef Name, size_t Index) {
+ std::string Output;
+ llvm::raw_string_ostream Stream(Output);
+ if (!Name.empty()) {
+Stream <
I only noticed this when I tried to build the weekly Windows snapshot,
and I didn't build one last week, so I don't know exactly when it
started failing. As you said, it might be due to a header change
somewhere. Since this was inside a DEBUG(), I suppose it would only
show in builds with asserts e
Hi,
On Mon, 29 Feb 2016, Jason Merrill wrote:
> > Also this insistence that all of "trivially copyable" is already quite
> > nicely specified in the C++ ABI is still not really relevant because
> > C++ _is not the only language out there_. I'm not sure how often I
> > have to repeat this unti
jbcoe created this revision.
jbcoe added reviewers: aaron.ballman, alexfh.
jbcoe added a subscriber: cfe-commits.
jbcoe set the repository for this revision to rL LLVM.
Find instances where a string_view is constructed from a temporary string and
replace the string_view with a string.
Repository
Author: dsanders
Date: Tue Mar 1 11:15:11 2016
New Revision: 262350
URL: http://llvm.org/viewvc/llvm-project?rev=262350&view=rev
Log:
Explicitly select IAS in new embed-bitcode.c test.
This should fix clang-cmake-mips builder since MIPS does not have IAS enabled
by default (yet).
Modified:
Hi,
I've made a small change to the test case in r262350 to fix the
clang-cmake-mips builder. MIPS doesn't
enable the integrated assembler by default yet so it was failing to find the
-emit-obj option. I've fixed this by adding -fintegrated-as.
From: cfe
Great. Thanks for the fix.
Steven
> On Mar 1, 2016, at 9:24 AM, Daniel Sanders wrote:
>
> Hi,
>
> I've made a small change to the test case in r262350 to fix the
> clang-cmake-mips builder. MIPS doesn't
> enable the integrated assembler by default yet so it was failing to find the
> -emit-ob
dblaikie added a subscriber: dblaikie.
dblaikie added a comment.
Any way to/would it be worth broadening this with an annotation or some
such (or just a lost for now) of types that maintain references to their
ctor params? (Eg: llvm arrayref, etc)
Repository:
rL LLVM
http://reviews.llvm.org/D
Any way to/would it be worth broadening this with an annotation or some
such (or just a lost for now) of types that maintain references to their
ctor params? (Eg: llvm arrayref, etc)
On Mar 1, 2016 9:19 AM, "Jonathan B Coe via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> jbcoe created this
rnk added inline comments.
Comment at: lib/CodeGen/CGException.cpp:1680-1682
@@ -1679,4 +1679,5 @@
StartFunction(GlobalDecl(), RetTy, Fn, FnInfo, Args,
OutlinedStmt->getLocStart(), OutlinedStmt->getLocStart());
+ CurCodeDecl = ParentCGF.CurCodeDecl;
--
arsenm added inline comments.
Comment at: include/clang/Basic/Attr.td:993-998
@@ +992,8 @@
+
+def AMDGPUToolsInsertNops : InheritableAttr {
+ let Spellings = [GNU<"amdgpu_tools_insert_nops">];
+ let Documentation = [AMDGPUToolsInsertNopsDocs];
+ let Subjects = SubjectList<[Func
Author: mzuckerm
Date: Tue Mar 1 11:49:03 2016
New Revision: 262355
URL: http://llvm.org/viewvc/llvm-project?rev=262355&view=rev
Log:
[CLANG][AVX512][BUILTIN] Adding PSRL{DI|QI}{128|256|512} builtin
Differential Revision: http://reviews.llvm.org/D17714
Modified:
cfe/trunk/include/clang/Basi
alexfh added a comment.
As David noted, there are other similar classes like `llvm::StringRef`,
`llvm::ArraryRef`, `gsl::span`, `StringPiece` (in various Google projects, e.g.
https://github.com/google/re2/blob/master/re2/stringpiece.h) and numerous other
in different code bases. I think, we sh
Author: kbarton
Date: Tue Mar 1 12:11:28 2016
New Revision: 262359
URL: http://llvm.org/viewvc/llvm-project?rev=262359&view=rev
Log:
[PPC64][VSX] Add short, char, and bool data type for vec_vsx_ld and vec_vsx_st
intrinsics
Issue: https://llvm.org/bugs/show_bug.cgi?id=26720
Fix compile error wh
weimingz added a comment.
In http://reviews.llvm.org/D17741#364954, @thakis wrote:
> In http://reviews.llvm.org/D17741#364931, @weimingz wrote:
>
> > In http://reviews.llvm.org/D17741#364756, @thakis wrote:
> >
> > > Instead of doing this, would it make sense to have a flag like
> > > -ffile-bas
kbarton closed this revision.
kbarton added a comment.
Committed r262359
http://reviews.llvm.org/D17637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
LGTM. You should probably wait for someone else to approve it though.
http://reviews.llvm.org/D17741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dblaikie added a comment.
Are there not any existing cases that test this diagnostic?
Could you just update some existing cases to cover this? (it looks like, in the
same file, the test case added for PR 6117 could be expanded to test this as
well, perhaps?) It looks like that's the original te
I'd quite happily add them... but can I do it in another patch? I think I
could be more thorough that way.
For the same reason, can we list all the microsoft memory allocating
routines here? There are a thousand routines we might want to add, and then
a few others (like _dupenv_s, _malloca, and _e
nemanjai updated this revision to Diff 49508.
nemanjai added a comment.
Removed questionable macro definitions.
Renamed the test function for invalid conversions and changed the semantics so
that it allows __float128 <-> long double conversions only if the two types
have the same representation
Hi Dmitri,
Thank you for your reply. I have double-checked that compiling a test invoking
an intrinsic that has C++ style doxygen comments in the corresponding header
doesn't cause compile-time errors/warnings in
-std=c89 (and in gnu89, c99, gnu99, c11, gnu11) modes.
I will continue committing
wristow created this revision.
wristow added reviewers: cfe-commits, rnk, majnemer.
This change just adds tests for some corner cases of dllimport/dllexport,
primarily for some static methods.
We plan to enable dllimport/dllexport support for the PS4, and these
additional tests are for points we
thakis added a comment.
> I think we can do this separately. A "basename" macro is easier for
> programmers to use and no build system change needed.
Hm, I would think that adding a flag to your CFLAGS is easier than getting all
your dependencies to use a clang-only new macro…
http://reviews
xur marked an inline comment as done.
Comment at: lib/CodeGen/CodeGenModule.cpp:154
@@ +153,3 @@
+assert(!CodeGenOpts.ProfileInstrumentUsePath.empty() &&
+ "Need to explicitly specify the profile name.");
+auto ReaderOrErr = llvm::IndexedInstrProfReader::create(
That's fine, thanks.
On Tue, Mar 1, 2016 at 10:52 AM Romanova, Katya <
katya_roman...@playstation.sony.com> wrote:
> Hi Dmitri,
> Thank you for your reply. I have double-checked that compiling a test
> invoking an intrinsic that has C++ style doxygen comments in the
> corresponding header doesn't
Anastasia accepted this revision.
Anastasia added a comment.
LGTM!
http://reviews.llvm.org/D16876
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
majnemer updated this revision to Diff 49522.
majnemer added a comment.
- Address Reid's review comments
http://reviews.llvm.org/D17752
Files:
lib/CodeGen/CGException.cpp
lib/CodeGen/CodeGenFunction.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGen/exceptions-seh-finally.c
Index: test/Cod
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D17752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262379: [MSVC Compat] Correctly handle finallys nested
within finallys (authored by majnemer).
Changed prior to commit:
http://reviews.llvm.org/D17752?vs=49522&id=49525#toc
Repository:
rL LLVM
http:
Author: majnemer
Date: Tue Mar 1 13:42:53 2016
New Revision: 262379
URL: http://llvm.org/viewvc/llvm-project?rev=262379&view=rev
Log:
[MSVC Compat] Correctly handle finallys nested within finallys
We'd lose track of the parent CodeGenFunction, leading us to get
confused with regard to which func
Author: rnk
Date: Tue Mar 1 13:51:48 2016
New Revision: 262382
URL: http://llvm.org/viewvc/llvm-project?rev=262382&view=rev
Log:
Reword a misleading comment discussing landingpads and SEH
SEH doesn't use landingpads anymore.
Modified:
cfe/trunk/lib/CodeGen/CGException.cpp
Modified: cfe/tru
On Tue, Mar 1, 2016 at 10:54 AM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> thakis added a comment.
>
> > I think we can do this separately. A "basename" macro is easier for
> programmers to use and no build system change needed.
>
>
> Hm, I would think that adding a flag to
bcraig added a comment.
In http://reviews.llvm.org/D17741#365457, @thakis wrote:
> > I think we can do this separately. A "basename" macro is easier for
> > programmers to use and no build system change needed.
>
>
> Hm, I would think that adding a flag to your CFLAGS is easier than getting
> a
silvas added a subscriber: silvas.
silvas added a comment.
Random question:
> We plan to enable dllimport/dllexport support for the PS4
How are you planning on codegenning them? The same way as we do in our private
branch?
http://reviews.llvm.org/D17775
___
jbcoe added a comment.
Has anyone had a chance to look over this?
http://reviews.llvm.org/D15654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kromanova
Date: Tue Mar 1 14:04:57 2016
New Revision: 262385
URL: http://llvm.org/viewvc/llvm-project?rev=262385&view=rev
Log:
This patch adds doxygen comments for the intrinsincs in the header file
popcntintrin.h.
The doxygen comments are automatically generated based on Sony's intrins
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262385: This patch adds doxygen comments for the intrinsincs
in the header file… (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D17550?vs=48844&id=49534#toc
Repository:
rL
Maybe config options could allow addition of owning and non-owning pairs?
I'd like to do that as an extension if this path is approved.
Jon
On 1 March 2016 at 12:29, David Blaikie wrote:
> Any way to/would it be worth broadening this with an annotation or some
> such (or just a lost for now) o
ariccio added a comment.
Is this patch all clear to go?
I hope I don't sound too pushy - I just don't want to lose momentum here.
http://reviews.llvm.org/D17688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
aaron.ballman added a comment.
Some quick thoughts below.
Comment at: include/clang/Basic/Attr.td:997
@@ +996,3 @@
+ let Subjects = SubjectList<[Function], ErrorDiag,
+ "ExpectedKernelFunction">;
+}
I don't see any code that checks w
On Tue, Mar 1, 2016 at 1:42 PM,
wrote:
> I'd quite happily add them... but can I do it in another patch? I think I
> could be more thorough that way.
I'm not certain I understand the reasoning, but I also don't have
strong feelings on whether it's this patch or another. I just don't
understand w
ygao added a subscriber: ygao.
Comment at: lib/Basic/Targets.cpp:2772
@@ -2771,2 +2771,3 @@
setFeatureEnabledImpl(Features, "xsaveopt", true);
+setFeatureEnabledImpl(Features, "xsave", true);
// FALLTHROUGH
Is this line necessary? Line#3027 below in
Hi Richard,
it looks like this commit causes an assertion failure in Sema when mixing PCH
and modules. The following script is the smallest reproduction I could come up
with. Could you please have a look?
$ cat ../repro.sh
mkdir -p usr/include
mkdir -p usr/include/bsm
mkdir -p usr/include/netin
tra created this revision.
tra added reviewers: jlebar, jingyue.
tra added a subscriber: cfe-commits.
.. and register them with CUDA runtime.
This is needed for commonly used cudaMemcpy*() APIs that use address of
host-side shadow to access their counterparts on device side.
Fixes PR26340.
htt
wristow added a comment.
In http://reviews.llvm.org/D17775#365611, @silvas wrote:
> Random question:
>
> > We plan to enable dllimport/dllexport support for the PS4
>
>
> How are you planning on codegenning them? The same way as we do in our
> private branch?
Yes, that's the intention.
http:
LegalizeAdulthood added a comment.
Squeak
http://reviews.llvm.org/D17482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hubert.reinterpretcast added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:1658
@@ -1657,1 +1657,3 @@
} else if (FromType->isRealFloatingType() && ToType->isRealFloatingType()) {
+// FIXME: disable conversions between long double and __float128 if
+// their rep
tra created this revision.
tra added reviewers: jlebar, jingyue.
tra added a subscriber: cfe-commits.
Do not generate runtime init code if we don't have anything to init.
http://reviews.llvm.org/D17780
Files:
lib/CodeGen/CGCUDANV.cpp
test/CodeGenCUDA/device-stub.cu
Index: test/CodeGenCUDA/d
Author: djasper
Date: Tue Mar 1 15:41:58 2016
New Revision: 262402
URL: http://llvm.org/viewvc/llvm-project?rev=262402&view=rev
Log:
[clang-format] Detect constructor initializers preceded by `noexcept`.
Patch by Erik Kessler, thank you.
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
thakis updated the summary for this revision.
thakis updated this revision to Diff 49541.
thakis marked 5 inline comments as done.
thakis added a comment.
- rebase across jlebar's r261774 => implicit_inputs gone, ForceSuccessCommand
is new
- .h file is found relative to include paths => introduce
djasper closed this revision.
djasper added a comment.
Submitted as r262402. Thank you.
http://reviews.llvm.org/D17621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis added inline comments.
Comment at: lib/Driver/Driver.cpp:2355
@@ +2354,3 @@
+
+// Add pch if needed: "If you do not specify an extension as part of the
+// path name, an extension of .pch is assumed. "
hans wrote:
> Maybe add .pch if needed?
It alre
thakis updated this revision to Diff 49544.
thakis added a comment.
forgot to `svn add` two new test files
http://reviews.llvm.org/D17695
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/DiagnosticGroups.td
include/clang/Driver/CC1Options.td
include/clang/Driver/C
Author: dsanders
Date: Tue Mar 1 15:57:22 2016
New Revision: 262409
URL: http://llvm.org/viewvc/llvm-project?rev=262409&view=rev
Log:
Explicitly select IAS on one more RUN line in new embed-bitcode.c test.
This should fix clang-cmake-mips builder since MIPS does not have IAS enabled
by default (
No problem.
It seems I missed one of the relevant RUN lines on the first attempt. I've
fixed that in r262409.
From: steve...@apple.com [steve...@apple.com]
Sent: 01 March 2016 17:26
To: Daniel Sanders
Cc: cfe-commits@lists.llvm.org
Subject: Re: r262282 -
On Tue, Mar 1, 2016 at 1:00 PM, Warren Ristow <
warren_ris...@playstation.sony.com> wrote:
> wristow added a comment.
>
> In http://reviews.llvm.org/D17775#365611, @silvas wrote:
>
> > Random question:
> >
> > > We plan to enable dllimport/dllexport support for the PS4
> >
> >
> > How are you plan
steven_wu updated this revision to Diff 49549.
steven_wu added a comment.
I did some more digging of the issue. It seems ObjCSubscriptRefExpr always
rebuilds and hinds both base and key behind OpaqueValueExpr. See
ObjCSubscriptOpBuilder::rebuildAndCaptureObject so it looks the AST generated
is in
Author: rjmccall
Date: Tue Mar 1 16:18:03 2016
New Revision: 262414
URL: http://llvm.org/viewvc/llvm-project?rev=262414&view=rev
Log:
Mangle extended qualifiers in the proper order and mangle the
ARC ownership-convention function type modifications.
According to the Itanium ABI, vendor extended
RKSimon updated this revision to Diff 49552.
RKSimon added a comment.
Thanks - I've removed adding XSAVE to btver2, as long as nobody thinks we need
to keep it to be explicit?
Repository:
rL LLVM
http://reviews.llvm.org/D17682
Files:
lib/Basic/Targets.cpp
test/Preprocessor/predefined-ar
jlebar added inline comments.
Comment at: lib/CodeGen/CGCUDANV.cpp:168
@@ -163,1 +167,3 @@
+/// of global scope device-side variables generated in this module
+/// with the CUDA runtime.
/// \code
This is kind of hard to parse. How about rephrasing to something
Author: rksimon
Date: Tue Mar 1 16:38:33 2016
New Revision: 262418
URL: http://llvm.org/viewvc/llvm-project?rev=262418&view=rev
Log:
Updated SSE41 builtin tests to more closely match the llvm fast-isel equivalent
tests
Modified:
cfe/trunk/test/CodeGen/sse41-builtins.c
Modified: cfe/trunk/t
chaoren created this revision.
chaoren added reviewers: kparzysz, bkramer.
chaoren added a subscriber: cfe-commits.
LLVM_PREFIX could be undefined if CMAKE_INSTALL_PREFIX were set to empty.
http://reviews.llvm.org/D17784
Files:
lib/Driver/ToolChains.cpp
Index: lib/Driver/ToolChains.cpp
==
hans added a comment.
lgtm2
Comment at: include/clang/Driver/Job.h:142
@@ +141,3 @@
+/// Like Command, but always pretends that the wrapped command succeeded.
+/// the primary command crashes.
+class ForceSuccessCommand : public Command {
The second sentence loo
thakis closed this revision.
thakis marked 3 inline comments as done.
thakis added a comment.
r262420, thanks!
http://reviews.llvm.org/D17695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: nico
Date: Tue Mar 1 17:16:44 2016
New Revision: 262420
URL: http://llvm.org/viewvc/llvm-project?rev=262420&view=rev
Log:
clang-cl: Implement initial limited support for precompiled headers.
In the gcc precompiled header model, one explicitly runs clang with `-x
c++-header` on a .h file
djasper added inline comments.
Comment at: include/clang/Format/Format.h:606
@@ +605,3 @@
+ /// \brief The QuoteStyle to use for JavaScript strings.
+ QuoteStyle Quotes;
+
As this only affects JavaScript and doesn't make any sense for Java or C++, I'd
like to h
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Sorry for the delayed reply. I think this looks good.
http://reviews.llvm.org/D15643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
> I just don't understand why some functions made it in this patch and not
> others (notably, why the lack of _mbsdup, which is documented on the same
> page as others you are adding).
It's partly because of the better wrapper class that was mentioned (in a
discussion that I'm having trouble fi
zaks.anna added a comment.
I suggest to update the malloc regression test with these.
http://reviews.llvm.org/D17688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra updated this revision to Diff 49561.
tra marked 9 inline comments as done.
tra added a comment.
Addressed Justin's comments.
http://reviews.llvm.org/D17779
Files:
lib/CodeGen/CGCUDANV.cpp
lib/CodeGen/CGCUDARuntime.h
lib/CodeGen/CodeGenModule.cpp
test/CodeGenCUDA/device-stub.cu
tes
mprobst added inline comments.
Comment at: lib/Format/Format.cpp:1087
@@ +1086,3 @@
+(Style.Quotes == FormatStyle::QS_Single &&
+ !FormatTok->TokenText.startswith("\"")) ||
+(Style.Quotes == FormatStyle::QS_Double &&
djasper wrote:
> Are th
1 - 100 of 136 matches
Mail list logo
