a.sidorin updated this revision to Diff 45360.
a.sidorin added a comment.
Replace NULL with nullptr.
http://reviews.llvm.org/D16215
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
include/clang/ASTMatchers/ASTMatchersInternal.h
unittests/ASTMatchers/ASTM
The direction and change LGTM. Feel free to commit once the change has some
tests.
On Fri, Jan 8, 2016 at 5:45 PM, Duncan P. N. Exon Smith <
dexonsm...@apple.com> wrote:
> No one is waiting for me on this, are they? FWIW, this seems like
> a good solution to me. I'll see what I can do internall
Author: abataev
Date: Wed Jan 20 03:07:54 2016
New Revision: 258299
URL: http://llvm.org/viewvc/llvm-project?rev=258299&view=rev
Log:
[OPENMP 4.5] Allow to use non-static data members in non-static member
functions in 'private' clause.
OpenMP 4.5 allows to use non-static members of current class
EricWF added a subscriber: EricWF.
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D16006
___
cfe-commits mailing list
cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
I don't see anything in the Itanium ABI spec that would prefer one demangling
over another.
I also double checked that `scanf("%a", ...)` generates the expected
bit-pattern for each te
Author: abataev
Date: Wed Jan 20 06:29:47 2016
New Revision: 258307
URL: http://llvm.org/viewvc/llvm-project?rev=258307&view=rev
Log:
[OPENMP 4.0] Fix for codegen of 'cancel' directive within 'sections' directive.
Allow to emit code for 'cancel' directive within 'sections' directive with
single s
nick.sumner created this revision.
nick.sumner added reviewers: bkramer, rsmith.
nick.sumner added a subscriber: cfe-commits.
Allow C style casts to be printed correctly even when the incoming
PrintingPolicy suppresses specifiers. This can happen, for instance,
when casts occur during the initiali
Eric, Marshall: another ping. This should be fixed on the 3.8 branch, so it
needs to be resolved soon.
On Jan 5, 2016 5:25 PM, "Nico Weber" wrote:
> On Wed, Dec 30, 2015 at 8:28 PM, Richard Smith
> wrote:
>
>> On Wed, Dec 30, 2015 at 1:17 PM, Nico Weber wrote:
>>
>>> One problem with this patch
danielmarjamaki added a comment.
In http://reviews.llvm.org/D16310#330367, @LegalizeAdulthood wrote:
> Why not supply a fixit that removes the cast?
I am skeptic. There are different valid fixes.
Example code:
l = (long)(a*1000);
Fix1:
l = ((long)a * 1000);
Fix2:
l = (a * (long)1000
danielmarjamaki removed rL LLVM as the repository for this revision.
danielmarjamaki updated this revision to Diff 45378.
danielmarjamaki added a comment.
Fixed review comment; s/checker/check/
http://reviews.llvm.org/D16310
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/LongCastChec
danielmarjamaki marked an inline comment as done.
danielmarjamaki added a comment.
http://reviews.llvm.org/D16310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielmarjamaki added a comment.
In http://reviews.llvm.org/D16310#330312, @Eugene.Zelenko wrote:
> Clang-tidy has 6 cast related checks. May be this is good time to introduce
> dedicated category for them?
I am not against this.
I don't know which ones you are thinking about.. but if a check
Author: bcraig
Date: Wed Jan 20 08:03:27 2016
New Revision: 258311
URL: http://llvm.org/viewvc/llvm-project?rev=258311&view=rev
Log:
[libcxxabi] Make test tolerant of uncommon floating literal demanglings
libcxxabi uses the C99 library's %a format specifier to turn a floating
point value into a h
Author: bcraig
Date: Wed Jan 20 08:10:23 2016
New Revision: 258313
URL: http://llvm.org/viewvc/llvm-project?rev=258313&view=rev
Log:
[libcxxabi] Teach cxa_demangle about Hexagon's long double size
cxa_demangle's default size for a long double is 10 bytes. Hexagon
only has an 8 byte long double th
Author: aaronballman
Date: Wed Jan 20 09:25:30 2016
New Revision: 258317
URL: http://llvm.org/viewvc/llvm-project?rev=258317&view=rev
Log:
Silencing several -Wcast-qual warnings; NFC.
Modified:
cfe/trunk/tools/libclang/CIndex.cpp
Modified: cfe/trunk/tools/libclang/CIndex.cpp
URL:
http://llv
danielmarjamaki marked 7 inline comments as done.
danielmarjamaki added a comment.
http://reviews.llvm.org/D13126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Wed Jan 20 10:17:39 2016
New Revision: 258321
URL: http://llvm.org/viewvc/llvm-project?rev=258321&view=rev
Log:
Add AST matcher for paren expressions.
Patch by Adrian Zgorzałek.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk/include/clang/ASTMa
aaron.ballman closed this revision.
aaron.ballman added a comment.
Thanks! I've commit in r258321
http://reviews.llvm.org/D16278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman closed this revision.
aaron.ballman added a comment.
Thanks! I went ahead and commit in r258322.
http://reviews.llvm.org/D16215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: aaronballman
Date: Wed Jan 20 10:26:48 2016
New Revision: 258322
URL: http://llvm.org/viewvc/llvm-project?rev=258322&view=rev
Log:
Add AST matcher support for FunctionDecls with the hasBody matcher.
Patch by Aleksei Sidorin.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
c
aaron.ballman added a comment.
Mostly looks good, except I do still have the question about list delimiters
that I'd like to hear some thoughts on. My primary concern is that I hope to
avoid having different separators for different lists, and I wonder whether we
want a common "parse a list of
arpith-jacob created this revision.
arpith-jacob added reviewers: ABataev, kkwli0, hfinkel, sfantao, carlo.bertolli.
arpith-jacob added subscribers: cfe-commits, caomhin, fraggamuffin.
Allow nowait clause on target directive in sema and add test cases.
http://reviews.llvm.org/D16358
Files:
inc
aaboud updated this revision to Diff 45400.
aaboud added a comment.
Merged all 4 Lit tests into one.
http://reviews.llvm.org/D15977
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
lib/CodeGen/CGDecl.cpp
test/CodeGenCXX/debug-info-lb.cpp
Index: lib/CodeGen/CGDecl.cpp
==
LegalizeAdulthood added inline comments.
Comment at: docs/clang-tidy/checks/readability-simplify-boolean-expr.rst:59
@@ -56,3 +58,3 @@
4. The conditional return ``if (p) return true; return false;`` has an
implicit conversion of a pointer to ``bool`` and becomes
---
LegalizeAdulthood added inline comments.
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.h:77
@@ -74,3 +76,3 @@
/// implicit conversion of `i & 1` to `bool` and becomes
-/// `bool b = static_cast(i & 1);`.
+/// `bool b = i & 1 != 0;`.
///
-
aaron.ballman added a comment.
Ping
http://reviews.llvm.org/D16012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
Ping
http://reviews.llvm.org/D15935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Tue, Jan 19, 2016 at 6:08 PM, Marshall Clow wrote:
> On Tue, Jan 19, 2016 at 3:34 PM, Eric Fiselier wrote:
>> I would like to merge the following commits into 3.8.
>>
>> 1. r258196 (libc++)
>> 2. r258198 (libc++)
>> 3. r258201 (libc++abi)
>>
>> These commits simply add missing license headers.
d.zobnin.bugzilla updated this revision to Diff 45401.
d.zobnin.bugzilla added a comment.
Updated the patch after committed fix for http://reviews.llvm.org/D16301
(r258213).
This patch:
1. Adds "Enum" Subject to 'mode' attribute to be able to compile code like
"typedef enum { X } __attribute__
No problem. Please go ahead and merge with utils/release/merge.sh, or
let me know if you'd prefer me to do it.
On Tue, Jan 19, 2016 at 7:09 PM, Eric Fiselier wrote:
> Hi Hans,
>
> Sorry to make this more complicated, but can you also include the follow-up
> libc++abi commit r258277.
>
> /Eric
>
>
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.h:77
@@ -74,3 +76,3 @@
/// implicit conversion of `i & 1` to `bool` and becomes
-/// `bool b = static_cast(i & 1);`.
+/// `bool b = i & 1 != 0;`.
///
dexonsmith created this revision.
dexonsmith added a reviewer: EricWF.
dexonsmith added a subscriber: cfe-commits.
(Repost of:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160118/147379.html
on Phabricator as requested by Eric.)
This is a follow-up to r239666: "Fix PR12999 - unordere
Reviewer's choice:
http://reviews.llvm.org/D16360
(I've barely used phab, so let me know if it's broken somehow...)
> On 2016-Jan-19, at 16:15, Eric Fiselier wrote:
>
> Hey Duncan,
>
> I know this isn't required, but would it be possible to put this on
> phabricator?
>
> /Eric
>
> On Mon,
ahatanak added a comment.
ping
http://reviews.llvm.org/D15599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
/sub
On Wed, Jan 20, 2016 at 4:45 AM, Nico Weber via cfe-commits
wrote:
> Eric, Marshall: another ping. This should be fixed on the 3.8 branch, so it
> needs to be resolved soon.
>
> On Jan 5, 2016 5:25 PM, "Nico Weber" wrote:
>>
>> On Wed, Dec 30, 2015 at 8:28 PM, Richard Smith
>> wrote:
>>>
>
arpith-jacob created this revision.
arpith-jacob added reviewers: ABataev, kkwli0, hfinkel, sfantao, carlo.bertolli.
arpith-jacob added subscribers: cfe-commits, fraggamuffin, caomhin.
Accept nowait clause on target enter data directive in sema and add test cases.
http://reviews.llvm.org/D16361
arpith-jacob created this revision.
arpith-jacob added reviewers: ABataev, kkwli0, hfinkel, sfantao, carlo.bertolli.
arpith-jacob added subscribers: cfe-commits, fraggamuffin, caomhin.
Accept nowait clause on target exit data directive in sema and add test cases.
http://reviews.llvm.org/D16362
F
kmensah created this revision.
kmensah added a reviewer: djasper.
kmensah added a subscriber: cfe-commits.
kmensah set the repository for this revision to rL LLVM.
A command line option that lets users of the script specify which clang-format
binary to use. Useful if clang-format is not on PATH o
Author: dim
Date: Wed Jan 20 12:53:44 2016
New Revision: 258327
URL: http://llvm.org/viewvc/llvm-project?rev=258327&view=rev
Log:
Ensure the lit.site.cfg and Unit/lit.site.cfg make targets do not use
the same temporary file, otherwise there is a race condition when using
parallel make jobs.
Modif
Author: djasper
Date: Wed Jan 20 12:55:57 2016
New Revision: 258328
URL: http://llvm.org/viewvc/llvm-project?rev=258328&view=rev
Log:
clang-format-diff: Replace hard-code default for clang-format binary with flag.
Patch by Kwasi Mensah, thank you.
Modified:
cfe/trunk/tools/clang-format/clang
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Submitted as r258328.
Repository:
rL LLVM
http://reviews.llvm.org/D16363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
On 1/20/16 11:53 AM, Dimitry Andric via cfe-commits wrote:
Author: dim
Date: Wed Jan 20 12:53:44 2016
New Revision: 258327
URL: http://llvm.org/viewvc/llvm-project?rev=258327&view=rev
Log:
Ensure the lit.site.cfg and Unit/lit.site.cfg make targets do not use
the same temporary file, otherwise
ygao created this revision.
ygao added a reviewer: rsmith.
ygao added a subscriber: cfe-commits.
Herald added subscribers: dschuff, jfb.
Hi,
I was looking at the list of pre-defined macros by the new LLVM release and
noticed that the __GXX_RTTI macro is being defined for both C and C++, and I
wo
bruno updated this revision to Diff 45421.
bruno added a comment.
Update patch after Richard comments
http://reviews.llvm.org/D15173
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/PPCaching.cpp
lib/Parse/ParseTemplate.cpp
test/Parser/objcxx11-protocol-in-template.mm
Index: test/Parser
manmanren added a subscriber: manmanren.
manmanren added a comment.
Thanks for working on this! A few comments inline.
Manman
Comment at: lib/CodeGen/CodeGenFunction.cpp:1962
@@ +1961,3 @@
+for (auto *U : I->users())
+ InstrsToRemove.push_back(cast(U));
+
-
thakis added a comment.
After some more debugging, the only thing in this test that's still faiilng on
Windows is the "unsigned-integer-overflow:do_overflow" suppression -- when
llvm-symbolizer gets symbols from PDBs it currently requires the DIA SDK. If
that's not found at cmake time, then llv
Author: aaronballman
Date: Wed Jan 20 14:47:58 2016
New Revision: 258341
URL: http://llvm.org/viewvc/llvm-project?rev=258341&view=rev
Log:
Register the isCopyAssignmentOperator AST matcher so that it can be used
dynamically.
Path by Jonathan Coe.
Modified:
cfe/trunk/lib/ASTMatchers/Dynamic/
dcoughlin closed this revision.
dcoughlin added a comment.
Committed in r258336.
http://reviews.llvm.org/D16115
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Wed, Jan 20, 2016 at 11:00 AM, Jonathan Roelofs
wrote:
>
>
> On 1/20/16 11:53 AM, Dimitry Andric via cfe-commits wrote:
>>
>> Author: dim
>> Date: Wed Jan 20 12:53:44 2016
>> New Revision: 258327
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=258327&view=rev
>> Log:
>> Ensure the lit.site.c
zaks.anna updated this revision to Diff 45437.
zaks.anna added a comment.
Refactor the code to address Samsonov's review.
http://reviews.llvm.org/D15624
Files:
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
test/Driver/fsanitize.c
Index: test/Driver/fsanitize.c
===
zaks.anna marked an inline comment as done.
zaks.anna added a comment.
I've introduced the helper function. Looks like addProfileRTLibs might be able
to use it in the future (after support for autoconf is dropped) as well.
http://reviews.llvm.org/D15624
__
kromanova added a comment.
In http://reviews.llvm.org/D15999#330794, @silvas wrote:
> This may sound stupid, but: can you benchmark the time it takes to build some
> project (that actually uses intrinsics in most translation units, e.g. a
> game) with the headers w/ and w/o the doxygen comments
LegalizeAdulthood added inline comments.
Comment at: docs/clang-tidy/checks/readability-simplify-boolean-expr.rst:59
@@ -56,3 +58,3 @@
4. The conditional return ``if (p) return true; return false;`` has an
implicit conversion of a pointer to ``bool`` and becomes
---
sbenza updated this revision to Diff 45438.
sbenza added a comment.
Rename functions.
http://reviews.llvm.org/D15506
Files:
include/clang/ASTMatchers/ASTMatchersInternal.h
lib/ASTMatchers/ASTMatchersInternal.cpp
unittests/ASTMatchers/ASTMatchersTest.cpp
Index: unittests/ASTMatchers/ASTMa
sbenza added inline comments.
Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:351
@@ +350,3 @@
+
+ // First, match the name.
+ if (!MatchNodeName(Pattern, Node))
klimek wrote:
> Perhaps comment that Pattern will be changed to the prefix, so it's clear
> aft
davidxl added inline comments.
Comment at: lib/CodeGen/CodeGenPGO.cpp:768
@@ +767,3 @@
+ llvm::IndexedInstrProfReader *PGOReader = CGM.getPGOReader();
+ if (!InstrumentValueSites && !PGOReader)
+return;
&& --> ||
Comment at: lib/CodeGen/Cod
LegalizeAdulthood added a comment.
If you state what the check does, then
In http://reviews.llvm.org/D16310#331054, @danielmarjamaki wrote:
> In http://reviews.llvm.org/D16310#330367, @LegalizeAdulthood wrote:
>
> > Why not supply a fixit that removes the cast?
>
>
> I am skeptic. There are diff
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: jhen, echristo, cfe-commits.
The code in CGCUDACall is largely based on a patch written by Eli
Bendersky:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20140324/210218.html
That patch implemented an L
LegalizeAdulthood added inline comments.
Comment at: clang-tidy/misc/LongCastCheck.cpp:43
@@ +42,3 @@
+
+static unsigned getMaxCalculationWidth(ASTContext &C, const Expr *E) {
+ E = E->IgnoreParenImpCasts();
Prefer anonymous namespace over `static` to scope visib
jlebar updated this revision to Diff 45446.
jlebar added a comment.
Remove {} around an if statement.
http://reviews.llvm.org/D16372
Files:
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CGCUDACall.cpp
lib/CodeGen/CMakeLists.txt
lib/CodeGen/CodeGenFunction.h
lib/Headers/__clang_cuda_runtime_wr
Richard: ping?
On Tue, Jan 12, 2016 at 6:41 PM, Reid Kleckner wrote:
> rnk accepted this revision.
> rnk added a comment.
> This revision is now accepted and ready to land.
>
> Seems reasonable to me, but we should check with Richard.
>
>
> http://reviews.llvm.org/D15670
>
>
>
>
--
Ehsan
ehsan added a subscriber: ehsan.
ehsan added a comment.
Richard: ping?
http://reviews.llvm.org/D15670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arpith-jacob created this revision.
arpith-jacob added reviewers: ABataev, kkwli0, hfinkel, sfantao, carlo.bertolli.
arpith-jacob added subscribers: cfe-commits, fraggamuffin, caomhin.
Accept depend clause on target directive in sema and add test cases.
http://reviews.llvm.org/D16375
Files:
in
Author: aaronballman
Date: Wed Jan 20 16:14:10 2016
New Revision: 258356
URL: http://llvm.org/viewvc/llvm-project?rev=258356&view=rev
Log:
Make modernize-use-default tolerant of delayed template parsing; this code was
previously causing failed assertions because dyn_cast was being passed a null
xazax.hun added inline comments.
Comment at: tools/clang/lib/StaticAnalyzer/Core/MemRegion.cpp:660
@@ +659,3 @@
+}
+
+else if (auto SV =
The else should go into the same line as the closing }.
Comment at: tools/clang/lib/StaticAnalyzer/Co
Hello everyone,
Below are some buildbot numbers for the last week of 1/10/2016 - 1/16/2016.
Thanks
Galina
Number of commits by project:
project | commits
---+---
llvm | 391
cfe | 100
tra added inline comments.
Comment at: lib/CodeGen/CGCUDACall.cpp:1
@@ +1,2 @@
+//===- CGCUDACall.cpp - Codegen for special CUDA calls
===//
+//
We'll need to handle other builtins soon. Perhaps we can keep them in this file
and rename it CGC
kromanova added a comment.
In http://reviews.llvm.org/D15999#330794, @silvas wrote:
> This may sound stupid, but: can you benchmark the time it takes to build some
> project (that actually uses intrinsics in most translation units, e.g. a
> game) with the headers w/ and w/o the doxygen comments
aaron.ballman created this revision.
aaron.ballman added reviewers: congliu, alexfh.
aaron.ballman added a subscriber: cfe-commits.
Special member functions don't always have names, and so calling
FunctionDecl::getName() can cause assertions. This patch addresses the issue by
assuming any such f
aaron.ballman updated this revision to Diff 45451.
aaron.ballman added a comment.
Now checking that both the base *and* the derived functions have names.
http://reviews.llvm.org/D16377
Files:
clang-tidy/misc/VirtualNearMissCheck.cpp
test/clang-tidy/misc-virtual-near-miss.cpp
Index: test/cl
Uncertain whether this meets the bar for inclusion in 3.8.
clang-modernize was moved into clang-tidy and from what I can tell, it
did not suffer from this crash. I wouldn't normally recommend this,
but just about any use of clang-tidy (that does not filter out this
check) over code that includes th
On Wed, Jan 20, 2016 at 2:32 PM Katya Romanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> kromanova added a comment.
>
> In http://reviews.llvm.org/D15999#330794, @silvas wrote:
>
> > This may sound stupid, but: can you benchmark the time it takes to build
> some project (that actually
nwilson updated this revision to Diff 45453.
nwilson added a comment.
- Take qualifiers into account.
- Check `VarDecl` is valid when checking declaration type to account for
`constexpr` being specified. Is there any opinion on a better way to handle
this? I *could* check for both diagnostics in
silvas added a comment.
In http://reviews.llvm.org/D15999#331601, @kromanova wrote:
> In http://reviews.llvm.org/D15999#330794, @silvas wrote:
>
> > This may sound stupid, but: can you benchmark the time it takes to build
> > some project (that actually uses intrinsics in most translation units,
On Wed, Jan 20, 2016 at 3:12 PM Sean Silva wrote:
> silvas added a comment.
>
> In http://reviews.llvm.org/D15999#331601, @kromanova wrote:
>
> > In http://reviews.llvm.org/D15999#330794, @silvas wrote:
> >
> > > This may sound stupid, but: can you benchmark the time it takes to
> build some proj
silvas added a comment.
In http://reviews.llvm.org/D15999#331512, @kromanova wrote:
> In http://reviews.llvm.org/D15999#330794, @silvas wrote:
>
> > This may sound stupid, but: can you benchmark the time it takes to build
> > some project (that actually uses intrinsics in most translation units,
I see. I was hoping that if you were, I could have used the same benchmark and
compare what build time increase caused by using target attributes (might be
much more substantial) and by adding doxygen comments.
From: Eric Christopher [mailto:echri...@gmail.com]
Sent: Wednesday, January 20, 2016
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D15921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
I have some benchmarks, but none of them moved when I added the support
that I could see. It wouldn't catch small regressions though.
-eric
On Wed, Jan 20, 2016 at 3:17 PM Romanova, Katya <
katya_roman...@playstation.sony.com> wrote:
> I see. I was hoping that if you were, I could have used the
jlebar added inline comments.
Comment at: test/CodeGenCUDA/printf.cu:12
@@ +11,3 @@
+// Check a simple call to printf end-to-end.
+__device__ int CheckSimple() {
+ // CHECK: [[FMT:%[0-9]+]] = load{{.*}}%fmt
tra wrote:
> You may want to add a test case for printf(
jlebar updated this revision to Diff 45456.
jlebar marked 3 inline comments as done.
jlebar added a comment.
Address tra's review comments.
http://reviews.llvm.org/D16372
Files:
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CGCUDABuiltin.cpp
lib/CodeGen/CMakeLists.txt
lib/CodeGen/CodeGenFunctio
On Wed, Jan 20, 2016 at 3:14 PM, Eric Christopher
wrote:
>
>
> On Wed, Jan 20, 2016 at 3:12 PM Sean Silva wrote:
>
>> silvas added a comment.
>>
>> In http://reviews.llvm.org/D15999#331601, @kromanova wrote:
>>
>> > In http://reviews.llvm.org/D15999#330794, @silvas wrote:
>> >
>> > > This may so
dblaikie added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:1479
@@ +1478,3 @@
+void CGDebugInfo::recordDeclarationLexicalScope(const Decl &D) {
+ assert(LexicalBlockMap.find(&D) == LexicalBlockMap.end() &&
+ "D is already mapped to lexical block scope");
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.
Looks reasonable to me.
-eric
http://reviews.llvm.org/D16372
___
cfe-commits mailing list
cfe-commits@l
kromanova added a comment.
In http://reviews.llvm.org/D15999#331639, @silvas wrote:
> In http://reviews.llvm.org/D15999#331601, @kromanova wrote:
>
> >
>
>
> I don't think we did any testing at SCE, but we probably should have. I don't
> think Google's primary codebases (nor Apple's, or anybody
kromanova added a comment.
In http://reviews.llvm.org/D15999#331649, @silvas wrote:
> In http://reviews.llvm.org/D15999#331512, @kromanova wrote:
>
> > In http://reviews.llvm.org/D15999#330794, @silvas wrote:
> >
> > > Also, can you post a patch that changes "all" the headers to have doxygen
> >
kromanova updated this revision to Diff 45458.
kromanova added a comment.
Craig, thank you for the review. Here are the changes that you requested.
Katya.
Repository:
rL LLVM
http://reviews.llvm.org/D16177
Files:
lib/Headers/f16cintrin.h
test/CodeGen/f16c-builtins.c
Index: test/CodeGen/
nwilson marked an inline comment as done.
Comment at: test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.spec.concept/p5.cpp:22
@@ +21,3 @@
+template
+concept float fcrtf() { return 5.5; } // expected-error {{declared return type
of function concept must be 'bool'}}
+
The
This patch looks correct to me. Is there any reason it wasn't committed?
> On 2015-Aug-25, at 22:22, Eric Fiselier via cfe-commits
> wrote:
>
> EricWF updated this revision to Diff 33180.
> EricWF added a comment.
>
> Cleanup the diff and remove extra changes.
>
>
> https://urldefense.proof
dexonsmith added a subscriber: dexonsmith.
dexonsmith added a comment.
This patch looks correct to me. Is there any reason it wasn't committed?
http://reviews.llvm.org/D12354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, kkwli0, arpith-jacob, carlo.bertolli.
sfantao added subscribers: caomhin, fraggamuffin, cfe-commits.
Extend support in the map clause SEMA for the expressions supported in the
OpenMP 4.5 specification, namely member express
george.burgess.iv added a comment.
Ping :)
http://reviews.llvm.org/D15721
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun added inline comments.
Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:54-55
@@ -53,16 +53,4 @@
// Both types must be pointers or references to classes.
- if (const auto *DerivedPT = DerivedReturnTy->getAs()) {
-if (const auto *BasePT = BaseReturnTy->getAs
xazax.hun updated this revision to Diff 45482.
xazax.hun marked an inline comment as done.
xazax.hun added a comment.
- Addressed review comments.
http://reviews.llvm.org/D16179
Files:
clang-tidy/misc/VirtualNearMissCheck.cpp
clang-tidy/misc/VirtualNearMissCheck.h
test/clang-tidy/misc-vir
thakis created this revision.
thakis added a reviewer: aaron.ballman.
thakis added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
http://reviews.llvm.org/D16394
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.c
ABataev added a comment.
Please, update your workspace to latest version, many changes are in trunk
already
http://reviews.llvm.org/D16385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
klimek accepted this revision.
klimek added a reviewer: klimek.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D16394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
craig.topper added inline comments.
Comment at: lib/Headers/f16cintrin.h:47
@@ -34,1 +46,3 @@
+
+
#define _mm_cvtps_ph(a, imm) __extension__ ({ \
Can we do something like this to remove the last temporary?
#define _cvtss_sh(a, imm) __extension__ ({ \
(unsigned
Hi Alexey,
Phabricator doesn't send mails when only the review state changes as mentioned
in documentation. This makes following the current status hard when relying on
them.
Could you therefore please type a "LGTM" which should trigger an email to the
mailing list?
Thanks,
Jonas
> -Origi
vsk created this revision.
vsk added a reviewer: davidxl.
vsk added a subscriber: cfe-commits.
Replace a string append operation in addFunctionMappingRecord with a
vector append. The existing behavior is quadratic in the worst case:
this patch makes it linear.
http://reviews.llvm.org/D16395
File
1 - 100 of 101 matches
Mail list logo
