seaneveson updated this revision to Diff 44098.
seaneveson marked an inline comment as done.
seaneveson added a comment.
Removing old "experimental" comment
http://reviews.llvm.org/D15888
Files:
lib/Driver/Tools.cpp
test/Driver/ps4-analyzer-defaults.cpp
Index: test/Driver/ps4-analyzer-defa
On Wed, Jan 06, 2016 at 07:42:18AM -, Dimitry Andric via cfe-commits wrote:
> Author: dim
> Date: Wed Jan 6 01:42:18 2016
> New Revision: 256920
>
> URL: http://llvm.org/viewvc/llvm-project?rev=256920&view=rev
> Log:
> Add -fno-movt frontend option, to disable movt/movw on ARM
Commit message
Author: seaneveson
Date: Wed Jan 6 04:03:58 2016
New Revision: 256926
URL: http://llvm.org/viewvc/llvm-project?rev=256926&view=rev
Log:
[Analyzer] Change the default SA checkers for PS4
Summary: This patch removes security.*, unix.API and unix.Vfork from the
default checkers for PS4.
Reviewers
Hahnfeld created this revision.
Hahnfeld added reviewers: chandlerc, mclow.lists, beanz.
Hahnfeld added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
With this option one can set the default library to use if no `-stdlib=` is
provided on compiler invocation
aaron.ballman added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:4283
@@ +4282,3 @@
+ EXPECT_TRUE(matches("void f(int i);", functionProtoType()));
+ EXPECT_TRUE(matches("void f();", functionProtoType(parameterCountIs(0;
+ EXPECT_TRUE(notMatchesC("v
xazax.hun created this revision.
xazax.hun added reviewers: zaks.anna, dcoughlin.
xazax.hun added subscribers: cfe-commits, dkrupp.
This patch adds a small utility to match function calls and Obj-C messages.
This utility abstracts away the mutable keywords and the lazy initialization
and caching
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the fix!
Comment at: tools/libclang/CIndexInclusionStack.cpp:32
@@ -36,13 +31,3 @@
SmallVector InclusionStack;
- unsigned n = SM.local_sloc_entry_size(
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:26
@@ +25,3 @@
+ StringRef Filename = SM.getFilename(ExpansionLoc);
+ return Filename.endswith(".h") || Filename.endswith(".hh") ||
+ Filename.endswith(".hpp") || Filename.ends
The patch was reapplied in r256933 and includes the fixes for the different
regressions that were identified, including the one reported below.
Thanks for your help!
Samuel
From: "Liao, Michael"
To: Samuel F Antao/Watson/IBM@IBMUS
Cc: cfe-commits , Artem Belevich
Date:
Author: kparzysz
Date: Wed Jan 6 08:13:11 2016
New Revision: 256934
URL: http://llvm.org/viewvc/llvm-project?rev=256934&view=rev
Log:
[Hexagon] Use back_inserter as target iterator in std::copy
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
Modified: cfe/trunk/lib/Driver/ToolChains.cpp
URL:
aaron.ballman added a comment.
I notice there are a few other comments from reviewers that have not been
addressed -- is there a newer version of the patch that hasn't been uploaded
yet, or are you looking for further information on some of the comments?
Comment at: clang-tidy
xazax.hun created this revision.
xazax.hun added reviewers: zaks.anna, dcoughlin, Alexander_Droste.
xazax.hun added subscribers: cfe-commits, dkrupp.
This patch adds a small utility to extract variable name from a memory region.
This patch does not contain any test or user yet.
There are however t
xazax.hun added inline comments.
Comment at: tools/clang/lib/StaticAnalyzer/Checkers/MPI-Checker/Utility.h:54
@@ +53,3 @@
+/// \returns variable name for memory region
+std::string variableName(const clang::ento::MemRegion *MR);
+
zaks.anna wrote:
> Since this tak
Author: mcrosier
Date: Wed Jan 6 08:35:46 2016
New Revision: 256937
URL: http://llvm.org/viewvc/llvm-project?rev=256937&view=rev
Log:
[Driver] Add support for -fno-builtin-foo options.
Addresses PR4941 and rdar://6756912.
http://reviews.llvm.org/D15195
Modified:
cfe/trunk/include/clang/Basi
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/Regions.def:31
@@ +30,3 @@
+// is both instantiated and derived from.
+// Additionally, its kind is not its name with "Kind" suffix,
+// unlike all other regions.
zaks.anna wrot
mcrosier closed this revision.
mcrosier added a comment.
Committed in r256937. Thanks, Bob.
http://reviews.llvm.org/D15195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: erikjv
Date: Wed Jan 6 09:12:51 2016
New Revision: 256939
URL: http://llvm.org/viewvc/llvm-project?rev=256939&view=rev
Log:
Show inclusions from a preamble in clang_getInclusions.
When reparsing a translation unit with preamble generation turned on,
no includes are found. This is due to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256939: Show inclusions from a preamble in
clang_getInclusions. (authored by erikjv).
Changed prior to commit:
http://reviews.llvm.org/D14329?vs=39187&id=44120#toc
Repository:
rL LLVM
http://reviews
erikjv created this revision.
erikjv added reviewers: klimek, rsmith.
erikjv added a subscriber: cfe-commits.
When generating pre-compiled headers, or when opening a header file with
libclang, suppress the warnings "#pragma once in main file" and
"#include_next in primary source file".
Fixes
sfantao updated this revision to Diff 44124.
sfantao added a comment.
Rebase.
http://reviews.llvm.org/D7606
Files:
lib/Sema/Sema.cpp
lib/Sema/SemaCast.cpp
test/CodeGen/address-space-explicit-cast.c
Index: test/CodeGen/address-space-explicit-cast.c
Alexander_Droste added inline comments.
Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:586
@@ +585,3 @@
+return "";
+ return nd->getName();
+}
Isn't calling `getDecl()` and `getName()` afterwards identical to
`printPretty()`?
Is it possible that a `NamedD
davidxl updated this revision to Diff 44127.
davidxl added a comment.
Update patch to reduce overhead: Only record names for unused functions.
http://reviews.llvm.org/D15853
Files:
lib/CodeGen/CodeGenPGO.cpp
lib/CodeGen/CoverageMappingGen.cpp
lib/CodeGen/CoverageMappingGen.h
Index: lib/C
LegalizeAdulthood added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:4283
@@ +4282,3 @@
+ EXPECT_TRUE(matches("void f(int i);", functionProtoType()));
+ EXPECT_TRUE(matches("void f();", functionProtoType(parameterCountIs(0;
+ EXPECT_TRUE(notMatches
jhen updated this revision to Diff 44131.
jhen added a reviewer: jlebar.
jhen removed a subscriber: jlebar.
jhen added a comment.
- Correct dependence info in CUDA kernel call AST
This patch removes the propagation of type and value dependence and the
propagation of information on unexpanded p
jlebar added inline comments.
Comment at: lib/Driver/ToolChains.cpp:4125
@@ +4124,3 @@
+ ArgStringList &LDArgs) const {
+ if (DriverArgs.hasArg(options::OPT_nocudalib) || !CudaInstallation.isValid())
+return;
tra wrote:
> I'd rena
Author: ab
Date: Wed Jan 6 12:43:14 2016
New Revision: 256956
URL: http://llvm.org/viewvc/llvm-project?rev=256956&view=rev
Log:
Bump DiagnosticDriverKinds count; we're close to hitting it.
$ grep '= DIAG_START_DRIVER' include/clang/Basic/DiagnosticIDs.h
DIAG_START_FRONTEND = DIAG_ST
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
Looks sane to me, although I have no idea what I'm doing here; you should
probably get someone else's approval.
http://reviews.llvm.org/D15858
_
thakis created this revision.
thakis added a reviewer: rtrieu.
thakis added a subscriber: cfe-commits.
Every time I try this warning, it finds a few bugs (I think about 4 total in
Chromium so far), with 0 false positives. I couldn't measure any build
performance degradation when turning it on; I
jhen added inline comments.
Comment at: test/SemaCUDA/kernel-call.cu:27
@@ -26,1 +26,3 @@
+
+ g1<<>>(42); // expected-error {{use of undeclared identifier
'undeclared'}}
}
Thanks for bringing this up. While trying to find tests that dealt with each
dependence
joker.eph added a subscriber: joker.eph.
Comment at: include/clang/Basic/SourceManager.h:660
@@ -659,1 +659,3 @@
+ bool MainFileIsHeader = false;
+
Document?
Comment at: include/clang/Basic/SourceManager.h:764
@@ -761,1 +763,3 @@
+ void set
Author: nico
Date: Wed Jan 6 13:13:49 2016
New Revision: 256960
URL: http://llvm.org/viewvc/llvm-project?rev=256960&view=rev
Log:
Fix -Wdocumentation warning after r256933
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h
URL:
http://llvm.o
rsmith added a subscriber: rsmith.
Comment at: include/clang/AST/ExprCXX.h:175
@@ +174,3 @@
+ void setConfig(CallExpr *E) {
+setPreArg(CONFIG, E);
+setInstantiationDependent(isInstantiationDependent() ||
Can you assert that the argument is only set once h
zaks.anna added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:309
@@ -286,1 +308,3 @@
+ /// \brief Returns true if the CallEvent is call to a function that matches
+ /// the CallDescription.
"is call" -> "is a ca
jhen marked 2 inline comments as done.
jhen added a comment.
http://reviews.llvm.org/D15858
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: adrian
Date: Wed Jan 6 13:22:19 2016
New Revision: 256962
URL: http://llvm.org/viewvc/llvm-project?rev=256962&view=rev
Log:
Module debugging: Defer emitting tag types until their definition
was visited and all decls have been merged.
We only get a single chance to emit the types for virt
Author: adrian
Date: Wed Jan 6 13:22:23 2016
New Revision: 256963
URL: http://llvm.org/viewvc/llvm-project?rev=256963&view=rev
Log:
Fix a typo.
Modified:
cfe/trunk/test/Modules/Inputs/DebugCXX.h
Modified: cfe/trunk/test/Modules/Inputs/DebugCXX.h
URL:
http://llvm.org/viewvc/llvm-project/cfe
zaks.anna added a comment.
> This patch also fixes a bug in 'RangeSet::pin' causing single value ranges to
> not be considered conventionally ordered.
Can that fix be submitted as a separate patch? Is there a test for it?
Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:35
> On Jan 5, 2016, at 6:56 PM, Richard Smith wrote:
>
> On Tue, Jan 5, 2016 at 1:32 PM, Adrian Prantl via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> > On Dec 16, 2015, at 5:19 PM, Bob Wilson via cfe-commits
> > mailto:cfe-commits@lists.llvm.org>> wrote:
> >> On Nov 12, 2015, at
zaks.anna added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/Regions.def:31
@@ +30,3 @@
+// is both instantiated and derived from.
+// Additionally, its kind is not its name with "Kind" suffix,
+// unlike all other regions.
NoQ wrot
zaks.anna added a comment.
What was the last outstanding issue with this patch (I believe it was related
to either make or cmake changes)?
Has it been addressed?
Repository:
rL LLVM
http://reviews.llvm.org/D15611
___
cfe-commits mailing list
cf
Author: djg
Date: Wed Jan 6 13:43:32 2016
New Revision: 256967
URL: http://llvm.org/viewvc/llvm-project?rev=256967&view=rev
Log:
[WebAssembly] Add --gc-sections to the link line.
This will eventually be accompanied with a change to enable -ffunction-sections
and -fdata-sections by default, which
aaron.ballman added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:4283
@@ +4282,3 @@
+ EXPECT_TRUE(matches("void f(int i);", functionProtoType()));
+ EXPECT_TRUE(matches("void f();", functionProtoType(parameterCountIs(0;
+ EXPECT_TRUE(notMatchesC("v
jhen updated this revision to Diff 44143.
jhen added a comment.
- Assert setConfig only called once
http://reviews.llvm.org/D15858
Files:
include/clang/AST/ExprCXX.h
test/SemaCUDA/kernel-call.cu
Index: test/SemaCUDA/kernel-call.cu
===
jhen marked an inline comment as done.
Comment at: test/SemaCUDA/kernel-call.cu:27
@@ -26,1 +26,3 @@
+
+ g1<<>>(42); // expected-error {{use of undeclared identifier
'undeclared'}}
}
rsmith wrote:
> jhen wrote:
> > Thanks for bringing this up. While trying to f
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
Per discussion in D15596.
http://reviews.llvm.org/D15933
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains.cpp
test/Driver/cuda-detect.cu
Index: test/Driver/cuda-detect.cu
==
jlebar updated this revision to Diff 44145.
jlebar added a dependency: D15933: Rename -nocudalib to -nocudalibdevice..
jlebar added a comment.
Now also pass -lcudart_static -lcuda -ldl -lrt -pthread for CUDA compiles.
Depends on http://reviews.llvm.org/D15933.
http://reviews.llvm.org/D15596
Fi
rtrieu accepted this revision.
rtrieu added a comment.
This revision is now accepted and ready to land.
LGTM
The most complex things these warnings use is an AST visitor, so the compile
time impact should be minimal.
http://reviews.llvm.org/D15928
___
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
LGTM as well, FWIW
http://reviews.llvm.org/D15928
___
cfe-commits mailing list
cfe-c
jlebar marked an inline comment as done.
jlebar added a comment.
Done, please have another look.
http://reviews.llvm.org/D15596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D15933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Wed Jan 6 14:55:00 2016
New Revision: 256975
URL: http://llvm.org/viewvc/llvm-project?rev=256975&view=rev
Log:
Add -Wfor-loop-analysis to -Wall.
This warning seems to have 0 false positives and some true positives in
practice, without a measurable compile time cost. It should
thakis closed this revision.
thakis added a comment.
r256975, thanks!
http://reviews.llvm.org/D15928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rtrieu
Date: Wed Jan 6 15:11:18 2016
New Revision: 256976
URL: http://llvm.org/viewvc/llvm-project?rev=256976&view=rev
Log:
Improve conditional checking during template instantiation.
When the condition in an if statement, while statement, or for loop is created
during template instantia
Author: kparzysz
Date: Wed Jan 6 15:12:03 2016
New Revision: 256977
URL: http://llvm.org/viewvc/llvm-project?rev=256977&view=rev
Log:
[Hexagon] Treat -march and -mcpu as equivalent
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
Modified: cfe/trunk/lib/Driver/ToolChains.cpp
URL:
http://llvm.
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, dblaikie.
aaron.ballman added a subscriber: cfe-commits.
This patch improves the literal conversion diagnostics where the target type is
a Boolean by handling literals more consistently, and telling the user whether
the
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
Use llvm::make_unique, std::all_of, std::find, etc.
No functional changes.
Prerequisite for further changes to Driver.
http://reviews.llvm.org/D15936
Files:
lib/Driver/Driver.cpp
Index: lib/D
Author: kparzysz
Date: Wed Jan 6 15:27:42 2016
New Revision: 256978
URL: http://llvm.org/viewvc/llvm-project?rev=256978&view=rev
Log:
[Hexagon] Expand -mvN to -mcpu=hexagonvN
Modified:
cfe/trunk/include/clang/Driver/Options.td
Modified: cfe/trunk/include/clang/Driver/Options.td
URL:
http:/
jlebar updated this revision to Diff 44154.
jlebar added a dependency: D15911: Switch Action and ActionList over to using
std::shared_ptr..
jlebar added a comment.
Rebasing onto http://reviews.llvm.org/D15911.
Depends on http://reviews.llvm.org/D15911.
http://reviews.llvm.org/D15936
Files:
jlebar updated this revision to Diff 44155.
jlebar added a comment.
Fix rebase conflict.
http://reviews.llvm.org/D15936
Files:
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Driver.cpp
+++ lib/Driver/Drive
tra added inline comments.
Comment at: include/clang/Driver/Options.td:1636
@@ -1635,1 +1635,3 @@
+def nocudalib : Flag<["-"], "nocudalib">,
+ HelpText<"Don't include libraries necessary for running CUDA
(-L/path/to/cuda/lib{,64} -lcudart_static -lrt -lpthread -ldl)">;
def nocu
Author: rsmith
Date: Wed Jan 6 15:54:29 2016
New Revision: 256979
URL: http://llvm.org/viewvc/llvm-project?rev=256979&view=rev
Log:
Fix half of PR26048. We don't yet diagnose the case where the anonymous union
member is declared first and the tag name is declared second.
Added:
cfe/trunk/te
jlebar updated this revision to Diff 44156.
jlebar marked 4 inline comments as done.
jlebar added a comment.
Address tra's review comments.
http://reviews.llvm.org/D15596
Files:
include/clang/Driver/Options.td
include/clang/Driver/ToolChain.h
lib/Driver/ToolChain.cpp
lib/Driver/ToolChai
> On Jan 6, 2016, at 1:54 PM, Richard Smith via cfe-commits
> wrote:
>
> Author: rsmith
> Date: Wed Jan 6 15:54:29 2016
> New Revision: 256979
>
> URL: http://llvm.org/viewvc/llvm-project?rev=256979&view=rev
> Log:
> Fix half of PR26048. We don't yet diagnose the case where the anonymous unio
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Driver/Driver.cpp:1300
@@ -1299,5 +1299,3 @@
for (Arg *A : Args) {
-if (A->getOption().matches(options::OPT_cuda_gpu_arch_EQ)) {
- A->claim();
-
jlebar added a comment.
Updated code; please have a look.
Comment at: include/clang/Driver/Options.td:1636
@@ -1635,1 +1635,3 @@
+def nocudalib : Flag<["-"], "nocudalib">,
+ HelpText<"Don't include libraries necessary for running CUDA
(-L/path/to/cuda/lib{,64} -lcudart_static
rsmith added inline comments.
Comment at: include/clang/AST/ExprCXX.h:181
@@ +180,3 @@
+assert(
+!IsConfigSet &&
+"CUDAKernelCallExpr.setConfig can only be called once per instance.");
Perhaps `assert(!getPreArg(CONFIG))` instead of storing a s
jlebar updated this revision to Diff 44158.
jlebar added a comment.
Address tra's review comments.
http://reviews.llvm.org/D15936
Files:
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Driver.cpp
+++ lib/Dr
jlebar marked an inline comment as done.
jlebar added a comment.
http://reviews.llvm.org/D15936
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar updated this revision to Diff 44160.
jlebar added a comment.
Adding back testcase that ensures that our flags are added after user flags.
http://reviews.llvm.org/D15596
Files:
include/clang/Driver/Options.td
include/clang/Driver/ToolChain.h
lib/Driver/ToolChain.cpp
lib/Driver/Too
jlebar added inline comments.
Comment at: lib/Driver/ToolChains.cpp:4129-4137
@@ -4123,4 +4128,11 @@
+ LDArgs.push_back("-L");
+ LDArgs.push_back(DriverArgs.MakeArgString(CudaInstallation.getLibPath()));
+ for (const char *Flag : {"-lcudart_static", "-ldl", "-lrt", "-lpthread"}
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Minor nit, but looks good otherwise.
Comment at: include/clang/Driver/Options.td:1636
@@ -1635,1 +1635,3 @@
+def nocudalib : Flag<["-"], "nocudalib">,
+ HelpText<"Don't link with l
Author: rjmccall
Date: Wed Jan 6 16:34:54 2016
New Revision: 256983
URL: http://llvm.org/viewvc/llvm-project?rev=256983&view=rev
Log:
Only instantiate a default argument once.
By storing the instantiated expression back in the ParmVarDecl,
we remove the last need for separately storing the sub-e
aaron.ballman added a comment.
Sorry for the delay in reviewing this!
In terms of a test case, presumably you need this because a diagnostic location
is incorrect -- would it be possible to write the exception specification such
that it is on its own line, and then expect-warning|error|note on
Author: rsmith
Date: Wed Jan 6 16:49:11 2016
New Revision: 256985
URL: http://llvm.org/viewvc/llvm-project?rev=256985&view=rev
Log:
PR26048, PR26050: put non-type template parameters and indirect field decls
into IDNS_Tag in C++, because they conflict with redeclarations of tags. (This
doesn't af
jhen added inline comments.
Comment at: include/clang/AST/ExprCXX.h:181
@@ +180,3 @@
+assert(
+!IsConfigSet &&
+"CUDAKernelCallExpr.setConfig can only be called once per instance.");
rsmith wrote:
> Perhaps `assert(!getPreArg(CONFIG))` instead
jhen updated this revision to Diff 44167.
jhen added a comment.
- Use config ptr itself rather than boolean flag
http://reviews.llvm.org/D15858
Files:
include/clang/AST/ExprCXX.h
lib/AST/Expr.cpp
test/SemaCUDA/kernel-call.cu
Index: test/SemaCUDA/kernel-call.cu
===
jlebar updated this revision to Diff 44170.
jlebar marked 2 inline comments as done.
jlebar added a comment.
Address tra's review comments.
http://reviews.llvm.org/D15596
Files:
include/clang/Driver/Options.td
include/clang/Driver/ToolChain.h
lib/Driver/ToolChain.cpp
lib/Driver/ToolChai
jlebar added inline comments.
Comment at: include/clang/Driver/Options.td:1636
@@ -1635,1 +1635,3 @@
+def nocudalib : Flag<["-"], "nocudalib">,
+ HelpText<"Don't link with libraries necessary for running CUDA
(-L/path/to/cuda/lib{,64} -lcudart_static -lrt -lpthread -ldl)">;
def
loladiro added a comment.
Bumping this again.
http://reviews.llvm.org/D13330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a comment.
I'm unconvinced this meets the bar for an on-by-default warning. Your suggested
workaround for correct-but-diagnosed code doesn't seem to work: if I have
struct X {
X(const volatile X&);
};
... adding
X(const X&) = delete;
or a private "normal" copy construct
Author: rjmccall
Date: Wed Jan 6 17:34:20 2016
New Revision: 256996
URL: http://llvm.org/viewvc/llvm-project?rev=256996&view=rev
Log:
Properly bind up any cleanups in an ExprWithCleanups after
instantiating a default argument expression.
This was previously just working implicitly by reinstantia
On Wed, Jan 06, 2016 at 07:43:32PM -, Dan Gohman via cfe-commits wrote:
> Author: djg
> Date: Wed Jan 6 13:43:32 2016
> New Revision: 256967
>
> URL: http://llvm.org/viewvc/llvm-project?rev=256967&view=rev
> Log:
> [WebAssembly] Add --gc-sections to the link line.
Can you make sure it is add
jlebar created this revision.
jlebar added reviewers: tra, echristo.
jlebar added a subscriber: cfe-commits.
Currently this arg is unused; a use is added in D15596.
http://reviews.llvm.org/D15939
Files:
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
=
On Wed, Jan 6, 2016 at 3:34 PM, John McCall via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rjmccall
> Date: Wed Jan 6 17:34:20 2016
> New Revision: 256996
>
> URL: http://llvm.org/viewvc/llvm-project?rev=256996&view=rev
> Log:
> Properly bind up any cleanups in an ExprWithCleanups
jlebar updated this revision to Diff 44178.
jlebar added a comment.
Split out the bits adding an arg to AddLinkerInputs into a separate patch,
http://reviews.llvm.org/D15939.
http://reviews.llvm.org/D15596
Files:
include/clang/Driver/Options.td
include/clang/Driver/ToolChain.h
lib/Driver
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D15939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> On Jan 6, 2016, at 3:54 PM, Richard Smith wrote:
> On Wed, Jan 6, 2016 at 3:34 PM, John McCall via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: rjmccall
> Date: Wed Jan 6 17:34:20 2016
> New Revision: 256996
>
> URL: http://llvm.org/viewvc/llvm-project?rev=256996&view=re
tra added inline comments.
Comment at: lib/Driver/Tools.cpp:276
@@ +275,3 @@
+
+ // Add -L/path/to/cuda/lib if any of our inputs are .cu files.
+ if (std::any_of(C.getActions().begin(), C.getActions().end(), isCudaAction))
It just struck me that this patch may n
bruno updated this revision to Diff 44180.
bruno added a comment.
Hi Richard,
Thanks for the comments. Updated the patch!
In http://reviews.llvm.org/D15173#313235, @rsmith wrote:
> I think that this will leave us with a broken token stream. In your example,
> the cached token stream starts as
jlebar abandoned this revision.
jlebar added a comment.
> It just struck me that this patch may not be as useful as we'd like it to be.
Oh. Yes.
I guess I'll drop this and http://reviews.llvm.org/D15939. :(
http://reviews.llvm.org/D15596
___
cf
jlebar abandoned this revision.
jlebar added a comment.
Per http://reviews.llvm.org/D15596, this actually doesn't help us. Oops.
http://reviews.llvm.org/D15939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
LegalizeAdulthood added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:4992
@@ +4991,3 @@
+ EXPECT_TRUE(matches("typedef int hasUnderlyingTypeTest;",
+ typedefDecl(hasUnderlyingType(asString("int");
+ EXPECT_TRUE(matches("typedef
Author: djg
Date: Wed Jan 6 18:32:04 2016
New Revision: 257004
URL: http://llvm.org/viewvc/llvm-project?rev=257004&view=rev
Log:
[WebAssembly] Only enable --gc-sections when optimizations are enabled.
Also, revamp the wasm-toolchain.c test and add a test to ensure that
a user-supplied --no-gc-se
On Wed, Jan 6, 2016 at 3:53 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Wed, Jan 06, 2016 at 07:43:32PM -, Dan Gohman via cfe-commits wrote:
> > Author: djg
> > Date: Wed Jan 6 13:43:32 2016
> > New Revision: 256967
> >
> > URL: http://llvm.org/viewvc/llvm
Author: djg
Date: Wed Jan 6 18:50:27 2016
New Revision: 257005
URL: http://llvm.org/viewvc/llvm-project?rev=257005&view=rev
Log:
[WebAssembly] Enable -ffunction-sections and -fdata-sections by default.
These remain user-overridable with -fno-function-sections and
-fno-data-sections.
Modified:
Author: djg
Date: Wed Jan 6 19:00:21 2016
New Revision: 257006
URL: http://llvm.org/viewvc/llvm-project?rev=257006&view=rev
Log:
[WebAssembly] Enable -fvisibility=hidden by default.
This, along with many things in the WebAssembly target, is experimental.
Feedback is welcome.
Modified:
cfe/t
dcoughlin added a comment.
Hi Laszlo,
I've run scan-build-py with both environment-variable-based and library-based
interposition on our open source benchmark suite and it looks like it is in
great shape on Darwin! There are still some remaining issues with xcodebuild,
but I will help fix thes
Author: djg
Date: Wed Jan 6 19:15:05 2016
New Revision: 257007
URL: http://llvm.org/viewvc/llvm-project?rev=257007&view=rev
Log:
[WebAssembly] Add a test to ensure that -fvisibility=default works.
It should override the default of -fvisibility=hidden.
Modified:
cfe/trunk/test/Driver/wasm-to
Author: rsmith
Date: Wed Jan 6 19:17:43 2016
New Revision: 257008
URL: http://llvm.org/viewvc/llvm-project?rev=257008&view=rev
Log:
Improve documentation comments for IdentifierNamespace values.
Modified:
cfe/trunk/include/clang/AST/DeclBase.h
Modified: cfe/trunk/include/clang/AST/DeclBase.
Author: echristo
Date: Wed Jan 6 19:23:12 2016
New Revision: 257009
URL: http://llvm.org/viewvc/llvm-project?rev=257009&view=rev
Log:
Test that we're not forwarding on -g options to the non integrated assembler.
This is adding a test for an old fixed PR to make sure we don't regress.
Modified:
1 - 100 of 118 matches
Mail list logo
