tra added inline comments.

================
Comment at: lib/Driver/Tools.cpp:276
@@ +275,3 @@
+
+  // Add -L/path/to/cuda/lib if any of our inputs are .cu files.
+  if (std::any_of(C.getActions().begin(), C.getActions().end(), isCudaAction))
----------------
It just struck me that this patch may not be as useful as we'd like it to be.

For typical compilation source-to-object and object-to-executable are separate 
phases.
We need these flags during linking phase, but we will rarely see any CUDA 
inputs passed to clang. Most of the time we'll be dealing with .o files and 
will have no way to tell whether those were compiled from CUDA sources. :-(



http://reviews.llvm.org/D15596



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to