EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Accepting. Any additional review can happen post-commit.
http://reviews.llvm.org/D13750
___
cfe-commits mailing
Author: ericwf
Date: Wed Dec 23 02:20:26 2015
New Revision: 256325
URL: http://llvm.org/viewvc/llvm-project?rev=256325&view=rev
Log:
[libcxx] Fix LWG Issue #2367 - Fixing std::tuple and std::pair's default
constructors.
Summary: This patch implements the solution for LWG Issue #2367. See
http:/
Author: abataev
Date: Wed Dec 23 04:27:45 2015
New Revision: 256330
URL: http://llvm.org/viewvc/llvm-project?rev=256330&view=rev
Log:
[OPENMP 4.5] Parsing/sema for 'depend(sink:vec)' clause in 'ordered' directive.
OpenMP 4.5 adds 'depend(sink:vec)' in 'ordered' directive for doacross loop
synchro
faisalv added a comment.
*ping*
http://reviews.llvm.org/D15005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek created this revision.
klimek added a reviewer: rsmith.
klimek added a subscriber: cfe-commits.
Covers significantly more code in the template template pack argument
test and fixes the resulting assert problem.
http://reviews.llvm.org/D15743
Files:
lib/Sema/TreeTransform.h
test/SemaTe
alexfh added a comment.
Thank you for the fix. See the comments inline.
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:493
@@ +492,3 @@
+const ast_matchers::MatchFinder::MatchResult &Result, SourceRange Range) {
+ CharSourceRange CharRange = Lexer::makeFile
myatsina created this revision.
myatsina added reviewers: rnk, mcrosier.
myatsina added subscribers: llvm-commits, cfe-commits.
myatsina set the repository for this revision to rL LLVM.
Test case for review:
http://reviews.llvm.org/D15748
Repository:
rL LLVM
http://reviews.llvm.org/D15749
Fi
It appears the reason it was only caught on Windows was that only Windows
appends ".exe" to executable files. Your change to match lld with {{.*}}
appended fixes it. Thanks!
Dan
On Tue, Dec 22, 2015 at 2:34 PM, Nico Weber wrote:
> This might have broken the test on Windows:
>
> Command 1 Stder
It looks like the two Windows buildbots for clang on that page are already
red for other reasons.
Dan
On Tue, Dec 22, 2015 at 2:54 PM, Nico Weber wrote:
> Well yes, but we have a Windows bot on http://lab.llvm.org:8011/console,
> right?
>
> On Tue, Dec 22, 2015 at 5:54 PM, Dan Gohman wrote:
>
mcrosier accepted this revision.
mcrosier added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D15749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
hokein updated this revision to Diff 43544.
hokein added a comment.
Update patch to address review comments.
http://reviews.llvm.org/D15710
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/DefinitionsInHeadersCheck.cpp
clang-tidy/misc/DefinitionsInHeadersCheck.h
clang-tidy/misc/Mis
hokein marked 9 inline comments as done.
Comment at: clang-tidy/google/DefinitionsInHeadersCheck.cpp:52
@@ +51,3 @@
+// Inline function is allowed.
+if (funDecl->isInlined())
+ return;
alexfh wrote:
> This check can be done in the matcher.
The `isInli
hokein added a comment.
@alexfh The case of member function of a nest class in a class template (like
`int A::B::fun() {...}`) is also fixed now. Please review the patch again.
Thanks.
http://reviews.llvm.org/D15710
___
cfe-commits mailing list
c
Author: djasper
Date: Wed Dec 23 12:01:29 2015
New Revision: 256342
URL: http://llvm.org/viewvc/llvm-project?rev=256342&view=rev
Log:
clang-format: Fix incorrect pointer detection.
Before:
return * this += 1;
After:
return *this += 1;
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
Author: djasper
Date: Wed Dec 23 12:01:43 2015
New Revision: 256343
URL: http://llvm.org/viewvc/llvm-project?rev=256343&view=rev
Log:
clang-format: Lower penalty for breaking between array subscripts.
Before:
a[aaa()][bbb(
)]
ygao added a comment.
Hi Rafael,
Yes I can do that, and it works for me. Do you know whether there is a way to
keep the UNIX line ending on the test file upon checkout rather than having svn
or git auto-translate the line endings? The UNIX line ending is necessary to
trigger the original bug,
ygao updated this revision to Diff 43554.
ygao added a comment.
I think what I can do is to run
svn propset svn:eol-style 'LF'
on the new file, and hopefully the subversion or git client will get the hint
and not auto-translate the line endings.
http://reviews.llvm.org/D15705
Files:
test/Pre
Author: yrnkrn
Date: Wed Dec 23 14:38:13 2015
New Revision: 256349
URL: http://llvm.org/viewvc/llvm-project?rev=256349&view=rev
Log:
Replace isa+cast with dyn_cast and obey the no else after return rule.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL
Are you sure the line ending in a problem? The preprocessor output has
16 lines, but the last one is very long.
In any case, it looks like at least on linux clang produces an output
with '\n' even when the input has CRLF:
$ file test.c
test.c: ASCII text, with CRLF line terminators
$ clang -E tes
ygao added a comment.
If you take a look at
void PrintPreprocessedAction::ExecuteAction() {
...
while (next < end) {
if (*cur == 0x0D) { // CR
if (*next == 0x0A) // CRLF
BinaryMode = false;
...
The value of this BinaryMode reflects whethe
Gosh, that is quite unfortunate. The problems I see are
* The code only work on windows, as opening a file as text on other
systems is not special.
* There is a confusion in the code about binary being "crlf
translation" or "produce a .o". The logic for creating a buffer is
there because the .o wr
Author: ctopper
Date: Wed Dec 23 20:55:45 2015
New Revision: 256358
URL: http://llvm.org/viewvc/llvm-project?rev=256358&view=rev
Log:
[StaticAnalyzer] Use front() and back() instead of dereferencing begin() and
rbegin(). Makes the code a little cleaner. NFC
Modified:
cfe/trunk/lib/StaticAnal
Author: jyknight
Date: Wed Dec 23 20:59:37 2015
New Revision: 256359
URL: http://llvm.org/viewvc/llvm-project?rev=256359&view=rev
Log:
[TrailingObjects] Convert ASTTemplateKWAndArgsInfo and
ASTTemplateArgumentListInfo.
Doing so required separating them so that the former doesn't inherit
from the
23 matches
Mail list logo
