Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

rjmccall added a comment. I don't understand why that's true. buildSet is called with captureSetValueAsResult=true, and the set value is definitely capturable, so that value should be set as the result; and you're not overriding it. Why does the expression end up having type void? http://re

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

rjmccall added a reviewer: akyrtzi. Comment at: lib/AST/ASTContext.cpp:5424 @@ -5410,1 +5423,3 @@ +// FIXME: need to figure out what this is for __float128 +case BuiltinType::Float128: return 'K'; case BuiltinType::NullPtr:return '*'; // like char* -

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

Set value is a call to SetX() function, neither the argument of the SetX(), nor the result of the GetX(). So, expression a.x=5 always emits the following code as a result a.Setx(5). MSPropertyRefBuilder::buildSet() does not capture results at all. It just ignores captureSetValueAsResult value

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

danielmarjamaki marked 2 inline comments as done. danielmarjamaki added a comment. In http://reviews.llvm.org/D13126#302647, @dcoughlin wrote: > In http://reviews.llvm.org/D13126#302328, @danielmarjamaki wrote: > > > When scanning 692 projects with this checker I got 56 warnings. I've > > triage

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

labrinea updated this revision to Diff 42035. labrinea added a comment. ASM tests have been removed. http://reviews.llvm.org/D15223 Files: test/CodeGen/aarch64-v8.1a-neon-intrinsics.c test/CodeGen/arm-v8.1a-neon-intrinsics.c Index: test/CodeGen/arm-v8.1a-neon-intrinsics.c =

Re: [PATCH] D12726: [analyzer] A fix for symbolic element region index lifetime.

NoQ added a comment. In http://reviews.llvm.org/D12726#303122, @zaks.anna wrote: > > So the real question is whether (or rather how) the Store should maintain > > correct region liveness information > > > after completing its internal garbage collection pass, because there are, > > in fact, o

r254899 - [OPENMP 4.5] parsing/sema support for 'nogroup' clause.

Author: abataev Date: Mon Dec 7 04:51:44 2015 New Revision: 254899 URL: http://llvm.org/viewvc/llvm-project?rev=254899&view=rev Log: [OPENMP 4.5] parsing/sema support for 'nogroup' clause. OpenMP 4.5 adds 'taskloop' and 'taskloop simd' directives. These directives have new 'nogroup' clause. Patc

Re: [PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

kubabrecka updated this revision to Diff 42041. kubabrecka added a comment. Applying clang-format. http://reviews.llvm.org/D15225 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/ToolChain.h lib/Driver/SanitizerArgs.cpp lib/Driver/ToolChain.cpp lib/Driver/ToolC

[PATCH] D15283: [ARMv8-M] Add Clang targeting for ARMv8-M Baseline/Mainline

bsmith created this revision. bsmith added a reviewer: t.p.northover. bsmith added a subscriber: cfe-commits. bsmith set the repository for this revision to rL LLVM. Herald added subscribers: rengolin, aemerson. This patch forms part of the ARMv8-M Baseline/Mainline support, adding Clang targetin

Re: [PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

kubabrecka added a comment. > The one thing I'm not sure about on this is, do we really want this to be > darwin-only? I kinda think it might be nice if we unified this behavior > across all platforms. > ... I wonder if this can't be better abstracted. > I'd really like to see all operating

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

alexfh added a comment. Before I can tell you whether this checker makes sense as a clang-tidy check, can you please explain to me (don't want to deduce this from the code) what specific issues does this check target? Is this limited to a set of AST patterns or is there (or is going to be) some

r254903 - [OPENMP 4.5] parsing/sema support for 'grainsize' clause.

Author: abataev Date: Mon Dec 7 06:52:51 2015 New Revision: 254903 URL: http://llvm.org/viewvc/llvm-project?rev=254903&view=rev Log: [OPENMP 4.5] parsing/sema support for 'grainsize' clause. OpenMP 4.5 adds 'taksloop' and 'taskloop simd' directives, which have 'grainsize' clause. Patch adds pars

r254906 - [avx512] rename gcc intrinsics to be align with gcc format

Author: abadouh Date: Mon Dec 7 07:14:22 2015 New Revision: 254906 URL: http://llvm.org/viewvc/llvm-project?rev=254906&view=rev Log: [avx512] rename gcc intrinsics to be align with gcc format rename the gcc intrinsics suffix : _mask ->_round Differential Revision: http://reviews.llvm.org/D15284

Re: [PATCH] D15251: [Clang] Use range loops and autos in lib/Serialization/ASTReader.cpp

aaron.ballman added inline comments. Comment at: lib/Serialization/ASTReader.cpp:3390 @@ -3393,5 +3389,3 @@ Mod->getExportedModules(Exports); -for (SmallVectorImpl::iterator - I = Exports.begin(), E = Exports.end(); I != E; ++I) { - Module *Exported = *I; +

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please wait for David to sign off before committing. http://reviews.llvm.org/D13330 ___ cfe-commits mailing list cfe-comm

Re: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

On Thu, Dec 03, 2015 at 01:36:22AM -, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Wed Dec 2 19:36:22 2015 > New Revision: 254574 > > URL: http://llvm.org/viewvc/llvm-project?rev=254574&view=rev > Log: > PR17381: Treat undefined behavior during expression evaluation as an unm

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

tejohnson updated this revision to Diff 42069. tejohnson added a comment. - Rename -fthinlto-backend to -fthinlto-index as per review and IRC. http://reviews.llvm.org/D15025 Files: include/clang/CodeGen/BackendUtil.h include/clang/Driver/Options.td include/clang/Driver/Types.h include/c

Re: [PATCH] D15220: [OPENMP] dist_schedule clause for distribute directive

carlo.bertolli updated this revision to Diff 42070. carlo.bertolli added a comment. Added regression test. Repository: rL LLVM http://reviews.llvm.org/D15220 Files: include/clang/AST/OpenMPClause.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/OpenMPKinds.def include/cl

Re: [PATCH] D13731: [Analyzer] Supporting function attributes in .model files.

pgousseau added a comment. In http://reviews.llvm.org/D13731#302989, @zaks.anna wrote: > Pierre, > > Have you seen the post about API Notes? > http://llvm.cc/t/cfe-dev-clang-and-swift/331 > > I believe using API notes would be a better approach for adding annotations. > By the time the static a

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

joker.eph accepted this revision. joker.eph added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D15025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

zaks.anna added a comment. This patch contains a mix of checks, some are path sensitive and some are AST checks. See MPICheckerAST.cpp for the latter. http://reviews.llvm.org/D12761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

majnemer added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1736-1755 @@ -1722,2 +1735,22 @@ + +// Explicit template definition (in exactly ONE .cpp file) +template struct __attribute__((unique_instantiation)) my_template; + + +When the unique_instantiation

[PATCH] D15293: [OpenCL] Correct NULL constant handling after applying default AS

Anastasia created this revision. Anastasia added a reviewer: pekka.jaaskelainen. Anastasia added a subscriber: cfe-commits. In OpenCL2.0 s6.5 all pointers are implicitly in generic address space unless address space is explicitly specified. Correct the behavior of NULL constant detection - gener

Re: [PATCH] D14441: [OpenCL] Pipe types support.

Anastasia added a comment. I've made a few small comments. Don't see any reply though. http://reviews.llvm.org/D14441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: [Patch][OpenCL] Custom atomic Builtin check ignores address space of a non-atomic pointer

Could someone jump in, please! I have made a small improvement in testing after the patch has been first approved by Pekka. The last change is essentially this: Index: test/CodeGen/atomic-ops.c === --- test/CodeGen/atomic-ops.c (

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1736-1755 @@ -1722,2 +1735,22 @@ + +// Explicit template definition (in exactly ONE .cpp file) +template struct __attribute__((unique_instantiation)) my_template; + + +When the unique_instantiation

LLVM buildmaster outage during the weekend

Hello everyone, There was LLVM buildmaster outage during the weekend. Sorry about this. It seems llvm lab outgrow consumer-grade router and should be updated later or sooner. I will look more at this what could be done about this. Thanks Galina ___ cfe

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno added a comment. Ping! http://reviews.llvm.org/D15173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

samsonov added inline comments. Comment at: include/clang/Driver/ToolChain.h:410 @@ -407,1 +409,3 @@ + /// (don't require runtime library). + virtual SanitizerMask getSanitizersRequiringTrap() const; }; I don't think this is relevant to ToolChain at all. `Sanit

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

> On Dec 7, 2015, at 12:16 AM, John McCall wrote: > > rjmccall added a reviewer: akyrtzi. > > > Comment at: lib/AST/ASTContext.cpp:5424 > @@ -5410,1 +5423,3 @@ > +// FIXME: need to figure out what this is for __float128 > +case BuiltinType::Float128: return 'K'; >

Re: [PATCH] D15223: [ARM] [AARCH64] Add CodeGen IR tests for {VS}QRDML{AS}H v8.1a intrinsics.

echristo added a comment. One inline comment, thanks! -eric Comment at: test/CodeGen/aarch64-v8.1a-neon-intrinsics.c:4 @@ -3,4 +3,3 @@ // RUN: %clang_cc1 -triple aarch64-linux-gnu -target-feature +neon \ -// RUN: -target-feature +v8.1a -O3 -S -o - %s \ -// RUN: | FileCheck %

Re: [PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

kubabrecka added inline comments. Comment at: test/Driver/fsanitize.c:221 @@ +220,3 @@ +// RUN: %clang -target x86_64-apple-darwin10 -resource-dir=%S/Inputs/resource_dir -fsanitize=memory -fsanitize=thread,memory %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-MSAN-TSAN-MSAN-DA

r254927 - [ThinLTO] Option to invoke ThinLTO backend passes and importing

Author: tejohnson Date: Mon Dec 7 13:21:34 2015 New Revision: 254927 URL: http://llvm.org/viewvc/llvm-project?rev=254927&view=rev Log: [ThinLTO] Option to invoke ThinLTO backend passes and importing Summary: Adds new option -fthinlto-index= to invoke the LTO pipeline along with function importin

Re: [PATCH] D15025: [ThinLTO] Option to invoke ThinLTO backend passes and importing

This revision was automatically updated to reflect the committed changes. Closed by commit rL254927: [ThinLTO] Option to invoke ThinLTO backend passes and importing (authored by tejohnson). Changed prior to commit: http://reviews.llvm.org/D15025?vs=42069&id=42084#toc Repository: rL LLVM htt

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

rjmccall added a comment. Oh, I see, of course. It would be clearer if you asked the subclass which value to use abstractly (i.e. independently of the actual set expression) and then passed down captureSetValueAsResult=false when the subclass says to use the setter result. http://reviews.llvm

r254933 - clang-format: Make wrapping after "./->" cheaper, even if the element

Author: djasper Date: Mon Dec 7 13:50:48 2015 New Revision: 254933 URL: http://llvm.org/viewvc/llvm-project?rev=254933&view=rev Log: clang-format: Make wrapping after "./->" cheaper, even if the element before it is not a closing parenthesis. Otherwise, this frequently leads to "hanging" indents

Re: [PATCH] D15251: [Clang] Use range loops and autos in lib/Serialization/ASTReader.cpp

Eugene.Zelenko removed rL LLVM as the repository for this revision. Eugene.Zelenko updated this revision to Diff 42087. Eugene.Zelenko added a comment. I fixed two loops and don't use auto instead of bool. Auto is also used for results of new. http://reviews.llvm.org/D15251 Files: lib/Serial

Re: [PATCH] D15251: [Clang] Use range loops and autos in lib/Serialization/ASTReader.cpp

Eugene.Zelenko added inline comments. Comment at: lib/Serialization/ASTReader.cpp:5074 @@ -5087,3 +5073,3 @@ bool operator()(ModuleFile &M) { - HeaderFileInfoLookupTable *Table + auto *Table = static_cast(M.HeaderFileInfoTable); I don't thi

r254935 - AST: defer to TypeLoc::copy in TypeLoc::initializeFullCopy

Author: bogner Date: Mon Dec 7 14:04:57 2015 New Revision: 254935 URL: http://llvm.org/viewvc/llvm-project?rev=254935&view=rev Log: AST: defer to TypeLoc::copy in TypeLoc::initializeFullCopy If we're initializing a TypeLoc from one that's been allocated with different alignment, memcpy will get

Re: [PATCH] D15251: [Clang] Use range loops and autos in lib/Serialization/ASTReader.cpp

aaron.ballman added inline comments. Comment at: lib/Serialization/ASTReader.cpp:5074 @@ -5087,3 +5073,3 @@ bool operator()(ModuleFile &M) { - HeaderFileInfoLookupTable *Table + auto *Table = static_cast(M.HeaderFileInfoTable); Eugene.Zelen

r254938 - Adjust test to fix bot error from r254927.

Author: tejohnson Date: Mon Dec 7 14:26:57 2015 New Revision: 254938 URL: http://llvm.org/viewvc/llvm-project?rev=254938&view=rev Log: Adjust test to fix bot error from r254927. Remove the part of the error message that may vary across systems. Modified: cfe/trunk/test/CodeGen/thinlto_backe

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

Hi Bruno, > On Dec 2, 2015, at 7:29 PM, Bruno Cardoso Lopes > wrote: > > bruno created this revision. > bruno added reviewers: doug.gregor, akyrtzi. > bruno added subscribers: cfe-commits, dexonsmith. > > Consider the following ObjC++ snippet: > > @protocol PA; > @protocol PB; > > @class

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

akyrtzi added a subscriber: akyrtzi. akyrtzi added a comment. Hi Bruno, http://reviews.llvm.org/D15173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14980: PR18513: make gcc compatible layout for bit-fields with explicit aligned attribute

DmitryPolukhin added a comment. Added TODO, any other comments or suggestions? http://reviews.llvm.org/D14980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r254940 - Remove target specifier from new tests

Author: tejohnson Date: Mon Dec 7 14:40:36 2015 New Revision: 254940 URL: http://llvm.org/viewvc/llvm-project?rev=254940&view=rev Log: Remove target specifier from new tests Hopefully fix the remaining bot failure from r254927. Remove target specification since it shouldn't be needed, and this c

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno added a comment. Hi Argyrios, Thanks for the suggestions, will apply them. The assertion seems important to catch subtle bugs, are you sure it should be placed inside a "#ifndef NDEBUG”? http://reviews.llvm.org/D15173 ___ cfe-commits mailing

Re: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

On Mon, Dec 7, 2015 at 7:25 AM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, Dec 03, 2015 at 01:36:22AM -, Richard Smith via cfe-commits > wrote: > > Author: rsmith > > Date: Wed Dec 2 19:36:22 2015 > > New Revision: 254574 > > > > URL: http://llvm.org/vie

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro updated this revision to Diff 42100. loladiro added a comment. Address stylistic concerns brought up by David http://reviews.llvm.org/D13330 Files: include/clang/AST/ASTContext.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds

Re: [PATCH] D15005: Fix PR8170: Clang does not check constructor declaration that uses a template-id

faisalv added a comment. *ping* My main question is, does it make sense to suppress diagnostics when checking the template-id, and then rewording it as I do. If it does make sense to suppress and then report a new diagnostic - is my method of suppression a reasonable one (as opposed to SFINAE

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

majnemer added inline comments. Comment at: lib/AST/ASTContext.cpp:8257-8266 @@ -8256,1 +8256,12 @@ +bool ASTContext::containedInUniqueInstantiation(const Decl *D) { + const RecordDecl *RD; + while ((RD = dyn_cast(D->getDeclContext( { +auto *CTSD = dyn_cast(RD); +i

Re: [PATCH] D15005: Fix PR8170: Clang does not check constructor declaration that uses a template-id

majnemer added a subscriber: majnemer. Comment at: lib/Sema/SemaTemplate.cpp:528 @@ +527,3 @@ +[&StringifiedTemplateArgs, this](const TemplateArgument &TA) { +if (const bool IsFirst = !StringifiedTemplateArgs.size()) + StringifiedTemplateArgs = "<"; --

RE: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

Explicitly cc: cfe-commits *again*…. | C11 6.3.1.5/1: "If the value being converted is outside the range of values that can be represented, the behavior is undefined." I think 5.2.4.2.2/5 says if infinities are representable, there are no values "outside" the floating-point ra

[PATCH] D15305: [CUDA] Do not allow dynamic initialization of global device side variables.

tra created this revision. tra added reviewers: rsmith, jingyue, jpienaar. tra added a subscriber: cfe-commits. In general CUDA does not allow dynamic initialization of global device-side variables except for records with empty constructors as described in section [[ http://docs.nvidia.com/cuda/

Fix for Paths with Whitespace

Dear Reviewer, The current doxygen.cfg.in will produce paths that cannot be understood by Doxygen/Graphviz, when any generated paths contain white space. This patch simply adds quotations to all generated paths so that white space cannot be misinterpreted by Doxygen/Graphviz. ~Scott Constable d

Re: [PATCH] D15305: [CUDA] Do not allow dynamic initialization of global device side variables.

tra added inline comments. Comment at: lib/CodeGen/CGDeclCXX.cpp:329 @@ +328,3 @@ + for (const CXXCtorInitializer *CI: CD->inits()) +if (CI->isAnyMemberInitializer() && CI->isWritten()) + return false; @rsmith: is this a good way to find member initializ

Re: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

On Mon, Dec 7, 2015 at 4:32 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Dec 7, 2015 at 7:25 AM, Joerg Sonnenberger via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Thu, Dec 03, 2015 at 01:36:22AM -, Richard Smith via cfe-commits >> wrote: >> >

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

> On 2015-Dec-07, at 13:29, Bruno Cardoso Lopes wrote: > > bruno added a comment. > > Hi Argyrios, > > Thanks for the suggestions, will apply them. > The assertion seems important to catch subtle bugs, are you sure it should be > placed inside a "#ifndef NDEBUG”? FYI, the definition for `ass

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

> On 2015-Dec-07, at 14:22, Duncan P. N. Exon Smith > wrote: > > >> On 2015-Dec-07, at 13:29, Bruno Cardoso Lopes >> wrote: >> >> bruno added a comment. >> >> Hi Argyrios, >> >> Thanks for the suggestions, will apply them. >> The assertion seems important to catch subtle bugs, are you sur

Re: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

On Mon, Dec 7, 2015 at 2:14 PM, David Majnemer wrote: > > > On Mon, Dec 7, 2015 at 4:32 PM, Richard Smith via cfe-commits > wrote: >> >> On Mon, Dec 7, 2015 at 7:25 AM, Joerg Sonnenberger via cfe-commits >> wrote: >>> >>> On Thu, Dec 03, 2015 at 01:36:22AM -, Richard Smith via cfe-commits >>

Re: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

On Mon, Dec 7, 2015 at 5:25 PM, Hans Wennborg wrote: > On Mon, Dec 7, 2015 at 2:14 PM, David Majnemer > wrote: > > > > > > On Mon, Dec 7, 2015 at 4:32 PM, Richard Smith via cfe-commits > > wrote: > >> > >> On Mon, Dec 7, 2015 at 7:25 AM, Joerg Sonnenberger via cfe-commits > >> wrote: > >>> > >

[PATCH] D15309: [CUDA] emit vtables only for classes with methods usable on this side of compilation.

tra created this revision. tra added reviewers: rsmith, jingyue, jpienaar. tra added a subscriber: cfe-commits. C++ emits vtables for classes that have key function present in the current TU. While we compile CUDA the fact that key function was found in this TU does not mean that we are going to g

r254958 - 80-col and whitespace fixups.

Author: echristo Date: Mon Dec 7 16:43:05 2015 New Revision: 254958 URL: http://llvm.org/viewvc/llvm-project?rev=254958&view=rev Log: 80-col and whitespace fixups. Modified: cfe/trunk/lib/Driver/ToolChains.cpp Modified: cfe/trunk/lib/Driver/ToolChains.cpp URL: http://llvm.org/viewvc/llvm-p

r254961 - Add llvm-objdump to compiler-rt test deps.

Author: samsonov Date: Mon Dec 7 16:45:36 2015 New Revision: 254961 URL: http://llvm.org/viewvc/llvm-project?rev=254961&view=rev Log: Add llvm-objdump to compiler-rt test deps. Modified: cfe/trunk/runtime/CMakeLists.txt Modified: cfe/trunk/runtime/CMakeLists.txt URL: http://llvm.org/viewvc

[PATCH] D15311: [Clang] Use range loops and autos in lib/Serialization/ASTWriter.cpp

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I fixed Clang-tidy modernize-loop-convert and modernize-use-auto. Autos are also used for poin

Re: r254935 - AST: defer to TypeLoc::copy in TypeLoc::initializeFullCopy

Thanks for taking care of this! On Mon, Dec 7, 2015 at 12:04 PM, Justin Bogner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: bogner > Date: Mon Dec 7 14:04:57 2015 > New Revision: 254935 > > URL: http://llvm.org/viewvc/llvm-project?rev=254935&view=rev > Log: > AST: defer to Type

Re: [PATCH] D15005: Fix PR8170: Clang does not check constructor declaration that uses a template-id

faisalv added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:528 @@ +527,3 @@ +[&StringifiedTemplateArgs, this](const TemplateArgument &TA) { +if (const bool IsFirst = !StringifiedTemplateArgs.size()) + StringifiedTemplateArgs = "<"; --

r254962 - [analyzer] Fix crash when lambda captures a variable-length array.

Author: dcoughlin Date: Mon Dec 7 17:01:53 2015 New Revision: 254962 URL: http://llvm.org/viewvc/llvm-project?rev=254962&view=rev Log: [analyzer] Fix crash when lambda captures a variable-length array. When a C++ lambda captures a variable-length array, it creates a capture field to store the si

Re: [PATCH] D15309: [CUDA] emit vtables only for classes with methods usable on this side of compilation.

On Mon, Dec 7, 2015 at 2:44 PM, Artem Belevich via cfe-commits < cfe-commits@lists.llvm.org> wrote: > tra created this revision. > tra added reviewers: rsmith, jingyue, jpienaar. > tra added a subscriber: cfe-commits. > > C++ emits vtables for classes that have key function present in the > curren

[PATCH] D15313: [Clang] Use range loops and autos in utils/TableGen/ClangAttrEmitter.cpp

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I fixed Clang-tidy modernize-loop-convert and modernize-use-auto. Autos are also used for poin

[PATCH] D15314: Fix a bug in unavailable checking

manmanren created this revision. manmanren added reviewers: rjmccall, rsmith. manmanren added a subscriber: cfe-commits. The issue — Given the following test case, we don’t emit any message, and will silently ignore the variable "foo2", with a release compiler; we will get an assertio

Re: [PATCH] D15309: [CUDA] emit vtables only for classes with methods usable on this side of compilation.

On Mon, Dec 7, 2015 at 3:20 PM, David Blaikie wrote: > Index: lib/AST/RecordLayoutBuilder.cpp >> === >> --- lib/AST/RecordLayoutBuilder.cpp >> +++ lib/AST/RecordLayoutBuilder.cpp >> @@ -1996,6 +1996,16 @@ >>bool allowInlineFuncti

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

alexfh added a comment. The only conclusion I can make is that this patch is huge and very inconvenient to review. I'm fine with moving the AST-based checks to clang-tidy, but I strongly prefer each separate check to go in a separate patch. http://reviews.llvm.org/D12761 ___

[libcxx] r254971 - Cleaned up the intro for the TS status page; really need much more info here

Author: marshall Date: Mon Dec 7 18:08:23 2015 New Revision: 254971 URL: http://llvm.org/viewvc/llvm-project?rev=254971&view=rev Log: Cleaned up the intro for the TS status page; really need much more info here Modified: libcxx/trunk/www/ts1z_status.html Modified: libcxx/trunk/www/ts1z_stat

r254973 - 80-column fixup.

Author: echristo Date: Mon Dec 7 18:10:13 2015 New Revision: 254973 URL: http://llvm.org/viewvc/llvm-project?rev=254973&view=rev Log: 80-column fixup. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Dr

r254972 - Update comment.

Author: echristo Date: Mon Dec 7 18:10:10 2015 New Revision: 254972 URL: http://llvm.org/viewvc/llvm-project?rev=254972&view=rev Log: Update comment. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Dri

Re: [PATCH] D15309: [CUDA] emit vtables only for classes with methods usable on this side of compilation.

tra updated this revision to Diff 42122. tra added a comment. Removed unnecessary temporary variable and 'else'. http://reviews.llvm.org/D15309 Files: lib/AST/RecordLayoutBuilder.cpp test/CodeGenCUDA/device-vtable.cu Index: test/CodeGenCUDA/device-vtable.cu

Buildbot numbers for week of 11/29/2015 - 12/05/2015

Hello everyone, Below are some buildbot numbers for the last week of 11/29/2015 - 12/05/2015. Thanks Galina Top 10 fastest builders(not docs): lldb-amd64-ninja-freebsd11 clang-bpf-build llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast libomp-gcc-x86_64-linux-debian sanitizer-windows llvm-hex

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro added inline comments. Comment at: lib/AST/ASTContext.cpp:8257-8266 @@ -8256,1 +8256,12 @@ +bool ASTContext::containedInUniqueInstantiation(const Decl *D) { + const RecordDecl *RD; + while ((RD = dyn_cast(D->getDeclContext( { +auto *CTSD = dyn_cast(RD); +i

r254981 - [diagnostics] Avoid crashes while printing macro backtraces

Author: rnk Date: Mon Dec 7 19:08:09 2015 New Revision: 254981 URL: http://llvm.org/viewvc/llvm-project?rev=254981&view=rev Log: [diagnostics] Avoid crashes while printing macro backtraces When attempting to map a source into a given level of macro expansion, this code was ignoring the possibili

[PATCH] D15319: [Sema] Don't accept e.g. "(int *)(long)&x" as a constant expression if x is in address space != 0.

mjacob created this revision. mjacob added a reviewer: rsmith. mjacob added subscribers: cfe-commits, alex. The constant expression evaluator for pointers returns a base and an offset if successful. In this case, CodeGen generates a constant pointer cast, casting the base (with offset applied if

Re: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

It wasn't Chrome, it was some internal dependency on torch-cephes. I submitted a patch for it upstream: https://github.com/deepmind/torch-cephes/commit/9c4a97c90dc200ecbecb883e7230fe3c847954df It's not a pretty, though. I know LLVM IR rules are not C++ rules, but LLVM generally believes in NaN. It

r254984 - Update comment to reflect that we use other tools via the toolchain to

Author: echristo Date: Mon Dec 7 19:59:47 2015 New Revision: 254984 URL: http://llvm.org/viewvc/llvm-project?rev=254984&view=rev Log: Update comment to reflect that we use other tools via the toolchain to handle more than just C. Modified: cfe/trunk/include/clang/Driver/ToolChain.h Modified

r254985 - Remove name from FIXME.

Author: echristo Date: Mon Dec 7 19:59:51 2015 New Revision: 254985 URL: http://llvm.org/viewvc/llvm-project?rev=254985&view=rev Log: Remove name from FIXME. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro updated this revision to Diff 42132. loladiro added a comment. Address David's concern about inner classes. David also suggested on IRC to propagate the unique instantiation attribute down rather than walking the context chain to check for the attribute. I'll try that out, but wanted to

r254986 - Replace a bunch of duplicate conditions with the call from types::.

Author: echristo Date: Mon Dec 7 20:10:19 2015 New Revision: 254986 URL: http://llvm.org/viewvc/llvm-project?rev=254986&view=rev Log: Replace a bunch of duplicate conditions with the call from types::. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: h

[PATCH] D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support)

fraggamuffin created this revision. fraggamuffin added a reviewer: cfe-commits. fraggamuffin set the repository for this revision to rL LLVM. Add parsing, sema analysis for 'declare target' construct for OpenMP 4.0. Summary The declare target directive specifies that variables, functions (C, C++ a

RE: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

Two more questions: (1) Commit message implied this is only for C, but I see it with C++11 (but not C++03). $ cat t.cpp enum { foo = 123456 * 234567 }; $ clang -c t.cpp -std=c++03 $ clang -c t.cpp -std=c++11 t.cpp:1:14: error: expression is not an integral constant expression (2) Shouldn't

Re: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

[Adding back cfe-commits] On Mon, Dec 7, 2015 at 6:46 PM, Richard Smith wrote: > On Mon, Dec 7, 2015 at 1:59 PM, Robinson, Paul < > paul_robin...@playstation.sony.com> wrote: > >> | C11 6.3.1.5/1: "If the value being converted is outside the range of >> values that can be represented, the behavi

Re: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

On Mon, Dec 7, 2015 at 5:26 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > It wasn't Chrome, it was some internal dependency on torch-cephes. I > submitted a patch for it upstream: > > https://github.com/deepmind/torch-cephes/commit/9c4a97c90dc200ecbecb883e7230fe3c847954d

Re: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

On Mon, Dec 7, 2015 at 9:51 PM, Richard Smith wrote: > On Mon, Dec 7, 2015 at 5:26 PM, Reid Kleckner via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> It wasn't Chrome, it was some internal dependency on torch-cephes. I >> submitted a patch for it upstream: >> >> https://github.com/deep

Re: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

I've amended this change to permit constant-foldable UB in C variable initializers again in r254992. On Mon, Dec 7, 2015 at 6:45 PM, Robinson, Paul via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Two more questions: > > (1) Commit message implied this is only for C, but I see it with C++11

r254992 - Explicitly permit undefined behavior in constant initializers for global

Author: rsmith Date: Mon Dec 7 21:21:47 2015 New Revision: 254992 URL: http://llvm.org/viewvc/llvm-project?rev=254992&view=rev Log: Explicitly permit undefined behavior in constant initializers for global variables in C, in the cases where we can constant-fold it to a value regardless (such as fl

Re: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

On Mon, Dec 7, 2015 at 7:20 PM, David Majnemer wrote: > On Mon, Dec 7, 2015 at 9:51 PM, Richard Smith > wrote: > >> On Mon, Dec 7, 2015 at 5:26 PM, Reid Kleckner via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> It wasn't Chrome, it was some internal dependency on torch-cephes. I >>

Re: [PATCH] D15220: [OPENMP] dist_schedule clause for distribute directive

ABataev added a comment. Carlo, 1. please post your diffs exactly as said in http://llvm.org/docs/Phabricator.html, with full context available. 2. add a test with ast-printing, serialization/deserialization Comment at: include/clang/Basic/OpenMPKinds.def:394-399 @@ -394,1 +39

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

Ok, I will implement this logic Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 07.12.2015 22:30, John McCall пишет: > rjmccall added a comment. > > Oh, I see, of course. > > It would be clearer if you asked the subclass which value to use abstractly > (i.e. indep

r255001 - Add parse and sema for OpenMP distribute directive and all its clauses excluding dist_schedule.

Author: cbertol Date: Mon Dec 7 22:21:03 2015 New Revision: 255001 URL: http://llvm.org/viewvc/llvm-project?rev=255001&view=rev Log: Add parse and sema for OpenMP distribute directive and all its clauses excluding dist_schedule. Added: cfe/trunk/test/OpenMP/distribute_ast_print.cpp cfe/

r255004 - [Sema] Remove tab characters. NFC

Author: ctopper Date: Mon Dec 7 22:33:04 2015 New Revision: 255004 URL: http://llvm.org/viewvc/llvm-project?rev=255004&view=rev Log: [Sema] Remove tab characters. NFC Modified: cfe/trunk/lib/Sema/SemaExpr.cpp Modified: cfe/trunk/lib/Sema/SemaExpr.cpp URL: http://llvm.org/viewvc/llvm-projec

Re: [PATCH] D15125: [OPENMP] 'omp distribute' directive basic support.

carlo.bertolli closed this revision. carlo.bertolli added a comment. This was committed in r255001. Many thanks for all your help. Repository: rL LLVM http://reviews.llvm.org/D15125 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: [PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro updated this revision to Diff 42137. loladiro added a comment. Propagate unique instantiation attribute to children rather than later trying to look through the DeclContexts to see if we're contained in one that has the attribute. http://reviews.llvm.org/D13330 Files: include/clang

Re: [PATCH] D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support)

ABataev added a comment. Michael, please provide full diff log, as described in http://llvm.org/docs/Phabricator.html (with full context) Repository: rL LLVM http://reviews.llvm.org/D15321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >