majnemer added a subscriber: majnemer.
================
Comment at: lib/Sema/SemaTemplate.cpp:528
@@ +527,3 @@
+ [&StringifiedTemplateArgs, this](const TemplateArgument &TA) {
+ if (const bool IsFirst = !StringifiedTemplateArgs.size())
+ StringifiedTemplateArgs = "<";
----------------
You could use `StringifiedTemplateArgs.empty()` instead.
================
Comment at: lib/Sema/SemaTemplate.cpp:529
@@ +528,3 @@
+ if (const bool IsFirst = !StringifiedTemplateArgs.size())
+ StringifiedTemplateArgs = "<";
+ else
----------------
You could hoist this bit out of the `std::for_each`
http://reviews.llvm.org/D15005
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits