rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM, too. Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D14804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
spetrovic added a comment.
ping
http://reviews.llvm.org/D13351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253551: PR10235: support for vector mode attributes +
warning, by Dmitry Polukhin. (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D14744?vs=40506&id=40618#toc
Repository:
rL
Author: abataev
Date: Thu Nov 19 04:13:11 2015
New Revision: 253551
URL: http://llvm.org/viewvc/llvm-project?rev=253551&view=rev
Log:
PR10235: support for vector mode attributes + warning, by Dmitry Polukhin.
Add support for vector mode attributes like "attribute((mode(V4SF)))". Also add
warning
rizsotto.mailinglist added a comment.
I think the `scan-build` user experience would be improved by config file! And
I really like how the `clang-tidy` guys were doing it. (In case if you are not
familiar with it, copy from the help output)
Configuration files:
clang-tidy attempts to read
chapuni accepted this revision.
chapuni added a comment.
This revision is now accepted and ready to land.
It is obviously missing dependency.
How to reproduce;
$ ninja -t clean
$ ninja clangFrontend
FYI, this is reported also in; https://llvm.org/bugs/show_bug.cgi?id=25565
Sorry for the del
Author: chapuni
Date: Thu Nov 19 04:59:48 2015
New Revision: 253554
URL: http://llvm.org/viewvc/llvm-project?rev=253554&view=rev
Log:
clangFrontend: [PR25565] Quick fix for dependencies on Attributes.inc.
FIXME: Attributes.inc may be an independent target.
Differential Revision: http://reviews.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253554: clangFrontend: [PR25565] Quick fix for dependencies
on Attributes.inc. (authored by chapuni).
Changed prior to commit:
http://reviews.llvm.org/D14760?vs=40439&id=40623#toc
Repository:
rL LLVM
K-ballo created this revision.
K-ballo added reviewers: mclow.lists, EricWF, majnemer, rsmith.
K-ballo added a subscriber: cfe-commits.
Use the `__make_integer_seq` builtin, introduced by r252036, when available.
This allows for an incredibly fast `std::make_integer_sequence` implementation.
htt
krytarowski created this revision.
krytarowski added a reviewer: beanz.
krytarowski added subscribers: joerg, cfe-commits.
krytarowski set the repository for this revision to rL LLVM.
Caught on NetBSD.
Repository:
rL LLVM
http://reviews.llvm.org/D14800
Files:
INSTALL.txt
tools/scan-build/
rmaprath abandoned this revision.
rmaprath added a comment.
Makes sense. Thanks.
http://reviews.llvm.org/D14616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
In http://reviews.llvm.org/D14779#292513, @zaks.anna wrote:
> This is a partial review. I did not look at the padding calculations closely.
>
> Have you run this over codebases other than clang? Are there any false
> positives?
I ran this over a large C code base, then
aturetsk updated this revision to Diff 40645.
aturetsk added a comment.
Do not enable X87 for i386
http://reviews.llvm.org/D13980
Files:
lib/Basic/Targets.cpp
test/CodeGen/attr-target-x86-mmx.c
test/CodeGen/attr-target-x86.c
Index: test/CodeGen/attr-target-x86.c
=
sfantao updated this revision to Diff 40646.
sfantao added a comment.
Update comment as suggested by John.
http://reviews.llvm.org/D14796
Files:
include/clang/CodeGen/CGFunctionInfo.h
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGExprComplex.cpp
lib/CodeGen/CGObjC.cpp
sfantao added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:3751
@@ +3750,3 @@
+ // Preserve the non-canonical function type because things like exception
+ // specifications disappear in the canonical type. That information is useful
+ // to drive the generation of more
aturetsk added a comment.
Hello Richard,
Thank for the review.
Comment at: lib/Basic/Targets.cpp:2538-2539
@@ -2537,1 +2537,4 @@
+ // All X86 processors but i386 have X87.
+ if (getCPUKind(CPU) != CK_i386)
+setFeatureEnabledImpl(Features, "x87", true);
Y
scott-0 added a subscriber: scott-0.
scott-0 added a comment.
It would be nice if the no-exceptions library called an intermediate helper,
for example `__libcxx_noexceptions_abort()`, instead of calling `abort()`
directly. Then the user and the tests could provide a replacement for
`__libcxx_n
jroelofs added inline comments.
Comment at: include/__noexcept:22
@@ +21,3 @@
+template
+inline void throw_helper(T t, const char *msg = nullptr)
+{
We're not allowed to pollute the global namespace. This must be prefixed with
`__`.
http://reviews.llvm.org/D146
bcraig updated this revision to Diff 40659.
bcraig added a comment.
Addressed the bulk of Anna's review comments.
http://reviews.llvm.org/D14779
Files:
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/PaddingChecker.cpp
test/
bcraig marked 15 inline comments as done.
bcraig added a comment.
http://reviews.llvm.org/D14779
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman created this revision.
aaron.ballman added reviewers: alexfh, sbenza.
aaron.ballman added a subscriber: cfe-commits.
Throwing an exception from the constructor of an object being used with static
or thread_local storage duration is a dangerous operation. The exception thrown
for an
Author: hans
Date: Thu Nov 19 11:49:59 2015
New Revision: 253582
URL: http://llvm.org/viewvc/llvm-project?rev=253582&view=rev
Log:
clang-cl: Make /W4 imply -Wall -Wextra (PR25563)
Modified:
cfe/trunk/docs/UsersManual.rst
cfe/trunk/include/clang/Driver/CLCompatOptions.td
cfe/trunk/lib/
rmaprath updated this revision to Diff 40669.
rmaprath added a comment.
Addressing review comments:
- Renamed `throw_helper` as `__throw_helper` in order to not pollute the global
namespace (@jroelofs)
- Made `try_buf` a `thread_local` in order to be able to support those tests
the launch multi
jroelofs added inline comments.
Comment at: include/__noexcept:19
@@ +18,3 @@
+
+void __libcxx_noexceptions_abort();
+#endif // _LIBCPP_NO_EXCEPTIONS
Make this:
void __attribute__((weak)) __libcxx_noexceptions_abort();
Comment at: include/__
jroelofs added inline comments.
Comment at: include/__noexcept:19
@@ +18,3 @@
+
+void __libcxx_noexceptions_abort();
+#endif // _LIBCPP_NO_EXCEPTIONS
jroelofs wrote:
> Make this:
>
> void __attribute__((weak)) __libcxx_noexceptions_abort();
I meant to write:
rjmccall added inline comments.
Comment at: lib/Sema/SemaPseudoObject.cpp:1627
@@ -1579,1 +1626,3 @@
+cast(Base->IgnoreParens())->getBaseExpr());
+return MSPropertyRefRebuilder(S, BaseOVE->getSourceExpr()).rebuild(E);
} else {
Hmm. Just like the Ob
rjmccall added a comment.
Thanks, that's great. One minor tweak, and feel free to just commit when
you've done that.
Comment at: lib/CodeGen/CGCall.cpp:1420
@@ +1419,3 @@
+ // If we have information about the function proto type, we can learn
+ // attributes form there.
+ A
Author: faisalv
Date: Thu Nov 19 13:20:17 2015
New Revision: 253590
URL: http://llvm.org/viewvc/llvm-project?rev=253590&view=rev
Log:
Change the expression evaluation context from Unevaluated to ConstantEvaluated
while substituting into non-type template argument defaults.
Also address a typo fr
Author: marshall
Date: Thu Nov 19 13:41:04 2015
New Revision: 253592
URL: http://llvm.org/viewvc/llvm-project?rev=253592&view=rev
Log:
Fix some mistakes in the synopsis. No functional change. Thanks to
K-ballo for the patch
Modified:
libcxx/trunk/include/array
Modified: libcxx/trunk/includ
Author: marshall
Date: Thu Nov 19 13:45:29 2015
New Revision: 253593
URL: http://llvm.org/viewvc/llvm-project?rev=253593&view=rev
Log:
Fix some mistakes in the and synopses. No functional change.
Thannks to K-ballo for the patch
Modified:
libcxx/trunk/include/tuple
libcxx/trunk/include
Author: dehao
Date: Thu Nov 19 13:53:16 2015
New Revision: 253595
URL: http://llvm.org/viewvc/llvm-project?rev=253595&view=rev
Log:
Update clang tests to accomendate discriminator changes.
Summary: The discriminator change in http://reviews.llvm.org/D14738 will fail
these clang tests. Update the
On Thu, Nov 19, 2015 at 11:53 AM, Dehao Chen via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dehao
> Date: Thu Nov 19 13:53:16 2015
> New Revision: 253595
>
> URL: http://llvm.org/viewvc/llvm-project?rev=253595&view=rev
> Log:
> Update clang tests to accomendate discriminator change
Yes, as discriminator is a backend pass, it should *not* affect frontend tests.
On Thu, Nov 19, 2015 at 12:36 PM, David Blaikie wrote:
>
>
> On Thu, Nov 19, 2015 at 11:53 AM, Dehao Chen via cfe-commits
> wrote:
>>
>> Author: dehao
>> Date: Thu Nov 19 13:53:16 2015
>> New Revision: 253595
>>
>> U
On Thu, Nov 19, 2015 at 12:42 PM, Dehao Chen wrote:
> Yes, as discriminator is a backend pass, it should *not* affect frontend
> tests.
>
Could you update these tests to not involve discriminators by passing
-disable-llvm-optzns instead?
>
> On Thu, Nov 19, 2015 at 12:36 PM, David Blaikie
> w
Author: aaronballman
Date: Thu Nov 19 14:45:35 2015
New Revision: 253598
URL: http://llvm.org/viewvc/llvm-project?rev=253598&view=rev
Log:
Test to ensure the function does not have an unresolved or unevaluated
exception specification before testing whether the function throws or not.
Fixes PR255
aaron.ballman updated this revision to Diff 40695.
aaron.ballman added a comment.
Ensuring unresolved exception specifications are properly handled.
http://reviews.llvm.org/D14824
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/cert/StaticObjectExceptio
K-ballo created this revision.
K-ballo added reviewers: mclow.lists, EricWF.
K-ballo added a subscriber: cfe-commits.
Implement LWG2485, `get()` should be overloaded for `const tuple&&`.
http://reviews.llvm.org/D14839
Files:
include/__tuple
include/array
include/tuple
include/utility
t
zaks.anna added a comment.
> I have seen plenty of structures where the specific layout was important and
> couldn't be changed.
Can you give specific examples of these? Can we develop heuristics for them?
> These generally felt like noisy reports unless I had more specific
> justification fo
george.burgess.iv added inline comments.
Comment at: include/clang/AST/Expr.h:631-634
@@ -630,1 +630,6 @@
+ /// \brief If the current Expr is either a pointer, this will try to
+ /// statically determine the number of bytes available where the pointer is
+ /// pointing. Retu
echristo added a subscriber: echristo.
echristo added a comment.
Are there any of the intrinsics in the headers that also depend on x87?
One inline comment.
-eric
Comment at: lib/Basic/Targets.cpp:2538-2539
@@ -2537,1 +2537,4 @@
+ // All X86 processors but i386 have X87.
+
thiagomacieira added a comment.
What happens now?
http://reviews.llvm.org/D14727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
beanz added a reviewer: jroelofs.
beanz added a comment.
This looks fine to me, but looping in jroelofs as he wrote the original patch.
Repository:
rL LLVM
http://reviews.llvm.org/D14800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D14800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
pete updated this revision to Diff 40703.
pete added a comment.
Updated with the following changes:
- Removed the -f-objc-X option and made the -fno-objc-X option be codegen only.
- Updated all the comments to be what John suggested.
- Added a method (shouldUseRuntimeFunctionsForAlloc) to single
Author: tstellar
Date: Thu Nov 19 16:11:58 2015
New Revision: 253610
URL: http://llvm.org/viewvc/llvm-project?rev=253610&view=rev
Log:
AMDGPU: Add support for 's' and 'v' asm constraints
Summary: 's' is used to specify sgprs and 'v' is used to specify vgprs.
Reviewers: arsenm, echristo
Subscrib
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253610: AMDGPU: Add support for 's' and 'v' asm constraints
(authored by tstellar).
Changed prior to commit:
http://reviews.llvm.org/D14307?vs=39121&id=40704#toc
Repository:
rL LLVM
http://reviews.l
bcraig marked an inline comment as done.
bcraig added a comment.
In http://reviews.llvm.org/D14779#293236, @zaks.anna wrote:
> > I have seen plenty of structures where the specific layout was important
> > and couldn't be changed.
>
>
> Can you give specific examples of these? Can we develop heu
pete updated this revision to Diff 40705.
pete added a comment.
After chatting with John offline, he mentioned that this code could be shared
with all ObjC CG's if I put it in EmitObjCMessageExpr.
This moves it here and also checks that we don't do the retain/release
call->msgSend optimization
krytarowski added a comment.
Please land it, I'm not a committer.
Repository:
rL LLVM
http://reviews.llvm.org/D14800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath updated this revision to Diff 40707.
rmaprath added a comment.
Addressing review comments by @jroelofs:
- Got rid of the default implementation for `__libcxx_noexceptions_abort` by
making it a weak reference.
http://reviews.llvm.org/D14653
Files:
include/__config
include/__noexce
rjmccall added a comment.
By "in CGObjC", I mean you should be able to do it in
CodeGenFunction::EmitObjCMessageExpr. Maybe put it in a separate function like
static llvm::Value *tryGenerateSpecializedMessageSend(...)
and then do something like
} else if (llvm::Value *SpecializedResult =
zaks.anna added a comment.
> can be suppressed without breaking ABI by adding explicit padding members.
We should convey the suppression mechanism as part of the diagnostic.
http://reviews.llvm.org/D14779
___
cfe-commits mailing list
cfe-commits@l
jroelofs added a subscriber: EricWF.
jroelofs added a comment.
I don't have any more comments, but I don't feel comfortable LGTM-ing this.
I'll save that for Eric or Marshall.
Comment at: test/support/noexcept.h:14
@@ +13,3 @@
+#include
+#include
+
s/http://rev
bcraig added a comment.
In http://reviews.llvm.org/D14779#293339, @zaks.anna wrote:
> > can be suppressed without breaking ABI by adding explicit padding members.
>
>
> We should convey the suppression mechanism as part of the diagnostic.
I can make the diagnostic longer. Alternatively, is the
beanz created this revision.
beanz added a reviewer: bogner.
beanz added a subscriber: cfe-commits.
This code is a bit undesirable, but it gets clang to work with the autoconf and
cmake-built libclang_rt.profile libraries.
http://reviews.llvm.org/D14847
Files:
lib/Driver/ToolChains.cpp
Index
Chris Bieneman writes:
> beanz created this revision.
> beanz added a reviewer: bogner.
> beanz added a subscriber: cfe-commits.
>
> This code is a bit undesirable, but it gets clang to work with the
> autoconf and cmake-built libclang_rt.profile libraries.
Yeah, this is a bit awkward, but it mak
> On Nov 19, 2015, at 4:12 PM, Justin Bogner wrote:
>
> Chris Bieneman mailto:be...@apple.com>> writes:
>> beanz created this revision.
>> beanz added a reviewer: bogner.
>> beanz added a subscriber: cfe-commits.
>>
>> This code is a bit undesirable, but it gets clang to work with the
>> autoco
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253625: Support CMake's clang_rt.profile library naming
scheme (authored by cbieneman).
Changed prior to commit:
http://reviews.llvm.org/D14847?vs=40712&id=40717#toc
Repository:
rL LLVM
http://revie
Author: cbieneman
Date: Thu Nov 19 18:19:21 2015
New Revision: 253625
URL: http://llvm.org/viewvc/llvm-project?rev=253625&view=rev
Log:
Support CMake's clang_rt.profile library naming scheme
Summary: This code is a bit undesirable, but it gets clang to work with the
autoconf and cmake-built libc
davidxl added a comment.
Can you also add a test case with option -momit-leaf-frame-pointer?
http://reviews.llvm.org/D14215
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pete updated this revision to Diff 40719.
pete added a comment.
Thanks for all the feedback!
I've addressed all of your previous feedback and also applied clang-format to
the whole patch as some parts were looking questionable.
BTW, each of the implementations of EmitObjC* ultimately called to
rjmccall added a comment.
The casts done by emitARCValueOperation will handle the input, but they don't
quite handle the result properly. The right test case here is a method named
"retain" that's declared to return something completely unrelated to its
receiver type, e.g.
@class A;
@inte
dcoughlin added a comment.
Hi Laszlo, thanks for the update!
Some high-level questions/comments (and various small things I noticed inline).
- I tried running scan-build in interposition mode (i.e., uncommenting out
#"$SCRIPT_DIR/analyze-build" $@ in scan-build) and got python compile errors.
Author: dcoughlin
Date: Thu Nov 19 19:53:44 2015
New Revision: 253630
URL: http://llvm.org/viewvc/llvm-project?rev=253630&view=rev
Log:
[analyzer] DeadStoresChecker: Treat locals captured by reference in C++ lambdas
as escaped.
The analyzer currently reports dead store false positives when a loc
Author: akirtzidis
Date: Thu Nov 19 20:24:03 2015
New Revision: 253636
URL: http://llvm.org/viewvc/llvm-project?rev=253636&view=rev
Log:
[CMake] Add a specific 'install-clang-headers' target.
Modified:
cfe/trunk/lib/Headers/CMakeLists.txt
Modified: cfe/trunk/lib/Headers/CMakeLists.txt
URL:
Author: rsmith
Date: Thu Nov 19 20:54:01 2015
New Revision: 253641
URL: http://llvm.org/viewvc/llvm-project?rev=253641&view=rev
Log:
[coroutines] Per latest wording paper, co_* are no longer permitted in any
unevaluated operands.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Author: akirtzidis
Date: Thu Nov 19 21:36:21 2015
New Revision: 253645
URL: http://llvm.org/viewvc/llvm-project?rev=253645&view=rev
Log:
[libclang] Make sure to use the raw module format for libclang parsing.
Fixes crash when passing '-gmodules' in the compiler options.
rdar://23588717
Modified:
Author: dougk
Date: Thu Nov 19 22:58:12 2015
New Revision: 253647
URL: http://llvm.org/viewvc/llvm-project?rev=253647&view=rev
Log:
[Myriad]: handle Preprocess job action (-E)
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/myriad-too
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253650: [MS] Fix for bug 25013 - #pragma vtordisp is unknown
inside functions, by… (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D14467?vs=40380&id=40745#toc
Repository:
rL
Author: abataev
Date: Fri Nov 20 01:02:57 2015
New Revision: 253650
URL: http://llvm.org/viewvc/llvm-project?rev=253650&view=rev
Log:
[MS] Fix for bug 25013 - #pragma vtordisp is unknown inside functions, by Denis
Zobnin.
This patch adds support of #pragma vtordisp inside functions in attempt to
70 matches
Mail list logo
