Re: [PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

[Jonathan Roelofs via cfe-commits]

jroelofs added inline comments.

================
Comment at: include/__noexcept:19
@@ +18,3 @@
+
+void __libcxx_noexceptions_abort();
+#endif // _LIBCPP_NO_EXCEPTIONS
----------------
Make this:
    void __attribute__((weak)) __libcxx_noexceptions_abort();

================
Comment at: include/__noexcept:36
@@ +35,3 @@
+      fprintf(stderr, "exception raised, cannot propagate. Aborting.\n");
+    __libcxx_noexceptions_abort();
+#endif // _LIBCPP_NO_EXCEPTIONS
----------------
Then this should be:

    if (__libcxx_noexceptions_abort)
      __libcxx_noexceptions_abort();
    else
      abort();

================
Comment at: src/noexcept.cpp:1
@@ +1,2 @@
+//===------------------------ noexcept.cpp 
--------------------------------===//
+//
----------------
And delete this whole file.


http://reviews.llvm.org/D14653



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits