Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

ABataev updated this revision to Diff 40253. ABataev marked 3 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D13336 Files: include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor.h inclu

r253190 - [CGDebugInfo] Set the size and align for reference types

Author: kfischer Date: Mon Nov 16 03:04:13 2015 New Revision: 253190 URL: http://llvm.org/viewvc/llvm-project?rev=253190&view=rev Log: [CGDebugInfo] Set the size and align for reference types In r253186, I changed the DIBuilder API to now take size and align for reference types as well. This was

r253191 - Update for the gnu flavor being renamed to old-gnu.

Author: rafael Date: Mon Nov 16 03:12:12 2015 New Revision: 253191 URL: http://llvm.org/viewvc/llvm-project?rev=253191&view=rev Log: Update for the gnu flavor being renamed to old-gnu. Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/amdgpu-toolchain.c cfe/trunk/test/Dri

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev marked 4 inline comments as done. Comment at: include/clang/Basic/AttrDocs.td:1620 @@ +1619,3 @@ + let Content = [{ +The declare simd construct can be applied to a function to enable the creation of one or more versions that can process multiple arguments using SIMD ins

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

ABataev updated this revision to Diff 40255. ABataev marked 4 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D10599 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticParseKinds.td include/clang

[PATCH] D14695: [libclang] Add entry points that take a full command line including argv[0].

bkramer created this revision. bkramer added a reviewer: klimek. bkramer added a subscriber: cfe-commits. This provides both a more uniform interface and makes libclang behave like clang tooling wrt relative paths against argv[0]. This is necessary for finding paths to a c++ standard library relat

Re: [PATCH] D14695: [libclang] Add entry points that take a full command line including argv[0].

klimek added inline comments. Comment at: include/clang-c/Index.h:5694-5695 @@ -5683,1 +5693,4 @@ /** + * \brief Same as clang_indexSourceFile but requires a full command line + * for \c command_line_args including argv[0]. + */ We should probably expand on why u

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev marked 2 inline comments as done. Comment at: include/clang/Basic/DiagnosticParseKinds.td:995 @@ -994,1 +994,3 @@ +def err_omp_expected_reduction_identifier : Error< + "expected identifier or one of the following operators: '+', '-', '*', '&', '|', '^', '&&' and '||'">;

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev updated this revision to Diff 40262. ABataev marked 2 inline comments as done. ABataev added a comment. Update after review http://reviews.llvm.org/D11182 Files: include/clang/AST/DataRecursiveASTVisitor.h include/clang/AST/DeclBase.h include/clang/AST/DeclCXX.h include/clang/AS

Re: [PATCH] D12031: Const std::move() argument ClangTidy check

alexfh added inline comments. Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:23 @@ +22,3 @@ +} + +void MoveConstantArgumentCheck::check(const MatchFinder::MatchResult &Result) { The problem is that each template class or function can have several repre

Re: [PATCH] D14662: [ARM] Pass architecture to TargetParser defaulting to cope with API change

bsmith closed this revision. bsmith added a comment. Thanks, committed as r253199. Repository: rL LLVM http://reviews.llvm.org/D14662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

r253199 - [ARM] Pass in the architecture to TargetParser to cope with API change

Author: brasmi01 Date: Mon Nov 16 05:16:36 2015 New Revision: 253199 URL: http://llvm.org/viewvc/llvm-project?rev=253199&view=rev Log: [ARM] Pass in the architecture to TargetParser to cope with API change The TargetParser API to get the default FPU and default extensions has changed so that it c

Re: [PATCH] D14695: [libclang] Add entry points that take a full command line including argv[0].

bkramer updated this revision to Diff 40269. bkramer added a comment. - Add a test case to make sure argv[0] handling actually works. - Clarify comments a bit. http://reviews.llvm.org/D14695 Files: include/clang-c/Index.h lib/Frontend/CreateInvocationFromCommandLine.cpp tools/diagtool/Sho

Re: [PATCH] D14570: Handle ARMv6KZ naming

rengolin added a comment. In http://reviews.llvm.org/D14570#288132, @compnerd wrote: > Wow, this is tricky: the code change is in LLVM, and test change in clang :(. > However, this does seem to preserve the features. The problem is that Clang is the most important user of this library, which

r253202 - clang-format: Enable #include sorting by default.

Author: djasper Date: Mon Nov 16 06:38:56 2015 New Revision: 253202 URL: http://llvm.org/viewvc/llvm-project?rev=253202&view=rev Log: clang-format: Enable #include sorting by default. This has seen quite some usage and I am not aware of any issues. Also add a style option to enable/disable includ

Re: [PATCH] D14570: Handle ARMv6KZ naming

Hi Renato, Ideally, shouldn't the clang tests be checking that the LLVM target parsing library is called with the correct arguments? then separate tests inside LLVM check that the target parser works correctly? As it stands, it seems like a very deliberate layering violation that could really do

[clang-tools-extra] r253203 - [clang-tidy] Test commit (playing with git-svn)

Author: alexfh Date: Mon Nov 16 07:06:15 2015 New Revision: 253203 URL: http://llvm.org/viewvc/llvm-project?rev=253203&view=rev Log: [clang-tidy] Test commit (playing with git-svn) Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp clang-tools-extra/trunk/clang-tidy/ClangTidyDiagn

r253207 - Handle ARMv6KZ naming

Author: askrobov Date: Mon Nov 16 08:05:48 2015 New Revision: 253207 URL: http://llvm.org/viewvc/llvm-project?rev=253207&view=rev Log: Handle ARMv6KZ naming Summary: Update for clang tests for D14568 Reviewers: rengolin, joerg, bogden Subscribers: aemerson, rengolin, cfe-commits Differential R

Re: [PATCH] D14570: Handle ARMv6KZ naming

This revision was automatically updated to reflect the committed changes. Closed by commit rL253207: Handle ARMv6KZ naming (authored by askrobov). Changed prior to commit: http://reviews.llvm.org/D14570?vs=39901&id=40280#toc Repository: rL LLVM http://reviews.llvm.org/D14570 Files: cfe/tr

Re: [PATCH] D14686: Protect against overloaded comma in random_shuffle and improve tests

mclow.lists added a comment. Nice catch. The fix in `` is exactly right, but I think the tests need more work. Comment at: test/std/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.pass.cpp:35 @@ -30,1 +34,3 @@ } + +template This is not

Re: [PATCH] D14609: [ARM, AArch64] Fix __rev16l and __rev16ll intrinsics

rengolin accepted this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision is now accepted and ready to land. LGTM. The 64-bit rev pattern can be added later. Thanks! Repository: rL LLVM http://reviews.llvm.org/D14609 _

[libcxx] r253212 - Mark P0013 as 'in progress'

Author: marshall Date: Mon Nov 16 09:05:09 2015 New Revision: 253212 URL: http://llvm.org/viewvc/llvm-project?rev=253212&view=rev Log: Mark P0013 as 'in progress' Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org/viewvc/llvm-proje

Re: [PATCH] D14609: [ARM, AArch64] Fix __rev16l and __rev16ll intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL253211: [ARM,AArch64] Fix __rev16l and __rev16ll intrinsics (authored by olista01). Changed prior to commit: http://reviews.llvm.org/D14609?vs=40029&id=40283#toc Repository: rL LLVM http://reviews.l

r253211 - [ARM,AArch64] Fix __rev16l and __rev16ll intrinsics

Author: olista01 Date: Mon Nov 16 08:58:50 2015 New Revision: 253211 URL: http://llvm.org/viewvc/llvm-project?rev=253211&view=rev Log: [ARM,AArch64] Fix __rev16l and __rev16ll intrinsics These two intrinsics are defined in arm_acle.h. __rev16l needs to rotate by 16 bits, bit it was actually rota

Re: [PATCH] D9600: Add scan-build python implementation

jroelofs added a comment. Thanks for re-uploading! Comment at: tools/scan-build-py/README.md:39 @@ +38,3 @@ + +$ python setup.py build +$ python setup.py install Mind adding a CMakeLists.txt to drive these from the clang build itself? C

r253213 - [Myriad]: pass the 'std=' option to moviCompile

Author: dougk Date: Mon Nov 16 09:38:40 2015 New Revision: 253213 URL: http://llvm.org/viewvc/llvm-project?rev=253213&view=rev Log: [Myriad]: pass the 'std=' option to moviCompile Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/myriad-toolchain.c Modified: cfe/trunk/lib/Dr

r253214 - [mips] Do not add arch name in the compiler-rt's components.

Author: vkalintiris Date: Mon Nov 16 09:41:30 2015 New Revision: 253214 URL: http://llvm.org/viewvc/llvm-project?rev=253214&view=rev Log: [mips] Do not add arch name in the compiler-rt's components. Instead, use the constant "mips" since the libraries are already placed under the multilib's OS su

Re: [PATCH] D14686: Protect against overloaded comma in random_shuffle and improve tests

gribozavr added inline comments. Comment at: test/std/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.pass.cpp:35 @@ -30,1 +34,3 @@ } + +template mclow.lists wrote: > This is not how I would rewrite this test. > I would write a routine tha

[libcxx] r253215 - Implement P0013R1: Logical Operator Type Traits. Make a hidden implementation (__and_, __or_, and __not_) so that we can use them elsewhere in non-C++17 code - for example, in the L

Author: marshall Date: Mon Nov 16 09:54:13 2015 New Revision: 253215 URL: http://llvm.org/viewvc/llvm-project?rev=253215&view=rev Log: Implement P0013R1: Logical Operator Type Traits. Make a hidden implementation (__and_, __or_, and __not_) so that we can use them elsewhere in non-C++17 code - f

[libcxx] r253223 - LWG#2156 loosened the requirements on unordered containers 'rehash' calls. Add tests to make sure we meet these requirements. Since we met the stricter ones, no code change needed t

Author: marshall Date: Mon Nov 16 10:42:16 2015 New Revision: 253223 URL: http://llvm.org/viewvc/llvm-project?rev=253223&view=rev Log: LWG#2156 loosened the requirements on unordered containers 'rehash' calls. Add tests to make sure we meet these requirements. Since we met the stricter ones, no

Re: [PATCH] D14215: Disable frame pointer elimination when using -pg

spatel added a subscriber: spatel. spatel added reviewers: davidxl, dnovillo, slingn. spatel added a comment. Adding some PGO-active reviewers. http://reviews.llvm.org/D14215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

Re: [PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

rmaprath updated this revision to Diff 40307. rmaprath added a comment. Tidied up the patch a bit: - Got rid of the different variants of the throw_helper function, can do with one in almost all the cases (the exceptional case will be submitted for review separately). - Modified __config a litt

Re: r252834 - Provide a frontend based error for always_inline functions that require

Hi Eric, On Fri, Nov 13, 2015 at 8:55 PM, Eric Christopher wrote: > This all sounds a little weird as _mm_mul_ps only requires sse. Can you give > me a testcase and command line that you're using to trigger this? clang -O3 -flto -arch x86_64h -fomit-frame-pointer -c test-suite/SingleSource/UnitT

r253242 - When producing error messages for always_inline functions with the

Author: echristo Date: Mon Nov 16 12:29:59 2015 New Revision: 253242 URL: http://llvm.org/viewvc/llvm-project?rev=253242&view=rev Log: When producing error messages for always_inline functions with the target attribute, don't include "negative" subtarget features in the list of required features.

Re: r252834 - Provide a frontend based error for always_inline functions that require

Fixed thusly: dzur:~/sources/llvm/tools/clang> git svn dcommit Committing to https://llvm.org/svn/llvm-project/cfe/trunk ... A test/CodeGen/target-features-no-error.c M lib/CodeGen/CodeGenFunction.cpp Committed r253242 Thanks! -eric On Mon, Nov 16, 2015 at 9:48 AM Bruno Cardoso Lopes wrote: >

Re: r253202 - clang-format: Enable #include sorting by default.

!!! Awesome :) -eric On Mon, Nov 16, 2015 at 4:41 AM Daniel Jasper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: djasper > Date: Mon Nov 16 06:38:56 2015 > New Revision: 253202 > > URL: http://llvm.org/viewvc/llvm-project?rev=253202&view=rev > Log: > clang-format: Enable #i

Re: r253202 - clang-format: Enable #include sorting by default.

Should this be a per-style default? It still only doesn't break webkit files only by accident, right? On Mon, Nov 16, 2015 at 10:35 AM, Eric Christopher via cfe-commits < cfe-commits@lists.llvm.org> wrote: > !!! > > Awesome :) > > -eric > > On Mon, Nov 16, 2015 at 4:41 AM Daniel Jasper via cf

Re: r253202 - clang-format: Enable #include sorting by default.

i.e. should SortIncludes be false for -style=WebKit for now? On Mon, Nov 16, 2015 at 11:19 AM, Nico Weber wrote: > Should this be a per-style default? It still only doesn't break webkit > files only by accident, right? > > On Mon, Nov 16, 2015 at 10:35 AM, Eric Christopher via cfe-commits < > cf

[clang-tools-extra] r253246 - Add a new clang-tidy checker that flags throw expressions whose thrown type is not nothrow copy constructible. While the compiler is free to elide copy constructor calls

Author: aaronballman Date: Mon Nov 16 13:17:43 2015 New Revision: 253246 URL: http://llvm.org/viewvc/llvm-project?rev=253246&view=rev Log: Add a new clang-tidy checker that flags throw expressions whose thrown type is not nothrow copy constructible. While the compiler is free to elide copy const

Re: [PATCH] D14619: [PATCH] clang-tidy checker for nothrow copy constructible exception objects

On Fri, Nov 13, 2015 at 10:45 PM, Alexander Kornienko wrote: > alexfh accepted this revision. > alexfh added a comment. > This revision is now accepted and ready to land. > > Looks good with one nit. Thank you! > > > > Comment at: clang-tidy/cert/ThrownExceptionTypeCheck.cpp:23 >

Re: r253202 - clang-format: Enable #include sorting by default.

Up to you. I am not worried about accidentally breaking it in the foreseeable future. On Mon, Nov 16, 2015 at 8:20 PM, Nico Weber wrote: > i.e. should SortIncludes be false for -style=WebKit for now? > > On Mon, Nov 16, 2015 at 11:19 AM, Nico Weber wrote: > >> Should this be a per-style default

Re: r252834 - Provide a frontend based error for always_inline functions that require

Thanks Eric!! On Mon, Nov 16, 2015 at 10:32 AM, Eric Christopher wrote: > Fixed thusly: > > dzur:~/sources/llvm/tools/clang> git svn dcommit > Committing to https://llvm.org/svn/llvm-project/cfe/trunk ... > A test/CodeGen/target-features-no-error.c > M lib/CodeGen/CodeGenFunction.cpp > Committed

Re: [PATCH] D14506: Porting shouldVisitImplicitCode to DataRecursiveASTVisitor.

bcraig added a comment. Ping. Note that the test is basically a copy / paste job, and the new code in DataRecursiveASTVisitor.h is a very direct translation from the 'regular' RecursiveASTVisitor.h. http://reviews.llvm.org/D14506 ___ cfe-commits

Re: [PATCH] D14619: [PATCH] clang-tidy checker for nothrow copy constructible exception objects

aaron.ballman closed this revision. aaron.ballman added a comment. Commit in r253246 http://reviews.llvm.org/D14619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10599: [OPENMP 4.0] Initial support for '#pragma omp declare simd' directive.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I don't think we generally want files commit with explicit svn properties like your new test files have. However, beyond that, LGTM. You should still wait for approval from Richa

Re: [PATCH] D14506: Porting shouldVisitImplicitCode to DataRecursiveASTVisitor.

LGTM. > On Nov 16, 2015, at 12:32 PM, Ben Craig wrote: > > bcraig added a comment. > > Ping. Note that the test is basically a copy / paste job, and the new code > in DataRecursiveASTVisitor.h is a very direct translation from the 'regular' > RecursiveASTVisitor.h. > > > http://reviews.llv

Re: [PATCH] D14506: Porting shouldVisitImplicitCode to DataRecursiveASTVisitor.

Rather than trying to maintain the horrible duplication between DataRecursiveASTVisitor and RecursiveASTVisitor, can we just delete DataRecursiveASTVisitor? RecursiveASTVisitor is data-recursive too these days (and has a smarter implementation than DataRecursiveASTVisitor's from what I can see), bu

[PATCH] D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations

thiagomacieira created this revision. thiagomacieira added a reviewer: cfe-commits. Some GCC 5 installations store the libstdc++ includes and GCC-specific files in paths without the minor part of the version number, such as /usr/include/c++/5 /usr/lib64/gcc/x86_64-suse-linux/5 http://revie

r253255 - Correctly handle type mismatches in the __weak copy/move-initialization

Author: rjmccall Date: Mon Nov 16 16:11:41 2015 New Revision: 253255 URL: http://llvm.org/viewvc/llvm-project?rev=253255&view=rev Log: Correctly handle type mismatches in the __weak copy/move-initialization peephole I added in r250916. rdar://23559789 Added: cfe/trunk/test/CodeGenObjC/arc-we

[libcxx] r253257 - More tests for LWG#2156

Author: marshall Date: Mon Nov 16 16:18:36 2015 New Revision: 253257 URL: http://llvm.org/viewvc/llvm-project?rev=253257&view=rev Log: More tests for LWG#2156 Modified: libcxx/trunk/test/std/containers/unord/unord.map/reserve.pass.cpp libcxx/trunk/test/std/containers/unord/unord.multimap/

[PATCH] D14731: [libcxx] Add clang thread safety annotations to mutex and lock_guard

jamesr created this revision. jamesr added a subscriber: cfe-commits. This adds clang thread safety annotations to std::mutex and std::lock_guard so code using these types can use these types directly instead of having to wrap the types to provide annotations. These checks when enabled by -Wthread

r253259 - Derive nacltools::Linker from GnuTool to get response file support

Author: dschuff Date: Mon Nov 16 16:21:25 2015 New Revision: 253259 URL: http://llvm.org/viewvc/llvm-project?rev=253259&view=rev Log: Derive nacltools::Linker from GnuTool to get response file support It could be derived from gnutools::Linker directly but this way makes it consistent with all the

Re: [PATCH] D14506: Porting shouldVisitImplicitCode to DataRecursiveASTVisitor.

I'm fine with this approach. How about I leave the file in place, but replace the contents with a "using DataRecursiveASTVisitor = RecursiveASTVisitor;" and see what breaks? That way I won't need to go through a large retrofit. On 11/16/2015 3:28 PM, Richard Smith wrote: Rather than trying t

Re: [PATCH] D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations

jroelofs added a subscriber: jroelofs. jroelofs added a comment. testcase? http://reviews.llvm.org/D14727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r253269 - Make FP_CONTRACT ON the default.

Author: scanon Date: Mon Nov 16 17:09:11 2015 New Revision: 253269 URL: http://llvm.org/viewvc/llvm-project?rev=253269&view=rev Log: Make FP_CONTRACT ON the default. Differential Revision: D14200 Added: cfe/trunk/test/CodeGen/aarch64-scalar-fma.c Modified: cfe/trunk/include/clang/Basic/L

Re: [PATCH] D14200: Make FP_CONTRACT ON default.

This revision was automatically updated to reflect the committed changes. Closed by commit rL253269: Make FP_CONTRACT ON the default. (authored by scanon). Changed prior to commit: http://reviews.llvm.org/D14200?vs=39205&id=40351#toc Repository: rL LLVM http://reviews.llvm.org/D14200 Files

Re: [libcxx] r253257 - More tests for LWG#2156

Hi Marshall, reserve.pass.cpp is failing on green dragon bot: /Users/buildslave/jenkins/sharedspace/clang-stage1-cmake-RA_workspace@2/llvm/projects/libcxx/test/std/containers/unord/unord.multimap/reserve.pass.cpp:45:14: error: type 'std::unordered_multimap' does not provide a subscript operator

[libcxx] r253271 - Fix compile error in test. Can't use `operator[]` for multimap.

Author: marshall Date: Mon Nov 16 17:40:27 2015 New Revision: 253271 URL: http://llvm.org/viewvc/llvm-project?rev=253271&view=rev Log: Fix compile error in test. Can't use `operator[]` for multimap. Modified: libcxx/trunk/test/std/containers/unord/unord.multimap/reserve.pass.cpp Modified: l

Re: [PATCH] D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations

jroelofs added a comment. hHave a look at the svn-blame for this file, then find other commits which changed this part of the file, and see where those commits added tests. http://reviews.llvm.org/D14727 ___ cfe-commits mailing list cfe-commits@lis

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r253274 - Implement P0007: Constant View: A proposal for a std::as_const helper function template.

Author: marshall Date: Mon Nov 16 18:08:08 2015 New Revision: 253274 URL: http://llvm.org/viewvc/llvm-project?rev=253274&view=rev Log: Implement P0007: Constant View: A proposal for a std::as_const helper function template. Added: libcxx/trunk/test/std/utilities/utility/as_const/ libcxx/

[PATCH] D14736: [analyzer] DeadStoresChecker: Treat locals captured by reference in C++ lambdas as escaped.

dcoughlin created this revision. dcoughlin added reviewers: zaks.anna, xazax.hun. dcoughlin added a subscriber: cfe-commits. The analyzer currently reports dead store false positives when a local variable is captured by reference in a C++ lambda. For example: int local = 0; auto lambda

Re: [PATCH] D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations

thiagomacieira updated this revision to Diff 40359. thiagomacieira added a comment. v2: fix accidental breakage of GCC 4 http://reviews.llvm.org/D14727 Files: lib/Driver/ToolChains.cpp Index: lib/Driver/ToolChains.cpp === --- li

Re: [PATCH] D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations

thiagomacieira added a comment. In http://reviews.llvm.org/D14727#290539, @jroelofs wrote: > testcase? Gladly, but where are the tests for GCCVersion located? http://reviews.llvm.org/D14727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14736: [analyzer] DeadStoresChecker: Treat locals captured by reference in C++ lambdas as escaped.

dcoughlin added a comment. This is PR 22834. https://llvm.org/bugs/show_bug.cgi?id=22834. http://reviews.llvm.org/D14736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D14737: Convert some ObjC msgSends to runtime calls

pete created this revision. pete added a reviewer: rjmccall. pete added a subscriber: cfe-commits. It is faster to directly call the ObjC runtime for methods such as retain/release instead of sending a message to those functions. This patch adds support for converting messages to retain/release

Lit test C++11 Compatibility Patch #4

Hi Everyone, Here is the forth Lit tests C++11 compatibility patch. This patch mainly added new diagnostics expected for C++11. There are 34 tests in total. They fall into 3 categories. [2 tests] New Warnings regarding storage class specifier "register"/"auto" being deprecated/not-allowed.

Re: [PATCH] D14506: Porting shouldVisitImplicitCode to DataRecursiveASTVisitor.

W00t! That’s awesome Richard! > On Nov 16, 2015, at 5:10 PM, Richard Smith wrote: > > Attached patch makes RAV fully data-recursive when visiting statements, > except in cases where the derived class could tell the difference (when it > falls back to a normal recursive walk). The queue represe

Re: [PATCH] D14592: Qt (version 4 or 5) signal/method checker

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. There are dedicated project to Qt checks: https://github.com/KDE/clazy. http://reviews.llvm.org/D14592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: r253012 - [modules] When a declaration has non-trivial visibility, check whether it's

On Sat, Nov 14, 2015 at 2:30 PM, Richard Smith wrote: > On Nov 13, 2015 7:23 PM, "Sean Silva" wrote: > > > > > > > > On Thu, Nov 12, 2015 at 9:14 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> > >> Author: rsmith > >> Date: Thu Nov 12 23:14:45 2015 > >> New Revisio

Re: Lit test C++11 Compatibility Patch #4

On Mon, Nov 16, 2015 at 5:17 PM, Li, Charles < charles...@playstation.sony.com> wrote: > Hi Everyone, > > > > Here is the forth Lit tests C++11 compatibility patch. > > This patch mainly added new diagnostics expected for C++11. > > There are 34 tests in total. They fall into 3 categories. > > > >

r253283 - [modules] Fix some more cases where we used to reject a conflict between two

Author: rsmith Date: Mon Nov 16 21:02:41 2015 New Revision: 253283 URL: http://llvm.org/viewvc/llvm-project?rev=253283&view=rev Log: [modules] Fix some more cases where we used to reject a conflict between two declarations that are not simultaneously visible, and where at least one of them has int

Re: r253012 - [modules] When a declaration has non-trivial visibility, check whether it's

On Mon, Nov 16, 2015 at 7:00 PM, Sean Silva wrote: > On Sat, Nov 14, 2015 at 2:30 PM, Richard Smith > wrote: > >> On Nov 13, 2015 7:23 PM, "Sean Silva" wrote: >> > >> > >> > >> > On Thu, Nov 12, 2015 at 9:14 PM, Richard Smith via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >> >> >> A

[libcxx] r253292 - Creating release directory for release_371.

Author: tstellar Date: Mon Nov 16 21:25:24 2015 New Revision: 253292 URL: http://llvm.org/viewvc/llvm-project?rev=253292&view=rev Log: Creating release directory for release_371. Added: libcxx/tags/RELEASE_371/ ___ cfe-commits mailing list cfe-comm

[libcxxabi] r253295 - Creating release candidate rc1 from release_371 branch

Author: tstellar Date: Mon Nov 16 21:25:31 2015 New Revision: 253295 URL: http://llvm.org/viewvc/llvm-project?rev=253295&view=rev Log: Creating release candidate rc1 from release_371 branch Added: libcxxabi/tags/RELEASE_371/rc1/ (props changed) - copied from r253294, libcxxabi/branche

[libcxxabi] r253294 - Creating release directory for release_371.

Author: tstellar Date: Mon Nov 16 21:25:28 2015 New Revision: 253294 URL: http://llvm.org/viewvc/llvm-project?rev=253294&view=rev Log: Creating release directory for release_371. Added: libcxxabi/tags/RELEASE_371/ ___ cfe-commits mailing list cfe-c

[libcxx] r253293 - Creating release candidate rc1 from release_371 branch

Author: tstellar Date: Mon Nov 16 21:25:27 2015 New Revision: 253293 URL: http://llvm.org/viewvc/llvm-project?rev=253293&view=rev Log: Creating release candidate rc1 from release_371 branch Added: libcxx/tags/RELEASE_371/rc1/ (props changed) - copied from r253292, libcxx/branches/rele

[libunwind] r253306 - Creating release directory for release_371.

Author: tstellar Date: Mon Nov 16 21:25:54 2015 New Revision: 253306 URL: http://llvm.org/viewvc/llvm-project?rev=253306&view=rev Log: Creating release directory for release_371. Added: libunwind/tags/RELEASE_371/ ___ cfe-commits mailing list cfe-c

[libunwind] r253307 - Creating release candidate rc1 from release_371 branch

Author: tstellar Date: Mon Nov 16 21:25:56 2015 New Revision: 253307 URL: http://llvm.org/viewvc/llvm-project?rev=253307&view=rev Log: Creating release candidate rc1 from release_371 branch Added: libunwind/tags/RELEASE_371/rc1/ (props changed) - copied from r253306, libunwind/branche

Re: r253012 - [modules] When a declaration has non-trivial visibility, check whether it's

On Mon, Nov 16, 2015 at 7:09 PM, Richard Smith wrote: > On Mon, Nov 16, 2015 at 7:00 PM, Sean Silva wrote: > >> On Sat, Nov 14, 2015 at 2:30 PM, Richard Smith >> wrote: >> >>> On Nov 13, 2015 7:23 PM, "Sean Silva" wrote: >>> > >>> > >>> > >>> > On Thu, Nov 12, 2015 at 9:14 PM, Richard Smith vi

[clang-tools-extra] r253310 - modularize: add install rule

Author: compnerd Date: Mon Nov 16 23:09:18 2015 New Revision: 253310 URL: http://llvm.org/viewvc/llvm-project?rev=253310&view=rev Log: modularize: add install rule This allows modularize to be installed. Previously, no install rule would be created for it. Modified: clang-tools-extra/trunk/

r253315 - [Sema] Combine similar diagnostics using %select. NFC

Author: ctopper Date: Mon Nov 16 23:40:09 2015 New Revision: 253315 URL: http://llvm.org/viewvc/llvm-project?rev=253315&view=rev Log: [Sema] Combine similar diagnostics using %select. NFC Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Sema/SemaChecking.cpp

r253314 - [Sema] Minor formatting fixes. NFC

Author: ctopper Date: Mon Nov 16 23:40:05 2015 New Revision: 253314 URL: http://llvm.org/viewvc/llvm-project?rev=253314&view=rev Log: [Sema] Minor formatting fixes. NFC Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp cfe/trunk/lib/Sema/SemaDeclObjC.cpp cfe/trunk/lib/Sema/SemaStmt.cpp

r253316 - [Sema] Remove unnecessary typecast of bool to int when passing arguments to diagnostics. NFC

Author: ctopper Date: Mon Nov 16 23:40:12 2015 New Revision: 253316 URL: http://llvm.org/viewvc/llvm-project?rev=253316&view=rev Log: [Sema] Remove unnecessary typecast of bool to int when passing arguments to diagnostics. NFC Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/li