Hi Renato, Ideally, shouldn't the clang tests be checking that the LLVM target parsing library is called with the correct arguments? then separate tests inside LLVM check that the target parser works correctly?
As it stands, it seems like a very deliberate layering violation that could really do with chopping up. James On Mon, 16 Nov 2015 at 12:19 Renato Golin via cfe-commits < cfe-commits@lists.llvm.org> wrote: > rengolin added a comment. > > In http://reviews.llvm.org/D14570#288132, @compnerd wrote: > > > Wow, this is tricky: the code change is in LLVM, and test change in > clang :(. However, this does seem to preserve the features. > > > The problem is that Clang is the most important user of this library, > which also has other users in LLVM. We just need to make sure that Clang is > doing the right thing, and that the intentions are recorded on the right > places. In this case, it's Clang. :) > > > http://reviews.llvm.org/D14570 > > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
