seaneveson abandoned this revision.
seaneveson added a comment.
Fixed by r252506. Thanks Devin.
http://reviews.llvm.org/D14498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added a comment.
Some of these are great improvements, especially using auto for iterators etc.
But I'm not sure we'll want to start changing "Foo *foo = new Foo;" to use auto
everywhere. I expect we'd have to do that in a huge number of places?
Comment at: include/clang/
rengolin added a comment.
In http://reviews.llvm.org/D14471#285492, @ahatanak wrote:
> Which two calls? Do you mean getAArch64TargetCPU and
> getAArch64ArchFeaturesFromMcpu?
No, the two getAArch64TargetCPU calls, but they don't even get called twice,
and the value is write-only. Ignore that.
tberghammer added a comment.
I am not in a hurry with getting this change in, but happy to take a look for
enabling the tuning if somebody can explain me what you mean under it (I have
almost no llvm/clang development experience)
http://reviews.llvm.org/D14354
__
spetrovic added a comment.
ping
http://reviews.llvm.org/D13351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: seaneveson
Date: Tue Nov 10 05:48:55 2015
New Revision: 252599
URL: http://llvm.org/viewvc/llvm-project?rev=252599&view=rev
Log:
[Analyzer] Fix comments and formatting. NFC.
Modified:
cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/LoopWidening.h
cfe/trunk/lib/StaticAnal
Author: aaronballman
Date: Tue Nov 10 06:51:25 2015
New Revision: 252601
URL: http://llvm.org/viewvc/llvm-project?rev=252601&view=rev
Log:
No longer creating the install-clang target for IDEs, as it was never meant for
those.
Modified:
cfe/trunk/tools/driver/CMakeLists.txt
Modified: cfe/tru
aaron.ballman closed this revision.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Committed in r252601.
http://reviews.llvm.org/D14502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
rmaprath closed this revision.
rmaprath added a comment.
Thanks Jon!
Committed as r252598. The current buildbots are happy (except for the ARM one,
which seem to have gone away).
I will update http://reviews.llvm.org/D14293 to include the new runs.
Cheers,
- Asiri
http://reviews.llvm.org/D1
danielmarjamaki created this revision.
danielmarjamaki added a reviewer: alexfh.
danielmarjamaki added a subscriber: cfe-commits.
This fixes the FP in http://llvm.org/bugs/show_bug.cgi?id=25208
http://reviews.llvm.org/D14540
Files:
clang-tidy/misc/MacroParenthesesCheck.cpp
test/clang-tidy/mi
aaron.ballman added inline comments.
Comment at: include/clang/Analysis/Analyses/Consumed.h:266
@@ -266,2 +265,3 @@
};
-}} // end namespace clang::consumed
+} // end namespace consumed
+} // end namespace clang
I don't know whether this is an improvement or not
rmaprath updated this revision to Diff 39806.
rmaprath added a comment.
Updated patch to remove the skipping of tests. Now that we have the appropriate
XFAILs in place, these two builders should be green.
I've locally tested the x86 run, I expect the ARM run to be fairly similar.
@Renato: could
aaron.ballman added a comment.
I generally think this LGTM, but I would wait for a second confirmation before
committing.
Comment at:
clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:33
@@ +32,3 @@
+ ast_matchers::internal::Matcher, InnerMatcher)
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you for the fix!
http://reviews.llvm.org/D14540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
seaneveson added a comment.
We are working on tools that use the new hash for bug suppression. There seems
to be no way to predict the names of future hashes. We have products (that will
use the bug identification) that are on a different release schedule to our
clang compiler. These tools will
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with a couple of comments. Thank you for the fix!
Comment at:
clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp:33
@@ +32,3 @@
+ ast_
xazax.hun added a comment.
Thank you for pointing this out. I think it would be great to be forward
compatible.
Right now one could use a heuristic such as for every hash the key has the
"hash" string in its name.
This information might not be sufficient, however, since it would be great to
ha
Author: danielmarjamaki
Date: Tue Nov 10 08:32:25 2015
New Revision: 252608
URL: http://llvm.org/viewvc/llvm-project?rev=252608&view=rev
Log:
[clang-tidy] misc-macro-parentheses: fix fp when using object member pointers
Fixes http://llvm.org/PR25208.
Modified:
clang-tools-extra/trunk/clang-
danielmarjamaki closed this revision.
danielmarjamaki added a comment.
Committed with 252608
http://reviews.llvm.org/D14540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jroelofs added inline comments.
Comment at: buildbot/osuosl/master/config/builders.py:880
@@ +879,3 @@
+# See: libcxxabi/test/lit.cfg
+lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread
-lunwind -ldl -L/opt/llvm/lib/clang/3.6.0/lib/linux -lclang_rt
seaneveson added a comment.
In http://reviews.llvm.org/D10305#286119, @xazax.hun wrote:
> A third alternative would be to have both semantic names (containing hash)
> and a number suffix which indicates the ordering.
Yes that would work, but I don't understand the benefit of having the semanti
Hi,
Sorry for my late answer.
We fixed the plist parser for the CodeChecker it shoud process the
plist generated by the current trunk clang with the issue hash tags.
Right now CodeChecker does not support forwarding additional options
directly to clang (uses only the compiler options from the ori
o.gyorgy added a comment.
Hi,
Sorry for my late answer.
We fixed the plist parser for the CodeChecker it shoud process the
plist generated by the current trunk clang with the issue hash tags.
Right now CodeChecker does not support forwarding additional options
directly to clang (uses only the co
Author: marshall
Date: Tue Nov 10 09:22:08 2015
New Revision: 252610
URL: http://llvm.org/viewvc/llvm-project?rev=252610&view=rev
Log:
Explicitly #include so that we get std::move. Thanks to Walter for
the bug report.
Modified:
libcxx/trunk/test/std/utilities/function.objects/func.invoke/in
Author: marshall
Date: Tue Nov 10 09:48:23 2015
New Revision: 252612
URL: http://llvm.org/viewvc/llvm-project?rev=252612&view=rev
Log:
Walter pointed out some missing includes in the tests. Fixing the includes
uncovered a couple bugs in the _v type traits. Fixed those, too
Modified:
libcxx/t
rmaprath added inline comments.
Comment at: buildbot/osuosl/master/config/builders.py:880
@@ +879,3 @@
+# See: libcxxabi/test/lit.cfg
+lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread
-lunwind -ldl -L/opt/llvm/lib/clang/3.6.0/lib/linux -lclang_rt
Author: marshall
Date: Tue Nov 10 10:04:13 2015
New Revision: 252613
URL: http://llvm.org/viewvc/llvm-project?rev=252613&view=rev
Log:
std:: qualify ptrdiff_t in the test. Thanks to Walter for the catch
Modified:
libcxx/trunk/test/std/depr/depr.c.headers/stdint_h.pass.cpp
Modified: libcxx/tr
Author: marshall
Date: Tue Nov 10 10:10:17 2015
New Revision: 252614
URL: http://llvm.org/viewvc/llvm-project?rev=252614&view=rev
Log:
Fix typo I just introduced.
Modified:
libcxx/trunk/test/std/utilities/function.objects/func.invoke/invoke.pass.cpp
Modified:
libcxx/trunk/test/std/utilities
pekka.jaaskelainen requested changes to this revision.
pekka.jaaskelainen added a comment.
This revision now requires changes to proceed.
Only small issues found, plus it could use some more test cases.
Comment at: include/clang/AST/TypeLoc.h:2049
@@ +2048,3 @@
+ SourceRange ge
rjmccall added a subscriber: rjmccall.
rjmccall added a comment.
Hmm. That cast to GlobalAlias seems quite brittle anyway; it would be good to
fix it (and diagnose the fact that forming the alias failed). But this change
seems independently useful.
Approved for 3.7.
Users:
hfinkel (Author
Eugene.Zelenko added inline comments.
Comment at: include/clang/AST/ASTVector.h:385
@@ -383,3 +384,3 @@
// Allocate the memory from the ASTContext.
- T *NewElts = new (C, llvm::alignOf()) T[NewCapacity];
+ auto *NewElts = new (C, llvm::alignOf()) T[NewCapacity];
---
comex updated this revision to Diff 39838.
comex marked 16 inline comments as done.
http://reviews.llvm.org/D12686
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Type.h
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticParseKinds.td
include/clang/Basic/Diagn
comex added a comment.
Addressed comments. Thanks, rsmith!
Comment at: lib/Sema/SemaType.cpp:3756-3760
@@ -3743,2 +3755,7 @@
}
+} else if (D.getDeclSpec().getTypeSpecType() ==
DeclSpec::TST_auto_type) {
+ S.Diag(D.getDeclSpec().getTypeSpecTypeLoc(),
Author: joerg
Date: Tue Nov 10 13:28:17 2015
New Revision: 252640
URL: http://llvm.org/viewvc/llvm-project?rev=252640&view=rev
Log:
Add the variant of __sparc_v9__ with five underscores, not just four.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/test/Preprocessor/predefined-arch-m
zaks.anna added a comment.
Please, move the conversation on how to configure/use CodeChecker in the
particular setting elsewhere. I think it could be useful to the clang dev list;
however, this patch review is not the proper place for it.
http://reviews.llvm.org/D12906
_
ahatanak added a comment.
I think I understand some of your concerns, but I'm not sure I fully understand
what you are suggesting.
I think I can use macro __aarch64__ to have getAArch64TargetCPU return "native"
when the compiler is not run on an AArch64 platform, but it doesn't sound like
that
zaks.anna added a comment.
> This makes forwards compatibility difficult, since there is no way to predict
> the names of future hashes
> (As far as I understand).
Can you describe what you are trying to achieve?
We can agree that all issue hashes start with "issue_hash" prefix. If you find
On 11/09/2015 05:12 PM, Jonathan Roelofs via cfe-commits wrote:
Author: jroelofs
Date: Mon Nov 9 10:12:56 2015
New Revision: 252474
URL: http://llvm.org/viewvc/llvm-project?rev=252474&view=rev
Log:
Create install targets for scan-build and scan-view
Hi Jonathan,
this is probably not the comm
tyomitch created this revision.
tyomitch added reviewers: joerg, rengolin, dougk, yaron.keren.
tyomitch added a subscriber: cfe-commits.
For clarity and ease of maintenance, I suggest porting this test
to use the same tooling as the rest of the tests.
http://reviews.llvm.org/D14548
Files:
test
http://reviews.llvm.org/D14480
This tries to improve the compilation time of the test case in
https://llvm.org/bugs/show_bug.cgi?id=25416
The problem is that when trying to get the SrcLocInfo for asm, it
tries to get the SrcLoc for each
line inside the asm string. For each line, it goes through t
Author: jroelofs
Date: Tue Nov 10 14:01:22 2015
New Revision: 252641
URL: http://llvm.org/viewvc/llvm-project?rev=252641&view=rev
Log:
Fix missing CMake dependency introduced in r252474
Modified:
cfe/trunk/tools/scan-build/CMakeLists.txt
cfe/trunk/tools/scan-view/CMakeLists.txt
Modified:
ABataev added inline comments.
Comment at: include/clang/AST/OpenMPClause.h:2628
@@ +2627,3 @@
+ friend class OMPClauseWriter;
+ friend class Sema;
+
I don't like the idea of friend Sema. If Sema needs some interfaces, they must
be public.
Com
On 11/10/15 12:48 PM, Tobias Grosser wrote:
On 11/09/2015 05:12 PM, Jonathan Roelofs via cfe-commits wrote:
Author: jroelofs
Date: Mon Nov 9 10:12:56 2015
New Revision: 252474
URL: http://llvm.org/viewvc/llvm-project?rev=252474&view=rev
Log:
Create install targets for scan-build and scan-vie
On 11/10/2015 09:05 PM, Jonathan Roelofs wrote:
On 11/10/15 12:48 PM, Tobias Grosser wrote:
On 11/09/2015 05:12 PM, Jonathan Roelofs via cfe-commits wrote:
Author: jroelofs
Date: Mon Nov 9 10:12:56 2015
New Revision: 252474
URL: http://llvm.org/viewvc/llvm-project?rev=252474&view=rev
Log:
C
Author: djg
Date: Tue Nov 10 15:01:46 2015
New Revision: 252646
URL: http://llvm.org/viewvc/llvm-project?rev=252646&view=rev
Log:
[WebAssembly] Change long double to be quadruple-precision floating point.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/test/CodeGen/wasm-arguments.c
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
This LGTM, do you have SVN access or would you like someone to commit for you?
Comment at: lib/Sema/SemaType.cpp:2616-2618
@@ -2616,5 +2615,5
eugenis closed this revision.
eugenis added a comment.
r252648.
Thanks everyone for the very detailed review!
Repository:
rL LLVM
http://reviews.llvm.org/D13925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: eugenis
Date: Tue Nov 10 15:28:44 2015
New Revision: 252648
URL: http://llvm.org/viewvc/llvm-project?rev=252648&view=rev
Log:
Implement __attribute__((internal_linkage)).
The attrubite is applicable to functions and variables and changes
the linkage of the subject to internal.
This is th
On 11/10/15 1:35 PM, Tobias Grosser wrote:
On 11/10/2015 09:05 PM, Jonathan Roelofs wrote:
On 11/10/15 12:48 PM, Tobias Grosser wrote:
On 11/09/2015 05:12 PM, Jonathan Roelofs via cfe-commits wrote:
Author: jroelofs
Date: Mon Nov 9 10:12:56 2015
New Revision: 252474
URL: http://llvm.org/
Your custom commands don’t have outputs, so ninja doesn’t know when they need
to run or not.
-Chris
> On Nov 10, 2015, at 2:14 PM, Jonathan Roelofs
> wrote:
>
>
>
> On 11/10/15 1:35 PM, Tobias Grosser wrote:
>> On 11/10/2015 09:05 PM, Jonathan Roelofs wrote:
>>>
>>>
>>> On 11/10/15 12:48
hfinkel added a comment.
Can you please make sure we produce some sensible error should someone try to
use soft float with ppc64 (since we don't support that), and add an associated
test.
Comment at: lib/Driver/Tools.h:739
@@ +738,3 @@
+ Soft,
+ SoftFP,
+ Hard,
Author: rnk
Date: Tue Nov 10 16:23:58 2015
New Revision: 252659
URL: http://llvm.org/viewvc/llvm-project?rev=252659&view=rev
Log:
[COFF] Don't try to emit weak aliases on COFF
This comes up when a derived class destructor is equivalent to a base
class destructor defined in the same TU, and we try
Author: jroelofs
Date: Tue Nov 10 16:38:59 2015
New Revision: 252662
URL: http://llvm.org/viewvc/llvm-project?rev=252662&view=rev
Log:
Implement the fix that r252641 should have been
Modified:
cfe/trunk/tools/scan-build/CMakeLists.txt
cfe/trunk/tools/scan-view/CMakeLists.txt
Modified: cf
On 11/10/15 3:18 PM, Chris Bieneman wrote:
Your custom commands don’t have outputs, so ninja doesn’t know when they need
to run or not.
Thanks!
-Chris
On Nov 10, 2015, at 2:14 PM, Jonathan Roelofs wrote:
On 11/10/15 1:35 PM, Tobias Grosser wrote:
On 11/10/2015 09:05 PM, Jonathan Ro
Author: jroelofs
Date: Tue Nov 10 16:48:11 2015
New Revision: 252664
URL: http://llvm.org/viewvc/llvm-project?rev=252664&view=rev
Log:
Implement post-commit review feedback on r252662
Modified:
cfe/trunk/tools/scan-build/CMakeLists.txt
cfe/trunk/tools/scan-view/CMakeLists.txt
Modified: c
Author: jroelofs
Date: Tue Nov 10 16:59:18 2015
New Revision: 252667
URL: http://llvm.org/viewvc/llvm-project?rev=252667&view=rev
Log:
Fix build
Modified:
cfe/trunk/tools/scan-view/CMakeLists.txt
Modified: cfe/trunk/tools/scan-view/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/cfe
Author: rjmccall
Date: Tue Nov 10 17:00:25 2015
New Revision: 252668
URL: http://llvm.org/viewvc/llvm-project?rev=252668&view=rev
Log:
Define __unsafe_unretained and __autoreleasing in ObjC GC mode.
This was an accidental regression from the MRC __weak patch.
Modified:
cfe/trunk/lib/Frontend
comex added a comment.
I don't have SVN access. If you want to commit it, feel free to remove that
comment, or else I'll update the diff tomorrow.
I just tried the test case in 25449 and it now gives a proper error rather than
crashing. (Though when trying to reduce a test failure I was encou
tra created this revision.
tra added a reviewer: echristo.
tra added a subscriber: cfe-commits.
This is libdevice-related part extracted from D13170
- added detection of libdevice bitcode file and API to find one appropriate
for the GPU we're compiling for.
- pass additional cc1 options
tra updated the summary for this revision.
tra updated this revision to Diff 39860.
tra added a comment.
Moved libdevice detection and linking into a separate patch
http://reviews.llvm.org/D14556.
http://reviews.llvm.org/D13170
Files:
include/clang/Driver/Options.td
include/clang/Driver/To
Hello Clang developers,
I am back again with another patch to make Clang Lit tests C++11 compatible.
There are 26 tests in total.
These are mainly diagnostics verifications where C++98/03 and C++11 differ.
I tried to preserve as much coverage as possible.
Unless otherwise stated, these tests have
You use this pattern in a few places:
+#if (__cplusplus <= 199711L) // C or C++03 or earlier modes
Please remove the "C or" from the tests that are not actually run in C mode
(most or all of these tests make no sense in C, so the comment is
confusing). Also remove the parens.
Otherwise, this loo
Author: zaks
Date: Tue Nov 10 18:49:22 2015
New Revision: 252679
URL: http://llvm.org/viewvc/llvm-project?rev=252679&view=rev
Log:
[static analyzer] Don't flag nil storage into NSMutableDictionary.
This is now allowed and has the behavior of removing the mapping.
Modified:
cfe/trunk/lib/Stat
Author: rsmith
Date: Tue Nov 10 19:36:17 2015
New Revision: 252688
URL: http://llvm.org/viewvc/llvm-project?rev=252688&view=rev
Log:
N3922: direct-list-initialization of an auto-typed variable no longer deduces a
std::initializer_list type. Instead, the list must contain a single element
and the t
Author: rsmith
Date: Tue Nov 10 20:02:15 2015
New Revision: 252690
URL: http://llvm.org/viewvc/llvm-project?rev=252690&view=rev
Log:
Add support for GCC's '__auto_type' extension, per the GCC manual:
https://gcc.gnu.org/onlinedocs/gcc/Typeof.html
Differences from the GCC extension:
* __auto_type
Committed as r252690.
Could I tempt you to put together a documentation patch for this, and a
change for the release notes?
On Tue, Nov 10, 2015 at 3:06 PM, Nicholas Allegra wrote:
> comex added a comment.
>
> I don't have SVN access. If you want to commit it, feel free to remove
> that commen
Author: echristo
Date: Tue Nov 10 20:04:08 2015
New Revision: 252691
URL: http://llvm.org/viewvc/llvm-project?rev=252691&view=rev
Log:
Fix a FIXME about using std::is_sorted.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp
URL:
http://llvm.org/vie
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: hans, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6. Regressions were OK.
Repository:
rL LLVM
ht
Author: ahatanak
Date: Tue Nov 10 20:13:36 2015
New Revision: 252693
URL: http://llvm.org/viewvc/llvm-project?rev=252693&view=rev
Log:
Reorder the check strings in test case following r252692.
rdar://problem/19836465
Modified:
cfe/trunk/test/CodeGen/ms-declspecs.c
Modified: cfe/trunk/test/C
Author: ctopper
Date: Tue Nov 10 20:51:18 2015
New Revision: 252697
URL: http://llvm.org/viewvc/llvm-project?rev=252697&view=rev
Log:
[X86] Change pointer type in AVX2 gather builtins to be the scalar type instead
of the vector type. This matches gcc and removes extras casts.
Modified:
cfe/t
Author: ctopper
Date: Tue Nov 10 21:47:10 2015
New Revision: 252700
URL: http://llvm.org/viewvc/llvm-project?rev=252700&view=rev
Log:
[X86] Add missing typecasts in intrinsic macros. This should make them more
robust against inputs that aren't already the right type.
Modified:
cfe/trunk/lib/
compnerd accepted this revision.
compnerd added a reviewer: compnerd.
This revision is now accepted and ready to land.
Comment at: lib/CodeGen/CGAtomic.cpp:901
@@ -897,1 +900,3 @@
+ PostOp = llvm::Instruction::Add;
+// Fall through.
case AtomicExpr::AO__c11_atomic_fe
On 11/10/2015 11:42 PM, Jonathan Roelofs wrote:
Fixed for real in r252662.
Confirmed. Thank you for addressing this so quickly.
Tobias
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
73 matches
Mail list logo
