r252664 - Implement post-commit review feedback on r252662

[Jonathan Roelofs via cfe-commits]

Author: jroelofs
Date: Tue Nov 10 16:48:11 2015
New Revision: 252664

URL: http://llvm.org/viewvc/llvm-project?rev=252664&view=rev
Log:
Implement post-commit review feedback on r252662

Modified:
    cfe/trunk/tools/scan-build/CMakeLists.txt
    cfe/trunk/tools/scan-view/CMakeLists.txt

Modified: cfe/trunk/tools/scan-build/CMakeLists.txt
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/scan-build/CMakeLists.txt?rev=252664&r1=252663&r2=252664&view=diff
==============================================================================
--- cfe/trunk/tools/scan-build/CMakeLists.txt (original)
+++ cfe/trunk/tools/scan-build/CMakeLists.txt Tue Nov 10 16:48:11 2015
@@ -13,8 +13,8 @@ else()
         ccc-analyzer
         c++-analyzer)
   if (APPLE)
-    set(BinFiles ${BinFiles}
-         set-xcode-analyzer)
+    list(APPEND BinFiles
+           set-xcode-analyzer)
   endif()
 endif()
 
@@ -27,7 +27,6 @@ set(ResourceFiles
 
 
 if(CLANG_INSTALL_SCANBUILD)
-  set(Depends )
   foreach(BinFile ${BinFiles})
     add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/bin/${BinFile}
                        COMMAND ${CMAKE_COMMAND} -E make_directory
@@ -36,7 +35,7 @@ if(CLANG_INSTALL_SCANBUILD)
                          ${CMAKE_CURRENT_SOURCE_DIR}/${BinFile}
                          ${CMAKE_BINARY_DIR}/bin/
                        DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${BinFile})
-    set(Depends ${Depends}  ${CMAKE_BINARY_DIR}/bin/${BinFile})
+    list(APPEND Depends ${CMAKE_BINARY_DIR}/bin/${BinFile})
     install(PROGRAMS ${BinFile} DESTINATION bin)
   endforeach()
 
@@ -48,7 +47,7 @@ if(CLANG_INSTALL_SCANBUILD)
                          ${CMAKE_CURRENT_SOURCE_DIR}/${LibexecFile}
                          ${CMAKE_BINARY_DIR}/libexec/
                        DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${LibexecFile})
-    set(Depends ${Depends} ${CMAKE_BINARY_DIR}/libexec/${LibexecFile})
+    list(APPEND Depends ${CMAKE_BINARY_DIR}/libexec/${LibexecFile})
     install(PROGRAMS ${LibexecFile} DESTINATION libexec)
   endforeach()
 
@@ -60,7 +59,7 @@ if(CLANG_INSTALL_SCANBUILD)
                          ${CMAKE_CURRENT_SOURCE_DIR}/${ManPage}
                          ${CMAKE_BINARY_DIR}/share/man/man1/
                        DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${ManPage})
-    set(Depends ${Depends} ${CMAKE_BINARY_DIR}/share/man/man1/${ManPage})
+    list(APPEND Depends ${CMAKE_BINARY_DIR}/share/man/man1/${ManPage})
     install(PROGRAMS ${ManPage} DESTINATION share/man/man1)
   endforeach()
 
@@ -72,7 +71,7 @@ if(CLANG_INSTALL_SCANBUILD)
                          ${CMAKE_CURRENT_SOURCE_DIR}/${ResourceFile}
                          ${CMAKE_BINARY_DIR}/bin/
                        DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${ResourceFile})
-    set(Depends ${Depends} ${CMAKE_BINARY_DIR}/bin/${ResourceFile})
+    list(APPEND Depends ${CMAKE_BINARY_DIR}/bin/${ResourceFile})
     install(FILES ${ResourceFile} DESTINATION bin)
   endforeach()
 

Modified: cfe/trunk/tools/scan-view/CMakeLists.txt
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/scan-view/CMakeLists.txt?rev=252664&r1=252663&r2=252664&view=diff
==============================================================================
--- cfe/trunk/tools/scan-view/CMakeLists.txt (original)
+++ cfe/trunk/tools/scan-view/CMakeLists.txt Tue Nov 10 16:48:11 2015
@@ -12,7 +12,6 @@ set(ResourceFiles
       bugcatcher.ico)
 
 if(CLANG_INSTALL_SCANVIEW)
-  set(Depends )
   foreach(BinFile ${BinFiles})
     add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/bin/${BinFile}
                        COMMAND ${CMAKE_COMMAND} -E make_directory
@@ -21,7 +20,7 @@ if(CLANG_INSTALL_SCANVIEW)
                          ${CMAKE_CURRENT_SOURCE_DIR}/${BinFile}
                          ${CMAKE_BINARY_DIR}/bin/
                        DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/${BinFile})
-    set(Depends ${Depends} ${CMAKE_BINARY_DIR}/bin/${BinFile})
+    list(APPEND Depends ${CMAKE_BINARY_DIR}/bin/${BinFile})
     install(PROGRAMS ${BinFile} DESTINATION bin)
   endforeach()
 
@@ -33,7 +32,7 @@ if(CLANG_INSTALL_SCANVIEW)
                          ${CMAKE_CURRENT_SOURCE_DIR}/Resources/${ResourceFile}
                          ${CMAKE_BINARY_DIR}/share/scan-view/
                        DEPENDS 
${CMAKE_CURRENT_SOURCE_DIR}/Resources/${ResourceFile})
-    set(Depends ${Depends} ${CMAKE_BINARY_DIR}/share/scan-view/${ResourceFile})
+    list(APPEND Depends ${CMAKE_BINARY_DIR}/share/scan-view/${ResourceFile})
     install(FILES ${ResourceFile} DESTINATION share/scan-view)
   endforeach()
 


_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits